Skip to content

Revert "Fix hit-testing order in semantics (#167522)" #168235

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
auto-submit merged 2 commits into from
May 5, 2025
Merged

Revert "Fix hit-testing order in semantics (#167522)" #168235

auto-submit merged 2 commits into from
May 5, 2025

Conversation

@QuncCccccc
Copy link
Contributor

@QuncCccccc QuncCccccc commented May 2, 2025 •
edited by reidbaker
Loading

This reverts commit d9cbff2.

Fixes #168164

@QuncCccccc QuncCccccc requested a review from chunhtai May 2, 2025 19:23
@github-actions github-actions bot added framework flutter/packages/flutter repository. See also f: labels. f: material design flutter/packages/flutter/material repository. a: accessibility Accessibility, e.g. VoiceOver or TalkBack. (aka a11y) f: scrolling Viewports, list views, slivers, etc. labels May 2, 2025
@QuncCccccc QuncCccccc requested a review from reidbaker May 2, 2025 19:23
@QuncCccccc QuncCccccc mentioned this pull request May 2, 2025
Closed
chunhtai
chunhtai approved these changes May 2, 2025
View reviewed changes
Copy link
Contributor

@chunhtai chunhtai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@QuncCccccc QuncCccccc added the autosubmit Merge PR when tree becomes green via auto submit App label May 2, 2025
justinmc
justinmc approved these changes May 2, 2025
View reviewed changes
Copy link
Contributor

@justinmc justinmc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 . Thanks for jumping on this @QuncCccccc and @chunhtai.

I guess #163576 should be reopened when this merges?

@QuncCccccc
Copy link
Contributor Author

QuncCccccc commented May 2, 2025

Reopened the original issue. Thanks for reminding!

@auto-submit auto-submit bot added this pull request to the merge queue May 5, 2025
Merged via the queue into flutter:master with commit 14c45d9 May 5, 2025
74 checks passed
@flutter-dashboard flutter-dashboard bot removed the autosubmit Merge PR when tree becomes green via auto submit App label May 5, 2025
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 5, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 5, 2025
@engine-flutter-autoroll
14c45d944 Revert "Fix hit-testing order in semantics (#167522)" (flut…
9293131 
…ter/flutter#168235)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 5, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 5, 2025
@engine-flutter-autoroll
14c45d944 Revert "Fix hit-testing order in semantics (#167522)" (flut…
c3df655 
…ter/flutter#168235)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 5, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 5, 2025
@engine-flutter-autoroll
14c45d944 Revert "Fix hit-testing order in semantics (#167522)" (flut…
47f5e14 
…ter/flutter#168235)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 5, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 5, 2025
@engine-flutter-autoroll
14c45d944 Revert "Fix hit-testing order in semantics (#167522)" (flut…
d299614 
…ter/flutter#168235)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 5, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 5, 2025
@engine-flutter-autoroll
14c45d944 Revert "Fix hit-testing order in semantics (#167522)" (flut…
dcbcba3 
…ter/flutter#168235)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 5, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 5, 2025
@engine-flutter-autoroll
14c45d944 Revert "Fix hit-testing order in semantics (#167522)" (flut…
b8f1da2 
…ter/flutter#168235)
ash2moon pushed a commit to ash2moon/flutter that referenced this pull request May 5, 2025
@QuncCccccc @ash2moon
Revert "Fix hit-testing order in semantics (flutter#167522)" (flutter…
1f7f474 
…#168235)

This reverts commit d9cbff2.

Fixes flutter#168164
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 5, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 5, 2025
@engine-flutter-autoroll
14c45d944 Revert "Fix hit-testing order in semantics (#167522)" (flut…
945f16c 
…ter/flutter#168235)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 5, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 5, 2025
@engine-flutter-autoroll
14c45d944 Revert "Fix hit-testing order in semantics (#167522)" (flut…
5a658f5 
…ter/flutter#168235)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 6, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 6, 2025
@engine-flutter-autoroll
14c45d944 Revert "Fix hit-testing order in semantics (#167522)" (flut…
5cf2206 
…ter/flutter#168235)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 6, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 6, 2025
@engine-flutter-autoroll
14c45d944 Revert "Fix hit-testing order in semantics (#167522)" (flut…
b619052 
…ter/flutter#168235)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 6, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 6, 2025
@engine-flutter-autoroll
14c45d944 Revert "Fix hit-testing order in semantics (#167522)" (flut…
f195295 
…ter/flutter#168235)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 6, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 6, 2025
@engine-flutter-autoroll
14c45d944 Revert "Fix hit-testing order in semantics (#167522)" (flut…
0c77f71 
…ter/flutter#168235)
mboetger pushed a commit to mboetger/flutter that referenced this pull request May 6, 2025
@QuncCccccc @mboetger
Revert "Fix hit-testing order in semantics (flutter#167522)" (flutter…
afab0ad 
…#168235)

This reverts commit d9cbff2.

Fixes flutter#168164
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 7, 2025
@engine-flutter-autoroll
14c45d944 Revert "Fix hit-testing order in semantics (#167522)" (flut…
86de7d4 
…ter/flutter#168235)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 7, 2025
@engine-flutter-autoroll
14c45d944 Revert "Fix hit-testing order in semantics (#167522)" (flut…
b5bbdc5 
…ter/flutter#168235)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 7, 2025
@engine-flutter-autoroll
14c45d944 Revert "Fix hit-testing order in semantics (#167522)" (flut…
c8facc3 
…ter/flutter#168235)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 7, 2025
@engine-flutter-autoroll
14c45d944 Revert "Fix hit-testing order in semantics (#167522)" (flut…
05ffd51 
…ter/flutter#168235)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 7, 2025
@engine-flutter-autoroll
14c45d944 Revert "Fix hit-testing order in semantics (#167522)" (flut…
624afc7 
…ter/flutter#168235)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 7, 2025
@engine-flutter-autoroll
14c45d944 Revert "Fix hit-testing order in semantics (#167522)" (flut…
a7e9015 
…ter/flutter#168235)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 7, 2025
@engine-flutter-autoroll
14c45d944 Revert "Fix hit-testing order in semantics (#167522)" (flut…
9888085 
…ter/flutter#168235)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 14, 2025
@engine-flutter-autoroll
14c45d944 Revert "Fix hit-testing order in semantics (#167522)" (flut…
195f8f5 
…ter/flutter#168235)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 14, 2025
@engine-flutter-autoroll
14c45d944 Revert "Fix hit-testing order in semantics (#167522)" (flut…
bd4f703 
…ter/flutter#168235)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 15, 2025
@engine-flutter-autoroll
14c45d944 Revert "Fix hit-testing order in semantics (#167522)" (flut…
fb8fcbb 
…ter/flutter#168235)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 15, 2025
@engine-flutter-autoroll
14c45d944 Revert "Fix hit-testing order in semantics (#167522)" (flut…
b243ef9 
…ter/flutter#168235)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 16, 2025
@engine-flutter-autoroll
14c45d944 Revert "Fix hit-testing order in semantics (#167522)" (flut…
126507e 
…ter/flutter#168235)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@justinmc justinmc justinmc approved these changes

@reidbaker reidbaker reidbaker approved these changes

@chunhtai chunhtai chunhtai approved these changes

Assignees

No one assigned

Labels

a: accessibility Accessibility, e.g. VoiceOver or TalkBack. (aka a11y) f: material design flutter/packages/flutter/material repository. f: scrolling Viewports, list views, slivers, etc. framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

DropdownButton options cannot be selected when using TalkBack on Android

4 participants

@QuncCccccc @justinmc @reidbaker @chunhtai