Skip to content

Slimpeller can stomp on gcs binary bits ☠️ #168178

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jtmcdole merged 1 commit into from
May 2, 2025
Merged

Slimpeller can stomp on gcs binary bits ☠️ #168178

jtmcdole merged 1 commit into from
May 2, 2025

Conversation

@jtmcdole
Copy link
Member

@jtmcdole jtmcdole commented May 1, 2025 •
edited
Loading

Binaries for the Android Slimpeller build were being uploaded to the same paths as regular Android builds. This race condition leads to artifacts.zip being incorrect.

fyi: @jonahwilliams

@jtmcdole jtmcdole requested a review from jason-simmons May 1, 2025 22:44
@github-actions github-actions bot added the engine flutter/engine related. See also e: labels. label May 1, 2025
@jason-simmons
Copy link
Member

jason-simmons commented May 1, 2025

Binaries for the Android Slimpeller build were being uploaded to the same paths as regular Android builds.

If Slimpeller builds need to be uploaded to GCS, then they will need to use different archive paths in:

@jtmcdole
Copy link
Member Author

jtmcdole commented May 1, 2025

Updated commit comment

@jtmcdole jtmcdole added the autosubmit Merge PR when tree becomes green via auto submit App label May 1, 2025
@jtmcdole jtmcdole mentioned this pull request May 1, 2025
Closed
@jtmcdole jtmcdole added this pull request to the merge queue May 2, 2025
Merged via the queue into flutter:master with commit 41a5cbd May 2, 2025
179 checks passed
@jtmcdole jtmcdole deleted the remove_slimpeller_artifactbuilds branch May 2, 2025 01:31
@flutter-dashboard flutter-dashboard bot removed the autosubmit Merge PR when tree becomes green via auto submit App label May 2, 2025
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 2, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 2, 2025
@engine-flutter-autoroll
41a5cbdf7 Slimpeller can stomp on gcs binary bits ☠️ (flutter/flutter…
c665b7a 
…#168178)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 2, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 2, 2025
@engine-flutter-autoroll
41a5cbdf7 Slimpeller can stomp on gcs binary bits ☠️ (flutter/flutter…
3414fca 
…#168178)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 2, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 2, 2025
@engine-flutter-autoroll
41a5cbdf7 Slimpeller can stomp on gcs binary bits ☠️ (flutter/flutter…
a2b9318 
…#168178)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 2, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 2, 2025
@engine-flutter-autoroll
41a5cbdf7 Slimpeller can stomp on gcs binary bits ☠️ (flutter/flutter…
a7aff8d 
…#168178)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 2, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 2, 2025
@engine-flutter-autoroll
41a5cbdf7 Slimpeller can stomp on gcs binary bits ☠️ (flutter/flutter…
c415793 
…#168178)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 3, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 3, 2025
@engine-flutter-autoroll
41a5cbdf7 Slimpeller can stomp on gcs binary bits ☠️ (flutter/flutter…
e46d513 
…#168178)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 3, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 3, 2025
@engine-flutter-autoroll
41a5cbdf7 Slimpeller can stomp on gcs binary bits ☠️ (flutter/flutter…
a5682d7 
…#168178)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 4, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 4, 2025
@engine-flutter-autoroll
41a5cbdf7 Slimpeller can stomp on gcs binary bits ☠️ (flutter/flutter…
55f1c53 
…#168178)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 5, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 5, 2025
@engine-flutter-autoroll
41a5cbdf7 Slimpeller can stomp on gcs binary bits ☠️ (flutter/flutter…
b5d3120 
…#168178)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 5, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 5, 2025
@engine-flutter-autoroll
41a5cbdf7 Slimpeller can stomp on gcs binary bits ☠️ (flutter/flutter…
4801cfc 
…#168178)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 5, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 5, 2025
@engine-flutter-autoroll
41a5cbdf7 Slimpeller can stomp on gcs binary bits ☠️ (flutter/flutter…
7a7286e 
…#168178)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 5, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 5, 2025
@engine-flutter-autoroll
41a5cbdf7 Slimpeller can stomp on gcs binary bits ☠️ (flutter/flutter…
23cb675 
…#168178)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 5, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 5, 2025
@engine-flutter-autoroll
41a5cbdf7 Slimpeller can stomp on gcs binary bits ☠️ (flutter/flutter…
bff02fa 
…#168178)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 5, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 5, 2025
@engine-flutter-autoroll
41a5cbdf7 Slimpeller can stomp on gcs binary bits ☠️ (flutter/flutter…
0436673 
…#168178)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 5, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 5, 2025
@engine-flutter-autoroll
41a5cbdf7 Slimpeller can stomp on gcs binary bits ☠️ (flutter/flutter…
12d70b5 
…#168178)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 6, 2025
@engine-flutter-autoroll
41a5cbdf7 Slimpeller can stomp on gcs binary bits ☠️ (flutter/flutter…
7e9aee2 
…#168178)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 6, 2025
@engine-flutter-autoroll
41a5cbdf7 Slimpeller can stomp on gcs binary bits ☠️ (flutter/flutter…
91e1b1e 
…#168178)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 6, 2025
@engine-flutter-autoroll
41a5cbdf7 Slimpeller can stomp on gcs binary bits ☠️ (flutter/flutter…
e1a7d85 
…#168178)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 6, 2025
@engine-flutter-autoroll
41a5cbdf7 Slimpeller can stomp on gcs binary bits ☠️ (flutter/flutter…
101042a 
…#168178)
mboetger pushed a commit to mboetger/flutter that referenced this pull request May 6, 2025
@jtmcdole @mboetger
Slimpeller can stomp on gcs binary bits ☠️ (flutter#168178)
903005a 
Binaries for the Android Slimpeller build were being uploaded to the
same paths as regular Android builds. This race condition leads to
artifacts.zip being incorrect.

fyi: @jonahwilliams
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 7, 2025
@engine-flutter-autoroll
41a5cbdf7 Slimpeller can stomp on gcs binary bits ☠️ (flutter/flutter…
be83aa4 
…#168178)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 7, 2025
@engine-flutter-autoroll
41a5cbdf7 Slimpeller can stomp on gcs binary bits ☠️ (flutter/flutter…
b874dfd 
…#168178)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 7, 2025
@engine-flutter-autoroll
41a5cbdf7 Slimpeller can stomp on gcs binary bits ☠️ (flutter/flutter…
9573947 
…#168178)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 7, 2025
@engine-flutter-autoroll
41a5cbdf7 Slimpeller can stomp on gcs binary bits ☠️ (flutter/flutter…
1da12f6 
…#168178)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 7, 2025
@engine-flutter-autoroll
41a5cbdf7 Slimpeller can stomp on gcs binary bits ☠️ (flutter/flutter…
a01aa13 
…#168178)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 7, 2025
@engine-flutter-autoroll
41a5cbdf7 Slimpeller can stomp on gcs binary bits ☠️ (flutter/flutter…
deff9d6 
…#168178)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 7, 2025
@engine-flutter-autoroll
41a5cbdf7 Slimpeller can stomp on gcs binary bits ☠️ (flutter/flutter…
f8fc42a 
…#168178)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 14, 2025
@engine-flutter-autoroll
41a5cbdf7 Slimpeller can stomp on gcs binary bits ☠️ (flutter/flutter…
138c303 
…#168178)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 14, 2025
@engine-flutter-autoroll
41a5cbdf7 Slimpeller can stomp on gcs binary bits ☠️ (flutter/flutter…
321a839 
…#168178)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 15, 2025
@engine-flutter-autoroll
41a5cbdf7 Slimpeller can stomp on gcs binary bits ☠️ (flutter/flutter…
a60c805 
…#168178)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 15, 2025
@engine-flutter-autoroll
41a5cbdf7 Slimpeller can stomp on gcs binary bits ☠️ (flutter/flutter…
9e1f23f 
…#168178)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 16, 2025
@engine-flutter-autoroll
41a5cbdf7 Slimpeller can stomp on gcs binary bits ☠️ (flutter/flutter…
149e6f6 
…#168178)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jason-simmons jason-simmons jason-simmons approved these changes

Assignees

No one assigned

Labels

engine flutter/engine related. See also e: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jtmcdole @jason-simmons