Increased the limit where we start chopping off the end of blurs #168109
Conversation
|
It looks like this pull request may not have tests. Please make sure to add tests or get an explicit test exemption before merging. If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.If you believe this PR qualifies for a test exemption, contact "@test-exemption-reviewer" in the #hackers channel in Discord (don't just cc them here, they won't see it!). The test exemption team is a small volunteer group, so all reviewers should feel empowered to ask for tests, without delegating that responsibility entirely to the test exemption group. |
github-actions
bot
added
engine
| // Chop off the last samples if the radius >= 3 where they account for < 1.56% | ||
| // of the result. | ||
| // Chop off the last samples if the radius >= 16 where they account for | ||
| // < 1.56% of the result. |
There was a problem hiding this comment.
Is it still 1.56% if you increase the radius size? I would think that the contribution %age would go way down at that radius.
There was a problem hiding this comment.
I didn't measure it, that's from the article on the lerp hack. I think it's probably still a good rule of thumb, it obviously isn't going to be exact for every radius.
There was a problem hiding this comment.
I updated the comment to reflect it isn't exactly 1.56%
gaaclarke
force-pushed
the
increase-blur-radius
branch
from
8196ef5 to
dcad843
Compare
gaaclarke
added
the
autosubmit
auto-submit
bot
removed
the
autosubmit
|
autosubmit label was removed for flutter/flutter/168109, because - The status or check suite Mac mac_unopt has failed. Please fix the issues identified (or deflake) before re-applying this label. |
gaaclarke
force-pushed
the
increase-blur-radius
branch
2 times, most recently
from
8c807e0 to
a327427
Compare
|
I'm having a hard time getting this through CI. I'm getting failures in things like |
gaaclarke
force-pushed
the
increase-blur-radius
branch
from
a327427 to
0df4796
Compare
gaaclarke
force-pushed
the
increase-blur-radius
branch
from
0df4796 to
6728ad9
Compare
|
This is failing because of changes to golden images in the bespoke platform view golden tests. |
|
Golden file changes have been found for this pull request. Click here to view and triage (e.g. because this is an intentional change). If you are still iterating on this change and are not ready to resolve the images on the Flutter Gold dashboard, consider marking this PR as a draft pull request above. You will still be able to view image results on the dashboard, commenting will be silenced, and the check will not try to resolve itself until marked ready for review. For more guidance, visit Writing a golden file test for Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
|
Man, looking at the goldens, most of the time this different is completely unnoticeable. It stinks to have to incur the extra performance cost because there isn't a good heuristic to determine if it is necessary or not. |
gaaclarke
added
the
autosubmit
|
Google testing is failing to set to passing, adding to queue. |
flutter-dashboard
bot
removed
the
autosubmit
flutter/flutter@02d8c1a...83082c1 2025-05-08 [email protected] [Widget Inspector] Clean-up changes in PR #167677 (flutter/flutter#168488) 2025-05-08 [email protected] Increased the limit where we start chopping off the end of blurs (flutter/flutter#168109) 2025-05-08 [email protected] Roll to Dart SDK 3.9 Beta 1 (flutter/flutter#168559) 2025-05-08 [email protected] Rename apple -> darwin across our buildroot (flutter/flutter#168558) 2025-05-08 [email protected] Update Engine to Android 16 (API 36) (flutter/flutter#166796) 2025-05-08 [email protected] Roll Skia from 43ae814d2d95 to efccaeb08b8d (5 revisions) (flutter/flutter#168554) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
…#9232) flutter/flutter@02d8c1a...83082c1 2025-05-08 [email protected] [Widget Inspector] Clean-up changes in PR #167677 (flutter/flutter#168488) 2025-05-08 [email protected] Increased the limit where we start chopping off the end of blurs (flutter/flutter#168109) 2025-05-08 [email protected] Roll to Dart SDK 3.9 Beta 1 (flutter/flutter#168559) 2025-05-08 [email protected] Rename apple -> darwin across our buildroot (flutter/flutter#168558) 2025-05-08 [email protected] Update Engine to Android 16 (API 36) (flutter/flutter#166796) 2025-05-08 [email protected] Roll Skia from 43ae814d2d95 to efccaeb08b8d (5 revisions) (flutter/flutter#168554) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
…#9232) flutter/flutter@02d8c1a...83082c1 2025-05-08 [email protected] [Widget Inspector] Clean-up changes in PR #167677 (flutter/flutter#168488) 2025-05-08 [email protected] Increased the limit where we start chopping off the end of blurs (flutter/flutter#168109) 2025-05-08 [email protected] Roll to Dart SDK 3.9 Beta 1 (flutter/flutter#168559) 2025-05-08 [email protected] Rename apple -> darwin across our buildroot (flutter/flutter#168558) 2025-05-08 [email protected] Update Engine to Android 16 (API 36) (flutter/flutter#166796) 2025-05-08 [email protected] Roll Skia from 43ae814d2d95 to efccaeb08b8d (5 revisions) (flutter/flutter#168554) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2 participants
issue: #165422
Here is the before/after screenshots at sigma = 30
beforeafter.mp4
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.