Error when trying to use old HC mode when HCPP is enabled #168027

gmackall · 2025-04-30T00:16:16Z

Pre-launch Checklist

I read the Contributor Guide and followed the process outlined there for submitting PRs.
I read the Tree Hygiene wiki page, which explains my responsibilities.
I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
I signed the CLA.
I listed at least one issue that this PR fixes in the description above.
I updated/added relevant documentation (doc comments with ///).
I added new tests to check the change I am making, or this PR is test-exempt.
I followed the breaking change policy and added Data Driven Fixes where supported.
All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

gmackall · 2025-05-02T20:29:55Z

...e/src/flutter/shell/platform/android/io/flutter/plugin/platform/PlatformViewsController.java

  // This isn't ideal, but given all the other limitations it's a reasonable tradeoff.
  // Related issue: https://github.com/flutter/flutter/issues/103630
-  private static Class[] VIEW_TYPES_REQUIRE_VIRTUAL_DISPLAY = {SurfaceView.class};
+  private static Class[] VIEW_TYPES_REQUIRE_NON_TLHC = {SurfaceView.class};


Unrelated to the current change, but as I understand this is a more accurate name

reidbaker · 2025-05-12T15:04:44Z

I know the point of this pr is to make sure we actually are using hcpp when it can be used. BUT we should acknowledge that choosing to crash is pretty extreme and it means we really need to be confident in our implementations to not crash for our users.

gmackall · 2025-05-12T17:07:43Z

I know the point of this pr is to make sure we actually are using hcpp when it can be used. BUT we should acknowledge that choosing to crash is pretty extreme and it means we really need to be confident in our implementations to not crash for our users.

I think the point is also that HC mode will not work with HCPP mode. So if you have HCPP enabled, the assumption is that you are also using HCPP, so trying to instantiate an HC mode platform view is doomed.

…lutter/flutter#168027)

flutter/flutter@54de32d...336a7ec 2025-05-13 [email protected] Add assert for index parameter in IndexedStack. (flutter/flutter#167757) 2025-05-13 [email protected] Fixed Android Lint Errors (flutter/flutter#168613) 2025-05-13 [email protected] Tab bar theme and dialog theme documentation cleanup (flutter/flutter#168724) 2025-05-13 [email protected] Roll Fuchsia Linux SDK from 6vjKe0bfYDVaECqBL... to 6J81agNhuK4q255Jj... (flutter/flutter#168712) 2025-05-12 [email protected] Make the barrier panel on the Material Drawer non-dismissible (flutter/flutter#164810) 2025-05-12 [email protected] Roll ICU from c9fb4b3a6fb5 to b929596baebf (5 revisions) (flutter/flutter#168691) 2025-05-12 [email protected] Fix DropdownButtonFormField icon not vertically centered (flutter/flutter#163205) 2025-05-12 [email protected] Android home/end keyboard shortcut support (flutter/flutter#168184) 2025-05-12 [email protected] Update `TESTOWNERS` for Android PV tests (flutter/flutter#168694) 2025-05-12 [email protected] Roll Dart SDK from 0bea6379f654 to 645d04a7a964 (14 revisions) (flutter/flutter#168679) 2025-05-12 [email protected] [Impeller] libImpeller: Allow setting text decorations. (flutter/flutter#168408) 2025-05-12 [email protected] Error when trying to use old HC mode when HCPP is enabled (flutter/flutter#168027) 2025-05-12 [email protected] Nav bar back label is not clipped mid-transition (flutter/flutter#168194) 2025-05-12 [email protected] Add test for stack trace mapping and test expression eval tests using DDC library bundle format (flutter/flutter#168017) 2025-05-12 [email protected] Remove CupertinoSliverNavigationBar background box when large title is extended (flutter/flutter#168407) 2025-05-12 [email protected] Label platform view modes using the unified naming scheme (flutter/flutter#168670) 2025-05-12 [email protected] Roll Packages from 7814fab to 6a28ad9 (2 revisions) (flutter/flutter#168669) 2025-05-12 [email protected] Update `Engine-artifacts.md` to reflect the new `engine.version` verifier (flutter/flutter#168413) 2025-05-12 [email protected] Roll Skia from 9f9e1f37917e to c97451da059f (1 revision) (flutter/flutter#168671) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

…r#9246) flutter/flutter@54de32d...336a7ec 2025-05-13 [email protected] Add assert for index parameter in IndexedStack. (flutter/flutter#167757) 2025-05-13 [email protected] Fixed Android Lint Errors (flutter/flutter#168613) 2025-05-13 [email protected] Tab bar theme and dialog theme documentation cleanup (flutter/flutter#168724) 2025-05-13 [email protected] Roll Fuchsia Linux SDK from 6vjKe0bfYDVaECqBL... to 6J81agNhuK4q255Jj... (flutter/flutter#168712) 2025-05-12 [email protected] Make the barrier panel on the Material Drawer non-dismissible (flutter/flutter#164810) 2025-05-12 [email protected] Roll ICU from c9fb4b3a6fb5 to b929596baebf (5 revisions) (flutter/flutter#168691) 2025-05-12 [email protected] Fix DropdownButtonFormField icon not vertically centered (flutter/flutter#163205) 2025-05-12 [email protected] Android home/end keyboard shortcut support (flutter/flutter#168184) 2025-05-12 [email protected] Update `TESTOWNERS` for Android PV tests (flutter/flutter#168694) 2025-05-12 [email protected] Roll Dart SDK from 0bea6379f654 to 645d04a7a964 (14 revisions) (flutter/flutter#168679) 2025-05-12 [email protected] [Impeller] libImpeller: Allow setting text decorations. (flutter/flutter#168408) 2025-05-12 [email protected] Error when trying to use old HC mode when HCPP is enabled (flutter/flutter#168027) 2025-05-12 [email protected] Nav bar back label is not clipped mid-transition (flutter/flutter#168194) 2025-05-12 [email protected] Add test for stack trace mapping and test expression eval tests using DDC library bundle format (flutter/flutter#168017) 2025-05-12 [email protected] Remove CupertinoSliverNavigationBar background box when large title is extended (flutter/flutter#168407) 2025-05-12 [email protected] Label platform view modes using the unified naming scheme (flutter/flutter#168670) 2025-05-12 [email protected] Roll Packages from 7814fab to 6a28ad9 (2 revisions) (flutter/flutter#168669) 2025-05-12 [email protected] Update `Engine-artifacts.md` to reflect the new `engine.version` verifier (flutter/flutter#168413) 2025-05-12 [email protected] Roll Skia from 9f9e1f37917e to c97451da059f (1 revision) (flutter/flutter#168671) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

…lutter/flutter#168027)

Gray Mackall added 3 commits April 29, 2025 16:50

wip

1759e20

draft

8655067

format

0ddfb03

github-actions bot added platform-android Android applications specifically engine flutter/engine related. See also e: labels. labels Apr 30, 2025

Gray Mackall and others added 5 commits May 2, 2025 10:35

tests require a jni attached to the platform views controller

336072e

format

5ad2794

also throw for tlhc fallback to hc

2f2a2c6

slightly refactor throwing

5a07ec1

Merge branch 'master' into throw_for_old_gc

e747d44

gmackall changed the title ~~[WIP] Error when trying to use old HC mode when HCPP is enabled~~ Error when trying to use old HC mode when HCPP is enabled May 2, 2025

gmackall commented May 2, 2025

View reviewed changes

Gray Mackall added 3 commits May 2, 2025 14:36

test?

5236711

it finally works (this took me forever)

d612e13

working tests

4299b89

gmackall marked this pull request as ready for review May 2, 2025 23:54

gmackall requested review from a team and johnmccutchan May 2, 2025 23:55

Gray Mackall and others added 3 commits May 2, 2025 17:39

format

d6c7cc8

Merge branch 'master' into throw_for_old_gc

454df60

Merge branch 'master' into throw_for_old_gc

f95970f

jesswrd requested a review from reidbaker May 6, 2025 18:51

Merge branch 'master' into throw_for_old_gc

6fb6d42

johnmccutchan approved these changes May 7, 2025

View reviewed changes

reidbaker approved these changes May 12, 2025

View reviewed changes

Merge branch 'master' into throw_for_old_gc

056116d

gmackall added the autosubmit Merge PR when tree becomes green via auto submit App label May 12, 2025

auto-submit bot added this pull request to the merge queue May 12, 2025

Merged via the queue into flutter:master with commit 88ce956 May 12, 2025
178 of 179 checks passed

flutter-dashboard bot removed the autosubmit Merge PR when tree becomes green via auto submit App label May 12, 2025

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 13, 2025

88ce9564c Error when trying to use old HC mode when HCPP is enabled (f…

451db2c

…lutter/flutter#168027)

engine-flutter-autoroll mentioned this pull request May 13, 2025

Roll Flutter from 54de32d6e159 to 358b07268828 (18 revisions) flutter/packages#9244

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 13, 2025

88ce9564c Error when trying to use old HC mode when HCPP is enabled (f…

39d3fa6

…lutter/flutter#168027)

engine-flutter-autoroll mentioned this pull request May 13, 2025

Roll Flutter from 54de32d6e159 to 336a7ecf7b40 (19 revisions) flutter/packages#9246

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 14, 2025

88ce9564c Error when trying to use old HC mode when HCPP is enabled (f…

87c472d

…lutter/flutter#168027)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 14, 2025

88ce9564c Error when trying to use old HC mode when HCPP is enabled (f…

00e4861

…lutter/flutter#168027)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 15, 2025

88ce9564c Error when trying to use old HC mode when HCPP is enabled (f…

3d4ddac

…lutter/flutter#168027)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 15, 2025

88ce9564c Error when trying to use old HC mode when HCPP is enabled (f…

b506e40

…lutter/flutter#168027)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 16, 2025

88ce9564c Error when trying to use old HC mode when HCPP is enabled (f…

e545fee

…lutter/flutter#168027)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Error when trying to use old HC mode when HCPP is enabled #168027

Error when trying to use old HC mode when HCPP is enabled #168027

Uh oh!

gmackall commented Apr 30, 2025 •

edited

Loading

Uh oh!

gmackall May 2, 2025

Uh oh!

reidbaker commented May 12, 2025

Uh oh!

gmackall commented May 12, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Error when trying to use old HC mode when HCPP is enabled #168027

Error when trying to use old HC mode when HCPP is enabled #168027

Uh oh!

Conversation

gmackall commented Apr 30, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Pre-launch Checklist

Uh oh!

gmackall May 2, 2025

Choose a reason for hiding this comment

Uh oh!

reidbaker commented May 12, 2025

Uh oh!

gmackall commented May 12, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

gmackall commented Apr 30, 2025 •

edited

Loading