Skip to content

Revert "[Impeller] Make incremental builds faster when tinkering on the compiler." #167965

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
auto-submit merged 1 commit into from
Apr 29, 2025
Merged

Revert "[Impeller] Make incremental builds faster when tinkering on the compiler." #167965

auto-submit merged 1 commit into from
Apr 29, 2025

Conversation

@chinmaygarde
Copy link
Member

@chinmaygarde chinmaygarde commented Apr 28, 2025

Reverts #167492

Makes things slower if the sources are newer than the outputs.

@github-actions github-actions bot added engine flutter/engine related. See also e: labels. e: impeller Impeller rendering backend issues and features requests labels Apr 28, 2025
flar
flar approved these changes Apr 28, 2025
View reviewed changes
Copy link
Contributor

@flar flar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RSLGTM

@chinmaygarde chinmaygarde added the autosubmit Merge PR when tree becomes green via auto submit App label Apr 28, 2025
@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Apr 28, 2025
@auto-submit
Copy link
Contributor

auto-submit bot commented Apr 28, 2025

autosubmit label was removed for flutter/flutter/167965, because - The status or check suite Windows build_tests_6_9 has failed. Please fix the issues identified (or deflake) before re-applying this label.

@chinmaygarde chinmaygarde added the autosubmit Merge PR when tree becomes green via auto submit App label Apr 29, 2025
@auto-submit auto-submit bot added this pull request to the merge queue Apr 29, 2025
Merged via the queue into master with commit f9f6953 Apr 29, 2025
186 checks passed
@auto-submit auto-submit bot deleted the revert-167492-fasterincbuilds branch April 29, 2025 04:59
@flutter-dashboard flutter-dashboard bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Apr 29, 2025
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 29, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 29, 2025
@engine-flutter-autoroll
f9f6953ef Revert "[Impeller] Make incremental builds faster when tink…
9c8f0db 
…ering on the compiler." (flutter/flutter#167965)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 29, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 29, 2025
@engine-flutter-autoroll
f9f6953ef Revert "[Impeller] Make incremental builds faster when tink…
40bf589 
…ering on the compiler." (flutter/flutter#167965)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 29, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 29, 2025
@engine-flutter-autoroll
f9f6953ef Revert "[Impeller] Make incremental builds faster when tink…
3b16b8f 
…ering on the compiler." (flutter/flutter#167965)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 30, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 30, 2025
@engine-flutter-autoroll
f9f6953ef Revert "[Impeller] Make incremental builds faster when tink…
0064dec 
…ering on the compiler." (flutter/flutter#167965)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 30, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 30, 2025
@engine-flutter-autoroll
f9f6953ef Revert "[Impeller] Make incremental builds faster when tink…
d3c1337 
…ering on the compiler." (flutter/flutter#167965)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 1, 2025
@engine-flutter-autoroll
f9f6953ef Revert "[Impeller] Make incremental builds faster when tink…
a03ac46 
…ering on the compiler." (flutter/flutter#167965)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 1, 2025
@engine-flutter-autoroll
f9f6953ef Revert "[Impeller] Make incremental builds faster when tink…
6fec97c 
…ering on the compiler." (flutter/flutter#167965)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 1, 2025
@engine-flutter-autoroll
f9f6953ef Revert "[Impeller] Make incremental builds faster when tink…
02614df 
…ering on the compiler." (flutter/flutter#167965)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 1, 2025
@engine-flutter-autoroll
f9f6953ef Revert "[Impeller] Make incremental builds faster when tink…
2c708ce 
…ering on the compiler." (flutter/flutter#167965)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 1, 2025
@engine-flutter-autoroll
f9f6953ef Revert "[Impeller] Make incremental builds faster when tink…
5586eab 
…ering on the compiler." (flutter/flutter#167965)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 1, 2025
@engine-flutter-autoroll
f9f6953ef Revert "[Impeller] Make incremental builds faster when tink…
3eccd6d 
…ering on the compiler." (flutter/flutter#167965)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 1, 2025
@engine-flutter-autoroll
f9f6953ef Revert "[Impeller] Make incremental builds faster when tink…
2f09eea 
…ering on the compiler." (flutter/flutter#167965)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 2, 2025
@engine-flutter-autoroll
f9f6953ef Revert "[Impeller] Make incremental builds faster when tink…
fa34324 
…ering on the compiler." (flutter/flutter#167965)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 2, 2025
@engine-flutter-autoroll
f9f6953ef Revert "[Impeller] Make incremental builds faster when tink…
4bd33c2 
…ering on the compiler." (flutter/flutter#167965)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 3, 2025
@engine-flutter-autoroll
f9f6953ef Revert "[Impeller] Make incremental builds faster when tink…
661d6c0 
…ering on the compiler." (flutter/flutter#167965)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 3, 2025
@engine-flutter-autoroll
f9f6953ef Revert "[Impeller] Make incremental builds faster when tink…
5a187f7 
…ering on the compiler." (flutter/flutter#167965)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 4, 2025
@engine-flutter-autoroll
f9f6953ef Revert "[Impeller] Make incremental builds faster when tink…
407f320 
…ering on the compiler." (flutter/flutter#167965)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 5, 2025
@engine-flutter-autoroll
f9f6953ef Revert "[Impeller] Make incremental builds faster when tink…
e5bee3a 
…ering on the compiler." (flutter/flutter#167965)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 5, 2025
@engine-flutter-autoroll
f9f6953ef Revert "[Impeller] Make incremental builds faster when tink…
c19b1c8 
…ering on the compiler." (flutter/flutter#167965)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 5, 2025
@engine-flutter-autoroll
f9f6953ef Revert "[Impeller] Make incremental builds faster when tink…
6a97b39 
…ering on the compiler." (flutter/flutter#167965)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 5, 2025
@engine-flutter-autoroll
f9f6953ef Revert "[Impeller] Make incremental builds faster when tink…
f84ca85 
…ering on the compiler." (flutter/flutter#167965)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 5, 2025
@engine-flutter-autoroll
f9f6953ef Revert "[Impeller] Make incremental builds faster when tink…
5c67d46 
…ering on the compiler." (flutter/flutter#167965)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 5, 2025
@engine-flutter-autoroll
f9f6953ef Revert "[Impeller] Make incremental builds faster when tink…
9cae59b 
…ering on the compiler." (flutter/flutter#167965)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 5, 2025
@engine-flutter-autoroll
f9f6953ef Revert "[Impeller] Make incremental builds faster when tink…
bddb2ae 
…ering on the compiler." (flutter/flutter#167965)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 5, 2025
@engine-flutter-autoroll
f9f6953ef Revert "[Impeller] Make incremental builds faster when tink…
faf17b2 
…ering on the compiler." (flutter/flutter#167965)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 6, 2025
@engine-flutter-autoroll
f9f6953ef Revert "[Impeller] Make incremental builds faster when tink…
365aba2 
…ering on the compiler." (flutter/flutter#167965)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 6, 2025
@engine-flutter-autoroll
f9f6953ef Revert "[Impeller] Make incremental builds faster when tink…
d8cfbd0 
…ering on the compiler." (flutter/flutter#167965)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 6, 2025
@engine-flutter-autoroll
f9f6953ef Revert "[Impeller] Make incremental builds faster when tink…
9395ad2 
…ering on the compiler." (flutter/flutter#167965)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 6, 2025
@engine-flutter-autoroll
f9f6953ef Revert "[Impeller] Make incremental builds faster when tink…
2ea9a6b 
…ering on the compiler." (flutter/flutter#167965)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 7, 2025
@engine-flutter-autoroll
f9f6953ef Revert "[Impeller] Make incremental builds faster when tink…
c27e54a 
…ering on the compiler." (flutter/flutter#167965)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 7, 2025
@engine-flutter-autoroll
f9f6953ef Revert "[Impeller] Make incremental builds faster when tink…
c198b22 
…ering on the compiler." (flutter/flutter#167965)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 7, 2025
@engine-flutter-autoroll
f9f6953ef Revert "[Impeller] Make incremental builds faster when tink…
a6ff339 
…ering on the compiler." (flutter/flutter#167965)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 7, 2025
@engine-flutter-autoroll
f9f6953ef Revert "[Impeller] Make incremental builds faster when tink…
a1f4dda 
…ering on the compiler." (flutter/flutter#167965)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 7, 2025
@engine-flutter-autoroll
f9f6953ef Revert "[Impeller] Make incremental builds faster when tink…
d2ec229 
…ering on the compiler." (flutter/flutter#167965)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 7, 2025
@engine-flutter-autoroll
f9f6953ef Revert "[Impeller] Make incremental builds faster when tink…
5187d6e 
…ering on the compiler." (flutter/flutter#167965)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 7, 2025
@engine-flutter-autoroll
f9f6953ef Revert "[Impeller] Make incremental builds faster when tink…
1e689ce 
…ering on the compiler." (flutter/flutter#167965)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 14, 2025
@engine-flutter-autoroll
f9f6953ef Revert "[Impeller] Make incremental builds faster when tink…
2e88e5e 
…ering on the compiler." (flutter/flutter#167965)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 14, 2025
@engine-flutter-autoroll
f9f6953ef Revert "[Impeller] Make incremental builds faster when tink…
8475c08 
…ering on the compiler." (flutter/flutter#167965)
romanejaquez pushed a commit to romanejaquez/flutter that referenced this pull request Aug 14, 2025
@chinmaygarde @romanejaquez
Revert "[Impeller] Make incremental builds faster when tinkering on t…
5d6838e 
…he compiler." (flutter#167965)

Reverts flutter#167492

Makes things slower if the sources are newer than the outputs.
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 15, 2025
@engine-flutter-autoroll
f9f6953ef Revert "[Impeller] Make incremental builds faster when tink…
3050b58 
…ering on the compiler." (flutter/flutter#167965)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 15, 2025
@engine-flutter-autoroll
f9f6953ef Revert "[Impeller] Make incremental builds faster when tink…
58ead15 
…ering on the compiler." (flutter/flutter#167965)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 16, 2025
@engine-flutter-autoroll
f9f6953ef Revert "[Impeller] Make incremental builds faster when tink…
dacd394 
…ering on the compiler." (flutter/flutter#167965)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@flar flar flar approved these changes

Assignees

No one assigned

Labels

e: impeller Impeller rendering backend issues and features requests engine flutter/engine related. See also e: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@chinmaygarde @flar