Replace hardcoded host and app level build.gradle paths with `AndroidProject`-level getters in `gradle_errors.dart` #167949

AbdeMohlbi · 2025-04-28T18:37:07Z

this PR refactors the usage of :

project.directory.childDirectory('android').childDirectory('app').childFile('build.gradle') to
project.android.appGradleFile
project.directory.childDirectory('android').childFile('build.gradle') to project.android.hostAppGradleFile
to include the cases of usage of build.gradle.kts in new templates which may may produce confusing errors to new devs

Pre-launch Checklist

I read the Contributor Guide and followed the process outlined there for submitting PRs.
I read the Tree Hygiene wiki page, which explains my responsibilities.
I followed the breaking change policy and added Data Driven Fixes where supported.
All existing and new tests are passing.
I signed the CLA.
I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
I listed at least one issue that this PR fixes in the description above.
I updated/added relevant documentation (doc comments with ///).
I added new tests to check the change I am making, or this PR is test-exempt.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

flutter-dashboard · 2025-04-28T18:37:09Z

It looks like this pull request may not have tests. Please make sure to add tests or get an explicit test exemption before merging.

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.If you believe this PR qualifies for a test exemption, contact "@test-exemption-reviewer" in the #hackers channel in Discord (don't just cc them here, they won't see it!). The test exemption team is a small volunteer group, so all reviewers should feel empowered to ask for tests, without delegating that responsibility entirely to the test exemption group.

reidbaker · 2025-04-28T18:44:16Z

packages/flutter_tools/lib/src/android/gradle_errors.dart

        .childDirectory('android')
        .childDirectory('app')
-        .childFile('build.gradle');
+        .childFile('build.gradle.kts');


I think this breaks our support for build.gradle files.

My suggestion would be to replace these getters with project.android.appGradleFile then modify the implementation of appGradleFile to return build.gradle if it exists and if not check build.gradle.kts.

seems fair , but wouldn't that break other tests that have some values hard coded some where ?

I am hoping it wont break tests because if the old gradle file is there then it will be returned. This will require new tests for the appGradleFile method.

…eFile`

flutter-dashboard · 2025-05-05T18:18:26Z

Golden file changes have been found for this pull request. Click here to view and triage (e.g. because this is an intentional change).

If you are still iterating on this change and are not ready to resolve the images on the Flutter Gold dashboard, consider marking this PR as a draft pull request above. You will still be able to view image results on the dashboard, commenting will be silenced, and the check will not try to resolve itself until marked ready for review.

For more guidance, visit Writing a golden file test for package:flutter.

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

Changes reported for pull request #167949 at sha 759f113

reidbaker

Sorry for the delay this feel off my queue.

AbdeMohlbi · 2025-05-13T07:26:07Z

Sorry for the delay this feel off my queue.

Yeah i also need to change the PR description according to what really changed

ash2moon · 2025-05-13T17:32:35Z

Other than the PR description that needs to be updated, are there any further changes being made to this PR or is it ready to be reviewed?

reidbaker · 2025-05-13T17:35:11Z

@ash2moon I think the code is ready to land so please review.

reidbaker · 2025-05-13T17:35:48Z

FWIW the description has already been updated

AbdeMohlbi · 2025-05-13T17:59:45Z

Other than the PR description that needs to be updated, are there any further changes being made to this PR or is it ready to be reviewed?

@ash2moon yes it is ready thank u

gmackall

Thanks for this change! I've modified the title and description slightly to reflect the changes.

AbdeMohlbi · 2025-05-13T18:00:42Z

Thanks for this change! I've modified the title and description slightly to reflect the changes.

thank u and sorry for the delay

…h `AndroidProject`-level getters in `gradle_errors.dart` (flutter/flutter#167949)

flutter/flutter@336a7ec...0b9f928 2025-05-14 [email protected] Fix Linux Impeller support broken by incorrect deletion of stencil buffer. (flutter/flutter#168668) 2025-05-14 [email protected] Roll Fuchsia Linux SDK from 6J81agNhuK4q255Jj... to fSvuEJgRmHxnewRJr... (flutter/flutter#168794) 2025-05-14 [email protected] Run `{Platform} flutter_packaging` builders on release candidates. (flutter/flutter#168762) 2025-05-14 [email protected] Remove `docs_deploy_beta`, fix `docs_publish`, add comments. (flutter/flutter#168754) 2025-05-14 [email protected] Add `titleAlignment` to `CheckboxListTile` and `RadioListTile` (flutter/flutter#168666) 2025-05-14 [email protected] Remove deprecated todo about caching (flutter/flutter#168534) 2025-05-13 [email protected] Replace hardcoded host and app level build.gradle paths with `AndroidProject`-level getters in `gradle_errors.dart` (flutter/flutter#167949) 2025-05-13 [email protected] Improve documentation for KeyedSubtree constructor (flutter/flutter#167198) 2025-05-13 [email protected] Wire up the system text scaler from `PlatformDispatcher` (flutter/flutter#159999) 2025-05-13 [email protected] Roll Dart SDK from 645d04a7a964 to b3520981e0f0 (3 revisions) (flutter/flutter#168721) 2025-05-13 [email protected] [a11y] Semanctis flag refactor step 3: framework part (flutter/flutter#167771) 2025-05-13 [email protected] Remove/replace the `team` label with `c: contributor-productivity`. (flutter/flutter#168702) 2025-05-13 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Clip search artifacts in CupertinoSliverNavigationBar searchable-to-searchable transitions (#168510)" (flutter/flutter#168775) 2025-05-13 [email protected] Use live region in error text input decorator for Android (flutter/flutter#165531) 2025-05-13 [email protected] [tool] Fix deprecated API calls within tool (flutter/flutter#168200) 2025-05-13 [email protected] Clip search artifacts in CupertinoSliverNavigationBar searchable-to-searchable transitions (flutter/flutter#168510) 2025-05-13 [email protected] Fixes hero not shown when remove pages without animation (flutter/flutter#168617) 2025-05-13 [email protected] [iOS] Do not hide selection handles when platform hides system context menu (flutter/flutter#168678) 2025-05-13 [email protected] Updated execution path to silently include --start-paused and updated tests (flutter/flutter#168400) 2025-05-13 [email protected] Roll Packages from 6a28ad9 to 2e166de (2 revisions) (flutter/flutter#168736) 2025-05-13 [email protected] [web] Fix multiline input selection in Chrome. (flutter/flutter#168217) 2025-05-13 [email protected] Call xcode_backend.dart from macos_assemble.sh (flutter/flutter#168108) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

…r#9251) flutter/flutter@336a7ec...0b9f928 2025-05-14 [email protected] Fix Linux Impeller support broken by incorrect deletion of stencil buffer. (flutter/flutter#168668) 2025-05-14 [email protected] Roll Fuchsia Linux SDK from 6J81agNhuK4q255Jj... to fSvuEJgRmHxnewRJr... (flutter/flutter#168794) 2025-05-14 [email protected] Run `{Platform} flutter_packaging` builders on release candidates. (flutter/flutter#168762) 2025-05-14 [email protected] Remove `docs_deploy_beta`, fix `docs_publish`, add comments. (flutter/flutter#168754) 2025-05-14 [email protected] Add `titleAlignment` to `CheckboxListTile` and `RadioListTile` (flutter/flutter#168666) 2025-05-14 [email protected] Remove deprecated todo about caching (flutter/flutter#168534) 2025-05-13 [email protected] Replace hardcoded host and app level build.gradle paths with `AndroidProject`-level getters in `gradle_errors.dart` (flutter/flutter#167949) 2025-05-13 [email protected] Improve documentation for KeyedSubtree constructor (flutter/flutter#167198) 2025-05-13 [email protected] Wire up the system text scaler from `PlatformDispatcher` (flutter/flutter#159999) 2025-05-13 [email protected] Roll Dart SDK from 645d04a7a964 to b3520981e0f0 (3 revisions) (flutter/flutter#168721) 2025-05-13 [email protected] [a11y] Semanctis flag refactor step 3: framework part (flutter/flutter#167771) 2025-05-13 [email protected] Remove/replace the `team` label with `c: contributor-productivity`. (flutter/flutter#168702) 2025-05-13 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Clip search artifacts in CupertinoSliverNavigationBar searchable-to-searchable transitions (#168510)" (flutter/flutter#168775) 2025-05-13 [email protected] Use live region in error text input decorator for Android (flutter/flutter#165531) 2025-05-13 [email protected] [tool] Fix deprecated API calls within tool (flutter/flutter#168200) 2025-05-13 [email protected] Clip search artifacts in CupertinoSliverNavigationBar searchable-to-searchable transitions (flutter/flutter#168510) 2025-05-13 [email protected] Fixes hero not shown when remove pages without animation (flutter/flutter#168617) 2025-05-13 [email protected] [iOS] Do not hide selection handles when platform hides system context menu (flutter/flutter#168678) 2025-05-13 [email protected] Updated execution path to silently include --start-paused and updated tests (flutter/flutter#168400) 2025-05-13 [email protected] Roll Packages from 6a28ad9 to 2e166de (2 revisions) (flutter/flutter#168736) 2025-05-13 [email protected] [web] Fix multiline input selection in Chrome. (flutter/flutter#168217) 2025-05-13 [email protected] Call xcode_backend.dart from macos_assemble.sh (flutter/flutter#168108) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

…h `AndroidProject`-level getters in `gradle_errors.dart` (flutter/flutter#167949)

replace buid.gradle with build.gradle.kts

36a5f60

github-actions bot added the tool Affects the "flutter" command-line tool. See also t: labels. label Apr 28, 2025

Update gradle_errors.dart

e99cbe5

reidbaker reviewed Apr 28, 2025

View reviewed changes

use project.android.appGradleFile and `project.android.hostAppGradl…

5ad1a90

…eFile`

AbdeMohlbi requested a review from reidbaker May 4, 2025 07:33

Merge branch 'master' into master

759f113

flutter-dashboard bot added the will affect goldens Changes to golden files label May 5, 2025

reidbaker requested a review from a team May 12, 2025 15:00

reidbaker approved these changes May 12, 2025

View reviewed changes

ash2moon self-requested a review May 13, 2025 17:33

gmackall changed the title ~~replace buid.gradle with build.gradle.kts~~ Replace hardcoded host and app level build.gradle paths with AndroidProject-level getters in gradle_errors.dart May 13, 2025

gmackall approved these changes May 13, 2025

View reviewed changes

ash2moon approved these changes May 13, 2025

View reviewed changes

gmackall added autosubmit Merge PR when tree becomes green via auto submit App and removed will affect goldens Changes to golden files labels May 13, 2025

auto-submit bot added this pull request to the merge queue May 13, 2025

Merged via the queue into flutter:master with commit 1d3a921 May 14, 2025
143 of 144 checks passed

flutter-dashboard bot removed the autosubmit Merge PR when tree becomes green via auto submit App label May 14, 2025

engine-flutter-autoroll mentioned this pull request May 14, 2025

Roll Flutter from 336a7ecf7b40 to 0b9f9288caf3 (22 revisions) flutter/packages#9251

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 14, 2025

1d3a921df Replace hardcoded host and app level build.gradle paths wit…

84ad7ad

…h `AndroidProject`-level getters in `gradle_errors.dart` (flutter/flutter#167949)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 14, 2025

1d3a921df Replace hardcoded host and app level build.gradle paths wit…

e81debb

…h `AndroidProject`-level getters in `gradle_errors.dart` (flutter/flutter#167949)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 14, 2025

1d3a921df Replace hardcoded host and app level build.gradle paths wit…

49ab872

…h `AndroidProject`-level getters in `gradle_errors.dart` (flutter/flutter#167949)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 15, 2025

1d3a921df Replace hardcoded host and app level build.gradle paths wit…

9fc0f48

…h `AndroidProject`-level getters in `gradle_errors.dart` (flutter/flutter#167949)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 15, 2025

1d3a921df Replace hardcoded host and app level build.gradle paths wit…

8fe5280

…h `AndroidProject`-level getters in `gradle_errors.dart` (flutter/flutter#167949)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 16, 2025

1d3a921df Replace hardcoded host and app level build.gradle paths wit…

d7cea70

…h `AndroidProject`-level getters in `gradle_errors.dart` (flutter/flutter#167949)

Replace hardcoded host and app level build.gradle paths with AndroidProject-level getters in gradle_errors.dart #167949

Replace hardcoded host and app level build.gradle paths with AndroidProject-level getters in gradle_errors.dart #167949

Uh oh!

Conversation

AbdeMohlbi commented Apr 28, 2025 • edited by gmackall Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Pre-launch Checklist

Uh oh!

flutter-dashboard bot commented Apr 28, 2025

Uh oh!

reidbaker Apr 28, 2025

Choose a reason for hiding this comment

Uh oh!

AbdeMohlbi Apr 28, 2025

Choose a reason for hiding this comment

Uh oh!

reidbaker Apr 28, 2025

Choose a reason for hiding this comment

Uh oh!

flutter-dashboard bot commented May 5, 2025

Uh oh!

reidbaker left a comment

Choose a reason for hiding this comment

Uh oh!

AbdeMohlbi commented May 13, 2025

Uh oh!

ash2moon commented May 13, 2025

Uh oh!

reidbaker commented May 13, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

reidbaker commented May 13, 2025

Uh oh!

AbdeMohlbi commented May 13, 2025

Uh oh!

gmackall left a comment

Choose a reason for hiding this comment

Uh oh!

AbdeMohlbi commented May 13, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Replace hardcoded host and app level build.gradle paths with `AndroidProject`-level getters in `gradle_errors.dart` #167949

Replace hardcoded host and app level build.gradle paths with `AndroidProject`-level getters in `gradle_errors.dart` #167949

AbdeMohlbi commented Apr 28, 2025 •

edited by gmackall

Loading

reidbaker commented May 13, 2025 •

edited

Loading