[Impeller] Render rects/ovals/rrects as path sources #167863
Conversation
|
It looks like this pull request may not have tests. Please make sure to add tests or get an explicit test exemption before merging. If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.If you believe this PR qualifies for a test exemption, contact "@test-exemption-reviewer" in the #hackers channel in Discord (don't just cc them here, they won't see it!). The test exemption team is a small volunteer group, so all reviewers should feel empowered to ask for tests, without delegating that responsibility entirely to the test exemption group. |
github-actions
bot
added
engine
|
I will be planning on adding tests in a future commit, but I wanted to test the basic mechanism here first. I also plan to convert super-ellipses to also use the new mechanism once it has passed proof-of-concept. |
|
Golden file changes have been found for this pull request. Click here to view and triage (e.g. because this is an intentional change). If you are still iterating on this change and are not ready to resolve the images on the Flutter Gold dashboard, consider marking this PR as a draft pull request above. You will still be able to view image results on the dashboard, commenting will be silenced, and the check will not try to resolve itself until marked ready for review. For more guidance, visit Writing a golden file test for Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
| ~PathGeometryBase() override; | ||
|
|
||
| protected: | ||
| const union { |
There was a problem hiding this comment.
Or should this be a variant? What happens in the destructor? I think all of the PathSource instances have an empty destructor, but DlPath might need its destructor called.
|
Golden file changes are available for triage from new commit, Click here to view. For more guidance, visit Writing a golden file test for Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
|
This is essentially superseded by #168125 |
1 participant
When basic rendering operations end up in a "general case" situation in Impeller, it converts the basic shape into a path and calls
DrawPath. But, the creation of the path is expensive and all the mechanisms behind drawing a path now only need aPathSourceobject which can replay the path to them.We now have explicit lightweight path source generators which can feed the path drawing operations directly from the source data without having to create a full
impeller::Pathobject.