Skip to content

Conversation

@xuexin
Copy link
Contributor

@xuexin xuexin commented Apr 20, 2018

If Locale's _countryCode is null, calling isEmpth on null object.
And Locale.toString() work fine here.

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

@xuexin
Copy link
Contributor Author

xuexin commented Apr 20, 2018

I signed it!

@googlebot
Copy link

CLAs look good, thanks!

@xster xster requested a review from HansMuller April 20, 2018 19:31
@HansMuller
Copy link
Contributor

Nice fix, thank you!

To complete this PR we'll need a small regression test. You can add one to /usr/local/google/home/hansmuller/github/flutter/packages/flutter_localizations/test

@xuexin
Copy link
Contributor Author

xuexin commented Apr 23, 2018

I'm sorry, I don't know how to run a test on flutter.
Could you give me some guide for that?

@xuexin
Copy link
Contributor Author

xuexin commented Apr 23, 2018

How about this?
Please review it.

@HansMuller
Copy link
Contributor

Thanks for providing the test! Your pull request LGTM.

I will land your change as soon as that's possible.

@googlebot
Copy link

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again. If the bot doesn't comment, it means it doesn't think anything has changed.

@HansMuller HansMuller merged commit 286cd35 into flutter:master Apr 23, 2018
@xuexin xuexin deleted the fix-null-NoSuchMethodError branch April 24, 2018 01:24
DaveShuckerow pushed a commit to DaveShuckerow/flutter that referenced this pull request May 14, 2018
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants