Feat: Add full screen dialog support for dialog routes #167794

rkishan516 · 2025-04-25T04:30:31Z

Feat: Add full screen dialog support for dialog routes
fixes: #165478

Pre-launch Checklist

I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
I read the [Tree Hygiene] wiki page, which explains my responsibilities.
I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
I signed the [CLA].
I listed at least one issue that this PR fixes in the description above.
I updated/added relevant documentation (doc comments with ///).
I added new tests to check the change I am making, or this PR is [test-exempt].
I followed the [breaking change policy] and added [Data Driven Fixes] where supported.
All existing and new tests are passing.

dkwingsmt

Using is to behave differently based on type is a bad style. It was bad before, and having to use two now is a scream for a change.

I suggest we expose this property to ModalRoute to allow subclass override. This makes sense because ModalRoute has a impliesAppBarDismissal to control whether to display this button at all, and it's fair for another method to define what kind of button it should display. We might name this property as bool appBarDismissByClosing, or something else you can think of.

rkishan516 · 2025-05-10T00:11:06Z

Using is to behave differently based on type is a bad style. It was bad before, and having to use two now is a scream for a change.

I suggest we expose this property to ModalRoute to allow subclass override. This makes sense because ModalRoute has a impliesAppBarDismissal to control whether to display this button at all, and it's fair for another method to define what kind of button it should display. We might name this property as bool appBarDismissByClosing, or something else you can think of.

Sure, Even I was hesitating writing that code, but yes moving it to ModalRoute make sensse. I will push the change sometime today.

packages/flutter/lib/src/widgets/routes.dart

dkwingsmt

LGTM except for the comments.

packages/flutter/lib/src/widgets/routes.dart

dkwingsmt · 2025-05-15T22:34:01Z

I've discussed with @MitchellGoodwin offline and here is the takeaway:

In terms of design:
- The name shouldUseAppBarClose is not ideal (not anyone's fault; naming is hard)
- The property fullscreenDialog is used more widely than it should be. Notably, PageRoute shouldn't have fullscreenDialog, since it's not a dialog yet at this level.
- This means that ModelRoute shouldn't have fullscreenDialog either. However, since we're not 100% sure where this property is used, it's hard to decide the solution without the compiler and discussions beyond the scope of this PR.
What we'll do:
- We'll approve this PR as it is now, which adds a new property fullscreenDialog to ModelRoute.
- We'll open a new PR that addresses the last issue above, renaming this property to something else. Specifically,
  - ModelRoute.fullscreenDialog will be directly renamed, since its addition is recent.
  - PageRoute.fullscreenDialog will be renamed with a deprecation.

packages/flutter/lib/src/widgets/routes.dart

MitchellGoodwin

LGTM, pending the TODO comment request

Co-authored-by: Tong Mu <[email protected]>

…tter/flutter#167794)

Roll Flutter from 33cdd8ef31dc to 85564cbba9e7 (39 revisions) flutter/flutter@33cdd8e...85564cb 2025-05-23 98614782+auto-submit[bot]@users.noreply.github.com Reverts "[Reland2] Implements UISceneDelegate dynamically w/ FlutterLaunchEngine (#169276)" (flutter/flutter#169347) 2025-05-23 [email protected] Roll Skia from a01ea49f53a4 to 956fd8b14e22 (1 revision) (flutter/flutter#169334) 2025-05-23 [email protected] Roll Dart SDK from 4de10a11ceb9 to 085f110ecf33 (1 revision) (flutter/flutter#169333) 2025-05-23 [email protected] Roll Skia from bcc7e7fce10e to a01ea49f53a4 (1 revision) (flutter/flutter#169329) 2025-05-23 [email protected] Roll Skia from 18b85aced9b7 to bcc7e7fce10e (3 revisions) (flutter/flutter#169323) 2025-05-23 [email protected] Roll Dart SDK from 2a45b2f88a4f to 4de10a11ceb9 (2 revisions) (flutter/flutter#169322) 2025-05-23 [email protected] Remove patching of `package_config.json` from Flutter Pub wrapper. (flutter/flutter#169306) 2025-05-23 [email protected] Add missing dart_dynamic_modules flag for iOS DDM simulator builds (flutter/flutter#169254) 2025-05-23 [email protected] Roll Skia from ea73ccdc1417 to 18b85aced9b7 (6 revisions) (flutter/flutter#169315) 2025-05-23 [email protected] Add flag to exclude focus for hidden children in Visibility, maintainFocusability. Set maintainFocusability to false in IndexedStack (flutter/flutter#159133) 2025-05-23 [email protected] [Reland2] Implements UISceneDelegate dynamically w/ FlutterLaunchEngine (flutter/flutter#169276) 2025-05-23 [email protected] Roll Dart SDK from 8f85d89fdc23 to 2a45b2f88a4f (6 revisions) (flutter/flutter#169312) 2025-05-23 [email protected] Removes unnecessary parentheses (flutter/flutter#169015) 2025-05-22 [email protected] Unpin test/test_core/test_api packages (flutter/flutter#169198) 2025-05-22 [email protected] [Engine] Fix an edge case of RoundSuperellipseParam::Contains with sharp corners (flutter/flutter#167977) 2025-05-22 [email protected] Replace goldens in test/cupertino/nav_bar_transition_test.dart (flutter/flutter#169172) 2025-05-22 [email protected] Roll Skia from 13a299964c9f to ea73ccdc1417 (35 revisions) (flutter/flutter#169303) 2025-05-22 [email protected] Increase sub-task timeout for Mac web_tool_tests (flutter/flutter#169307) 2025-05-22 [email protected] Fix crash on two finger selection gesture (flutter/flutter#168598) 2025-05-22 [email protected] Disable the ability to opt-out of `explicit-package-dependencies`. (flutter/flutter#169283) 2025-05-22 [email protected] Fixes tab semantics gets dropped if the child produce a semantics node (flutter/flutter#169233) 2025-05-22 [email protected] Skip `{PLAT}_web_tools_test#expression_evaluation_*_test.dart`, turning tree 🔴 (flutter/flutter#169305) 2025-05-22 [email protected] Update tool-internal `generateLocalizations...()` to never use synthetic (`flutter_gen`) packages (flutter/flutter#169285) 2025-05-22 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Make `build_android_host_app_with_module_aar` build using an aar (#169171)" (flutter/flutter#169287) 2025-05-22 [email protected] Increase sub-task timeout for `web_tool_tests_1_2` (flutter/flutter#169277) 2025-05-22 [email protected] refactor the usage of `MediaQuery.sizeOf(context).height` to use the new `.heightOf(context)` (flutter/flutter#168894) 2025-05-22 [email protected] [tool] Add --no-minify flag to JS Compiler (flutter/flutter#169102) 2025-05-22 [email protected] Update ButtonStyle documentation (flutter/flutter#168062) 2025-05-22 [email protected] Fix the issue where DropdownMenu disposes of the controller. (flutter/flutter#168541) 2025-05-22 [email protected] Add bottomSheetScrimBuilder to Scaffold (flutter/flutter#167335) 2025-05-22 98614782+auto-submit[bot]@users.noreply.github.com Reverts "[Reland] Implements UISceneDelegate dynamically w/ FlutterLaunchEngine (#168396) (#168914)" (flutter/flutter#169250) 2025-05-21 [email protected] Roll Dart SDK from 56940edd099d to 8f85d89fdc23 (6 revisions) (flutter/flutter#169237) 2025-05-21 [email protected] Use gestureSettings.touchSlop in PrimaryPointerGestureRecognizer (flutter/flutter#161549) 2025-05-21 [email protected] Normalize BottomAppBarTheme (continue) (flutter/flutter#168966) 2025-05-21 [email protected] [Reland] Implements UISceneDelegate dynamically w/ FlutterLaunchEngine (#168396) (flutter/flutter#168914) 2025-05-21 [email protected] Respect `calendarDelegate` in `showDateRangePicker` (flutter/flutter#168290) 2025-05-21 [email protected] Make `build_android_host_app_with_module_aar` build using an aar (flutter/flutter#169171) 2025-05-21 [email protected] Roll Dart SDK from 7c40eba6bf77 to 56940edd099d (flutter/flutter#169135) 2025-05-21 [email protected] Feat: Add full screen dialog support for dialog routes (flutter/flutter#167794) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. ...

…r#9315) Roll Flutter from 33cdd8ef31dc to 85564cbba9e7 (39 revisions) flutter/flutter@33cdd8e...85564cb 2025-05-23 98614782+auto-submit[bot]@users.noreply.github.com Reverts "[Reland2] Implements UISceneDelegate dynamically w/ FlutterLaunchEngine (#169276)" (flutter/flutter#169347) 2025-05-23 [email protected] Roll Skia from a01ea49f53a4 to 956fd8b14e22 (1 revision) (flutter/flutter#169334) 2025-05-23 [email protected] Roll Dart SDK from 4de10a11ceb9 to 085f110ecf33 (1 revision) (flutter/flutter#169333) 2025-05-23 [email protected] Roll Skia from bcc7e7fce10e to a01ea49f53a4 (1 revision) (flutter/flutter#169329) 2025-05-23 [email protected] Roll Skia from 18b85aced9b7 to bcc7e7fce10e (3 revisions) (flutter/flutter#169323) 2025-05-23 [email protected] Roll Dart SDK from 2a45b2f88a4f to 4de10a11ceb9 (2 revisions) (flutter/flutter#169322) 2025-05-23 [email protected] Remove patching of `package_config.json` from Flutter Pub wrapper. (flutter/flutter#169306) 2025-05-23 [email protected] Add missing dart_dynamic_modules flag for iOS DDM simulator builds (flutter/flutter#169254) 2025-05-23 [email protected] Roll Skia from ea73ccdc1417 to 18b85aced9b7 (6 revisions) (flutter/flutter#169315) 2025-05-23 [email protected] Add flag to exclude focus for hidden children in Visibility, maintainFocusability. Set maintainFocusability to false in IndexedStack (flutter/flutter#159133) 2025-05-23 [email protected] [Reland2] Implements UISceneDelegate dynamically w/ FlutterLaunchEngine (flutter/flutter#169276) 2025-05-23 [email protected] Roll Dart SDK from 8f85d89fdc23 to 2a45b2f88a4f (6 revisions) (flutter/flutter#169312) 2025-05-23 [email protected] Removes unnecessary parentheses (flutter/flutter#169015) 2025-05-22 [email protected] Unpin test/test_core/test_api packages (flutter/flutter#169198) 2025-05-22 [email protected] [Engine] Fix an edge case of RoundSuperellipseParam::Contains with sharp corners (flutter/flutter#167977) 2025-05-22 [email protected] Replace goldens in test/cupertino/nav_bar_transition_test.dart (flutter/flutter#169172) 2025-05-22 [email protected] Roll Skia from 13a299964c9f to ea73ccdc1417 (35 revisions) (flutter/flutter#169303) 2025-05-22 [email protected] Increase sub-task timeout for Mac web_tool_tests (flutter/flutter#169307) 2025-05-22 [email protected] Fix crash on two finger selection gesture (flutter/flutter#168598) 2025-05-22 [email protected] Disable the ability to opt-out of `explicit-package-dependencies`. (flutter/flutter#169283) 2025-05-22 [email protected] Fixes tab semantics gets dropped if the child produce a semantics node (flutter/flutter#169233) 2025-05-22 [email protected] Skip `{PLAT}_web_tools_test#expression_evaluation_*_test.dart`, turning tree 🔴 (flutter/flutter#169305) 2025-05-22 [email protected] Update tool-internal `generateLocalizations...()` to never use synthetic (`flutter_gen`) packages (flutter/flutter#169285) 2025-05-22 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Make `build_android_host_app_with_module_aar` build using an aar (#169171)" (flutter/flutter#169287) 2025-05-22 [email protected] Increase sub-task timeout for `web_tool_tests_1_2` (flutter/flutter#169277) 2025-05-22 [email protected] refactor the usage of `MediaQuery.sizeOf(context).height` to use the new `.heightOf(context)` (flutter/flutter#168894) 2025-05-22 [email protected] [tool] Add --no-minify flag to JS Compiler (flutter/flutter#169102) 2025-05-22 [email protected] Update ButtonStyle documentation (flutter/flutter#168062) 2025-05-22 [email protected] Fix the issue where DropdownMenu disposes of the controller. (flutter/flutter#168541) 2025-05-22 [email protected] Add bottomSheetScrimBuilder to Scaffold (flutter/flutter#167335) 2025-05-22 98614782+auto-submit[bot]@users.noreply.github.com Reverts "[Reland] Implements UISceneDelegate dynamically w/ FlutterLaunchEngine (#168396) (#168914)" (flutter/flutter#169250) 2025-05-21 [email protected] Roll Dart SDK from 56940edd099d to 8f85d89fdc23 (6 revisions) (flutter/flutter#169237) 2025-05-21 [email protected] Use gestureSettings.touchSlop in PrimaryPointerGestureRecognizer (flutter/flutter#161549) 2025-05-21 [email protected] Normalize BottomAppBarTheme (continue) (flutter/flutter#168966) 2025-05-21 [email protected] [Reland] Implements UISceneDelegate dynamically w/ FlutterLaunchEngine (#168396) (flutter/flutter#168914) 2025-05-21 [email protected] Respect `calendarDelegate` in `showDateRangePicker` (flutter/flutter#168290) 2025-05-21 [email protected] Make `build_android_host_app_with_module_aar` build using an aar (flutter/flutter#169171) 2025-05-21 [email protected] Roll Dart SDK from 7c40eba6bf77 to 56940edd099d (flutter/flutter#169135) 2025-05-21 [email protected] Feat: Add full screen dialog support for dialog routes (flutter/flutter#167794) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. ...

…tter/flutter#167794)

github-actions bot added framework flutter/packages/flutter repository. See also f: labels. f: material design flutter/packages/flutter/material repository. f: routes Navigator, Router, and related APIs. labels Apr 25, 2025

dkwingsmt self-requested a review April 30, 2025 18:34

dkwingsmt reviewed May 9, 2025

View reviewed changes

rkishan516 force-pushed the fullscreen-dialog branch 3 times, most recently from 660fa47 to 2de0aa3 Compare May 10, 2025 01:09

dkwingsmt reviewed May 14, 2025

View reviewed changes

packages/flutter/lib/src/widgets/routes.dart Outdated Show resolved Hide resolved

dkwingsmt reviewed May 14, 2025

View reviewed changes

packages/flutter/lib/src/widgets/routes.dart Show resolved Hide resolved

dkwingsmt approved these changes May 14, 2025

View reviewed changes

dkwingsmt requested a review from MitchellGoodwin May 14, 2025 18:36

MitchellGoodwin reviewed May 14, 2025

View reviewed changes

packages/flutter/lib/src/widgets/routes.dart Outdated Show resolved Hide resolved

rkishan516 force-pushed the fullscreen-dialog branch from 2de0aa3 to b84c543 Compare May 15, 2025 01:26

dkwingsmt mentioned this pull request May 15, 2025

Rename ModalRoute.fullscreenDialog and PageRoute.fullscreenDialog to something semantically more correct #168949

Open

dkwingsmt reviewed May 15, 2025

View reviewed changes

packages/flutter/lib/src/widgets/routes.dart Show resolved Hide resolved

MitchellGoodwin approved these changes May 15, 2025

View reviewed changes

rkishan516 and others added 4 commits May 16, 2025 11:09

Feat: Add full screen dialog support for dialog routes

efcdc52

Refactor: Replace fullScreenDialog check with shouldUseAppBarClose

d2a6cb8

Refactor: Utlize fullscreenDialog flag

0bbd1e8

Docs: Add TODO for renaming

b7f5666

Co-authored-by: Tong Mu <[email protected]>

dkwingsmt force-pushed the fullscreen-dialog branch from 1ceffdc to b7f5666 Compare May 16, 2025 18:09

dkwingsmt added the autosubmit Merge PR when tree becomes green via auto submit App label May 21, 2025

auto-submit bot added this pull request to the merge queue May 21, 2025

Merged via the queue into flutter:master with commit 78df503 May 21, 2025
76 checks passed

flutter-dashboard bot removed the autosubmit Merge PR when tree becomes green via auto submit App label May 21, 2025

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 22, 2025

78df5036d Feat: Add full screen dialog support for dialog routes (flu…

7a32677

…tter/flutter#167794)

engine-flutter-autoroll mentioned this pull request May 22, 2025

Roll Flutter from 33cdd8ef31dc to e78b434e8f08 (12 revisions) flutter/packages#9307

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 22, 2025

78df5036d Feat: Add full screen dialog support for dialog routes (flu…

c7ea02d

…tter/flutter#167794)

engine-flutter-autoroll mentioned this pull request May 22, 2025

Roll Flutter from 33cdd8ef31dc to cb3150f99848 (13 revisions) flutter/packages#9308

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 22, 2025

78df5036d Feat: Add full screen dialog support for dialog routes (flu…

f3c9438

…tter/flutter#167794)

engine-flutter-autoroll mentioned this pull request May 22, 2025

Roll Flutter from 33cdd8ef31dc to 5fd7aa2ed70d (16 revisions) flutter/packages#9309

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 23, 2025

78df5036d Feat: Add full screen dialog support for dialog routes (flu…

84ef564

…tter/flutter#167794)

engine-flutter-autoroll mentioned this pull request May 23, 2025

Roll Flutter from 33cdd8ef31dc to d5ae7839620b (38 revisions) flutter/packages#9314

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 23, 2025

78df5036d Feat: Add full screen dialog support for dialog routes (flu…

a57bcee

…tter/flutter#167794)

engine-flutter-autoroll mentioned this pull request May 23, 2025

Roll Flutter from 33cdd8ef31dc to 85564cbba9e7 (39 revisions) flutter/packages#9315

Merged

Piinks mentioned this pull request May 23, 2025

Flutter Notable Commits - 2025 #161460

Open

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 14, 2025

78df5036d Feat: Add full screen dialog support for dialog routes (flu…

f19f5e0

…tter/flutter#167794)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 14, 2025

78df5036d Feat: Add full screen dialog support for dialog routes (flu…

9de1ad1

…tter/flutter#167794)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 15, 2025

78df5036d Feat: Add full screen dialog support for dialog routes (flu…

bcaf13b

…tter/flutter#167794)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 15, 2025

78df5036d Feat: Add full screen dialog support for dialog routes (flu…

8b660fa

…tter/flutter#167794)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 16, 2025

78df5036d Feat: Add full screen dialog support for dialog routes (flu…

dcb0cb2

…tter/flutter#167794)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Feat: Add full screen dialog support for dialog routes #167794

Feat: Add full screen dialog support for dialog routes #167794

Uh oh!

rkishan516 commented Apr 25, 2025

Uh oh!

dkwingsmt left a comment •

edited

Loading

Uh oh!

rkishan516 commented May 10, 2025

Uh oh!

Uh oh!

Uh oh!

dkwingsmt left a comment

Uh oh!

Uh oh!

dkwingsmt commented May 15, 2025 •

edited

Loading

Uh oh!

Uh oh!

MitchellGoodwin left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Feat: Add full screen dialog support for dialog routes #167794

Feat: Add full screen dialog support for dialog routes #167794

Uh oh!

Conversation

rkishan516 commented Apr 25, 2025

Pre-launch Checklist

Uh oh!

dkwingsmt left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

rkishan516 commented May 10, 2025

Uh oh!

Uh oh!

Uh oh!

dkwingsmt left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

dkwingsmt commented May 15, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

MitchellGoodwin left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

dkwingsmt left a comment •

edited

Loading

dkwingsmt commented May 15, 2025 •

edited

Loading