Skip to content

Conversation

@jesswrd
Copy link
Contributor

@jesswrd jesswrd commented Apr 24, 2025

Bumping the engine to use Java 21.

Some Java 21 changes that affect our tests:

  • Starting JDK 19, we can no longer use Mockito's mock to fake the ByteBuffer class (mockito issue here). I replaced the usage with a captor instead.
  • Included in the Java 21 Release here are unicode updates that specifically affect chinese characters. It likely affects this unicode accessibility test itCanPredictCursorMovementsWithGranularityWordUnicode in AccessiblityBridgeTest.java, which uses chinese characters.

To reproduce the error in AccessiblityBridgeTest.java locally, follow these steps:

  1. Run et build -c android_debug_unopt
  2. Run gclient sync -D from root
  3. Navigate to engine/src/flutter/third_party/java/openjdk/openjdk.cipd.yaml to make sure JDK 21 has been properly generated. If you see "OpenJDK 21," it has been properly generated.
  4. Navigate to engine/src/flutter and run testing/run_tests.py --android-variant=android_debug_unopt --type=java --java-filter=io.flutter.view.AccessibilityBridgeTest

Pre-launch Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@github-actions github-actions bot added platform-android Android applications specifically engine flutter/engine related. See also e: labels. labels Apr 24, 2025
@jesswrd jesswrd changed the title Java 21 engine Updating Engine to Use Java 21 Apr 24, 2025
@jesswrd jesswrd changed the title Updating Engine to Use Java 21 [Android 16] Updating Engine to Use Java 21 Jun 10, 2025
auto-submit bot pushed a commit to flutter/packages that referenced this pull request Jun 26, 2025
Bumping AVD, SDK we test against to ensure Flutter works on Android 16. Also added potentially missing `android_virtual_device` dependency. This aligns with what has been and/or will be done in framework flutter/flutter#169121 and engine flutter/flutter#169124, flutter/flutter#167776.

Partially Addresses flutter/flutter#163071
Fixes flutter/flutter#137083

## Pre-Review Checklist

[^1]: Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling.
vashworth pushed a commit to vashworth/packages that referenced this pull request Jul 30, 2025
Bumping AVD, SDK we test against to ensure Flutter works on Android 16. Also added potentially missing `android_virtual_device` dependency. This aligns with what has been and/or will be done in framework flutter/flutter#169121 and engine flutter/flutter#169124, flutter/flutter#167776.

Partially Addresses flutter/flutter#163071
Fixes flutter/flutter#137083

## Pre-Review Checklist

[^1]: Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling.
@Piinks
Copy link
Contributor

Piinks commented Aug 11, 2025

Hey @jesswrd, greetings from stale PR triage! 👋 Is this one still on your radar?

@jesswrd
Copy link
Contributor Author

jesswrd commented Sep 15, 2025

Hey @jesswrd, greetings from stale PR triage! 👋 Is this one still on your radar?

nope closing now.

@jesswrd jesswrd closed this Sep 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

engine flutter/engine related. See also e: labels. platform-android Android applications specifically

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants