[WebParagraph] Initial wiring for the experimental WebParagraph implementation #167763
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It looks like this pull request may not have tests. Please make sure to add tests or get an explicit test exemption before merging. If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.If you believe this PR qualifies for a test exemption, contact "@test-exemption-reviewer" in the #hackers channel in Discord (don't just cc them here, they won't see it!). The test exemption team is a small volunteer group, so all reviewers should feel empowered to ask for tests, without delegating that responsibility entirely to the test exemption group. |
github-actions
bot
added
engine
mdebbar
changed the title
eyebrowsoffire
requested changes
Apr 30, 2025
eyebrowsoffire
requested changes
May 1, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
May 5, 2025
…raph implementation (flutter/flutter#167763)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
May 5, 2025
…raph implementation (flutter/flutter#167763)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
May 5, 2025
…raph implementation (flutter/flutter#167763)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
May 5, 2025
…raph implementation (flutter/flutter#167763)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
May 5, 2025
…raph implementation (flutter/flutter#167763)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
May 6, 2025
…raph implementation (flutter/flutter#167763)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
May 6, 2025
…raph implementation (flutter/flutter#167763)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
May 6, 2025
…raph implementation (flutter/flutter#167763)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
May 6, 2025
…raph implementation (flutter/flutter#167763)
mboetger
pushed a commit
to mboetger/flutter
that referenced
this pull request
May 6, 2025
…mentation (flutter#167763) In this PR: - `felt build --experimental-webparagraph` builds a 3rd variant of CanvasKit to be used for `WebParagraph`. - `felt test --suite=chrome-dart2js-experimental-webparagraph-ui` runs `test/ui/` tests against `WebParagraph`. - `felt test --suite=chrome-dart2js-experimental-webparagraph-ui` runs Chrome with the extra flag: - `--enable-experimental-web-platform-features` In the future: - Upgrade to [email protected] or above. - Actual implementation and tests of WebParagraph coming in flutter#167559 - Run the `chrome-dart2js-experimental-webparagraph-ui` suite in CI. - Trim the new experimental build of CK to realize the reduction in size.
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
May 7, 2025
…raph implementation (flutter/flutter#167763)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
May 7, 2025
…raph implementation (flutter/flutter#167763)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
May 7, 2025
…raph implementation (flutter/flutter#167763)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
May 7, 2025
…raph implementation (flutter/flutter#167763)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
May 7, 2025
…raph implementation (flutter/flutter#167763)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
May 7, 2025
…raph implementation (flutter/flutter#167763)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
May 7, 2025
…raph implementation (flutter/flutter#167763)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 14, 2025
…raph implementation (flutter/flutter#167763)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 14, 2025
…raph implementation (flutter/flutter#167763)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 15, 2025
…raph implementation (flutter/flutter#167763)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 15, 2025
…raph implementation (flutter/flutter#167763)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 16, 2025
…raph implementation (flutter/flutter#167763)
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR:
felt build --experimental-webparagraphbuilds a 3rd variant of CanvasKit to be used forWebParagraph.felt test --suite=chrome-dart2js-experimental-webparagraph-uirunstest/ui/tests againstWebParagraph.felt test --suite=chrome-dart2js-experimental-webparagraph-uiruns Chrome with the extra flag:--enable-experimental-web-platform-featuresIn the future:
chrome-dart2js-experimental-webparagraph-uisuite in CI.Part of #172561