Skip to content

Conversation

@gnprice
Copy link
Member

@gnprice gnprice commented Apr 24, 2025

This pulls in the 4 commits below:

flutter/tests@8be7209...c9cbc60

2025-04-24 [email protected] Bump Zulip pin to update sliver z-order tests (flutter/tests#456) 2025-04-17 [email protected] Revert "Disable flutter_devtools.test" (flutter/tests#455) 2025-04-15 [email protected] Update zulip hash to pick up version that can be analyzed cleanly. (flutter/tests#453) 2025-04-15 [email protected] Disable flutter_devtools.test (flutter/tests#452)

(using the command from 5ce5251 / #162763 to make the log).

The two changes from 2025-04-15 had been here since db68c95 (#16721), but then it looks like they were accidentally reverted earlier today by 417f47f (#165596).

The change from 04-17 doesn't appear to have made it here to flutter/flutter yet.

The latest change just went into flutter/tests today and is why I'm making this PR.

Pre-launch Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

This pulls in the 4 commits below:

flutter/tests@8be7209...c9cbc60

2025-04-24 [email protected] Bump Zulip pin to update sliver z-order tests (flutter/tests#456)
2025-04-17 [email protected] Revert "Disable flutter_devtools.test" (flutter/tests#455)
2025-04-15 [email protected] Update zulip hash to pick up version that can be analyzed cleanly. (flutter/tests#453)
2025-04-15 [email protected] Disable flutter_devtools.test (flutter/tests#452)

(using the command from 5ce5251 / flutter#162763 to make the log).

The two changes from 2025-04-15 had been here since db68c95 (flutter#16721),
but then it looks like they were accidentally reverted earlier today
by 417f47f (flutter#165596).

The change from 04-17 doesn't appear to have made it here to
flutter/flutter yet.

The latest change just went into flutter/tests today and is why I'm
making this PR.
@gnprice gnprice requested a review from Piinks April 24, 2025 19:47
@flutter-dashboard
Copy link

It looks like this pull request may not have tests. Please make sure to add tests or get an explicit test exemption before merging.

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.If you believe this PR qualifies for a test exemption, contact "@test-exemption-reviewer" in the #hackers channel in Discord (don't just cc them here, they won't see it!). The test exemption team is a small volunteer group, so all reviewers should feel empowered to ask for tests, without delegating that responsibility entirely to the test exemption group.

@gnprice
Copy link
Member Author

gnprice commented Apr 24, 2025

(@QuncCccccc FYI from #165596)

auto-submit bot pushed a commit to flutter/cocoon that referenced this pull request Apr 24, 2025
Makes the file test exempt. We could alternately count it as a test, but I think it is rare (and not a great practice) for someone to test the changes in their PR exclusively by modifying an element of the customer tests.

Motivated by flutter/flutter#167754
Copy link
Contributor

@Piinks Piinks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Piinks Piinks added the autosubmit Merge PR when tree becomes green via auto submit App label Apr 24, 2025
@auto-submit auto-submit bot added this pull request to the merge queue Apr 24, 2025
Merged via the queue into flutter:master with commit aecdc12 Apr 24, 2025
151 checks passed
@flutter-dashboard flutter-dashboard bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Apr 24, 2025
@gnprice gnprice deleted the pr-tests branch April 25, 2025 00:06
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 25, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 25, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 25, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 25, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 25, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 26, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 26, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 27, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 2, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 2, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 3, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 3, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 4, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 5, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 5, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 5, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 5, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 5, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 5, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 5, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 5, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 6, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 6, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 6, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 6, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 7, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 7, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 7, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 7, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 7, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 7, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 7, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 14, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 14, 2025
romanejaquez pushed a commit to romanejaquez/flutter that referenced this pull request Aug 14, 2025
…7754)

This pulls in the 4 commits below:

flutter/tests@8be7209...c9cbc60

2025-04-24 [email protected] Bump Zulip pin to update sliver z-order tests
(flutter/tests#456) 2025-04-17
[email protected] Revert "Disable
flutter_devtools.test" (flutter/tests#455) 2025-04-15 [email protected]
Update zulip hash to pick up version that can be analyzed cleanly.
(flutter/tests#453) 2025-04-15 [email protected] Disable
flutter_devtools.test (flutter/tests#452)

(using the command from 5ce5251 / flutter#162763 to make the log).

The two changes from 2025-04-15 had been here since db68c95 (flutter#16721),
but then it looks like they were accidentally reverted earlier today by
417f47f (flutter#165596).

The change from 04-17 doesn't appear to have made it here to
flutter/flutter yet.

The latest change just went into flutter/tests today and is why I'm
making this PR.

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [ ] I listed at least one issue that this PR fixes in the description
above.
- [ ] I updated/added relevant documentation (doc comments with `///`).
- [ ] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 15, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 15, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants