Skip to content

Fix a race in ShellTest.EncodeImageFailsWithoutGPUImpeller #167669

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
auto-submit merged 1 commit into from
Apr 23, 2025
Merged

Fix a race in ShellTest.EncodeImageFailsWithoutGPUImpeller #167669

auto-submit merged 1 commit into from
Apr 23, 2025

Conversation

@jason-simmons
Copy link
Member

@jason-simmons jason-simmons commented Apr 23, 2025

No description provided.

@github-actions github-actions bot added the engine flutter/engine related. See also e: labels. label Apr 23, 2025
jonahwilliams
jonahwilliams approved these changes Apr 23, 2025
View reviewed changes
Copy link
Contributor

@jonahwilliams jonahwilliams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jason-simmons jason-simmons mentioned this pull request Apr 23, 2025
Merged
@jason-simmons jason-simmons added the autosubmit Merge PR when tree becomes green via auto submit App label Apr 23, 2025
@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Apr 23, 2025
@auto-submit
Copy link
Contributor

auto-submit bot commented Apr 23, 2025

autosubmit label was removed for flutter/flutter/167669, because - The status or check suite Google testing has failed. Please fix the issues identified (or deflake) before re-applying this label.

@jason-simmons jason-simmons added the autosubmit Merge PR when tree becomes green via auto submit App label Apr 23, 2025
@auto-submit auto-submit bot added this pull request to the merge queue Apr 23, 2025
Merged via the queue into flutter:master with commit e1630da Apr 23, 2025
179 of 180 checks passed
@flutter-dashboard flutter-dashboard bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Apr 23, 2025
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 24, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 24, 2025
@engine-flutter-autoroll
e1630da24 Fix a race in ShellTest.EncodeImageFailsWithoutGPUImpeller (f…
fe172c4 
…lutter/flutter#167669)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 24, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 24, 2025
@engine-flutter-autoroll
e1630da24 Fix a race in ShellTest.EncodeImageFailsWithoutGPUImpeller (f…
b070799 
…lutter/flutter#167669)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 24, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 24, 2025
@engine-flutter-autoroll
e1630da24 Fix a race in ShellTest.EncodeImageFailsWithoutGPUImpeller (f…
77fb632 
…lutter/flutter#167669)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 24, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 24, 2025
@engine-flutter-autoroll
e1630da24 Fix a race in ShellTest.EncodeImageFailsWithoutGPUImpeller (f…
750ea1d 
…lutter/flutter#167669)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 24, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 24, 2025
@engine-flutter-autoroll
e1630da24 Fix a race in ShellTest.EncodeImageFailsWithoutGPUImpeller (f…
5fe75a0 
…lutter/flutter#167669)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 24, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 24, 2025
@engine-flutter-autoroll
e1630da24 Fix a race in ShellTest.EncodeImageFailsWithoutGPUImpeller (f…
9d9b46f 
…lutter/flutter#167669)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 24, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 24, 2025
@engine-flutter-autoroll
e1630da24 Fix a race in ShellTest.EncodeImageFailsWithoutGPUImpeller (f…
afdbc65 
…lutter/flutter#167669)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 25, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 25, 2025
@engine-flutter-autoroll
e1630da24 Fix a race in ShellTest.EncodeImageFailsWithoutGPUImpeller (f…
0e3bcc8 
…lutter/flutter#167669)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 25, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 2, 2025
@engine-flutter-autoroll
e1630da24 Fix a race in ShellTest.EncodeImageFailsWithoutGPUImpeller (f…
2f0bd3a 
…lutter/flutter#167669)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 2, 2025
@engine-flutter-autoroll
e1630da24 Fix a race in ShellTest.EncodeImageFailsWithoutGPUImpeller (f…
ef01d38 
…lutter/flutter#167669)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 3, 2025
@engine-flutter-autoroll
e1630da24 Fix a race in ShellTest.EncodeImageFailsWithoutGPUImpeller (f…
b593bae 
…lutter/flutter#167669)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 3, 2025
@engine-flutter-autoroll
e1630da24 Fix a race in ShellTest.EncodeImageFailsWithoutGPUImpeller (f…
0081ee3 
…lutter/flutter#167669)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 4, 2025
@engine-flutter-autoroll
e1630da24 Fix a race in ShellTest.EncodeImageFailsWithoutGPUImpeller (f…
7e5583b 
…lutter/flutter#167669)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 5, 2025
@engine-flutter-autoroll
e1630da24 Fix a race in ShellTest.EncodeImageFailsWithoutGPUImpeller (f…
7862d34 
…lutter/flutter#167669)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 5, 2025
@engine-flutter-autoroll
e1630da24 Fix a race in ShellTest.EncodeImageFailsWithoutGPUImpeller (f…
9a9facf 
…lutter/flutter#167669)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 5, 2025
@engine-flutter-autoroll
e1630da24 Fix a race in ShellTest.EncodeImageFailsWithoutGPUImpeller (f…
152d349 
…lutter/flutter#167669)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 5, 2025
@engine-flutter-autoroll
e1630da24 Fix a race in ShellTest.EncodeImageFailsWithoutGPUImpeller (f…
fe9f402 
…lutter/flutter#167669)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 5, 2025
@engine-flutter-autoroll
e1630da24 Fix a race in ShellTest.EncodeImageFailsWithoutGPUImpeller (f…
763bc5e 
…lutter/flutter#167669)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 5, 2025
@engine-flutter-autoroll
e1630da24 Fix a race in ShellTest.EncodeImageFailsWithoutGPUImpeller (f…
ada4e0f 
…lutter/flutter#167669)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 5, 2025
@engine-flutter-autoroll
e1630da24 Fix a race in ShellTest.EncodeImageFailsWithoutGPUImpeller (f…
dd5a263 
…lutter/flutter#167669)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 5, 2025
@engine-flutter-autoroll
e1630da24 Fix a race in ShellTest.EncodeImageFailsWithoutGPUImpeller (f…
2cb7f11 
…lutter/flutter#167669)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 6, 2025
@engine-flutter-autoroll
e1630da24 Fix a race in ShellTest.EncodeImageFailsWithoutGPUImpeller (f…
8e9e13f 
…lutter/flutter#167669)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 6, 2025
@engine-flutter-autoroll
e1630da24 Fix a race in ShellTest.EncodeImageFailsWithoutGPUImpeller (f…
36d697e 
…lutter/flutter#167669)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 6, 2025
@engine-flutter-autoroll
e1630da24 Fix a race in ShellTest.EncodeImageFailsWithoutGPUImpeller (f…
bb445a5 
…lutter/flutter#167669)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 6, 2025
@engine-flutter-autoroll
e1630da24 Fix a race in ShellTest.EncodeImageFailsWithoutGPUImpeller (f…
93354df 
…lutter/flutter#167669)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 7, 2025
@engine-flutter-autoroll
e1630da24 Fix a race in ShellTest.EncodeImageFailsWithoutGPUImpeller (f…
2cb2532 
…lutter/flutter#167669)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 7, 2025
@engine-flutter-autoroll
e1630da24 Fix a race in ShellTest.EncodeImageFailsWithoutGPUImpeller (f…
ec2c3e4 
…lutter/flutter#167669)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 7, 2025
@engine-flutter-autoroll
e1630da24 Fix a race in ShellTest.EncodeImageFailsWithoutGPUImpeller (f…
cbd7e9c 
…lutter/flutter#167669)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 7, 2025
@engine-flutter-autoroll
e1630da24 Fix a race in ShellTest.EncodeImageFailsWithoutGPUImpeller (f…
de269a4 
…lutter/flutter#167669)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 7, 2025
@engine-flutter-autoroll
e1630da24 Fix a race in ShellTest.EncodeImageFailsWithoutGPUImpeller (f…
3ca24d1 
…lutter/flutter#167669)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 7, 2025
@engine-flutter-autoroll
e1630da24 Fix a race in ShellTest.EncodeImageFailsWithoutGPUImpeller (f…
b3fa646 
…lutter/flutter#167669)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 7, 2025
@engine-flutter-autoroll
e1630da24 Fix a race in ShellTest.EncodeImageFailsWithoutGPUImpeller (f…
4d92bc5 
…lutter/flutter#167669)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 14, 2025
@engine-flutter-autoroll
e1630da24 Fix a race in ShellTest.EncodeImageFailsWithoutGPUImpeller (f…
f8fef37 
…lutter/flutter#167669)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 14, 2025
@engine-flutter-autoroll
e1630da24 Fix a race in ShellTest.EncodeImageFailsWithoutGPUImpeller (f…
380dcd0 
…lutter/flutter#167669)
romanejaquez pushed a commit to romanejaquez/flutter that referenced this pull request Aug 14, 2025
@jason-simmons @romanejaquez
Fix a race in ShellTest.EncodeImageFailsWithoutGPUImpeller (flutter#1…
1c4b9b5 
…67669)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 15, 2025
@engine-flutter-autoroll
e1630da24 Fix a race in ShellTest.EncodeImageFailsWithoutGPUImpeller (f…
8ad248d 
…lutter/flutter#167669)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 15, 2025
@engine-flutter-autoroll
e1630da24 Fix a race in ShellTest.EncodeImageFailsWithoutGPUImpeller (f…
dc3c181 
…lutter/flutter#167669)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 16, 2025
@engine-flutter-autoroll
e1630da24 Fix a race in ShellTest.EncodeImageFailsWithoutGPUImpeller (f…
04a5f61 
…lutter/flutter#167669)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@jonahwilliams jonahwilliams jonahwilliams approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

engine flutter/engine related. See also e: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jason-simmons @jonahwilliams