Fix: Delay showing tooltip during page transition #167614
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
framework
dkwingsmt
reviewed
Apr 23, 2025
| final ModalRoute<dynamic>? route = ModalRoute.of(context); | ||
| if (route?.secondaryAnimation != null && route!.secondaryAnimation!.isAnimating) { | ||
| _timer?.cancel(); | ||
| _timer = Timer(route.transitionDuration, show); |
Contributor
There was a problem hiding this comment.
Is it possible to listen to when the animation ends and start the timer then? The current way isn't compatible with cases where this happens halfway during the transition or simulation-based transition where there isn't a predefined duration.
Contributor
Author
There was a problem hiding this comment.
Yaa, was thinking the same. but for some reason below written code doesn't fix the issue.
if (route?.secondaryAnimation != null && route!.secondaryAnimation!.isAnimating) {
_timer?.cancel();
void onAnimationDismiss(AnimationStatus status) {
if (status == AnimationStatus.dismissed) {
route.secondaryAnimation!.removeStatusListener(onAnimationDismiss);
show();
}
}
route.secondaryAnimation!.addStatusListener(onAnimationDismiss);
return;
}
Contributor
There was a problem hiding this comment.
In some cases the secondaryAnimation is swapped for a different one, so that may be why. The secondaryAnimation with the status listener is replaced.
Contributor
There was a problem hiding this comment.
Rather than putting the logic here, should we have the check happen in tandem with the _visible check for _ExclusiveMouseRegion? So it ignores all mouse events while the route transitions are in motion?
Contributor
Author
There was a problem hiding this comment.
Oh yes, that will be better place and we don't even need listener.
Contributor
Author
There was a problem hiding this comment.
Pushed the change, everything looks good. Thanks.
rkishan516
force-pushed
the
tooltip-transition
branch
4 times, most recently
from
4ef9c09 to
0617cf1
Compare
MitchellGoodwin
approved these changes
Apr 29, 2025
Contributor
MitchellGoodwin
left a comment
MitchellGoodwin
left a comment
There was a problem hiding this comment.
LGTM! Thank you for making this fix. Just left one tiny nit.
| expect(tester.element(textAncestors.first).size, equals(tooltipConstraints.biggest)); | ||
| }); | ||
|
|
||
| testWidgets('Tooltip does not show while transitioning from another page', ( |
Contributor
There was a problem hiding this comment.
Extreme nit, for this case I think it needs a link to the issue it is checking against.
Suggested change
| testWidgets('Tooltip does not show while transitioning from another page', ( | |
| // This is a regression test for https://github.com/flutter/flutter/issues/167359. | |
| testWidgets('Tooltip does not show while transitioning from another page', ( |
Contributor
Author
There was a problem hiding this comment.
Thanks for suggestion. Pushed the change.
rkishan516
force-pushed
the
tooltip-transition
branch
from
0617cf1 to
910429c
Compare
flutter-dashboard
bot
removed
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
May 1, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
May 1, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
May 1, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
May 1, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
May 1, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
May 1, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
May 5, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
May 5, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
May 5, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
May 6, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
May 6, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
May 6, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
May 6, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
May 7, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
May 7, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
May 7, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
May 7, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
May 7, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
May 7, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
May 7, 2025
4 tasks
github-merge-queue bot
pushed a commit
that referenced
this pull request
Aug 8, 2025
Makes the tooltip interactive if the route is the current route and the route is not animating out. Added `_route` to cache `ModalRoute.of(context)`. Consolidates [Fix the issue with Tooltip](#168546) and [Delay showing tooltip during page transition](#167614) Fix [[Desktop] [Web] [Regression] [3.32] AppBar back - RenderBox was not laid out - TooltipState._buildTooltipOverlay](#169741)
SydneyBao
pushed a commit
to SydneyBao/flutter
that referenced
this pull request
Aug 11, 2025
Makes the tooltip interactive if the route is the current route and the route is not animating out. Added `_route` to cache `ModalRoute.of(context)`. Consolidates [Fix the issue with Tooltip](flutter#168546) and [Delay showing tooltip during page transition](flutter#167614) Fix [[Desktop] [Web] [Regression] [3.32] AppBar back - RenderBox was not laid out - TooltipState._buildTooltipOverlay](flutter#169741)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 14, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 14, 2025
romanejaquez
pushed a commit
to romanejaquez/flutter
that referenced
this pull request
Aug 14, 2025
Fix: Delay showing tooltip during page transition fixes: flutter#167359 ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [x] I listed at least one issue that this PR fixes in the description above. - [x] I updated/added relevant documentation (doc comments with `///`). - [x] I added new tests to check the change I am making, or this PR is [test-exempt]. - [x] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [x] All existing and new tests are passing.
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 15, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 15, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 16, 2025
ksokolovskyi
pushed a commit
to ksokolovskyi/flutter
that referenced
this pull request
Aug 19, 2025
Makes the tooltip interactive if the route is the current route and the route is not animating out. Added `_route` to cache `ModalRoute.of(context)`. Consolidates [Fix the issue with Tooltip](flutter#168546) and [Delay showing tooltip during page transition](flutter#167614) Fix [[Desktop] [Web] [Regression] [3.32] AppBar back - RenderBox was not laid out - TooltipState._buildTooltipOverlay](flutter#169741)
mboetger
pushed a commit
to mboetger/flutter
that referenced
this pull request
Sep 18, 2025
Makes the tooltip interactive if the route is the current route and the route is not animating out. Added `_route` to cache `ModalRoute.of(context)`. Consolidates [Fix the issue with Tooltip](flutter#168546) and [Delay showing tooltip during page transition](flutter#167614) Fix [[Desktop] [Web] [Regression] [3.32] AppBar back - RenderBox was not laid out - TooltipState._buildTooltipOverlay](flutter#169741)
korca0220
pushed a commit
to korca0220/flutter
that referenced
this pull request
Sep 22, 2025
Makes the tooltip interactive if the route is the current route and the route is not animating out. Added `_route` to cache `ModalRoute.of(context)`. Consolidates [Fix the issue with Tooltip](flutter#168546) and [Delay showing tooltip during page transition](flutter#167614) Fix [[Desktop] [Web] [Regression] [3.32] AppBar back - RenderBox was not laid out - TooltipState._buildTooltipOverlay](flutter#169741)
lucaantonelli
pushed a commit
to lucaantonelli/flutter
that referenced
this pull request
Nov 21, 2025
Makes the tooltip interactive if the route is the current route and the route is not animating out. Added `_route` to cache `ModalRoute.of(context)`. Consolidates [Fix the issue with Tooltip](flutter#168546) and [Delay showing tooltip during page transition](flutter#167614) Fix [[Desktop] [Web] [Regression] [3.32] AppBar back - RenderBox was not laid out - TooltipState._buildTooltipOverlay](flutter#169741)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix: Delay showing tooltip during page transition
fixes: #167359
Pre-launch Checklist
///).