Skip to content

Conversation

@Rusino
Copy link
Contributor

@Rusino Rusino commented Apr 22, 2025

This is the current (initial) state of WebParagraph project which is an implementation of SkParagraph
on top of TextCluster (https://github.com/fserb/canvas2D/blob/master/spec/enhanced-textmetrics.md).

Multilined text, mixed LTR/RTL text supported.

Part of #172561

@github-actions github-actions bot added the a: text input Entering text in a text field or keyboard related problems label Apr 22, 2025
@mdebbar mdebbar self-requested a review July 17, 2025 19:50
Copy link
Contributor

@mdebbar mdebbar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I fixed some things and added TODOs for others in order to avoid massive conflicts with the upcoming PR: #168412

This code is still inaccessible from normal Flutter.

LGTM!

@mdebbar mdebbar changed the title WebParagraph implementation WebParagraph initial commit Jul 18, 2025
@mdebbar mdebbar added the autosubmit Merge PR when tree becomes green via auto submit App label Jul 21, 2025
@auto-submit auto-submit bot added this pull request to the merge queue Jul 21, 2025
Merged via the queue into flutter:master with commit 70cdc0c Jul 21, 2025
175 of 176 checks passed
@flutter-dashboard flutter-dashboard bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Jul 21, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 21, 2025
auto-submit bot pushed a commit to flutter/packages that referenced this pull request Jul 21, 2025
flutter/flutter@70a3c3c...70cdc0c

2025-07-21 [email protected] WebParagraph initial commit (flutter/flutter#167559)
2025-07-21 [email protected] Roll Dart SDK from a821b47e7a4d to da9e0299c120 (1 revision) (flutter/flutter#172457)
2025-07-21 [email protected] [skia] Update call to SkImage::makeSubset (flutter/flutter#172456)
2025-07-21 [email protected] Roll Fuchsia Linux SDK from 8MyOdk7FEK-MqkzIF... to a_55b5hqpRnigzuNC... (flutter/flutter#172439)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
azatech pushed a commit to azatech/flutter that referenced this pull request Jul 28, 2025
This is the current (initial) state of WebParagraph project which is an
implementation of SkParagraph
on top of TextCluster
(https://github.com/fserb/canvas2D/blob/master/spec/enhanced-textmetrics.md).

Multilined text, mixed LTR/RTL text supported.

---------

Co-authored-by: Mouad Debbar <[email protected]>
vashworth pushed a commit to vashworth/packages that referenced this pull request Jul 30, 2025
…#9658)

flutter/flutter@70a3c3c...70cdc0c

2025-07-21 [email protected] WebParagraph initial commit (flutter/flutter#167559)
2025-07-21 [email protected] Roll Dart SDK from a821b47e7a4d to da9e0299c120 (1 revision) (flutter/flutter#172457)
2025-07-21 [email protected] [skia] Update call to SkImage::makeSubset (flutter/flutter#172456)
2025-07-21 [email protected] Roll Fuchsia Linux SDK from 8MyOdk7FEK-MqkzIF... to a_55b5hqpRnigzuNC... (flutter/flutter#172439)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
ksokolovskyi pushed a commit to ksokolovskyi/flutter that referenced this pull request Aug 19, 2025
This is the current (initial) state of WebParagraph project which is an
implementation of SkParagraph
on top of TextCluster
(https://github.com/fserb/canvas2D/blob/master/spec/enhanced-textmetrics.md).

Multilined text, mixed LTR/RTL text supported.

---------

Co-authored-by: Mouad Debbar <[email protected]>
mboetger pushed a commit to mboetger/flutter that referenced this pull request Sep 18, 2025
This is the current (initial) state of WebParagraph project which is an
implementation of SkParagraph
on top of TextCluster
(https://github.com/fserb/canvas2D/blob/master/spec/enhanced-textmetrics.md).

Multilined text, mixed LTR/RTL text supported.

---------

Co-authored-by: Mouad Debbar <[email protected]>
korca0220 pushed a commit to korca0220/flutter that referenced this pull request Sep 22, 2025
This is the current (initial) state of WebParagraph project which is an
implementation of SkParagraph
on top of TextCluster
(https://github.com/fserb/canvas2D/blob/master/spec/enhanced-textmetrics.md).

Multilined text, mixed LTR/RTL text supported.

---------

Co-authored-by: Mouad Debbar <[email protected]>
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 12, 2025
lucaantonelli pushed a commit to lucaantonelli/flutter that referenced this pull request Nov 21, 2025
This is the current (initial) state of WebParagraph project which is an
implementation of SkParagraph
on top of TextCluster
(https://github.com/fserb/canvas2D/blob/master/spec/enhanced-textmetrics.md).

Multilined text, mixed LTR/RTL text supported.

---------

Co-authored-by: Mouad Debbar <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

a: text input Entering text in a text field or keyboard related problems engine flutter/engine related. See also e: labels. platform-web Web applications specifically

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants