-
Notifications
You must be signed in to change notification settings - Fork 30.8k
Support Swift in the iOS embedder #167530
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
479ceaf
Support Swift in the iOS embedder
cbracken da02f00
Port FlutterUIPressProxy to Swift
cbracken e180a6e
Standardise TODO style
cbracken 3cbaae5
Ignore exported InternalFlutterSwift symbols
cbracken f6d4916
Appease licence script
cbracken 467892c
Extract, comment swiftc flags
cbracken 8949aff
Shebangs and chmod 755
cbracken 0312657
Extract apple_host_toolchain_path to apple_sdk.gni
cbracken 76d8f2d
Fix comments
cbracken 5252d09
Improve comment, drop rel_name
cbracken 5571001
Fix copyright headers
cbracken b4f2e51
review: add comment
cbracken 7db6e6a
Format
cbracken e5ae39c
Merge branch 'master' into add-swift-toolchain
cbracken File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,17 @@ | ||
| # Copyright 2013 The Flutter Authors. All rights reserved. | ||
| # Use of this source code is governed by a BSD-style license that can be | ||
| # found in the LICENSE file. | ||
|
|
||
| declare_args() { | ||
| # Path to the Xcode toolchain (XcodeDefault.xctoolchain). | ||
| apple_host_toolchain_path = "" | ||
| } | ||
|
|
||
| if (apple_host_toolchain_path == "") { | ||
| # Outputs the SDK path on the first line, and the host toolchain path on the | ||
| # second. | ||
| _find_sdk_lines = | ||
| exec_script("//build/mac/find_sdk.py", ["--print_sdk_path", "1.0"], "list lines") | ||
|
|
||
| apple_host_toolchain_path = _find_sdk_lines[1] | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,20 @@ | ||
| #!/usr/bin/env python3 | ||
| # | ||
| # Copyright 2013 The Flutter Authors. All rights reserved. | ||
|
cbracken marked this conversation as resolved.
|
||
| # Use of this source code is governed by a BSD-style license that can be | ||
| # found in the LICENSE file. | ||
|
|
||
|
|
||
| import os | ||
| import sys | ||
|
|
||
| # Usage: python get_tool_mtime.py path/to/file1.py path/to/file2.py | ||
| # | ||
| # Prints a GN scope with the variable name being the basename sans-extension | ||
| # and the value being the file modification time. A variable is emitted for | ||
| # each file argument on the command line. | ||
|
|
||
| if __name__ == '__main__': | ||
| for f in sys.argv[1:]: | ||
| variable = os.path.splitext(os.path.basename(f))[0] | ||
| print('%s = %d' % (variable, os.path.getmtime(f))) | ||
1 change: 1 addition & 0 deletions
1
engine/src/build/toolchain/apple/swift_const_gather_protocols.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| ["AppIntent","EntityQuery","AppEntity","TransientEntity","AppEnum","AppShortcutProviding","AppShortcutsProvider","AnyResolverProviding","AppIntentsPackage","DynamicOptionsProvider"] |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@cbracken Oh i just remembered I came across this a while back when trying to support swift 6.
From the comment it looks like you intended to pass it in below to handle xcode update scenario, but it's commented out. Wondering what's the current state (can it be removed or do we still want it?)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This can be removed.