Fix hit-testing order in semantics #167522
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
framework
QuncCccccc
force-pushed
the
hit_test_order_fix
branch
from
2dd4595 to
252e1dd
Compare
chunhtai
reviewed
Apr 23, 2025
| for (int i = childCount - 1; i >= 0; i -= 1) { | ||
| childrenInHitTestOrder[i] = _children![childCount - i - 1].id; | ||
| for (int i = 0; i < childCount; i += 1) { | ||
| childrenInHitTestOrder[i] = _children![i].id; |
Contributor
There was a problem hiding this comment.
This is surprising, does this mean we always get it wrong?
Contributor
There was a problem hiding this comment.
after reading the code more I think the original documentation may be wrong
_children is assigned with the childrenInInversePaintOrder in SemanticsNode.updateWith.
which is called in _buildSemanticsSubtree where the children is the same as _childrenAndElevationAdjustments order and I think by default the _childrenAndElevationAdjustments order is insertion order which will be RenderObject.visitChildForSemantics, which is the paint order.
so the the original code should be correct but just bad name.
Contributor
Author
There was a problem hiding this comment.
Just an update. Talked with @chunhtai offline. It seems the hit test order was incorrect all the time. But previously when we haven't applied OverlayPortal to any widgets, if we push a new route, the items underneath the new route will be thrown away so the hit test only need to handle one "layer" of items and everything is okay. After OverlayPortal is applied to Autocomplete, the items underneath the popup still stay in the tree, and the hit test order starts show problems.
QuncCccccc
force-pushed
the
hit_test_order_fix
branch
from
252e1dd to
4eb6771
Compare
QuncCccccc
force-pushed
the
hit_test_order_fix
branch
from
4eb6771 to
da4515c
Compare
QuncCccccc
added
the
autosubmit
flutter-dashboard
bot
removed
the
autosubmit
|
Thanks for the semantics fix, the attention to a11y is appreciated. |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Apr 26, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
May 5, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
May 5, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
May 5, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
May 5, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
May 5, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
May 5, 2025
ash2moon
pushed a commit
to ash2moon/flutter
that referenced
this pull request
May 5, 2025
…#168235) This reverts commit d9cbff2. Fixes flutter#168164
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
May 5, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
May 5, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
May 6, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
May 6, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
May 6, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
May 6, 2025
mboetger
pushed a commit
to mboetger/flutter
that referenced
this pull request
May 6, 2025
…#168235) This reverts commit d9cbff2. Fixes flutter#168164
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
May 7, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
May 7, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
May 7, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
May 7, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
May 7, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
May 7, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
May 7, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 14, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 14, 2025
romanejaquez
pushed a commit
to romanejaquez/flutter
that referenced
this pull request
Aug 14, 2025
Fixes flutter#163576 In `updateWith()` method, `_replaceChildren()` is called to generate `_children` list. `_children` list is used to generate the hit test order (`childrenInHitTestOrder`). In `_replaceChildren()`, `childrenIn**Inverse**PaintOrder` is directly assigned to _children, so _children itself follows hit test order. So when we generate the `childrenInHitTestOrder`, we don't need to reverse the children again. https://github.com/user-attachments/assets/df9d852f-231e-4480-8d8b-10c1d406f120 ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [x] I listed at least one issue that this PR fixes in the description above. - [x] I updated/added relevant documentation (doc comments with `///`). - [x] I added new tests to check the change I am making, or this PR is [test-exempt]. - [x] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [x] All existing and new tests are passing.
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 15, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 15, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #163576
In
updateWith()method,_replaceChildren()is called to generate_childrenlist._childrenlist is used to generate the hit test order (childrenInHitTestOrder).In
_replaceChildren(),childrenIn**Inverse**PaintOrderis directly assigned to _children, so _children itself follows hit test order. So when we generate thechildrenInHitTestOrder, we don't need to reverse the children again.Screen.Recording.2025-04-21.at.6.41.37.PM.mov
Pre-launch Checklist
///).