Add `CupertinoSlider` haptic feedback #167362

alex-medinsh · 2025-04-17T17:22:35Z

Pre-launch Checklist

I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
I read the [Tree Hygiene] wiki page, which explains my responsibilities.
I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
I signed the [CLA].
I listed at least one issue that this PR fixes in the description above.
I updated/added relevant documentation (doc comments with ///).
I added new tests to check the change I am making, or this PR is [test-exempt].
I followed the [breaking change policy] and added [Data Driven Fixes] where supported.
All existing and new tests are passing.

MaherSafadii · 2025-04-17T18:40:15Z

thanks for working on this, are you doing to implement apples mechanism for the haptic mentioned in the issue where the strength of the haptic depends on how hard you slam the slider?

alex-medinsh · 2025-04-17T18:46:24Z

Hi @MaherSafadii! Yes, I implemented different levels of haptics. Might need some adjustments, but overall it's there.

flutter/packages/flutter/lib/src/cupertino/slider.dart

Lines 253 to 257 in 7cfaac4

    
           if (isLargeDelta) { 
        
             HapticFeedback.mediumImpact(); 
        
           } else { 
        
             HapticFeedback.selectionClick(); 
        
           }

dkwingsmt

Thanks for the change!

packages/flutter/lib/src/cupertino/slider.dart

alex-medinsh · 2025-04-24T08:32:41Z

@dkwingsmt I have made the requested changes, please take a look. Thanks!

dkwingsmt

LGTM. Thank you!

alex-medinsh · 2025-05-01T07:59:48Z

@dkwingsmt I guess this needs one more approval to get merged?

justinmc

LGTM with nits 👍. Thanks for adding this! I thought the "slam" might be harder to implement but this seems pretty good and simple.

packages/flutter/lib/src/cupertino/slider.dart

justinmc · 2025-05-01T16:28:34Z

packages/flutter/lib/src/cupertino/slider.dart

+  void _emitHapticFeedback(bool isFastDrag) {
+    switch (defaultTargetPlatform) {
+      case TargetPlatform.iOS:
+        if (isFastDrag) {
+          HapticFeedback.mediumImpact();
+        } else {
+          HapticFeedback.selectionClick();
+        }
+      case TargetPlatform.android:
+      case TargetPlatform.fuchsia:
+      case TargetPlatform.linux:
+      case TargetPlatform.macOS:
+      case TargetPlatform.windows:
+        break;
+    }
+  }


Nit: I just want to double check that we don't want haptic feedback on non-iOS platforms. I guess only iOS can do the proper selectionClick? CupertinoPicker does a similar platform check:

flutter/packages/flutter/lib/src/cupertino/picker.dart

Lines 252 to 265 in fe60a2b

switch (defaultTargetPlatform) {

case TargetPlatform.iOS:

hasSuitableHapticHardware = true;

case TargetPlatform.android:

case TargetPlatform.fuchsia:

case TargetPlatform.linux:

case TargetPlatform.macOS:

case TargetPlatform.windows:

hasSuitableHapticHardware = false;

}

if (hasSuitableHapticHardware && index != _lastHapticIndex) {

_lastHapticIndex = index;

HapticFeedback.selectionClick();

}

I just followed what other Cupertino widgets like switch and picker do, so I think it would be a bit strange to enable haptics for this one particular Cupertino widget and not the others. I think this is ok for now and we can easily change this later.

Sounds good, I agree.

packages/flutter/test/cupertino/slider_test.dart

alex-medinsh · 2025-05-01T20:46:07Z

@justinmc I've added the docs and a test for non-iOS platforms.

alex-medinsh · 2025-05-08T15:36:53Z

@justinmc friendly ping :)

justinmc

LGTM 👍 . Thanks for adding the tests for the other platforms.

flutter/flutter@83082c1...992ad74 2025-05-10 [email protected] Roll Fuchsia Linux SDK from F2xwL6WosfD7ETcPm... to VIG5-P9wwXgQkCkeX... (flutter/flutter#168633) 2025-05-10 [email protected] delete stale references/includes to classes no longer used (flutter/flutter#168616) 2025-05-10 [email protected] Roll Skia from 645404ec2d60 to 0feee17aeaca (1 revision) (flutter/flutter#168624) 2025-05-10 [email protected] Roll Skia from 12dbc34d742e to 645404ec2d60 (1 revision) (flutter/flutter#168621) 2025-05-09 [email protected] Add Option to disable full selection on focus on TextField, TextFormField, and EditableText (flutter/flutter#163491) 2025-05-09 [email protected] Add `CupertinoSlider` haptic feedback (flutter/flutter#167362) 2025-05-09 [email protected] Roll Skia from 7f7555536e3c to 12dbc34d742e (1 revision) (flutter/flutter#168614) 2025-05-09 [email protected] Fix: Impeller playground's points should be draggable (flutter/flutter#168351) 2025-05-09 [email protected] Remove old link for java gradle incompatibility (flutter/flutter#168561) 2025-05-09 [email protected] Roll Skia from 0d16b74f74a5 to 7f7555536e3c (5 revisions) (flutter/flutter#168609) 2025-05-09 [email protected] add missing lockfiles not checked in from running generate_gradle_lockfiles.dart (flutter/flutter#168600) 2025-05-09 [email protected] [Impeller] libImpeller: Usability improvements for WASM and python bindings. (flutter/flutter#168397) 2025-05-09 [email protected] Fix ListTile overwriting parent IconButtonTheme for its children (#167727) (flutter/flutter#168480) 2025-05-09 [email protected] Roll Skia from efccaeb08b8d to 0d16b74f74a5 (6 revisions) (flutter/flutter#168569) 2025-05-09 [email protected] [web] more cleanup of unused APIs (flutter/flutter#168524) 2025-05-09 [email protected] Roll Fuchsia Linux SDK from mqhX1OP8ezmialgqA... to F2xwL6WosfD7ETcPm... (flutter/flutter#168587) 2025-05-09 [email protected] Roll Packages from ab44c26 to 7814fab (4 revisions) (flutter/flutter#168597) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

…r#9239) flutter/flutter@83082c1...992ad74 2025-05-10 [email protected] Roll Fuchsia Linux SDK from F2xwL6WosfD7ETcPm... to VIG5-P9wwXgQkCkeX... (flutter/flutter#168633) 2025-05-10 [email protected] delete stale references/includes to classes no longer used (flutter/flutter#168616) 2025-05-10 [email protected] Roll Skia from 645404ec2d60 to 0feee17aeaca (1 revision) (flutter/flutter#168624) 2025-05-10 [email protected] Roll Skia from 12dbc34d742e to 645404ec2d60 (1 revision) (flutter/flutter#168621) 2025-05-09 [email protected] Add Option to disable full selection on focus on TextField, TextFormField, and EditableText (flutter/flutter#163491) 2025-05-09 [email protected] Add `CupertinoSlider` haptic feedback (flutter/flutter#167362) 2025-05-09 [email protected] Roll Skia from 7f7555536e3c to 12dbc34d742e (1 revision) (flutter/flutter#168614) 2025-05-09 [email protected] Fix: Impeller playground's points should be draggable (flutter/flutter#168351) 2025-05-09 [email protected] Remove old link for java gradle incompatibility (flutter/flutter#168561) 2025-05-09 [email protected] Roll Skia from 0d16b74f74a5 to 7f7555536e3c (5 revisions) (flutter/flutter#168609) 2025-05-09 [email protected] add missing lockfiles not checked in from running generate_gradle_lockfiles.dart (flutter/flutter#168600) 2025-05-09 [email protected] [Impeller] libImpeller: Usability improvements for WASM and python bindings. (flutter/flutter#168397) 2025-05-09 [email protected] Fix ListTile overwriting parent IconButtonTheme for its children (#167727) (flutter/flutter#168480) 2025-05-09 [email protected] Roll Skia from efccaeb08b8d to 0d16b74f74a5 (6 revisions) (flutter/flutter#168569) 2025-05-09 [email protected] [web] more cleanup of unused APIs (flutter/flutter#168524) 2025-05-09 [email protected] Roll Fuchsia Linux SDK from mqhX1OP8ezmialgqA... to F2xwL6WosfD7ETcPm... (flutter/flutter#168587) 2025-05-09 [email protected] Roll Packages from ab44c26 to 7814fab (4 revisions) (flutter/flutter#168597) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

github-actions bot added framework flutter/packages/flutter repository. See also f: labels. f: cupertino flutter/packages/flutter/cupertino repository labels Apr 17, 2025

alex-medinsh changed the title ~~added slider haptic feedback~~ Add CupertinoSlider haptic feedback Apr 17, 2025

alex-medinsh force-pushed the slider-haptics branch from 658c201 to 5bb03da Compare April 17, 2025 17:23

alex-medinsh marked this pull request as ready for review April 17, 2025 18:59

dkwingsmt self-requested a review April 23, 2025 18:14

dkwingsmt reviewed Apr 23, 2025

View reviewed changes

packages/flutter/lib/src/cupertino/slider.dart Outdated Show resolved Hide resolved

packages/flutter/lib/src/cupertino/slider.dart Outdated Show resolved Hide resolved

alex-medinsh force-pushed the slider-haptics branch from 7cfaac4 to 40d0112 Compare April 24, 2025 07:54

dkwingsmt approved these changes May 1, 2025

View reviewed changes

justinmc approved these changes May 1, 2025

View reviewed changes

alex-medinsh force-pushed the slider-haptics branch from b99e61e to 773719a Compare May 1, 2025 17:11

alex-medinsh added 6 commits May 2, 2025 00:09

added slider haptic feedback

6835c40

remove unneeded var

a5a1aeb

drag velocity

b95fb69

var name

793fb0e

docs

2c7785b

add test

60ae03f

alex-medinsh force-pushed the slider-haptics branch from 366d77e to 60ae03f Compare May 1, 2025 21:09

justinmc approved these changes May 9, 2025

View reviewed changes

justinmc added the autosubmit Merge PR when tree becomes green via auto submit App label May 9, 2025

auto-submit bot added this pull request to the merge queue May 9, 2025

Merged via the queue into flutter:master with commit 7592aea May 9, 2025
76 checks passed

flutter-dashboard bot removed the autosubmit Merge PR when tree becomes green via auto submit App label May 9, 2025

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 10, 2025

7592aeaa9 Add CupertinoSlider haptic feedback (flutter/flutter#167362)

aedcd62

engine-flutter-autoroll mentioned this pull request May 10, 2025

Roll Flutter from 83082c19b727 to 8ee8eaa66e8d (16 revisions) flutter/packages#9235

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 10, 2025

7592aeaa9 Add CupertinoSlider haptic feedback (flutter/flutter#167362)

c29b7f5

This was referenced May 10, 2025

Roll Flutter from 83082c19b727 to 8ee8eaa66e8d (16 revisions) flutter/packages#9238

Closed

Roll Flutter from 83082c19b727 to 992ad7489c38 (17 revisions) flutter/packages#9239

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 11, 2025

7592aeaa9 Add CupertinoSlider haptic feedback (flutter/flutter#167362)

c567ef7

alex-medinsh deleted the slider-haptics branch July 2, 2025 08:01

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 14, 2025

7592aeaa9 Add CupertinoSlider haptic feedback (flutter/flutter#167362)

463e5d5

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 14, 2025

7592aeaa9 Add CupertinoSlider haptic feedback (flutter/flutter#167362)

30de372

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 15, 2025

7592aeaa9 Add CupertinoSlider haptic feedback (flutter/flutter#167362)

c2f7342

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 15, 2025

7592aeaa9 Add CupertinoSlider haptic feedback (flutter/flutter#167362)

a574bfc

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 16, 2025

7592aeaa9 Add CupertinoSlider haptic feedback (flutter/flutter#167362)

d43fa4f

	switch (defaultTargetPlatform) {
	case TargetPlatform.iOS:
	hasSuitableHapticHardware = true;
	case TargetPlatform.android:
	case TargetPlatform.fuchsia:
	case TargetPlatform.linux:
	case TargetPlatform.macOS:
	case TargetPlatform.windows:
	hasSuitableHapticHardware = false;
	}
	if (hasSuitableHapticHardware && index != _lastHapticIndex) {
	_lastHapticIndex = index;
	HapticFeedback.selectionClick();
	}

Add CupertinoSlider haptic feedback #167362

Add CupertinoSlider haptic feedback #167362

Uh oh!

Conversation

alex-medinsh commented Apr 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Pre-launch Checklist

Uh oh!

MaherSafadii commented Apr 17, 2025

Uh oh!

alex-medinsh commented Apr 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

dkwingsmt left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

alex-medinsh commented Apr 24, 2025

Uh oh!

dkwingsmt left a comment

Choose a reason for hiding this comment

Uh oh!

alex-medinsh commented May 1, 2025

Uh oh!

justinmc left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

justinmc May 1, 2025

Choose a reason for hiding this comment

Uh oh!

alex-medinsh May 1, 2025

Choose a reason for hiding this comment

Uh oh!

justinmc May 9, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

alex-medinsh commented May 1, 2025

Uh oh!

alex-medinsh commented May 8, 2025

Uh oh!

justinmc left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Add `CupertinoSlider` haptic feedback #167362

Add `CupertinoSlider` haptic feedback #167362

alex-medinsh commented Apr 17, 2025 •

edited

Loading

alex-medinsh commented Apr 17, 2025 •

edited

Loading