Fix codesigning for `Mac_arm64_ios imitation_game_flutter` #167307

LouiseHsu · 2025-04-16T21:13:44Z

https://ci.chromium.org/ui/p/flutter/builders/luci.flutter.staging/Mac_arm64_ios%20imitation_game_flutter

The swiftui benchmark has been failing in bring up because the project wasnt getting correctly codesigned. Also, fixes the fact that I flipped the naming of imitation_game_flutter and imitation_game_swiftui 😶‍🌫️ Also removes extraneous targets from the project

https://ci.chromium.org/ui/p/flutter/builders/try.shadow/Mac_arm64_ios%20imitation_game_flutter/14/overview
Tested with led, proof that it's working post this PR ^

Pre-launch Checklist

I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
I read the [Tree Hygiene] wiki page, which explains my responsibilities.
I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
I signed the [CLA].
I listed at least one issue that this PR fixes in the description above.
I updated/added relevant documentation (doc comments with ///).
I added new tests to check the change I am making, or this PR is [test-exempt].
I followed the [breaking change policy] and added [Data Driven Fixes] where supported.
All existing and new tests are passing.

gaaclarke

lgtm!

…67307) https://ci.chromium.org/ui/p/flutter/builders/luci.flutter.staging/Mac_arm64_ios%20imitation_game_flutter The swiftui benchmark has been failing in bring up because the project wasnt getting correctly codesigned. Also, fixes the fact that I flipped the naming of imitation_game_flutter and imitation_game_swiftui 😶‍🌫️ Also removes extraneous targets from the project https://ci.chromium.org/ui/p/flutter/builders/try.shadow/Mac_arm64_ios%20imitation_game_flutter/14/overview Tested with `led`, proof that it's working post this PR ^ ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [x] I listed at least one issue that this PR fixes in the description above. - [x] I updated/added relevant documentation (doc comments with `///`). - [x] I added new tests to check the change I am making, or this PR is [test-exempt]. - [x] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [x] All existing and new tests are passing.

…lutter/flutter#167307)

flutter/flutter@3ed38e2...cfb887c 2025-04-20 [email protected] Roll Fuchsia Linux SDK from 0U_vEALFF7qRJZ_cE... to RGmU4KeQhrxqE7hsr... (flutter/flutter#167447) 2025-04-19 [email protected] Roll Skia from 3dc3ffeb45f0 to bd9ef4955aad (1 revision) (flutter/flutter#167434) 2025-04-19 [email protected] Roll Fuchsia Linux SDK from MwYckh5OvwwmIYLx0... to 0U_vEALFF7qRJZ_cE... (flutter/flutter#167430) 2025-04-19 [email protected] Roll Skia from 177a2929e32f to 3dc3ffeb45f0 (1 revision) (flutter/flutter#167428) 2025-04-19 [email protected] Revert "Reduce app startup latency by initializing the engine on a separate thread (#166918)" (flutter/flutter#167427) 2025-04-18 [email protected] Fix keyboard cover SearchAnchor list results (flutter/flutter#165382) 2025-04-18 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Mark `windows_host_engine_test` flaky (#167419)" (flutter/flutter#167425) 2025-04-18 [email protected] Docs: Update date picker theme day color properties doc (flutter/flutter#166122) 2025-04-18 [email protected] Add ktlint test for generated files from templates (flutter/flutter#167378) 2025-04-18 [email protected] Revert "[Windows] Enable merged platform and UI thread by default" (flutter/flutter#167420) 2025-04-18 [email protected] Add a DrivenScrollActivity.simulation constructor (flutter/flutter#166730) 2025-04-18 [email protected] Added missing period for consistency and readability (flutter/flutter#162887) 2025-04-18 [email protected] Roll Skia from 6c4595124690 to 177a2929e32f (1 revision) (flutter/flutter#167417) 2025-04-18 [email protected] Fix codesigning for `Mac_arm64_ios imitation_game_flutter` (flutter/flutter#167307) 2025-04-18 [email protected] Mark `windows_host_engine_test` flaky (flutter/flutter#167419) 2025-04-18 [email protected] Roll Dart SDK from ab60afc99bcb to 0cfefe2a03fb (1 revision) (flutter/flutter#167414) 2025-04-18 [email protected] [web] close input connection when window/iframe loses focus (flutter/flutter#166804) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

…r#9118) flutter/flutter@3ed38e2...cfb887c 2025-04-20 [email protected] Roll Fuchsia Linux SDK from 0U_vEALFF7qRJZ_cE... to RGmU4KeQhrxqE7hsr... (flutter/flutter#167447) 2025-04-19 [email protected] Roll Skia from 3dc3ffeb45f0 to bd9ef4955aad (1 revision) (flutter/flutter#167434) 2025-04-19 [email protected] Roll Fuchsia Linux SDK from MwYckh5OvwwmIYLx0... to 0U_vEALFF7qRJZ_cE... (flutter/flutter#167430) 2025-04-19 [email protected] Roll Skia from 177a2929e32f to 3dc3ffeb45f0 (1 revision) (flutter/flutter#167428) 2025-04-19 [email protected] Revert "Reduce app startup latency by initializing the engine on a separate thread (#166918)" (flutter/flutter#167427) 2025-04-18 [email protected] Fix keyboard cover SearchAnchor list results (flutter/flutter#165382) 2025-04-18 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Mark `windows_host_engine_test` flaky (#167419)" (flutter/flutter#167425) 2025-04-18 [email protected] Docs: Update date picker theme day color properties doc (flutter/flutter#166122) 2025-04-18 [email protected] Add ktlint test for generated files from templates (flutter/flutter#167378) 2025-04-18 [email protected] Revert "[Windows] Enable merged platform and UI thread by default" (flutter/flutter#167420) 2025-04-18 [email protected] Add a DrivenScrollActivity.simulation constructor (flutter/flutter#166730) 2025-04-18 [email protected] Added missing period for consistency and readability (flutter/flutter#162887) 2025-04-18 [email protected] Roll Skia from 6c4595124690 to 177a2929e32f (1 revision) (flutter/flutter#167417) 2025-04-18 [email protected] Fix codesigning for `Mac_arm64_ios imitation_game_flutter` (flutter/flutter#167307) 2025-04-18 [email protected] Mark `windows_host_engine_test` flaky (flutter/flutter#167419) 2025-04-18 [email protected] Roll Dart SDK from ab60afc99bcb to 0cfefe2a03fb (1 revision) (flutter/flutter#167414) 2025-04-18 [email protected] [web] close input connection when window/iframe loses focus (flutter/flutter#166804) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

…lutter/flutter#167307)

…67307) https://ci.chromium.org/ui/p/flutter/builders/luci.flutter.staging/Mac_arm64_ios%20imitation_game_flutter The swiftui benchmark has been failing in bring up because the project wasnt getting correctly codesigned. Also, fixes the fact that I flipped the naming of imitation_game_flutter and imitation_game_swiftui 😶‍🌫️ Also removes extraneous targets from the project https://ci.chromium.org/ui/p/flutter/builders/try.shadow/Mac_arm64_ios%20imitation_game_flutter/14/overview Tested with `led`, proof that it's working post this PR ^ ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [x] I listed at least one issue that this PR fixes in the description above. - [x] I updated/added relevant documentation (doc comments with `///`). - [x] I added new tests to check the change I am making, or this PR is [test-exempt]. - [x] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [x] All existing and new tests are passing.

…lutter/flutter#167307)

LouiseHsu and others added 8 commits April 16, 2025 13:46

unformat tf

b7a5f27

Merge branch 'master' into fic-benchmarks

2e7971a

.

00875f3

scheme?

b78fdc1

remove random targets

b6207ec

try injecting codesigning stuff

b18c1ac

clean up

139b744

remove excess scheme file

d3099b7

LouiseHsu changed the title ~~led testing sigh~~ Fix codesigning for Mac_arm64_ios 20imitation_game_flutter Apr 18, 2025

LouiseHsu requested a review from gaaclarke April 18, 2025 19:22

LouiseHsu marked this pull request as ready for review April 18, 2025 19:22

LouiseHsu requested a review from matanlurey as a code owner April 18, 2025 19:22

Merge branch 'master' into fic-benchmarks

824aa04

LouiseHsu changed the title ~~Fix codesigning for Mac_arm64_ios 20imitation_game_flutter~~ Fix codesigning for Mac_arm64_ios imitation_game_flutter Apr 18, 2025

gaaclarke approved these changes Apr 18, 2025

View reviewed changes

format

c07a237

LouiseHsu added the autosubmit Merge PR when tree becomes green via auto submit App label Apr 18, 2025

auto-submit bot added this pull request to the merge queue Apr 18, 2025

Merged via the queue into flutter:master with commit 6f14c96 Apr 18, 2025
153 checks passed

flutter-dashboard bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Apr 18, 2025

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 19, 2025

6f14c960e Fix codesigning for Mac_arm64_ios imitation_game_flutter (f…

f08c3c6

…lutter/flutter#167307)

engine-flutter-autoroll mentioned this pull request Apr 19, 2025

Roll Flutter from 3ed38e24528a to 93e5d8120143 (15 revisions) flutter/packages#9115

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 19, 2025

6f14c960e Fix codesigning for Mac_arm64_ios imitation_game_flutter (f…

8736f17

…lutter/flutter#167307)

engine-flutter-autoroll mentioned this pull request Apr 19, 2025

Roll Flutter from 3ed38e24528a to 432fea845953 (16 revisions) flutter/packages#9116

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 20, 2025

6f14c960e Fix codesigning for Mac_arm64_ios imitation_game_flutter (f…

4d4a5fc

…lutter/flutter#167307)

engine-flutter-autoroll mentioned this pull request Apr 20, 2025

Roll Flutter from 3ed38e24528a to cfb887cd5f41 (17 revisions) flutter/packages#9118

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 14, 2025

6f14c960e Fix codesigning for Mac_arm64_ios imitation_game_flutter (f…

07ca8d1

…lutter/flutter#167307)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 14, 2025

6f14c960e Fix codesigning for Mac_arm64_ios imitation_game_flutter (f…

6c162b9

…lutter/flutter#167307)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 15, 2025

6f14c960e Fix codesigning for Mac_arm64_ios imitation_game_flutter (f…

15a0375

…lutter/flutter#167307)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 15, 2025

6f14c960e Fix codesigning for Mac_arm64_ios imitation_game_flutter (f…

ae932a2

…lutter/flutter#167307)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 16, 2025

6f14c960e Fix codesigning for Mac_arm64_ios imitation_game_flutter (f…

4a24d6f

…lutter/flutter#167307)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Fix codesigning for `Mac_arm64_ios imitation_game_flutter` #167307

Fix codesigning for `Mac_arm64_ios imitation_game_flutter` #167307

Uh oh!

LouiseHsu commented Apr 16, 2025 •

edited

Loading

Uh oh!

gaaclarke left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Fix codesigning for Mac_arm64_ios imitation_game_flutter #167307

Fix codesigning for Mac_arm64_ios imitation_game_flutter #167307

Uh oh!

Conversation

LouiseHsu commented Apr 16, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Pre-launch Checklist

Uh oh!

gaaclarke left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Fix codesigning for `Mac_arm64_ios imitation_game_flutter` #167307

Fix codesigning for `Mac_arm64_ios imitation_game_flutter` #167307

LouiseHsu commented Apr 16, 2025 •

edited

Loading