Fix CarouselView crashes when initlal viewportDimension is 0.0 #167271

bleroux · 2025-04-16T13:49:37Z

Description

This PR fixes CarouselView crashes due to viewportDimension being 0.0.

At startup, a warm-up frame can be produced before the Flutter engine has reported the
initial view metrics. As a result, the first frame can be produced with a size of zero. In the context of CarouselView this leads to some problems mainly related to division by zero.

Related Issue

Fixes #163436
Fixes #160679

Tests

Adds 5 tests.

flutter-dashboard · 2025-04-16T14:38:13Z

Golden file changes have been found for this pull request. Click here to view and triage (e.g. because this is an intentional change).

If you are still iterating on this change and are not ready to resolve the images on the Flutter Gold dashboard, consider marking this PR as a draft pull request above. You will still be able to view image results on the dashboard, commenting will be silenced, and the check will not try to resolve itself until marked ready for review.

For more guidance, visit Writing a golden file test for package:flutter.

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

Changes reported for pull request #167271 at sha 8f9ccf0

flutter-dashboard · 2025-04-16T15:18:25Z

Golden file changes are available for triage from new commit, Click here to view.

For more guidance, visit Writing a golden file test for package:flutter.

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

Changes reported for pull request #167271 at sha 9d4345d

QuncCccccc

Nice fix. LGTM. Thanks for adding so many test cases!

I think Carousel.weight might also need to be fixed, but it's okay to fix it in a separate PR!

QuncCccccc · 2025-04-17T23:26:53Z

packages/flutter/lib/src/material/carousel.dart

    }
-    final double newPixels = getPixelsFromItem(item, flexWeights, itemExtent);
+    final double newPixels =
+        (viewportDimension == 0.0) ? 0.0 : getPixelsFromItem(item, flexWeights, itemExtent);


Can we move this check in getPixelsFromItem so that we can remove the change in line 1408 as well? Just think it would be better if we move the logic into one method.

Great call! PR updated 🙏

QuncCccccc · 2025-04-17T23:27:16Z

packages/flutter/lib/src/material/carousel.dart

        };
        _itemExtent =
-            _itemExtent == null ? _itemExtent : clampDouble(_itemExtent!, 0, mainAxisExtent);
+            widget.itemExtent == null ? null : clampDouble(widget.itemExtent!, 0, mainAxisExtent);


Just curious, why do we want to have this change here?

Not obvious, but in fact it is crucial to fix this issue.
Without this change, when the viewport dimension is zero at first, _itemExtent is clamped to 0. Later when the viewport gets the final dimension, the old code clampDouble(_itemExtent!, 0, mainAxisExtent); still returns 0.0 and never check again the original widget.itemExtent value.
This is covered by the test named "itemExtent is applied when viewport dimension is updated".

Ah nice catch! Thanks for the explanation!

…0.0 (flutter/flutter#167271)

flutter/flutter@ecabb1a...3ed38e2 2025-04-18 [email protected] Update `led` docs (flutter/flutter#167380) 2025-04-18 [email protected] Throw an error if --local-engine-host is used without --local-engine (flutter/flutter#166948) 2025-04-18 [email protected] Add kotlin compatability to build file validation (flutter/flutter#167143) 2025-04-18 [email protected] Roll Skia from 844496884aa0 to 6c4595124690 (2 revisions) (flutter/flutter#167400) 2025-04-18 [email protected] Fix CarouselView crashes when initlal viewportDimension is 0.0 (flutter/flutter#167271) 2025-04-18 [email protected] Roll Dart SDK from b1eb743f97f5 to ab60afc99bcb (1 revision) (flutter/flutter#167396) 2025-04-18 [email protected] Add InputDecoration.visualDensity and InputDecorationTheme.visualDensity (flutter/flutter#166834) 2025-04-18 [email protected] Roll Skia from acc910544da7 to 844496884aa0 (1 revision) (flutter/flutter#167389) 2025-04-18 [email protected] Roll Skia from a409d685a711 to acc910544da7 (10 revisions) (flutter/flutter#167388) 2025-04-18 [email protected] Roll Dart SDK from 2bb85834e77e to b1eb743f97f5 (2 revisions) (flutter/flutter#167387) 2025-04-18 [email protected] Roll Fuchsia Linux SDK from m8Aln7fTF_8zy1V9N... to MwYckh5OvwwmIYLx0... (flutter/flutter#167385) 2025-04-17 [email protected] Roll Skia from cc2b57434651 to a409d685a711 (3 revisions) (flutter/flutter#167347) 2025-04-17 [email protected] Reduce app startup latency by initializing the engine on a separate thread (flutter/flutter#166918) 2025-04-17 [email protected] Roll Dart SDK from 992221a362ec to 2bb85834e77e (7 revisions) (flutter/flutter#167361) 2025-04-17 [email protected] Added docstring for FilterInput::GetSnapshot (flutter/flutter#167226) 2025-04-17 [email protected] adds Entity docstrings (flutter/flutter#167228) 2025-04-17 [email protected] fixed impeller golden content scale (flutter/flutter#167308) 2025-04-17 [email protected] Added docstring for FilterContents::RenderFilter (flutter/flutter#167227) 2025-04-17 [email protected] Feat: Add equality to NoDefaultCupertinoThemeData (flutter/flutter#166655) 2025-04-17 [email protected] Fix link to engine docs (flutter/flutter#167346) 2025-04-17 [email protected] [macOS] Enable merged platform and UI thread by default (flutter/flutter#166536) 2025-04-17 [email protected] [Windows] Enable merged platform and UI thread by default (flutter/flutter#163726) 2025-04-17 [email protected] Update `CHANGELOG.md` (flutter/flutter#167225) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

….0 (#167628) ## Description This PR fixes `CarouselView.weigthed` crashes due to given constraints being zero (which happen, for instance, when viewportDimension is 0.0). At startup, a warm-up frame can be produced before the Flutter engine has reported the initial view metrics. As a result, the first frame can be produced with a size of zero. In the context of CarouselView this leads to some problems mainly related to division by zero. Similar to #167271 which addressed the same problem for `CarouselView`. ## Related Issue Fixes #167621 ## Tests Adds 3 tests.

flutter/flutter@ecabb1a...3ed38e2 2025-04-18 [email protected] Update `led` docs (flutter/flutter#167380) 2025-04-18 [email protected] Throw an error if --local-engine-host is used without --local-engine (flutter/flutter#166948) 2025-04-18 [email protected] Add kotlin compatability to build file validation (flutter/flutter#167143) 2025-04-18 [email protected] Roll Skia from 844496884aa0 to 6c4595124690 (2 revisions) (flutter/flutter#167400) 2025-04-18 [email protected] Fix CarouselView crashes when initlal viewportDimension is 0.0 (flutter/flutter#167271) 2025-04-18 [email protected] Roll Dart SDK from b1eb743f97f5 to ab60afc99bcb (1 revision) (flutter/flutter#167396) 2025-04-18 [email protected] Add InputDecoration.visualDensity and InputDecorationTheme.visualDensity (flutter/flutter#166834) 2025-04-18 [email protected] Roll Skia from acc910544da7 to 844496884aa0 (1 revision) (flutter/flutter#167389) 2025-04-18 [email protected] Roll Skia from a409d685a711 to acc910544da7 (10 revisions) (flutter/flutter#167388) 2025-04-18 [email protected] Roll Dart SDK from 2bb85834e77e to b1eb743f97f5 (2 revisions) (flutter/flutter#167387) 2025-04-18 [email protected] Roll Fuchsia Linux SDK from m8Aln7fTF_8zy1V9N... to MwYckh5OvwwmIYLx0... (flutter/flutter#167385) 2025-04-17 [email protected] Roll Skia from cc2b57434651 to a409d685a711 (3 revisions) (flutter/flutter#167347) 2025-04-17 [email protected] Reduce app startup latency by initializing the engine on a separate thread (flutter/flutter#166918) 2025-04-17 [email protected] Roll Dart SDK from 992221a362ec to 2bb85834e77e (7 revisions) (flutter/flutter#167361) 2025-04-17 [email protected] Added docstring for FilterInput::GetSnapshot (flutter/flutter#167226) 2025-04-17 [email protected] adds Entity docstrings (flutter/flutter#167228) 2025-04-17 [email protected] fixed impeller golden content scale (flutter/flutter#167308) 2025-04-17 [email protected] Added docstring for FilterContents::RenderFilter (flutter/flutter#167227) 2025-04-17 [email protected] Feat: Add equality to NoDefaultCupertinoThemeData (flutter/flutter#166655) 2025-04-17 [email protected] Fix link to engine docs (flutter/flutter#167346) 2025-04-17 [email protected] [macOS] Enable merged platform and UI thread by default (flutter/flutter#166536) 2025-04-17 [email protected] [Windows] Enable merged platform and UI thread by default (flutter/flutter#163726) 2025-04-17 [email protected] Update `CHANGELOG.md` (flutter/flutter#167225) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

…r#9114) flutter/flutter@ecabb1a...3ed38e2 2025-04-18 [email protected] Update `led` docs (flutter/flutter#167380) 2025-04-18 [email protected] Throw an error if --local-engine-host is used without --local-engine (flutter/flutter#166948) 2025-04-18 [email protected] Add kotlin compatability to build file validation (flutter/flutter#167143) 2025-04-18 [email protected] Roll Skia from 844496884aa0 to 6c4595124690 (2 revisions) (flutter/flutter#167400) 2025-04-18 [email protected] Fix CarouselView crashes when initlal viewportDimension is 0.0 (flutter/flutter#167271) 2025-04-18 [email protected] Roll Dart SDK from b1eb743f97f5 to ab60afc99bcb (1 revision) (flutter/flutter#167396) 2025-04-18 [email protected] Add InputDecoration.visualDensity and InputDecorationTheme.visualDensity (flutter/flutter#166834) 2025-04-18 [email protected] Roll Skia from acc910544da7 to 844496884aa0 (1 revision) (flutter/flutter#167389) 2025-04-18 [email protected] Roll Skia from a409d685a711 to acc910544da7 (10 revisions) (flutter/flutter#167388) 2025-04-18 [email protected] Roll Dart SDK from 2bb85834e77e to b1eb743f97f5 (2 revisions) (flutter/flutter#167387) 2025-04-18 [email protected] Roll Fuchsia Linux SDK from m8Aln7fTF_8zy1V9N... to MwYckh5OvwwmIYLx0... (flutter/flutter#167385) 2025-04-17 [email protected] Roll Skia from cc2b57434651 to a409d685a711 (3 revisions) (flutter/flutter#167347) 2025-04-17 [email protected] Reduce app startup latency by initializing the engine on a separate thread (flutter/flutter#166918) 2025-04-17 [email protected] Roll Dart SDK from 992221a362ec to 2bb85834e77e (7 revisions) (flutter/flutter#167361) 2025-04-17 [email protected] Added docstring for FilterInput::GetSnapshot (flutter/flutter#167226) 2025-04-17 [email protected] adds Entity docstrings (flutter/flutter#167228) 2025-04-17 [email protected] fixed impeller golden content scale (flutter/flutter#167308) 2025-04-17 [email protected] Added docstring for FilterContents::RenderFilter (flutter/flutter#167227) 2025-04-17 [email protected] Feat: Add equality to NoDefaultCupertinoThemeData (flutter/flutter#166655) 2025-04-17 [email protected] Fix link to engine docs (flutter/flutter#167346) 2025-04-17 [email protected] [macOS] Enable merged platform and UI thread by default (flutter/flutter#166536) 2025-04-17 [email protected] [Windows] Enable merged platform and UI thread by default (flutter/flutter#163726) 2025-04-17 [email protected] Update `CHANGELOG.md` (flutter/flutter#167225) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

…0.0 (flutter/flutter#167271)

…er#167271) ## Description This PR fixes CarouselView crashes due to viewportDimension being 0.0. At startup, a warm-up frame can be produced before the Flutter engine has reported the initial view metrics. As a result, the first frame can be produced with a size of zero. In the context of CarouselView this leads to some problems mainly related to division by zero. ## Related Issue Fixes flutter#163436 Fixes flutter#160679 ## Tests Adds 5 tests.

….0 (flutter#167628) ## Description This PR fixes `CarouselView.weigthed` crashes due to given constraints being zero (which happen, for instance, when viewportDimension is 0.0). At startup, a warm-up frame can be produced before the Flutter engine has reported the initial view metrics. As a result, the first frame can be produced with a size of zero. In the context of CarouselView this leads to some problems mainly related to division by zero. Similar to flutter#167271 which addressed the same problem for `CarouselView`. ## Related Issue Fixes flutter#167621 ## Tests Adds 3 tests.

…0.0 (flutter/flutter#167271)

github-actions bot added framework flutter/packages/flutter repository. See also f: labels. f: material design flutter/packages/flutter/material repository. labels Apr 16, 2025

flutter-dashboard bot added the will affect goldens Changes to golden files label Apr 16, 2025

bleroux force-pushed the fix_carousel_view_crash_on_zero_viewport_dimension branch from 8f9ccf0 to 9d4345d Compare April 16, 2025 14:41

bleroux requested a review from QuncCccccc April 16, 2025 14:41

bleroux force-pushed the fix_carousel_view_crash_on_zero_viewport_dimension branch 2 times, most recently from 07a9690 to 0cf2333 Compare April 17, 2025 08:38

QuncCccccc approved these changes Apr 17, 2025

View reviewed changes

bleroux force-pushed the fix_carousel_view_crash_on_zero_viewport_dimension branch from 0cf2333 to 7d908c2 Compare April 18, 2025 08:59

bleroux removed the will affect goldens Changes to golden files label Apr 18, 2025

bleroux added 2 commits April 18, 2025 13:17

Fix CarouselView crashes when initlal viewportDimension is 0.0

bb3746f

Centralize logic based on review comment

2b155c6

bleroux force-pushed the fix_carousel_view_crash_on_zero_viewport_dimension branch from 7d908c2 to 2b155c6 Compare April 18, 2025 11:17

bleroux added the autosubmit Merge PR when tree becomes green via auto submit App label Apr 18, 2025

auto-submit bot added this pull request to the merge queue Apr 18, 2025

Merged via the queue into flutter:master with commit 7cadbea Apr 18, 2025
75 checks passed

flutter-dashboard bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Apr 18, 2025

bleroux deleted the fix_carousel_view_crash_on_zero_viewport_dimension branch April 18, 2025 13:05

engine-flutter-autoroll mentioned this pull request Apr 18, 2025

Roll Flutter from ecabb1a05212 to d20300874123 (20 revisions) flutter/packages#9111

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 18, 2025

7cadbeac6 Fix CarouselView crashes when initlal viewportDimension is …

722c029

…0.0 (flutter/flutter#167271)

engine-flutter-autoroll mentioned this pull request Apr 18, 2025

Roll Flutter from ecabb1a05212 to f20bc39cc005 (21 revisions) flutter/packages#9113

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 18, 2025

7cadbeac6 Fix CarouselView crashes when initlal viewportDimension is …

dba34d1

…0.0 (flutter/flutter#167271)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 18, 2025

7cadbeac6 Fix CarouselView crashes when initlal viewportDimension is …

fcdde10

…0.0 (flutter/flutter#167271)

engine-flutter-autoroll mentioned this pull request Apr 18, 2025

Roll Flutter from ecabb1a05212 to 3ed38e24528a (23 revisions) flutter/packages#9114

Merged

Piinks mentioned this pull request Apr 18, 2025

Flutter Notable Commits - 2025 #161460

Open

bleroux mentioned this pull request Apr 23, 2025

Fix CarouselView.weighted crashes when initlal viewportDimension is 0.0 #167628

Merged

bleroux mentioned this pull request May 13, 2025

Unsupported operation: Infinity or NaN toInt. In RenderSliverFixedExtentBoxAdaptor #105630

Open

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 14, 2025

7cadbeac6 Fix CarouselView crashes when initlal viewportDimension is …

34677b3

…0.0 (flutter/flutter#167271)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 14, 2025

7cadbeac6 Fix CarouselView crashes when initlal viewportDimension is …

5061b0f

…0.0 (flutter/flutter#167271)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 15, 2025

7cadbeac6 Fix CarouselView crashes when initlal viewportDimension is …

5a49718

…0.0 (flutter/flutter#167271)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 15, 2025

7cadbeac6 Fix CarouselView crashes when initlal viewportDimension is …

c34e311

…0.0 (flutter/flutter#167271)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 16, 2025

7cadbeac6 Fix CarouselView crashes when initlal viewportDimension is …

22f2542

…0.0 (flutter/flutter#167271)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Fix CarouselView crashes when initlal viewportDimension is 0.0 #167271

Fix CarouselView crashes when initlal viewportDimension is 0.0 #167271

Uh oh!

bleroux commented Apr 16, 2025 •

edited

Loading

Uh oh!

flutter-dashboard bot commented Apr 16, 2025

Uh oh!

flutter-dashboard bot commented Apr 16, 2025

Uh oh!

QuncCccccc left a comment

Uh oh!

QuncCccccc Apr 17, 2025

Uh oh!

bleroux Apr 18, 2025

Uh oh!

QuncCccccc Apr 17, 2025

Uh oh!

bleroux Apr 18, 2025

Uh oh!

QuncCccccc Apr 18, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Fix CarouselView crashes when initlal viewportDimension is 0.0 #167271

Fix CarouselView crashes when initlal viewportDimension is 0.0 #167271

Uh oh!

Conversation

bleroux commented Apr 16, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Related Issue

Tests

Uh oh!

flutter-dashboard bot commented Apr 16, 2025

Uh oh!

flutter-dashboard bot commented Apr 16, 2025

Uh oh!

QuncCccccc left a comment

Choose a reason for hiding this comment

Uh oh!

QuncCccccc Apr 17, 2025

Choose a reason for hiding this comment

Uh oh!

bleroux Apr 18, 2025

Choose a reason for hiding this comment

Uh oh!

QuncCccccc Apr 17, 2025

Choose a reason for hiding this comment

Uh oh!

bleroux Apr 18, 2025

Choose a reason for hiding this comment

Uh oh!

QuncCccccc Apr 18, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

bleroux commented Apr 16, 2025 •

edited

Loading