Skip to content

[Web] Remove webOnlyUniformRadii from RRect #167237

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
auto-submit merged 2 commits into from
Apr 16, 2025
Merged

[Web] Remove webOnlyUniformRadii from RRect #167237

auto-submit merged 2 commits into from
Apr 16, 2025

Conversation

@dkwingsmt
Copy link
Contributor

@dkwingsmt dkwingsmt commented Apr 15, 2025

This variable was added in flutter/engine#15970 (for the HTML renderer I guess?) and is apparently no long used anywhere.

Pre-launch Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@dkwingsmt dkwingsmt requested a review from yjbanov April 15, 2025 22:10
@github-actions github-actions bot added engine flutter/engine related. See also e: labels. platform-web Web applications specifically labels Apr 15, 2025
yjbanov
yjbanov approved these changes Apr 15, 2025
View reviewed changes
Copy link
Contributor

@yjbanov yjbanov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@yjbanov
Copy link
Contributor

yjbanov commented Apr 15, 2025 •
edited
Loading

Great catch!

@dkwingsmt dkwingsmt added the autosubmit Merge PR when tree becomes green via auto submit App label Apr 16, 2025
@auto-submit auto-submit bot added this pull request to the merge queue Apr 16, 2025
Merged via the queue into flutter:master with commit aef4718 Apr 16, 2025
177 checks passed
@flutter-dashboard flutter-dashboard bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Apr 16, 2025
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 16, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 16, 2025
@engine-flutter-autoroll
aef4718b3 [Web] Remove webOnlyUniformRadii from RRect (flutter/fl…
edd57a4 
…utter#167237)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 16, 2025
@engine-flutter-autoroll
aef4718b3 [Web] Remove webOnlyUniformRadii from RRect (flutter/fl…
d8c2816 
…utter#167237)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 16, 2025
Merged
mboetger pushed a commit to mboetger/flutter that referenced this pull request Apr 16, 2025
@dkwingsmt @mboetger
[Web] Remove webOnlyUniformRadii from RRect (flutter#167237)
8b7ccc5 
This variable was added in flutter/engine#15970
(for the HTML renderer I guess?) and is apparently no long used
anywhere.

## Pre-launch Checklist

- [ ] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [ ] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [ ] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [ ] I signed the [CLA].
- [ ] I listed at least one issue that this PR fixes in the description
above.
- [ ] I updated/added relevant documentation (doc comments with `///`).
- [ ] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [ ] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [ ] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
auto-submit bot pushed a commit to flutter/packages that referenced this pull request Apr 16, 2025
@engine-flutter-autoroll
Roll Flutter from db68c950c599 to aef4718b3956 (7 revisions) (#9098)
3e2b88d 
flutter/flutter@db68c95...aef4718

2025-04-16 [email protected] [Web] Remove `webOnlyUniformRadii` from `RRect` (flutter/flutter#167237)
2025-04-16 [email protected] Roll Skia from 76cb5d4fba27 to 6627deb65939 (10 revisions) (flutter/flutter#167249)
2025-04-16 [email protected] Adding macrobenchmarks for DDC (flutter/flutter#166617)
2025-04-15 [email protected] Add button icon support for animation duration (flutter/flutter#162667)
2025-04-15 [email protected] Roll Dartdoc to 8.3.3 (flutter/flutter#167231)
2025-04-15 [email protected] Removed superfluous copy in license checker (flutter/flutter#167146)
2025-04-15 [email protected] license checker: ignore git sha in dart license (flutter/flutter#167153)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
@dkwingsmt dkwingsmt deleted the remove-uniform-radii branch April 17, 2025 19:58
ash2moon pushed a commit to ash2moon/flutter that referenced this pull request Apr 21, 2025
@dkwingsmt @ash2moon
[Web] Remove webOnlyUniformRadii from RRect (flutter#167237)
3f023f1 
This variable was added in flutter/engine#15970
(for the HTML renderer I guess?) and is apparently no long used
anywhere.

## Pre-launch Checklist

- [ ] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [ ] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [ ] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [ ] I signed the [CLA].
- [ ] I listed at least one issue that this PR fixes in the description
above.
- [ ] I updated/added relevant documentation (doc comments with `///`).
- [ ] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [ ] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [ ] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
CodixNinja pushed a commit to CodixNinja/packages that referenced this pull request May 15, 2025
@engine-flutter-autoroll
Roll Flutter from db68c950c599 to aef4718b3956 (7 revisions) (#9098)
6da910d 
flutter/flutter@db68c95...aef4718

2025-04-16 [email protected] [Web] Remove `webOnlyUniformRadii` from `RRect` (flutter/flutter#167237)
2025-04-16 [email protected] Roll Skia from 76cb5d4fba27 to 6627deb65939 (10 revisions) (flutter/flutter#167249)
2025-04-16 [email protected] Adding macrobenchmarks for DDC (flutter/flutter#166617)
2025-04-15 [email protected] Add button icon support for animation duration (flutter/flutter#162667)
2025-04-15 [email protected] Roll Dartdoc to 8.3.3 (flutter/flutter#167231)
2025-04-15 [email protected] Removed superfluous copy in license checker (flutter/flutter#167146)
2025-04-15 [email protected] license checker: ignore git sha in dart license (flutter/flutter#167153)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
androidseb pushed a commit to androidseb/packages that referenced this pull request Jun 8, 2025
@engine-flutter-autoroll @androidseb
Roll Flutter from db68c950c599 to aef4718b3956 (7 revisions) (flutter…
a2614cd 
…#9098)

flutter/flutter@db68c95...aef4718

2025-04-16 [email protected] [Web] Remove `webOnlyUniformRadii` from `RRect` (flutter/flutter#167237)
2025-04-16 [email protected] Roll Skia from 76cb5d4fba27 to 6627deb65939 (10 revisions) (flutter/flutter#167249)
2025-04-16 [email protected] Adding macrobenchmarks for DDC (flutter/flutter#166617)
2025-04-15 [email protected] Add button icon support for animation duration (flutter/flutter#162667)
2025-04-15 [email protected] Roll Dartdoc to 8.3.3 (flutter/flutter#167231)
2025-04-15 [email protected] Removed superfluous copy in license checker (flutter/flutter#167146)
2025-04-15 [email protected] license checker: ignore git sha in dart license (flutter/flutter#167153)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
FMorschel pushed a commit to FMorschel/packages that referenced this pull request Jun 9, 2025
@engine-flutter-autoroll @FMorschel
Roll Flutter from db68c950c599 to aef4718b3956 (7 revisions) (flutter…
ed23464 
…#9098)

flutter/flutter@db68c95...aef4718

2025-04-16 [email protected] [Web] Remove `webOnlyUniformRadii` from `RRect` (flutter/flutter#167237)
2025-04-16 [email protected] Roll Skia from 76cb5d4fba27 to 6627deb65939 (10 revisions) (flutter/flutter#167249)
2025-04-16 [email protected] Adding macrobenchmarks for DDC (flutter/flutter#166617)
2025-04-15 [email protected] Add button icon support for animation duration (flutter/flutter#162667)
2025-04-15 [email protected] Roll Dartdoc to 8.3.3 (flutter/flutter#167231)
2025-04-15 [email protected] Removed superfluous copy in license checker (flutter/flutter#167146)
2025-04-15 [email protected] license checker: ignore git sha in dart license (flutter/flutter#167153)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Ortes pushed a commit to Ortes/packages that referenced this pull request Jun 25, 2025
@engine-flutter-autoroll @Ortes
Roll Flutter from db68c950c599 to aef4718b3956 (7 revisions) (flutter…
bc477e9 
…#9098)

flutter/flutter@db68c95...aef4718

2025-04-16 [email protected] [Web] Remove `webOnlyUniformRadii` from `RRect` (flutter/flutter#167237)
2025-04-16 [email protected] Roll Skia from 76cb5d4fba27 to 6627deb65939 (10 revisions) (flutter/flutter#167249)
2025-04-16 [email protected] Adding macrobenchmarks for DDC (flutter/flutter#166617)
2025-04-15 [email protected] Add button icon support for animation duration (flutter/flutter#162667)
2025-04-15 [email protected] Roll Dartdoc to 8.3.3 (flutter/flutter#167231)
2025-04-15 [email protected] Removed superfluous copy in license checker (flutter/flutter#167146)
2025-04-15 [email protected] license checker: ignore git sha in dart license (flutter/flutter#167153)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 14, 2025
@engine-flutter-autoroll
aef4718b3 [Web] Remove webOnlyUniformRadii from RRect (flutter/fl…
45fec8f 
…utter#167237)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 14, 2025
@engine-flutter-autoroll
aef4718b3 [Web] Remove webOnlyUniformRadii from RRect (flutter/fl…
75f00dc 
…utter#167237)
romanejaquez pushed a commit to romanejaquez/flutter that referenced this pull request Aug 14, 2025
@dkwingsmt @romanejaquez
[Web] Remove webOnlyUniformRadii from RRect (flutter#167237)
e3b822b 
This variable was added in flutter/engine#15970
(for the HTML renderer I guess?) and is apparently no long used
anywhere.

## Pre-launch Checklist

- [ ] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [ ] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [ ] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [ ] I signed the [CLA].
- [ ] I listed at least one issue that this PR fixes in the description
above.
- [ ] I updated/added relevant documentation (doc comments with `///`).
- [ ] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [ ] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [ ] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 15, 2025
@engine-flutter-autoroll
aef4718b3 [Web] Remove webOnlyUniformRadii from RRect (flutter/fl…
497068b 
…utter#167237)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 15, 2025
@engine-flutter-autoroll
aef4718b3 [Web] Remove webOnlyUniformRadii from RRect (flutter/fl…
e779ed0 
…utter#167237)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 16, 2025
@engine-flutter-autoroll
aef4718b3 [Web] Remove webOnlyUniformRadii from RRect (flutter/fl…
08385df 
…utter#167237)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yjbanov yjbanov yjbanov approved these changes

Assignees

No one assigned

Labels

engine flutter/engine related. See also e: labels. platform-web Web applications specifically

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@dkwingsmt @yjbanov