Don't throw on error for mDNS when searching for Dart VML url on core devices #167135

vashworth · 2025-04-14T20:23:09Z

When we discover the Dart VM for iOS Core Devices (iOS 17+), we use both the device logs and mDNS simultaneously. Since mDNS is having issues with macOS 15, don't throw if mDNS errors - this will allow the Dart VM to have a chance to be found by the device logs instead.

Improving experience for #150131.

Also should unblock #166843.

Pre-launch Checklist

I read the Contributor Guide and followed the process outlined there for submitting PRs.
I read the Tree Hygiene wiki page, which explains my responsibilities.
I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
I signed the CLA.
I listed at least one issue that this PR fixes in the description above.
I updated/added relevant documentation (doc comments with ///).
I added new tests to check the change I am making, or this PR is test-exempt.
I followed the breaking change policy and added Data Driven Fixes where supported.
All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

… devices

packages/flutter_tools/lib/src/ios/devices.dart

vashworth · 2025-04-15T18:04:44Z

packages/flutter_tools/lib/src/mdns_discovery.dart

-      throwToolExit(
-        'Flutter could not connect to the Dart VM service.\n'
+      throw MissingLocalNetworkPermissionsException(
+        'Flutter could not access the local network.\n'


I changed the error message because in some situations in can still connect to the Dart VM even if mDNS fails

loic-sharma · 2025-04-15T19:26:17Z

packages/flutter_tools/lib/src/ios/devices.dart

+        _logger.printError(e.toString());
+        localUri = await vmServiceDiscovery.uri;
+      } else {
+        rethrow;


Should this be a tool exit? We don't want this exception to show up in crash analytics if the user needs to take action to fix this.

Do all exceptions go to crash analytics? Like if this throws, it doesn't generate a crash report. @bkonyi Do you know?

Yeah, unhandled exceptions are captured by crash analytics. If we encounter a fatal error that isn't a crash or unexpected, we should tool exit instead.

@loic-sharma I'm going to revert back to passing down a throwOnError parameter so that we don't need to catch and rethrow a toolExit everywhere MDnsVmServiceDiscovery is used

I'm not exactly sure how this works, but my understanding is that tool exists are treated as a user error and are excluded from the tool's exception tracking.

loic-sharma

Looks good with one question!

flutter-dashboard · 2025-04-16T15:44:26Z

Golden file changes have been found for this pull request. Click here to view and triage (e.g. because this is an intentional change).

If you are still iterating on this change and are not ready to resolve the images on the Flutter Gold dashboard, consider marking this PR as a draft pull request above. You will still be able to view image results on the dashboard, commenting will be silenced, and the check will not try to resolve itself until marked ready for review.

For more guidance, visit Writing a golden file test for package:flutter.

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

Changes reported for pull request #167135 at sha 0c04d39

loic-sharma

LGTM!

auto-submit · 2025-04-16T18:29:21Z

autosubmit label was removed for flutter/flutter/167135, because - The status or check suite Mac tool_integration_tests_3_5 has failed. Please fix the issues identified (or deflake) before re-applying this label.

…rl on core devices (flutter/flutter#167135)

flutter/flutter@aef4718...ecabb1a 2025-04-17 [email protected] Hide error on mDNS registration failure and print warning in flutter attach (flutter/flutter#166782) 2025-04-17 [email protected] Add support for language hints in TextFields (Android only) (flutter/flutter#165554) 2025-04-17 [email protected] Roll Skia from d8f13372549d to cc2b57434651 (1 revision) (flutter/flutter#167331) 2025-04-17 [email protected] Add DropdownMenu.restorationId (flutter/flutter#166684) 2025-04-17 [email protected] Roll Skia from 3d6165b70199 to d8f13372549d (14 revisions) (flutter/flutter#167325) 2025-04-17 [email protected] fix(CircularProgressIndicator.adaptive): strokeWidth default value (flutter/flutter#165370) 2025-04-17 [email protected] Remove unnecessary builder (flutter/flutter#166623) 2025-04-17 [email protected] Add a `gradle_errors.dart`entry for missing NDK source.properties file (flutter/flutter#167320) 2025-04-17 [email protected] Roll Skia from 6627deb65939 to 3d6165b70199 (1 revision) (flutter/flutter#167255) 2025-04-17 [email protected] Manual roll Dart SDK from 87965ab4864e to 992221a362ec (35 revisions) (flutter/flutter#167243) 2025-04-16 [email protected] Roll Fuchsia Linux SDK from 7bWzHwIPBTyU6R9nO... to m8Aln7fTF_8zy1V9N... (flutter/flutter#167312) 2025-04-16 [email protected] Don't throw on error for mDNS when searching for Dart VML url on core devices (flutter/flutter#167135) 2025-04-16 [email protected] Fix: Localization for non zero time in 24 hours format (flutter/flutter#164885) 2025-04-16 [email protected] Updated docstrings for TextureContents (flutter/flutter#167221) 2025-04-16 [email protected] Broke cyclical dependency with dlpath and typographer. (flutter/flutter#167293) 2025-04-16 [email protected] Set an additional CMake arg in `forceNdkDownload` to make the task name align with the `BuildType` (flutter/flutter#167240) 2025-04-16 [email protected] Fix Carousel crashes when using PageStorageKey (flutter/flutter#166817) 2025-04-16 [email protected] Revert "Removed superfluous copy in license checker (#167146)" (flutter/flutter#167246) 2025-04-16 [email protected] [native assets] Roll dependencies (flutter/flutter#167287) 2025-04-16 [email protected] Marks Linux_pixel_7pro static_path_stroke_tessellation_perf__timeline_summary to be unflaky (flutter/flutter#167259) 2025-04-16 [email protected] Feat: Add carousel view theme (flutter/flutter#164769) 2025-04-16 [email protected] Marks Mac_ios dynamic_path_stroke_tessellation_perf_ios__timeline_summary to be unflaky (flutter/flutter#167261) 2025-04-16 [email protected] When using --local-web-sdk, use a locally built Dart SDK if one is available (flutter/flutter#166732) 2025-04-16 [email protected] Added emulator version to doctor (flutter/flutter#167236) 2025-04-16 [email protected] Marks Mac_ios static_path_stroke_tessellation_perf_ios__timeline_summary to be unflaky (flutter/flutter#167260) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

flutter/flutter@aef4718...ecabb1a 2025-04-17 [email protected] Hide error on mDNS registration failure and print warning in flutter attach (flutter/flutter#166782) 2025-04-17 [email protected] Add support for language hints in TextFields (Android only) (flutter/flutter#165554) 2025-04-17 [email protected] Roll Skia from d8f13372549d to cc2b57434651 (1 revision) (flutter/flutter#167331) 2025-04-17 [email protected] Add DropdownMenu.restorationId (flutter/flutter#166684) 2025-04-17 [email protected] Roll Skia from 3d6165b70199 to d8f13372549d (14 revisions) (flutter/flutter#167325) 2025-04-17 [email protected] fix(CircularProgressIndicator.adaptive): strokeWidth default value (flutter/flutter#165370) 2025-04-17 [email protected] Remove unnecessary builder (flutter/flutter#166623) 2025-04-17 [email protected] Add a `gradle_errors.dart`entry for missing NDK source.properties file (flutter/flutter#167320) 2025-04-17 [email protected] Roll Skia from 6627deb65939 to 3d6165b70199 (1 revision) (flutter/flutter#167255) 2025-04-17 [email protected] Manual roll Dart SDK from 87965ab4864e to 992221a362ec (35 revisions) (flutter/flutter#167243) 2025-04-16 [email protected] Roll Fuchsia Linux SDK from 7bWzHwIPBTyU6R9nO... to m8Aln7fTF_8zy1V9N... (flutter/flutter#167312) 2025-04-16 [email protected] Don't throw on error for mDNS when searching for Dart VML url on core devices (flutter/flutter#167135) 2025-04-16 [email protected] Fix: Localization for non zero time in 24 hours format (flutter/flutter#164885) 2025-04-16 [email protected] Updated docstrings for TextureContents (flutter/flutter#167221) 2025-04-16 [email protected] Broke cyclical dependency with dlpath and typographer. (flutter/flutter#167293) 2025-04-16 [email protected] Set an additional CMake arg in `forceNdkDownload` to make the task name align with the `BuildType` (flutter/flutter#167240) 2025-04-16 [email protected] Fix Carousel crashes when using PageStorageKey (flutter/flutter#166817) 2025-04-16 [email protected] Revert "Removed superfluous copy in license checker (#167146)" (flutter/flutter#167246) 2025-04-16 [email protected] [native assets] Roll dependencies (flutter/flutter#167287) 2025-04-16 [email protected] Marks Linux_pixel_7pro static_path_stroke_tessellation_perf__timeline_summary to be unflaky (flutter/flutter#167259) 2025-04-16 [email protected] Feat: Add carousel view theme (flutter/flutter#164769) 2025-04-16 [email protected] Marks Mac_ios dynamic_path_stroke_tessellation_perf_ios__timeline_summary to be unflaky (flutter/flutter#167261) 2025-04-16 [email protected] When using --local-web-sdk, use a locally built Dart SDK if one is available (flutter/flutter#166732) 2025-04-16 [email protected] Added emulator version to doctor (flutter/flutter#167236) 2025-04-16 [email protected] Marks Mac_ios static_path_stroke_tessellation_perf_ios__timeline_summary to be unflaky (flutter/flutter#167260) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

…r#9104) flutter/flutter@aef4718...ecabb1a 2025-04-17 [email protected] Hide error on mDNS registration failure and print warning in flutter attach (flutter/flutter#166782) 2025-04-17 [email protected] Add support for language hints in TextFields (Android only) (flutter/flutter#165554) 2025-04-17 [email protected] Roll Skia from d8f13372549d to cc2b57434651 (1 revision) (flutter/flutter#167331) 2025-04-17 [email protected] Add DropdownMenu.restorationId (flutter/flutter#166684) 2025-04-17 [email protected] Roll Skia from 3d6165b70199 to d8f13372549d (14 revisions) (flutter/flutter#167325) 2025-04-17 [email protected] fix(CircularProgressIndicator.adaptive): strokeWidth default value (flutter/flutter#165370) 2025-04-17 [email protected] Remove unnecessary builder (flutter/flutter#166623) 2025-04-17 [email protected] Add a `gradle_errors.dart`entry for missing NDK source.properties file (flutter/flutter#167320) 2025-04-17 [email protected] Roll Skia from 6627deb65939 to 3d6165b70199 (1 revision) (flutter/flutter#167255) 2025-04-17 [email protected] Manual roll Dart SDK from 87965ab4864e to 992221a362ec (35 revisions) (flutter/flutter#167243) 2025-04-16 [email protected] Roll Fuchsia Linux SDK from 7bWzHwIPBTyU6R9nO... to m8Aln7fTF_8zy1V9N... (flutter/flutter#167312) 2025-04-16 [email protected] Don't throw on error for mDNS when searching for Dart VML url on core devices (flutter/flutter#167135) 2025-04-16 [email protected] Fix: Localization for non zero time in 24 hours format (flutter/flutter#164885) 2025-04-16 [email protected] Updated docstrings for TextureContents (flutter/flutter#167221) 2025-04-16 [email protected] Broke cyclical dependency with dlpath and typographer. (flutter/flutter#167293) 2025-04-16 [email protected] Set an additional CMake arg in `forceNdkDownload` to make the task name align with the `BuildType` (flutter/flutter#167240) 2025-04-16 [email protected] Fix Carousel crashes when using PageStorageKey (flutter/flutter#166817) 2025-04-16 [email protected] Revert "Removed superfluous copy in license checker (#167146)" (flutter/flutter#167246) 2025-04-16 [email protected] [native assets] Roll dependencies (flutter/flutter#167287) 2025-04-16 [email protected] Marks Linux_pixel_7pro static_path_stroke_tessellation_perf__timeline_summary to be unflaky (flutter/flutter#167259) 2025-04-16 [email protected] Feat: Add carousel view theme (flutter/flutter#164769) 2025-04-16 [email protected] Marks Mac_ios dynamic_path_stroke_tessellation_perf_ios__timeline_summary to be unflaky (flutter/flutter#167261) 2025-04-16 [email protected] When using --local-web-sdk, use a locally built Dart SDK if one is available (flutter/flutter#166732) 2025-04-16 [email protected] Added emulator version to doctor (flutter/flutter#167236) 2025-04-16 [email protected] Marks Mac_ios static_path_stroke_tessellation_perf_ios__timeline_summary to be unflaky (flutter/flutter#167260) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

…rl on core devices (flutter/flutter#167135)

…rl on core devices (flutter/flutter#167135)

Don't throw on error for mDNS when searching for Dart VML url on core…

fee8666

… devices

github-actions bot added platform-ios iOS applications specifically tool Affects the "flutter" command-line tool. See also t: labels. team-ios Owned by iOS platform team labels Apr 14, 2025

vashworth marked this pull request as ready for review April 14, 2025 21:01

vashworth requested a review from a team as a code owner April 14, 2025 21:01

vashworth requested a review from loic-sharma April 14, 2025 21:01

loic-sharma reviewed Apr 14, 2025

View reviewed changes

packages/flutter_tools/lib/src/ios/devices.dart Outdated Show resolved Hide resolved

vashworth added 2 commits April 15, 2025 11:56

catch error

6922d54

readd platform check

825565d

vashworth commented Apr 15, 2025

View reviewed changes

vashworth requested a review from loic-sharma April 15, 2025 18:05

loic-sharma reviewed Apr 15, 2025

View reviewed changes

loic-sharma approved these changes Apr 15, 2025

View reviewed changes

vashworth added 2 commits April 15, 2025 15:23

Throw toolExit on error if parameter indicates it

b3a7bf1

trace stackTrace either way

b65089e

vashworth requested a review from loic-sharma April 15, 2025 20:26

rename throwOnError parameter

0c04d39

flutter-dashboard bot added the will affect goldens Changes to golden files label Apr 16, 2025

loic-sharma approved these changes Apr 16, 2025

View reviewed changes

vashworth added the autosubmit Merge PR when tree becomes green via auto submit App label Apr 16, 2025

Merge branch 'master' into prevent_mDNS_throw

8b09240

auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Apr 16, 2025

vashworth added the autosubmit Merge PR when tree becomes green via auto submit App label Apr 16, 2025

auto-submit bot added this pull request to the merge queue Apr 16, 2025

Merged via the queue into flutter:master with commit e841350 Apr 16, 2025
141 of 142 checks passed

flutter-dashboard bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Apr 16, 2025

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 17, 2025

e841350bf Don't throw on error for mDNS when searching for Dart VML u…

f343970

…rl on core devices (flutter/flutter#167135)

engine-flutter-autoroll mentioned this pull request Apr 17, 2025

Roll Flutter from aef4718b3956 to ecabb1a05212 (25 revisions) flutter/packages#9104

Merged

This was referenced Apr 18, 2025

On macOS Sequoia - [tool_crash] SocketException: Send failed, OS Error: No route to host, errno = 65 #150131

Open

[Mac-15] mDNS fails due to missing permission #166843

Open

This was referenced Apr 25, 2025

CP macOS 15 fixes for beta and stable #167837

Closed

Tracking issue for any infra or test failures with macOS 15 #167681

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 14, 2025

e841350bf Don't throw on error for mDNS when searching for Dart VML u…

25eae32

…rl on core devices (flutter/flutter#167135)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 14, 2025

e841350bf Don't throw on error for mDNS when searching for Dart VML u…

07e1d26

…rl on core devices (flutter/flutter#167135)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 15, 2025

e841350bf Don't throw on error for mDNS when searching for Dart VML u…

25b1534

…rl on core devices (flutter/flutter#167135)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 15, 2025

e841350bf Don't throw on error for mDNS when searching for Dart VML u…

f08266e

…rl on core devices (flutter/flutter#167135)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 16, 2025

e841350bf Don't throw on error for mDNS when searching for Dart VML u…

97d00a1

…rl on core devices (flutter/flutter#167135)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Don't throw on error for mDNS when searching for Dart VML url on core devices #167135

Don't throw on error for mDNS when searching for Dart VML url on core devices #167135

Uh oh!

vashworth commented Apr 14, 2025 •

edited

Loading

Uh oh!

Uh oh!

vashworth Apr 15, 2025

Uh oh!

loic-sharma Apr 15, 2025

Uh oh!

vashworth Apr 15, 2025

Uh oh!

bkonyi Apr 15, 2025

Uh oh!

vashworth Apr 15, 2025 •

edited

Loading

Uh oh!

loic-sharma Apr 15, 2025

Uh oh!

loic-sharma left a comment

Uh oh!

flutter-dashboard bot commented Apr 16, 2025

Uh oh!

loic-sharma left a comment

Uh oh!

auto-submit bot commented Apr 16, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Don't throw on error for mDNS when searching for Dart VML url on core devices #167135

Don't throw on error for mDNS when searching for Dart VML url on core devices #167135

Uh oh!

Conversation

vashworth commented Apr 14, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Pre-launch Checklist

Uh oh!

Uh oh!

vashworth Apr 15, 2025

Choose a reason for hiding this comment

Uh oh!

loic-sharma Apr 15, 2025

Choose a reason for hiding this comment

Uh oh!

vashworth Apr 15, 2025

Choose a reason for hiding this comment

Uh oh!

bkonyi Apr 15, 2025

Choose a reason for hiding this comment

Uh oh!

vashworth Apr 15, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

loic-sharma Apr 15, 2025

Choose a reason for hiding this comment

Uh oh!

loic-sharma left a comment

Choose a reason for hiding this comment

Uh oh!

flutter-dashboard bot commented Apr 16, 2025

Uh oh!

loic-sharma left a comment

Choose a reason for hiding this comment

Uh oh!

auto-submit bot commented Apr 16, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

vashworth commented Apr 14, 2025 •

edited

Loading

vashworth Apr 15, 2025 •

edited

Loading