Fix visual overlap of transparent routes barrier when using FadeForwardsPageTransitionsBuilder #167032

TheLastFlame · 2025-04-12T13:01:19Z

Reopens #165726 with the removed test that has become irrelevant.

Depends on: #167324

Actual master:

Screen.Recording.2025-04-11.165345.mp4

After fix:

Screen.Recording.2025-04-12.225920.mp4

Pre-launch Checklist

I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
I read the [Tree Hygiene] wiki page, which explains my responsibilities.
I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
I signed the [CLA].
I listed at least one issue that this PR fixes in the description above.
I updated/added relevant documentation (doc comments with ///).
I added new tests to check the change I am making, or this PR is [test-exempt].
I followed the [breaking change policy] and added [Data Driven Fixes] where supported.
All existing and new tests are passing.

flutter-dashboard · 2025-04-12T13:01:22Z

It looks like this pull request may not have tests. Please make sure to add tests or get an explicit test exemption before merging.

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.If you believe this PR qualifies for a test exemption, contact "@test-exemption-reviewer" in the #hackers channel in Discord (don't just cc them here, they won't see it!). The test exemption team is a small volunteer group, so all reviewers should feel empowered to ask for tests, without delegating that responsibility entirely to the test exemption group.

flutter-dashboard · 2025-04-12T13:57:12Z

Golden file changes have been found for this pull request. Click here to view and triage (e.g. because this is an intentional change).

If you are still iterating on this change and are not ready to resolve the images on the Flutter Gold dashboard, consider marking this PR as a draft pull request above. You will still be able to view image results on the dashboard, commenting will be silenced, and the check will not try to resolve itself until marked ready for review.

For more guidance, visit Writing a golden file test for package:flutter.

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

Changes reported for pull request #167032 at sha 6752c16

TheLastFlame · 2025-04-12T15:03:44Z

I didn't really understand what happened with the golden test. I did not make any changes that could affect the cupertino date picker displayed there.

navaronbracke

Some drive-by feedback.

You will also need a test for this, that asserts that no ColoredBox is used when the modal route is not opaque. (for the forward & reverse cases)

packages/flutter/lib/src/material/page_transitions_theme.dart

flutter-dashboard · 2025-04-17T00:15:45Z

This pull request has been changed to a draft. The currently pending flutter-gold status will not be able to resolve until a new commit is pushed or the change is marked ready for review again.

For more guidance, visit Writing a golden file test for package:flutter.

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

QuncCccccc

Thanks for your contribution! Seems this PR change overlaps #167324, should we wait until that PR lands and then proceed this one:)?

QuncCccccc · 2025-04-30T17:14:19Z

packages/flutter/lib/src/material/page_transitions_theme.dart

        color:
            animation.isAnimating
-                ? backgroundColor ?? Theme.of(context).colorScheme.surface
+                ? backgroundColor ?? ColorScheme.of(context).surface


This is equivalent to Theme.of(context).colorScheme, so I guess we change it here for simplicity?

Yes, I did suggest that in #167032 (comment) for exactly that reason :)

QuncCccccc · 2025-05-05T20:19:18Z

I saw some error like this

Maybe try to rebase master to see if we can fix the failures. This role is removed several days ago.

QuncCccccc

LGTM:) Thank you!

justinmc

Looks good but we are still waiting on #167324. I'll make sure we have a decision on that one next week.

justinmc · 2025-05-29T20:51:25Z

#167324 is now merged. @TheLastFlame can you update this PR now?

TheLastFlame · 2025-05-29T23:38:49Z

@justinmc , Google testing failed 🤔
Can you see what happened?

packages/flutter/lib/src/material/page_transitions_theme.dart

packages/flutter/test/material/page_transitions_theme_test.dart

QuncCccccc · 2025-08-13T05:37:01Z

Since it's just formatting issue and a nit, I just committed the change. Hope you don't mind:)

… FadeForwardsPageTransitionsBuilder (flutter/flutter#167032)

flutter/flutter@34c2a3b...f4334d2 2025-08-14 [email protected] Roll Dart SDK from 9b4691f35139 to 214a7f829913 (2 revisions) (flutter/flutter#173769) 2025-08-14 [email protected] Roll Skia from b3e86773dae1 to dca5f05fee87 (4 revisions) (flutter/flutter#173763) 2025-08-14 [email protected] Roll Dart SDK from 73153bdc1459 to 9b4691f35139 (3 revisions) (flutter/flutter#173755) 2025-08-14 [email protected] Roll Skia from 5852eddfd404 to b3e86773dae1 (1 revision) (flutter/flutter#173750) 2025-08-14 [email protected] Allow empty initial time when using text input mode in showTimePicker dialog (flutter/flutter#172847) 2025-08-13 [email protected] Roll Skia from 525e2bf80559 to 5852eddfd404 (2 revisions) (flutter/flutter#173740) 2025-08-13 [email protected] [web] Popping a nameless route should preserve the correct route name (flutter/flutter#173652) 2025-08-13 [email protected] Make sure that a ChoiceChip doesn't crash in 0x0 environment (flutter/flutter#173322) 2025-08-13 [email protected] [ Tool ] Fix missing import for widget_preview.dart (flutter/flutter#173731) 2025-08-13 [email protected] Roll Skia from f7fdda3cd0e6 to 525e2bf80559 (7 revisions) (flutter/flutter#173727) 2025-08-13 [email protected] Do not include `:unittests` unless `enable_unittests` (flutter/flutter#173729) 2025-08-13 [email protected] Roll Packages from 08a9b2c to 6cb9113 (1 revision) (flutter/flutter#173726) 2025-08-13 [email protected] fix: selected date decorator renders outside PageView in `DatePickerDialog` dialog (flutter/flutter#171718) 2025-08-13 [email protected] [ Widget Preview ] Add `--machine` mode (flutter/flutter#173654) 2025-08-13 [email protected] Make sure that a Chip doesn't crash in 0x0 environment (flutter/flutter#173245) 2025-08-13 [email protected] feat: Cupertino sheet implement upward stretch on full sheet (flutter/flutter#168547) 2025-08-13 [email protected] Fix visual overlap of transparent routes barrier when using FadeForwardsPageTransitionsBuilder (flutter/flutter#167032) 2025-08-13 [email protected] Fix `ChipThemeData` lerp for `BorderSide` (flutter/flutter#173160) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

…rdsPageTransitionsBuilder (flutter#167032) Reopens flutter#165726 with the removed test that has become irrelevant. Depends on: flutter#167324 Actual master: https://github.com/user-attachments/assets/28619355-9c1e-4f06-9ede-38c4dddd13df After fix: https://github.com/user-attachments/assets/a5f2ecf2-5d8e-445a-b5a9-a7d6c0e3ec5d ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [ ] I listed at least one issue that this PR fixes in the description above. - [x] I updated/added relevant documentation (doc comments with `///`). - [x] I added new tests to check the change I am making, or this PR is [test-exempt]. - [x] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [x] All existing and new tests are passing. --------- Co-authored-by: Justin McCandless <[email protected]> Co-authored-by: Qun Cheng <[email protected]>

MaterialApp introduced a ColoredBox in the widget tree, causing this test to fail on master Related flutter/flutter#167032

…rdsPageTransitionsBuilder (flutter#167032) Reopens flutter#165726 with the removed test that has become irrelevant. Depends on: flutter#167324 Actual master: https://github.com/user-attachments/assets/28619355-9c1e-4f06-9ede-38c4dddd13df After fix: https://github.com/user-attachments/assets/a5f2ecf2-5d8e-445a-b5a9-a7d6c0e3ec5d ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [ ] I listed at least one issue that this PR fixes in the description above. - [x] I updated/added relevant documentation (doc comments with `///`). - [x] I added new tests to check the change I am making, or this PR is [test-exempt]. - [x] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [x] All existing and new tests are passing. --------- Co-authored-by: Justin McCandless <[email protected]> Co-authored-by: Qun Cheng <[email protected]>

* Add debug logging for CI * Use own widget in test MaterialApp introduced a ColoredBox in the widget tree, causing this test to fail on master Related flutter/flutter#167032 * Revert dump * Ignore deprecated members until finally removed This is only test code, irrelevant for package compatability * Explicitly set device * Tune android emulator * Reduce number of args * Use default args * Try another api level * Try 64bit

…r#9807) flutter/flutter@34c2a3b...f4334d2 2025-08-14 [email protected] Roll Dart SDK from 9b4691f35139 to 214a7f829913 (2 revisions) (flutter/flutter#173769) 2025-08-14 [email protected] Roll Skia from b3e86773dae1 to dca5f05fee87 (4 revisions) (flutter/flutter#173763) 2025-08-14 [email protected] Roll Dart SDK from 73153bdc1459 to 9b4691f35139 (3 revisions) (flutter/flutter#173755) 2025-08-14 [email protected] Roll Skia from 5852eddfd404 to b3e86773dae1 (1 revision) (flutter/flutter#173750) 2025-08-14 [email protected] Allow empty initial time when using text input mode in showTimePicker dialog (flutter/flutter#172847) 2025-08-13 [email protected] Roll Skia from 525e2bf80559 to 5852eddfd404 (2 revisions) (flutter/flutter#173740) 2025-08-13 [email protected] [web] Popping a nameless route should preserve the correct route name (flutter/flutter#173652) 2025-08-13 [email protected] Make sure that a ChoiceChip doesn't crash in 0x0 environment (flutter/flutter#173322) 2025-08-13 [email protected] [ Tool ] Fix missing import for widget_preview.dart (flutter/flutter#173731) 2025-08-13 [email protected] Roll Skia from f7fdda3cd0e6 to 525e2bf80559 (7 revisions) (flutter/flutter#173727) 2025-08-13 [email protected] Do not include `:unittests` unless `enable_unittests` (flutter/flutter#173729) 2025-08-13 [email protected] Roll Packages from 08a9b2c to 6cb9113 (1 revision) (flutter/flutter#173726) 2025-08-13 [email protected] fix: selected date decorator renders outside PageView in `DatePickerDialog` dialog (flutter/flutter#171718) 2025-08-13 [email protected] [ Widget Preview ] Add `--machine` mode (flutter/flutter#173654) 2025-08-13 [email protected] Make sure that a Chip doesn't crash in 0x0 environment (flutter/flutter#173245) 2025-08-13 [email protected] feat: Cupertino sheet implement upward stretch on full sheet (flutter/flutter#168547) 2025-08-13 [email protected] Fix visual overlap of transparent routes barrier when using FadeForwardsPageTransitionsBuilder (flutter/flutter#167032) 2025-08-13 [email protected] Fix `ChipThemeData` lerp for `BorderSide` (flutter/flutter#173160) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

…rdsPageTransitionsBuilder (flutter#167032) Reopens flutter#165726 with the removed test that has become irrelevant. Depends on: flutter#167324 Actual master: https://github.com/user-attachments/assets/28619355-9c1e-4f06-9ede-38c4dddd13df After fix: https://github.com/user-attachments/assets/a5f2ecf2-5d8e-445a-b5a9-a7d6c0e3ec5d ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [ ] I listed at least one issue that this PR fixes in the description above. - [x] I updated/added relevant documentation (doc comments with `///`). - [x] I added new tests to check the change I am making, or this PR is [test-exempt]. - [x] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [x] All existing and new tests are passing. --------- Co-authored-by: Justin McCandless <[email protected]> Co-authored-by: Qun Cheng <[email protected]>

… FadeForwardsPageTransitionsBuilder (flutter/flutter#167032)

Fix test failures caused by Flutter 3.38+ adding a transparent ColoredBox for page transitions (flutter/flutter#167032). Replace type-based widget finders with Key-based finders to explicitly target test widgets and avoid conflicts with framework-added ColoredBox widgets.

- Bump Flutter SDK minimum version: 3.32.0 -> 3.38.0 - Update accessibility_tools: ^2.0.0 -> ^2.8.0 Required for compatibility with MaterialApp page transition changes introduced in Flutter 3.38 (flutter/flutter#167032).

This PR updates the test suite to be compatible with Flutter 3.38+, which introduced a breaking change in `MaterialApp`'s page transition implementation. Flutter 3.38 added a transparent `ColoredBox` widget for page transitions ([flutter/flutter#167032](flutter/flutter#167032)), which caused existing tests that used type-based widget finders to fail with `Bad state: Too many elements` errors. The solution replaces all type-based `ColoredBox` finders with Key-based finders, making tests more explicit and robust against framework changes.

…rdsPageTransitionsBuilder (flutter#167032) Reopens flutter#165726 with the removed test that has become irrelevant. Depends on: flutter#167324 Actual master: https://github.com/user-attachments/assets/28619355-9c1e-4f06-9ede-38c4dddd13df After fix: https://github.com/user-attachments/assets/a5f2ecf2-5d8e-445a-b5a9-a7d6c0e3ec5d ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [ ] I listed at least one issue that this PR fixes in the description above. - [x] I updated/added relevant documentation (doc comments with `///`). - [x] I added new tests to check the change I am making, or this PR is [test-exempt]. - [x] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [x] All existing and new tests are passing. --------- Co-authored-by: Justin McCandless <[email protected]> Co-authored-by: Qun Cheng <[email protected]>

github-actions bot added framework flutter/packages/flutter repository. See also f: labels. f: material design flutter/packages/flutter/material repository. labels Apr 12, 2025

flutter-dashboard bot added the will affect goldens Changes to golden files label Apr 12, 2025

navaronbracke reviewed Apr 13, 2025

View reviewed changes

navaronbracke mentioned this pull request Apr 13, 2025

ModalRoute lacks aspect for opaque property #167058

Closed

TheLastFlame marked this pull request as draft April 17, 2025 00:12

TheLastFlame force-pushed the fix-fade_forwards_transition branch from 6752c16 to 4164bba Compare April 17, 2025 23:43

github-actions bot added the f: routes Navigator, Router, and related APIs. label Apr 17, 2025

TheLastFlame requested a review from navaronbracke April 18, 2025 00:56

TheLastFlame marked this pull request as ready for review April 18, 2025 00:56

dkwingsmt requested review from QuncCccccc and removed request for navaronbracke April 23, 2025 18:17

QuncCccccc reviewed Apr 30, 2025

View reviewed changes

dkwingsmt requested a review from justinmc April 30, 2025 18:37

TheLastFlame force-pushed the fix-fade_forwards_transition branch from bca7234 to b0484e0 Compare May 3, 2025 19:35

TheLastFlame mentioned this pull request May 3, 2025

fix FadeForwardsTransitionBuilder input irresponsive during return animation #164241 #168277

Closed

9 tasks

TheLastFlame force-pushed the fix-fade_forwards_transition branch from 3c19520 to e39b501 Compare May 6, 2025 01:18

QuncCccccc approved these changes May 16, 2025

View reviewed changes

justinmc mentioned this pull request May 16, 2025

Feat: Add opaque, isActive, isFirst, popDisposition aspects for ModalRoute #167324

Merged

9 tasks

justinmc reviewed May 16, 2025

View reviewed changes

TheLastFlame mentioned this pull request May 21, 2025

Refactor delegatedTransition with the addition of a route parameter #169120

Open

TheLastFlame force-pushed the fix-fade_forwards_transition branch from e39b501 to fcff2dd Compare May 29, 2025 22:58

github-actions bot removed the f: routes Navigator, Router, and related APIs. label May 29, 2025

QuncCccccc reviewed Aug 13, 2025

View reviewed changes

packages/flutter/lib/src/material/page_transitions_theme.dart Outdated Show resolved Hide resolved

packages/flutter/test/material/page_transitions_theme_test.dart Outdated Show resolved Hide resolved

QuncCccccc added 3 commits August 12, 2025 22:16

Update packages/flutter/lib/src/material/page_transitions_theme.dart

c2ebb46

Update packages/flutter/test/material/page_transitions_theme_test.dart

2f50db3

Merge branch 'master' into fix-fade_forwards_transition

9f028db

dkwingsmt added the autosubmit Merge PR when tree becomes green via auto submit App label Aug 13, 2025

auto-submit bot added this pull request to the merge queue Aug 13, 2025

Merged via the queue into flutter:master with commit 61a4d24 Aug 13, 2025
74 checks passed

flutter-dashboard bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Aug 13, 2025

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 14, 2025

61a4d24da Fix visual overlap of transparent routes barrier when using…

b855f35

… FadeForwardsPageTransitionsBuilder (flutter/flutter#167032)

engine-flutter-autoroll mentioned this pull request Aug 14, 2025

Roll Flutter from 34c2a3b158b2 to c932faf75472 (17 revisions) flutter/packages#9806

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 14, 2025

61a4d24da Fix visual overlap of transparent routes barrier when using…

169ad0d

… FadeForwardsPageTransitionsBuilder (flutter/flutter#167032)

engine-flutter-autoroll mentioned this pull request Aug 14, 2025

Roll Flutter from 34c2a3b158b2 to f4334d27934b (18 revisions) flutter/packages#9807

Merged

Piinks mentioned this pull request Aug 15, 2025

Flutter Notable Commits - 2025 #161460

Open

passsy added a commit to passsy/spot that referenced this pull request Aug 18, 2025

Use own widget in test

7f7e8db

MaterialApp introduced a ColoredBox in the widget tree, causing this test to fail on master Related flutter/flutter#167032

passsy mentioned this pull request Aug 18, 2025

Fix CI for master branch passsy/spot#123

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 12, 2025

61a4d24da Fix visual overlap of transparent routes barrier when using…

14524f3

… FadeForwardsPageTransitionsBuilder (flutter/flutter#167032)

SoutaTanaka mentioned this pull request Nov 17, 2025

test: fix ColoredBox tests on flutter 3.38 widgetbook/widgetbook#1736

Merged

5 tasks

Fix visual overlap of transparent routes barrier when using FadeForwardsPageTransitionsBuilder #167032

Fix visual overlap of transparent routes barrier when using FadeForwardsPageTransitionsBuilder #167032

Uh oh!

Conversation

TheLastFlame commented Apr 12, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Pre-launch Checklist

Uh oh!

flutter-dashboard bot commented Apr 12, 2025

Uh oh!

flutter-dashboard bot commented Apr 12, 2025

Uh oh!

TheLastFlame commented Apr 12, 2025

Uh oh!

navaronbracke left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

flutter-dashboard bot commented Apr 17, 2025

Uh oh!

QuncCccccc left a comment

Choose a reason for hiding this comment

Uh oh!

QuncCccccc Apr 30, 2025

Choose a reason for hiding this comment

Uh oh!

navaronbracke Apr 30, 2025

Choose a reason for hiding this comment

Uh oh!

QuncCccccc commented May 5, 2025

Uh oh!

QuncCccccc left a comment

Choose a reason for hiding this comment

Uh oh!

justinmc left a comment

Choose a reason for hiding this comment

Uh oh!

justinmc commented May 29, 2025

Uh oh!

TheLastFlame commented May 29, 2025

Uh oh!

Uh oh!

Uh oh!

QuncCccccc commented Aug 13, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

TheLastFlame commented Apr 12, 2025 •

edited

Loading