Skip to content

Reverts "Fix regression in NDK version checking (#166998)" #167007

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
auto-submit merged 1 commit into from
Apr 11, 2025
Merged

Reverts "Fix regression in NDK version checking (#166998)" #167007

auto-submit merged 1 commit into from
Apr 11, 2025
+3 −23

Conversation

@auto-submit
Copy link
Contributor

@auto-submit auto-submit bot commented Apr 11, 2025

Reverts: #166998

Initiated by: gmackall

Reason for reverting: #166998 (comment)

Original PR Author: gmackall

Reviewed By: {stuartmorgan-g}

This change reverts the following previous change:
Fixes a regression from #166727, see https://discord.com/channels/608014603317936148/846507907876257822/1360306682999210204

Adds a dependency on shared_preferences_android to the smoke tests we have that run across the range of AGP/Gradle versions we support. Chosen randomly, just to recreate the error. Hopefully this doesn't push the test target into timeout range, it was already a kind of long running one.

The IDE suggestion here was misleading, as this value switched from nullable to non nullable in AGP 8.1/8.2. Unfortunately the IDE makes these suggestions based on one AGP version, specified in the project level build.gradle.kts. I checked all other files with our minimum supported AGP version, and this was the only error.

Pre-launch Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@auto-submit auto-submit bot requested a review from matanlurey as a code owner April 11, 2025 21:34
@auto-submit auto-submit bot added the revert of Bot Only: Tracking label for bot. Tracks new revert of pull requests. label Apr 11, 2025
@flutter-dashboard
Copy link

flutter-dashboard bot commented Apr 11, 2025

It looks like this pull request may not have tests. Please make sure to add tests or get an explicit test exemption before merging.

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.If you believe this PR qualifies for a test exemption, contact "@test-exemption-reviewer" in the #hackers channel in Discord (don't just cc them here, they won't see it!). The test exemption team is a small volunteer group, so all reviewers should feel empowered to ask for tests, without delegating that responsibility entirely to the test exemption group.

@github-actions github-actions bot added platform-android Android applications specifically tool Affects the "flutter" command-line tool. See also t: labels. labels Apr 11, 2025
@auto-submit auto-submit bot added this pull request to the merge queue Apr 11, 2025
Merged via the queue into master with commit 28cc211 Apr 11, 2025
8 of 11 checks passed
@auto-submit auto-submit bot deleted the revert_a4b5a502d0abfb99f7e00077b0201951850ff8d3 branch April 11, 2025 22:01
gmackall pushed a commit to gmackall/flutter that referenced this pull request Apr 11, 2025
Revert "Reverts "Fix regression in NDK version checking (flutter#166998…
6faa510 
…)" (flutter#167007)"

This reverts commit 28cc211.
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 12, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 12, 2025
@engine-flutter-autoroll
28cc211fc Reverts "Fix regression in NDK version checking (#166998)" (f…
76996ea 
…lutter/flutter#167007)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 12, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 12, 2025
@engine-flutter-autoroll
28cc211fc Reverts "Fix regression in NDK version checking (#166998)" (f…
7762c45 
…lutter/flutter#167007)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 13, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 13, 2025
@engine-flutter-autoroll
28cc211fc Reverts "Fix regression in NDK version checking (#166998)" (f…
c894943 
…lutter/flutter#167007)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 14, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 14, 2025
@engine-flutter-autoroll
28cc211fc Reverts "Fix regression in NDK version checking (#166998)" (f…
7a4e081 
…lutter/flutter#167007)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 14, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 14, 2025
@engine-flutter-autoroll
28cc211fc Reverts "Fix regression in NDK version checking (#166998)" (f…
663f516 
…lutter/flutter#167007)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 14, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 14, 2025
@engine-flutter-autoroll
28cc211fc Reverts "Fix regression in NDK version checking (#166998)" (f…
02e5ed8 
…lutter/flutter#167007)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 14, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 14, 2025
@engine-flutter-autoroll
28cc211fc Reverts "Fix regression in NDK version checking (#166998)" (f…
a391292 
…lutter/flutter#167007)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 14, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 14, 2025
@engine-flutter-autoroll
28cc211fc Reverts "Fix regression in NDK version checking (#166998)" (f…
9983ee3 
…lutter/flutter#167007)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 14, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 14, 2025
@engine-flutter-autoroll
28cc211fc Reverts "Fix regression in NDK version checking (#166998)" (f…
e09bbf9 
…lutter/flutter#167007)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 14, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 14, 2025
@engine-flutter-autoroll
28cc211fc Reverts "Fix regression in NDK version checking (#166998)" (f…
283b4f9 
…lutter/flutter#167007)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 14, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 14, 2025
@engine-flutter-autoroll
28cc211fc Reverts "Fix regression in NDK version checking (#166998)" (f…
c561830 
…lutter/flutter#167007)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 15, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 15, 2025
@engine-flutter-autoroll
28cc211fc Reverts "Fix regression in NDK version checking (#166998)" (f…
8a7dc00 
…lutter/flutter#167007)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 15, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 15, 2025
@engine-flutter-autoroll
28cc211fc Reverts "Fix regression in NDK version checking (#166998)" (f…
f23fd31 
…lutter/flutter#167007)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 15, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 15, 2025
@engine-flutter-autoroll
28cc211fc Reverts "Fix regression in NDK version checking (#166998)" (f…
5bb1985 
…lutter/flutter#167007)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 15, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 15, 2025
@engine-flutter-autoroll
28cc211fc Reverts "Fix regression in NDK version checking (#166998)" (f…
a78c501 
…lutter/flutter#167007)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 15, 2025
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 15, 2025
@engine-flutter-autoroll
28cc211fc Reverts "Fix regression in NDK version checking (#166998)" (f…
3d69f68 
…lutter/flutter#167007)
auto-submit bot pushed a commit to flutter/packages that referenced this pull request Apr 16, 2025
@engine-flutter-autoroll
Manual roll Flutter from 30e53b0 to db68c950c599 (98 revisions) (#9092)
1f0a894 
Manual roll Flutter from 30e53b0 to db68c950c599 (98 revisions)

Manual roll requested by [email protected]

flutter/flutter@30e53b0...db68c95

2025-04-15 [email protected] [customer_testing] Pick up the fix for issue found by flutter/dart hh. (flutter/flutter#167212)
2025-04-15 [email protected] Roll Packages from f26b681 to 2fcc403 (4 revisions) (flutter/flutter#167218)
2025-04-15 [email protected] Fix: Update sheet route bottom padding with top padding (flutter/flutter#164473)
2025-04-15 [email protected] Add Irish(ga) to Flutter (flutter/flutter#167129)
2025-04-15 [email protected] Roll Fuchsia Linux SDK from 91RIHvX0YC3wzD7qj... to 7bWzHwIPBTyU6R9nO... (flutter/flutter#167213)
2025-04-15 [email protected] Change saturation calculation for HSLColor.fromColor (flutter/flutter#166639)
2025-04-15 [email protected] fix: Update time picker dialog input size (flutter/flutter#163184)
2025-04-15 [email protected] Clarify how/when `FLUTTER_PREBUILT_ENGINE_VERSION` is passed in Flutter's CI (flutter/flutter#167204)
2025-04-15 [email protected] [ Widget Preview ] Add support for `theme` and `brightness` properties on `Preview` (flutter/flutter#167001)
2025-04-15 [email protected] Update `tests.version` to fix `customer_testing`. (flutter/flutter#167206)
2025-04-15 [email protected] Persistent CupertinoListTile leading and trailing (flutter/flutter#166799)
2025-04-15 [email protected] Add buildroot compatibility for HWASAN. (flutter/flutter#167133)
2025-04-15 [email protected] Correct max height calculation to fade and animate insets on scroll in CupertinoSearchTextField (flutter/flutter#166569)
2025-04-15 [email protected] Clip bottom widgets in nav bar transition (flutter/flutter#166705)
2025-04-14 [email protected] Roll Skia from e7aa93f33a20 to 76cb5d4fba27 (13 revisions) (flutter/flutter#167132)
2025-04-14 [email protected] [fuchsia] Uprev test-scripts with FUCHSIA_READELF env (flutter/flutter#166929)
2025-04-14 [email protected] Cleanup links to flutter/engine in ci/builders docs (flutter/flutter#166916)
2025-04-14 [email protected] Roll Packages from 465bcff to f26b681 (1 revision) (flutter/flutter#167122)
2025-04-14 [email protected] [skwasm] Use `queueMicrotask` instead of `postMessage` when single-threaded (flutter/flutter#166997)
2025-04-14 [email protected] Remove some unused third party library build scripts (flutter/flutter#166960)
2025-04-14 [email protected] [reland] Fix regression in NDK version checking (flutter/flutter#167011)
2025-04-14 [email protected] Add network permissions information to the dart doc of network image.  (flutter/flutter#167110)
2025-04-14 [email protected] Include 3.29.3 and 3.29.2 changelog entries to master (flutter/flutter#166994)
2025-04-12 [email protected] [Impeller] various iOS cleanups. (flutter/flutter#166859)
2025-04-11 [email protected] [Impeller] reland: defer vulkan context initialization as long as possible. (flutter/flutter#167000)
2025-04-11 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Fix regression in NDK version checking (#166998)" (flutter/flutter#167007)
2025-04-11 [email protected] Fix regression in NDK version checking (flutter/flutter#166998)
2025-04-11 [email protected] [iOS] Infer autocorrect value from autofillHints (flutter/flutter#165637)
2025-04-11 [email protected] [Impeller] fix vulkan/gl color space decode. (flutter/flutter#166957)
2025-04-11 [email protected] modify toggle mode style with DatePickerTheme (flutter/flutter#164102)
2025-04-11 [email protected] [iOS/macOS] Add Xcode error if dev dependencies are incorrect (flutter/flutter#165916)
2025-04-11 98614782+auto-submit[bot]@users.noreply.github.com Reverts "[Impeller] defer vulkan context initialization as long as possible. (#166941)" (flutter/flutter#166990)
2025-04-11 [email protected] Roll Packages from 431dc61 to 465bcff (2 revisions) (flutter/flutter#166982)
2025-04-11 [email protected] [Impeller] defer vulkan context initialization as long as possible. (flutter/flutter#166941)
2025-04-11 [email protected] Reland "[ Widget Preview ] Add initial support for communications over the Dart Tooling Daemon (DTD) (#166698)" (flutter/flutter#166877)
2025-04-11 [email protected] [native assets] Use workspace pubspec for user-defines (flutter/flutter#166977)
2025-04-11 [email protected] [native assets] Roll dependencies (flutter/flutter#166969)
2025-04-11 [email protected] Roll Skia from 98deb838d3b8 to e7aa93f33a20 (1 revision) (flutter/flutter#166966)
2025-04-11 [email protected] Roll Fuchsia Linux SDK from vYisSsIgqw0mqFRVJ... to 91RIHvX0YC3wzD7qj... (flutter/flutter#166963)
2025-04-11 [email protected] [native assets] Support user-defines in pubspec (flutter/flutter#166940)
2025-04-11 [email protected] [Impeller] correct render pass bariers when resolve has mips. (flutter/flutter#166892)
2025-04-11 [email protected] [Impeller] re-make AHB swapchain lazy and allow usage on < 34 (flutter/flutter#166943)
2025-04-11 [email protected] Reland "SliverEnsureSemantics (#165589)" (flutter/flutter#166889)
2025-04-11 [email protected] Roll Skia from 171b2bf1e496 to 98deb838d3b8 (2 revisions) (flutter/flutter#166955)
...
CodixNinja pushed a commit to CodixNinja/packages that referenced this pull request May 15, 2025
@engine-flutter-autoroll
Manual roll Flutter from 30e53b0d9caa to db68c950c599 (98 revisions) …
fc4e794 
…(#9092)

Manual roll Flutter from 30e53b0d9caa to db68c950c599 (98 revisions)

Manual roll requested by [email protected]

flutter/flutter@30e53b0...db68c95

2025-04-15 [email protected] [customer_testing] Pick up the fix for issue found by flutter/dart hh. (flutter/flutter#167212)
2025-04-15 [email protected] Roll Packages from 853e96a to a5ed6cb (4 revisions) (flutter/flutter#167218)
2025-04-15 [email protected] Fix: Update sheet route bottom padding with top padding (flutter/flutter#164473)
2025-04-15 [email protected] Add Irish(ga) to Flutter (flutter/flutter#167129)
2025-04-15 [email protected] Roll Fuchsia Linux SDK from 91RIHvX0YC3wzD7qj... to 7bWzHwIPBTyU6R9nO... (flutter/flutter#167213)
2025-04-15 [email protected] Change saturation calculation for HSLColor.fromColor (flutter/flutter#166639)
2025-04-15 [email protected] fix: Update time picker dialog input size (flutter/flutter#163184)
2025-04-15 [email protected] Clarify how/when `FLUTTER_PREBUILT_ENGINE_VERSION` is passed in Flutter's CI (flutter/flutter#167204)
2025-04-15 [email protected] [ Widget Preview ] Add support for `theme` and `brightness` properties on `Preview` (flutter/flutter#167001)
2025-04-15 [email protected] Update `tests.version` to fix `customer_testing`. (flutter/flutter#167206)
2025-04-15 [email protected] Persistent CupertinoListTile leading and trailing (flutter/flutter#166799)
2025-04-15 [email protected] Add buildroot compatibility for HWASAN. (flutter/flutter#167133)
2025-04-15 [email protected] Correct max height calculation to fade and animate insets on scroll in CupertinoSearchTextField (flutter/flutter#166569)
2025-04-15 [email protected] Clip bottom widgets in nav bar transition (flutter/flutter#166705)
2025-04-14 [email protected] Roll Skia from e7aa93f33a20 to 76cb5d4fba27 (13 revisions) (flutter/flutter#167132)
2025-04-14 [email protected] [fuchsia] Uprev test-scripts with FUCHSIA_READELF env (flutter/flutter#166929)
2025-04-14 [email protected] Cleanup links to flutter/engine in ci/builders docs (flutter/flutter#166916)
2025-04-14 [email protected] Roll Packages from 4808eff to 853e96a (1 revision) (flutter/flutter#167122)
2025-04-14 [email protected] [skwasm] Use `queueMicrotask` instead of `postMessage` when single-threaded (flutter/flutter#166997)
2025-04-14 [email protected] Remove some unused third party library build scripts (flutter/flutter#166960)
2025-04-14 [email protected] [reland] Fix regression in NDK version checking (flutter/flutter#167011)
2025-04-14 [email protected] Add network permissions information to the dart doc of network image.  (flutter/flutter#167110)
2025-04-14 [email protected] Include 3.29.3 and 3.29.2 changelog entries to master (flutter/flutter#166994)
2025-04-12 [email protected] [Impeller] various iOS cleanups. (flutter/flutter#166859)
2025-04-11 [email protected] [Impeller] reland: defer vulkan context initialization as long as possible. (flutter/flutter#167000)
2025-04-11 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Fix regression in NDK version checking (#166998)" (flutter/flutter#167007)
2025-04-11 [email protected] Fix regression in NDK version checking (flutter/flutter#166998)
2025-04-11 [email protected] [iOS] Infer autocorrect value from autofillHints (flutter/flutter#165637)
2025-04-11 [email protected] [Impeller] fix vulkan/gl color space decode. (flutter/flutter#166957)
2025-04-11 [email protected] modify toggle mode style with DatePickerTheme (flutter/flutter#164102)
2025-04-11 [email protected] [iOS/macOS] Add Xcode error if dev dependencies are incorrect (flutter/flutter#165916)
2025-04-11 98614782+auto-submit[bot]@users.noreply.github.com Reverts "[Impeller] defer vulkan context initialization as long as possible. (#166941)" (flutter/flutter#166990)
2025-04-11 [email protected] Roll Packages from b2c45f9 to 4808eff (2 revisions) (flutter/flutter#166982)
2025-04-11 [email protected] [Impeller] defer vulkan context initialization as long as possible. (flutter/flutter#166941)
2025-04-11 [email protected] Reland "[ Widget Preview ] Add initial support for communications over the Dart Tooling Daemon (DTD) (#166698)" (flutter/flutter#166877)
2025-04-11 [email protected] [native assets] Use workspace pubspec for user-defines (flutter/flutter#166977)
2025-04-11 [email protected] [native assets] Roll dependencies (flutter/flutter#166969)
2025-04-11 [email protected] Roll Skia from 98deb838d3b8 to e7aa93f33a20 (1 revision) (flutter/flutter#166966)
2025-04-11 [email protected] Roll Fuchsia Linux SDK from vYisSsIgqw0mqFRVJ... to 91RIHvX0YC3wzD7qj... (flutter/flutter#166963)
2025-04-11 [email protected] [native assets] Support user-defines in pubspec (flutter/flutter#166940)
2025-04-11 [email protected] [Impeller] correct render pass bariers when resolve has mips. (flutter/flutter#166892)
2025-04-11 [email protected] [Impeller] re-make AHB swapchain lazy and allow usage on < 34 (flutter/flutter#166943)
2025-04-11 [email protected] Reland "SliverEnsureSemantics (#165589)" (flutter/flutter#166889)
2025-04-11 [email protected] Roll Skia from 171b2bf1e496 to 98deb838d3b8 (2 revisions) (flutter/flutter#166955)
...
@gmackall gmackall added the cp: stable cherry pick this pull request to stable release candidate branch label May 22, 2025
@flutteractionsbot
Copy link

flutteractionsbot commented May 22, 2025

Failed to create CP due to merge conflicts.
You will need to create the PR manually. See the cherrypick wiki for more info.

@gmackall gmackall removed the cp: stable cherry pick this pull request to stable release candidate branch label May 22, 2025
@gmackall
Copy link
Member

gmackall commented May 22, 2025

Failed to create CP due to merge conflicts.You will need to create the PR manually. See the cherrypick wiki for more info.

I meant to add this to #167011, though I expect that will fail for the same reason

androidseb pushed a commit to androidseb/packages that referenced this pull request Jun 8, 2025
@engine-flutter-autoroll @androidseb
Manual roll Flutter from 30e53b0 to db68c950c599 (98 revisions) (flut…
b21d593 
…ter#9092)

Manual roll Flutter from 30e53b0 to db68c950c599 (98 revisions)

Manual roll requested by [email protected]

flutter/flutter@30e53b0...db68c95

2025-04-15 [email protected] [customer_testing] Pick up the fix for issue found by flutter/dart hh. (flutter/flutter#167212)
2025-04-15 [email protected] Roll Packages from f26b681 to 2fcc403 (4 revisions) (flutter/flutter#167218)
2025-04-15 [email protected] Fix: Update sheet route bottom padding with top padding (flutter/flutter#164473)
2025-04-15 [email protected] Add Irish(ga) to Flutter (flutter/flutter#167129)
2025-04-15 [email protected] Roll Fuchsia Linux SDK from 91RIHvX0YC3wzD7qj... to 7bWzHwIPBTyU6R9nO... (flutter/flutter#167213)
2025-04-15 [email protected] Change saturation calculation for HSLColor.fromColor (flutter/flutter#166639)
2025-04-15 [email protected] fix: Update time picker dialog input size (flutter/flutter#163184)
2025-04-15 [email protected] Clarify how/when `FLUTTER_PREBUILT_ENGINE_VERSION` is passed in Flutter's CI (flutter/flutter#167204)
2025-04-15 [email protected] [ Widget Preview ] Add support for `theme` and `brightness` properties on `Preview` (flutter/flutter#167001)
2025-04-15 [email protected] Update `tests.version` to fix `customer_testing`. (flutter/flutter#167206)
2025-04-15 [email protected] Persistent CupertinoListTile leading and trailing (flutter/flutter#166799)
2025-04-15 [email protected] Add buildroot compatibility for HWASAN. (flutter/flutter#167133)
2025-04-15 [email protected] Correct max height calculation to fade and animate insets on scroll in CupertinoSearchTextField (flutter/flutter#166569)
2025-04-15 [email protected] Clip bottom widgets in nav bar transition (flutter/flutter#166705)
2025-04-14 [email protected] Roll Skia from e7aa93f33a20 to 76cb5d4fba27 (13 revisions) (flutter/flutter#167132)
2025-04-14 [email protected] [fuchsia] Uprev test-scripts with FUCHSIA_READELF env (flutter/flutter#166929)
2025-04-14 [email protected] Cleanup links to flutter/engine in ci/builders docs (flutter/flutter#166916)
2025-04-14 [email protected] Roll Packages from 465bcff to f26b681 (1 revision) (flutter/flutter#167122)
2025-04-14 [email protected] [skwasm] Use `queueMicrotask` instead of `postMessage` when single-threaded (flutter/flutter#166997)
2025-04-14 [email protected] Remove some unused third party library build scripts (flutter/flutter#166960)
2025-04-14 [email protected] [reland] Fix regression in NDK version checking (flutter/flutter#167011)
2025-04-14 [email protected] Add network permissions information to the dart doc of network image.  (flutter/flutter#167110)
2025-04-14 [email protected] Include 3.29.3 and 3.29.2 changelog entries to master (flutter/flutter#166994)
2025-04-12 [email protected] [Impeller] various iOS cleanups. (flutter/flutter#166859)
2025-04-11 [email protected] [Impeller] reland: defer vulkan context initialization as long as possible. (flutter/flutter#167000)
2025-04-11 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Fix regression in NDK version checking (#166998)" (flutter/flutter#167007)
2025-04-11 [email protected] Fix regression in NDK version checking (flutter/flutter#166998)
2025-04-11 [email protected] [iOS] Infer autocorrect value from autofillHints (flutter/flutter#165637)
2025-04-11 [email protected] [Impeller] fix vulkan/gl color space decode. (flutter/flutter#166957)
2025-04-11 [email protected] modify toggle mode style with DatePickerTheme (flutter/flutter#164102)
2025-04-11 [email protected] [iOS/macOS] Add Xcode error if dev dependencies are incorrect (flutter/flutter#165916)
2025-04-11 98614782+auto-submit[bot]@users.noreply.github.com Reverts "[Impeller] defer vulkan context initialization as long as possible. (#166941)" (flutter/flutter#166990)
2025-04-11 [email protected] Roll Packages from 431dc61 to 465bcff (2 revisions) (flutter/flutter#166982)
2025-04-11 [email protected] [Impeller] defer vulkan context initialization as long as possible. (flutter/flutter#166941)
2025-04-11 [email protected] Reland "[ Widget Preview ] Add initial support for communications over the Dart Tooling Daemon (DTD) (#166698)" (flutter/flutter#166877)
2025-04-11 [email protected] [native assets] Use workspace pubspec for user-defines (flutter/flutter#166977)
2025-04-11 [email protected] [native assets] Roll dependencies (flutter/flutter#166969)
2025-04-11 [email protected] Roll Skia from 98deb838d3b8 to e7aa93f33a20 (1 revision) (flutter/flutter#166966)
2025-04-11 [email protected] Roll Fuchsia Linux SDK from vYisSsIgqw0mqFRVJ... to 91RIHvX0YC3wzD7qj... (flutter/flutter#166963)
2025-04-11 [email protected] [native assets] Support user-defines in pubspec (flutter/flutter#166940)
2025-04-11 [email protected] [Impeller] correct render pass bariers when resolve has mips. (flutter/flutter#166892)
2025-04-11 [email protected] [Impeller] re-make AHB swapchain lazy and allow usage on < 34 (flutter/flutter#166943)
2025-04-11 [email protected] Reland "SliverEnsureSemantics (#165589)" (flutter/flutter#166889)
2025-04-11 [email protected] Roll Skia from 171b2bf1e496 to 98deb838d3b8 (2 revisions) (flutter/flutter#166955)
...
FMorschel pushed a commit to FMorschel/packages that referenced this pull request Jun 9, 2025
@engine-flutter-autoroll @FMorschel
Manual roll Flutter from 30e53b0 to db68c950c599 (98 revisions) (flut…
9ee6018 
…ter#9092)

Manual roll Flutter from 30e53b0 to db68c950c599 (98 revisions)

Manual roll requested by [email protected]

flutter/flutter@30e53b0...db68c95

2025-04-15 [email protected] [customer_testing] Pick up the fix for issue found by flutter/dart hh. (flutter/flutter#167212)
2025-04-15 [email protected] Roll Packages from f26b681 to 2fcc403 (4 revisions) (flutter/flutter#167218)
2025-04-15 [email protected] Fix: Update sheet route bottom padding with top padding (flutter/flutter#164473)
2025-04-15 [email protected] Add Irish(ga) to Flutter (flutter/flutter#167129)
2025-04-15 [email protected] Roll Fuchsia Linux SDK from 91RIHvX0YC3wzD7qj... to 7bWzHwIPBTyU6R9nO... (flutter/flutter#167213)
2025-04-15 [email protected] Change saturation calculation for HSLColor.fromColor (flutter/flutter#166639)
2025-04-15 [email protected] fix: Update time picker dialog input size (flutter/flutter#163184)
2025-04-15 [email protected] Clarify how/when `FLUTTER_PREBUILT_ENGINE_VERSION` is passed in Flutter's CI (flutter/flutter#167204)
2025-04-15 [email protected] [ Widget Preview ] Add support for `theme` and `brightness` properties on `Preview` (flutter/flutter#167001)
2025-04-15 [email protected] Update `tests.version` to fix `customer_testing`. (flutter/flutter#167206)
2025-04-15 [email protected] Persistent CupertinoListTile leading and trailing (flutter/flutter#166799)
2025-04-15 [email protected] Add buildroot compatibility for HWASAN. (flutter/flutter#167133)
2025-04-15 [email protected] Correct max height calculation to fade and animate insets on scroll in CupertinoSearchTextField (flutter/flutter#166569)
2025-04-15 [email protected] Clip bottom widgets in nav bar transition (flutter/flutter#166705)
2025-04-14 [email protected] Roll Skia from e7aa93f33a20 to 76cb5d4fba27 (13 revisions) (flutter/flutter#167132)
2025-04-14 [email protected] [fuchsia] Uprev test-scripts with FUCHSIA_READELF env (flutter/flutter#166929)
2025-04-14 [email protected] Cleanup links to flutter/engine in ci/builders docs (flutter/flutter#166916)
2025-04-14 [email protected] Roll Packages from 465bcff to f26b681 (1 revision) (flutter/flutter#167122)
2025-04-14 [email protected] [skwasm] Use `queueMicrotask` instead of `postMessage` when single-threaded (flutter/flutter#166997)
2025-04-14 [email protected] Remove some unused third party library build scripts (flutter/flutter#166960)
2025-04-14 [email protected] [reland] Fix regression in NDK version checking (flutter/flutter#167011)
2025-04-14 [email protected] Add network permissions information to the dart doc of network image.  (flutter/flutter#167110)
2025-04-14 [email protected] Include 3.29.3 and 3.29.2 changelog entries to master (flutter/flutter#166994)
2025-04-12 [email protected] [Impeller] various iOS cleanups. (flutter/flutter#166859)
2025-04-11 [email protected] [Impeller] reland: defer vulkan context initialization as long as possible. (flutter/flutter#167000)
2025-04-11 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Fix regression in NDK version checking (#166998)" (flutter/flutter#167007)
2025-04-11 [email protected] Fix regression in NDK version checking (flutter/flutter#166998)
2025-04-11 [email protected] [iOS] Infer autocorrect value from autofillHints (flutter/flutter#165637)
2025-04-11 [email protected] [Impeller] fix vulkan/gl color space decode. (flutter/flutter#166957)
2025-04-11 [email protected] modify toggle mode style with DatePickerTheme (flutter/flutter#164102)
2025-04-11 [email protected] [iOS/macOS] Add Xcode error if dev dependencies are incorrect (flutter/flutter#165916)
2025-04-11 98614782+auto-submit[bot]@users.noreply.github.com Reverts "[Impeller] defer vulkan context initialization as long as possible. (#166941)" (flutter/flutter#166990)
2025-04-11 [email protected] Roll Packages from 431dc61 to 465bcff (2 revisions) (flutter/flutter#166982)
2025-04-11 [email protected] [Impeller] defer vulkan context initialization as long as possible. (flutter/flutter#166941)
2025-04-11 [email protected] Reland "[ Widget Preview ] Add initial support for communications over the Dart Tooling Daemon (DTD) (#166698)" (flutter/flutter#166877)
2025-04-11 [email protected] [native assets] Use workspace pubspec for user-defines (flutter/flutter#166977)
2025-04-11 [email protected] [native assets] Roll dependencies (flutter/flutter#166969)
2025-04-11 [email protected] Roll Skia from 98deb838d3b8 to e7aa93f33a20 (1 revision) (flutter/flutter#166966)
2025-04-11 [email protected] Roll Fuchsia Linux SDK from vYisSsIgqw0mqFRVJ... to 91RIHvX0YC3wzD7qj... (flutter/flutter#166963)
2025-04-11 [email protected] [native assets] Support user-defines in pubspec (flutter/flutter#166940)
2025-04-11 [email protected] [Impeller] correct render pass bariers when resolve has mips. (flutter/flutter#166892)
2025-04-11 [email protected] [Impeller] re-make AHB swapchain lazy and allow usage on < 34 (flutter/flutter#166943)
2025-04-11 [email protected] Reland "SliverEnsureSemantics (#165589)" (flutter/flutter#166889)
2025-04-11 [email protected] Roll Skia from 171b2bf1e496 to 98deb838d3b8 (2 revisions) (flutter/flutter#166955)
...
Ortes pushed a commit to Ortes/packages that referenced this pull request Jun 25, 2025
@engine-flutter-autoroll @Ortes
Manual roll Flutter from 30e53b0 to db68c950c599 (98 revisions) (flut…
35ba046 
…ter#9092)

Manual roll Flutter from 30e53b0 to db68c950c599 (98 revisions)

Manual roll requested by [email protected]

flutter/flutter@30e53b0...db68c95

2025-04-15 [email protected] [customer_testing] Pick up the fix for issue found by flutter/dart hh. (flutter/flutter#167212)
2025-04-15 [email protected] Roll Packages from f26b681 to 2fcc403 (4 revisions) (flutter/flutter#167218)
2025-04-15 [email protected] Fix: Update sheet route bottom padding with top padding (flutter/flutter#164473)
2025-04-15 [email protected] Add Irish(ga) to Flutter (flutter/flutter#167129)
2025-04-15 [email protected] Roll Fuchsia Linux SDK from 91RIHvX0YC3wzD7qj... to 7bWzHwIPBTyU6R9nO... (flutter/flutter#167213)
2025-04-15 [email protected] Change saturation calculation for HSLColor.fromColor (flutter/flutter#166639)
2025-04-15 [email protected] fix: Update time picker dialog input size (flutter/flutter#163184)
2025-04-15 [email protected] Clarify how/when `FLUTTER_PREBUILT_ENGINE_VERSION` is passed in Flutter's CI (flutter/flutter#167204)
2025-04-15 [email protected] [ Widget Preview ] Add support for `theme` and `brightness` properties on `Preview` (flutter/flutter#167001)
2025-04-15 [email protected] Update `tests.version` to fix `customer_testing`. (flutter/flutter#167206)
2025-04-15 [email protected] Persistent CupertinoListTile leading and trailing (flutter/flutter#166799)
2025-04-15 [email protected] Add buildroot compatibility for HWASAN. (flutter/flutter#167133)
2025-04-15 [email protected] Correct max height calculation to fade and animate insets on scroll in CupertinoSearchTextField (flutter/flutter#166569)
2025-04-15 [email protected] Clip bottom widgets in nav bar transition (flutter/flutter#166705)
2025-04-14 [email protected] Roll Skia from e7aa93f33a20 to 76cb5d4fba27 (13 revisions) (flutter/flutter#167132)
2025-04-14 [email protected] [fuchsia] Uprev test-scripts with FUCHSIA_READELF env (flutter/flutter#166929)
2025-04-14 [email protected] Cleanup links to flutter/engine in ci/builders docs (flutter/flutter#166916)
2025-04-14 [email protected] Roll Packages from 465bcff to f26b681 (1 revision) (flutter/flutter#167122)
2025-04-14 [email protected] [skwasm] Use `queueMicrotask` instead of `postMessage` when single-threaded (flutter/flutter#166997)
2025-04-14 [email protected] Remove some unused third party library build scripts (flutter/flutter#166960)
2025-04-14 [email protected] [reland] Fix regression in NDK version checking (flutter/flutter#167011)
2025-04-14 [email protected] Add network permissions information to the dart doc of network image.  (flutter/flutter#167110)
2025-04-14 [email protected] Include 3.29.3 and 3.29.2 changelog entries to master (flutter/flutter#166994)
2025-04-12 [email protected] [Impeller] various iOS cleanups. (flutter/flutter#166859)
2025-04-11 [email protected] [Impeller] reland: defer vulkan context initialization as long as possible. (flutter/flutter#167000)
2025-04-11 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Fix regression in NDK version checking (#166998)" (flutter/flutter#167007)
2025-04-11 [email protected] Fix regression in NDK version checking (flutter/flutter#166998)
2025-04-11 [email protected] [iOS] Infer autocorrect value from autofillHints (flutter/flutter#165637)
2025-04-11 [email protected] [Impeller] fix vulkan/gl color space decode. (flutter/flutter#166957)
2025-04-11 [email protected] modify toggle mode style with DatePickerTheme (flutter/flutter#164102)
2025-04-11 [email protected] [iOS/macOS] Add Xcode error if dev dependencies are incorrect (flutter/flutter#165916)
2025-04-11 98614782+auto-submit[bot]@users.noreply.github.com Reverts "[Impeller] defer vulkan context initialization as long as possible. (#166941)" (flutter/flutter#166990)
2025-04-11 [email protected] Roll Packages from 431dc61 to 465bcff (2 revisions) (flutter/flutter#166982)
2025-04-11 [email protected] [Impeller] defer vulkan context initialization as long as possible. (flutter/flutter#166941)
2025-04-11 [email protected] Reland "[ Widget Preview ] Add initial support for communications over the Dart Tooling Daemon (DTD) (#166698)" (flutter/flutter#166877)
2025-04-11 [email protected] [native assets] Use workspace pubspec for user-defines (flutter/flutter#166977)
2025-04-11 [email protected] [native assets] Roll dependencies (flutter/flutter#166969)
2025-04-11 [email protected] Roll Skia from 98deb838d3b8 to e7aa93f33a20 (1 revision) (flutter/flutter#166966)
2025-04-11 [email protected] Roll Fuchsia Linux SDK from vYisSsIgqw0mqFRVJ... to 91RIHvX0YC3wzD7qj... (flutter/flutter#166963)
2025-04-11 [email protected] [native assets] Support user-defines in pubspec (flutter/flutter#166940)
2025-04-11 [email protected] [Impeller] correct render pass bariers when resolve has mips. (flutter/flutter#166892)
2025-04-11 [email protected] [Impeller] re-make AHB swapchain lazy and allow usage on < 34 (flutter/flutter#166943)
2025-04-11 [email protected] Reland "SliverEnsureSemantics (#165589)" (flutter/flutter#166889)
2025-04-11 [email protected] Roll Skia from 171b2bf1e496 to 98deb838d3b8 (2 revisions) (flutter/flutter#166955)
...
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 14, 2025
@engine-flutter-autoroll
28cc211fc Reverts "Fix regression in NDK version checking (#166998)" (f…
56b0e66 
…lutter/flutter#167007)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 14, 2025
@engine-flutter-autoroll
28cc211fc Reverts "Fix regression in NDK version checking (#166998)" (f…
b35469b 
…lutter/flutter#167007)
romanejaquez pushed a commit to romanejaquez/flutter that referenced this pull request Aug 14, 2025
@auto-submit @romanejaquez
Reverts "Fix regression in NDK version checking (flutter#166998)" (fl…
3d4e9b8 
…utter#167007)

<!-- start_original_pr_link -->
Reverts: flutter#166998
<!-- end_original_pr_link -->
<!-- start_initiating_author -->
Initiated by: gmackall
<!-- end_initiating_author -->
<!-- start_revert_reason -->
Reason for reverting:
flutter#166998 (comment)
<!-- end_revert_reason -->
<!-- start_original_pr_author -->
Original PR Author: gmackall
<!-- end_original_pr_author -->

<!-- start_reviewers -->
Reviewed By: {stuartmorgan-g}
<!-- end_reviewers -->

<!-- start_revert_body -->
This change reverts the following previous change:
Fixes a regression from flutter#166727,
see
https://discord.com/channels/608014603317936148/846507907876257822/1360306682999210204

Adds a dependency on `shared_preferences_android` to the smoke tests we
have that run across the range of AGP/Gradle versions we support. Chosen
randomly, just to recreate the error. Hopefully this doesn't push the
test target into timeout range, it was already a kind of long running
one.

The IDE suggestion here was misleading, as this value switched from
nullable to non nullable in AGP 8.1/8.2. Unfortunately the IDE makes
these suggestions based on one AGP version, specified in the project
level `build.gradle.kts`. I checked all other files with our minimum
supported AGP version, and this was the only error.

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [ ] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md

<!-- end_revert_body -->

Co-authored-by: auto-submit[bot] <[email protected]>
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 15, 2025
@engine-flutter-autoroll
28cc211fc Reverts "Fix regression in NDK version checking (#166998)" (f…
1d96367 
…lutter/flutter#167007)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 15, 2025
@engine-flutter-autoroll
28cc211fc Reverts "Fix regression in NDK version checking (#166998)" (f…
520189c 
…lutter/flutter#167007)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 16, 2025
@engine-flutter-autoroll
28cc211fc Reverts "Fix regression in NDK version checking (#166998)" (f…
aae7c86 
…lutter/flutter#167007)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fluttergithubbot fluttergithubbot fluttergithubbot approved these changes

@matanlurey matanlurey Awaiting requested review from matanlurey

Assignees

@gmackall gmackall

Labels

platform-android Android applications specifically revert of Bot Only: Tracking label for bot. Tracks new revert of pull requests. tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@flutteractionsbot @gmackall @fluttergithubbot