Skip to content

[skwasm] Use queueMicrotask instead of postMessage when single-threaded #166997

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
auto-submit merged 5 commits into from
Apr 14, 2025
Merged

[skwasm] Use queueMicrotask instead of postMessage when single-threaded #166997

auto-submit merged 5 commits into from
Apr 14, 2025

Conversation

@eyebrowsoffire
Copy link
Contributor

@eyebrowsoffire eyebrowsoffire commented Apr 11, 2025

It turns out postMessage is quite a bit more expensive than queueMicrotask. Before dynamic threading, this is what we actually did, and perf regressed when we started using postMessage instead.

This fixes #166905

@eyebrowsoffire
[skwasm] Use queueMicrotask instead of postMessage when single-th…
cee3d15 
…readed.

It turns out `postMessage` is quite a bit more expensive than `queueMicrotask`.
Before dynamic threading, this is what we actually did, and perf regressed
when we started using `postMessage` instead.
@flutter-dashboard
Copy link

flutter-dashboard bot commented Apr 11, 2025

It looks like this pull request may not have tests. Please make sure to add tests or get an explicit test exemption before merging.

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.If you believe this PR qualifies for a test exemption, contact "@test-exemption-reviewer" in the #hackers channel in Discord (don't just cc them here, they won't see it!). The test exemption team is a small volunteer group, so all reviewers should feel empowered to ask for tests, without delegating that responsibility entirely to the test exemption group.

@github-actions github-actions bot added engine flutter/engine related. See also e: labels. platform-web Web applications specifically labels Apr 11, 2025
@eyebrowsoffire eyebrowsoffire mentioned this pull request Apr 11, 2025
Closed
@eyebrowsoffire
Copy link
Contributor Author

eyebrowsoffire commented Apr 11, 2025

This doesn't actually change any functionality, and the differences should be picked up in the benchmarks, so we don't need unit tests here.

yjbanov
yjbanov approved these changes Apr 11, 2025
View reviewed changes
Copy link
Contributor

@yjbanov yjbanov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@eyebrowsoffire eyebrowsoffire added the autosubmit Merge PR when tree becomes green via auto submit App label Apr 14, 2025
@auto-submit auto-submit bot added this pull request to the merge queue Apr 14, 2025
Merged via the queue into flutter:master with commit 2f6cdc3 Apr 14, 2025
177 checks passed
@flutter-dashboard flutter-dashboard bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Apr 14, 2025
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 14, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 14, 2025
@engine-flutter-autoroll
2f6cdc3fe [skwasm] Use queueMicrotask instead of postMessage when…
5222d8f 
… single-threaded (flutter/flutter#166997)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 14, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 14, 2025
@engine-flutter-autoroll
2f6cdc3fe [skwasm] Use queueMicrotask instead of postMessage when…
d149cf6 
… single-threaded (flutter/flutter#166997)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 14, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 14, 2025
@engine-flutter-autoroll
2f6cdc3fe [skwasm] Use queueMicrotask instead of postMessage when…
3eb6184 
… single-threaded (flutter/flutter#166997)
@eyebrowsoffire eyebrowsoffire added the cp: beta cherry pick this pull request to beta release candidate branch label Apr 15, 2025
flutteractionsbot pushed a commit to flutteractionsbot/flutter that referenced this pull request Apr 15, 2025
@eyebrowsoffire
[skwasm] Use queueMicrotask instead of postMessage when single-th…
4338ec7 
…readed (flutter#166997)

It turns out `postMessage` is quite a bit more expensive than
`queueMicrotask`. Before dynamic threading, this is what we actually
did, and perf regressed when we started using `postMessage` instead.

This fixes flutter#166905
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 15, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 15, 2025
@engine-flutter-autoroll
2f6cdc3fe [skwasm] Use queueMicrotask instead of postMessage when…
a2e5f0f 
… single-threaded (flutter/flutter#166997)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 15, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 15, 2025
@engine-flutter-autoroll
2f6cdc3fe [skwasm] Use queueMicrotask instead of postMessage when…
7be5155 
… single-threaded (flutter/flutter#166997)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 15, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 15, 2025
@engine-flutter-autoroll
2f6cdc3fe [skwasm] Use queueMicrotask instead of postMessage when…
eb7dbe1 
… single-threaded (flutter/flutter#166997)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 15, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 15, 2025
@engine-flutter-autoroll
2f6cdc3fe [skwasm] Use queueMicrotask instead of postMessage when…
16ed992 
… single-threaded (flutter/flutter#166997)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 15, 2025
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 15, 2025
@engine-flutter-autoroll
2f6cdc3fe [skwasm] Use queueMicrotask instead of postMessage when…
bdd9f56 
… single-threaded (flutter/flutter#166997)
auto-submit bot pushed a commit to flutter/packages that referenced this pull request Apr 16, 2025
@engine-flutter-autoroll
Manual roll Flutter from 30e53b0 to db68c950c599 (98 revisions) (#9092)
1f0a894 
Manual roll Flutter from 30e53b0 to db68c950c599 (98 revisions)

Manual roll requested by [email protected]

flutter/flutter@30e53b0...db68c95

2025-04-15 [email protected] [customer_testing] Pick up the fix for issue found by flutter/dart hh. (flutter/flutter#167212)
2025-04-15 [email protected] Roll Packages from f26b681 to 2fcc403 (4 revisions) (flutter/flutter#167218)
2025-04-15 [email protected] Fix: Update sheet route bottom padding with top padding (flutter/flutter#164473)
2025-04-15 [email protected] Add Irish(ga) to Flutter (flutter/flutter#167129)
2025-04-15 [email protected] Roll Fuchsia Linux SDK from 91RIHvX0YC3wzD7qj... to 7bWzHwIPBTyU6R9nO... (flutter/flutter#167213)
2025-04-15 [email protected] Change saturation calculation for HSLColor.fromColor (flutter/flutter#166639)
2025-04-15 [email protected] fix: Update time picker dialog input size (flutter/flutter#163184)
2025-04-15 [email protected] Clarify how/when `FLUTTER_PREBUILT_ENGINE_VERSION` is passed in Flutter's CI (flutter/flutter#167204)
2025-04-15 [email protected] [ Widget Preview ] Add support for `theme` and `brightness` properties on `Preview` (flutter/flutter#167001)
2025-04-15 [email protected] Update `tests.version` to fix `customer_testing`. (flutter/flutter#167206)
2025-04-15 [email protected] Persistent CupertinoListTile leading and trailing (flutter/flutter#166799)
2025-04-15 [email protected] Add buildroot compatibility for HWASAN. (flutter/flutter#167133)
2025-04-15 [email protected] Correct max height calculation to fade and animate insets on scroll in CupertinoSearchTextField (flutter/flutter#166569)
2025-04-15 [email protected] Clip bottom widgets in nav bar transition (flutter/flutter#166705)
2025-04-14 [email protected] Roll Skia from e7aa93f33a20 to 76cb5d4fba27 (13 revisions) (flutter/flutter#167132)
2025-04-14 [email protected] [fuchsia] Uprev test-scripts with FUCHSIA_READELF env (flutter/flutter#166929)
2025-04-14 [email protected] Cleanup links to flutter/engine in ci/builders docs (flutter/flutter#166916)
2025-04-14 [email protected] Roll Packages from 465bcff to f26b681 (1 revision) (flutter/flutter#167122)
2025-04-14 [email protected] [skwasm] Use `queueMicrotask` instead of `postMessage` when single-threaded (flutter/flutter#166997)
2025-04-14 [email protected] Remove some unused third party library build scripts (flutter/flutter#166960)
2025-04-14 [email protected] [reland] Fix regression in NDK version checking (flutter/flutter#167011)
2025-04-14 [email protected] Add network permissions information to the dart doc of network image.  (flutter/flutter#167110)
2025-04-14 [email protected] Include 3.29.3 and 3.29.2 changelog entries to master (flutter/flutter#166994)
2025-04-12 [email protected] [Impeller] various iOS cleanups. (flutter/flutter#166859)
2025-04-11 [email protected] [Impeller] reland: defer vulkan context initialization as long as possible. (flutter/flutter#167000)
2025-04-11 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Fix regression in NDK version checking (#166998)" (flutter/flutter#167007)
2025-04-11 [email protected] Fix regression in NDK version checking (flutter/flutter#166998)
2025-04-11 [email protected] [iOS] Infer autocorrect value from autofillHints (flutter/flutter#165637)
2025-04-11 [email protected] [Impeller] fix vulkan/gl color space decode. (flutter/flutter#166957)
2025-04-11 [email protected] modify toggle mode style with DatePickerTheme (flutter/flutter#164102)
2025-04-11 [email protected] [iOS/macOS] Add Xcode error if dev dependencies are incorrect (flutter/flutter#165916)
2025-04-11 98614782+auto-submit[bot]@users.noreply.github.com Reverts "[Impeller] defer vulkan context initialization as long as possible. (#166941)" (flutter/flutter#166990)
2025-04-11 [email protected] Roll Packages from 431dc61 to 465bcff (2 revisions) (flutter/flutter#166982)
2025-04-11 [email protected] [Impeller] defer vulkan context initialization as long as possible. (flutter/flutter#166941)
2025-04-11 [email protected] Reland "[ Widget Preview ] Add initial support for communications over the Dart Tooling Daemon (DTD) (#166698)" (flutter/flutter#166877)
2025-04-11 [email protected] [native assets] Use workspace pubspec for user-defines (flutter/flutter#166977)
2025-04-11 [email protected] [native assets] Roll dependencies (flutter/flutter#166969)
2025-04-11 [email protected] Roll Skia from 98deb838d3b8 to e7aa93f33a20 (1 revision) (flutter/flutter#166966)
2025-04-11 [email protected] Roll Fuchsia Linux SDK from vYisSsIgqw0mqFRVJ... to 91RIHvX0YC3wzD7qj... (flutter/flutter#166963)
2025-04-11 [email protected] [native assets] Support user-defines in pubspec (flutter/flutter#166940)
2025-04-11 [email protected] [Impeller] correct render pass bariers when resolve has mips. (flutter/flutter#166892)
2025-04-11 [email protected] [Impeller] re-make AHB swapchain lazy and allow usage on < 34 (flutter/flutter#166943)
2025-04-11 [email protected] Reland "SliverEnsureSemantics (#165589)" (flutter/flutter#166889)
2025-04-11 [email protected] Roll Skia from 171b2bf1e496 to 98deb838d3b8 (2 revisions) (flutter/flutter#166955)
...
CodixNinja pushed a commit to CodixNinja/packages that referenced this pull request May 15, 2025
@engine-flutter-autoroll
Manual roll Flutter from 30e53b0d9caa to db68c950c599 (98 revisions) …
fc4e794 
…(#9092)

Manual roll Flutter from 30e53b0d9caa to db68c950c599 (98 revisions)

Manual roll requested by [email protected]

flutter/flutter@30e53b0...db68c95

2025-04-15 [email protected] [customer_testing] Pick up the fix for issue found by flutter/dart hh. (flutter/flutter#167212)
2025-04-15 [email protected] Roll Packages from 853e96a to a5ed6cb (4 revisions) (flutter/flutter#167218)
2025-04-15 [email protected] Fix: Update sheet route bottom padding with top padding (flutter/flutter#164473)
2025-04-15 [email protected] Add Irish(ga) to Flutter (flutter/flutter#167129)
2025-04-15 [email protected] Roll Fuchsia Linux SDK from 91RIHvX0YC3wzD7qj... to 7bWzHwIPBTyU6R9nO... (flutter/flutter#167213)
2025-04-15 [email protected] Change saturation calculation for HSLColor.fromColor (flutter/flutter#166639)
2025-04-15 [email protected] fix: Update time picker dialog input size (flutter/flutter#163184)
2025-04-15 [email protected] Clarify how/when `FLUTTER_PREBUILT_ENGINE_VERSION` is passed in Flutter's CI (flutter/flutter#167204)
2025-04-15 [email protected] [ Widget Preview ] Add support for `theme` and `brightness` properties on `Preview` (flutter/flutter#167001)
2025-04-15 [email protected] Update `tests.version` to fix `customer_testing`. (flutter/flutter#167206)
2025-04-15 [email protected] Persistent CupertinoListTile leading and trailing (flutter/flutter#166799)
2025-04-15 [email protected] Add buildroot compatibility for HWASAN. (flutter/flutter#167133)
2025-04-15 [email protected] Correct max height calculation to fade and animate insets on scroll in CupertinoSearchTextField (flutter/flutter#166569)
2025-04-15 [email protected] Clip bottom widgets in nav bar transition (flutter/flutter#166705)
2025-04-14 [email protected] Roll Skia from e7aa93f33a20 to 76cb5d4fba27 (13 revisions) (flutter/flutter#167132)
2025-04-14 [email protected] [fuchsia] Uprev test-scripts with FUCHSIA_READELF env (flutter/flutter#166929)
2025-04-14 [email protected] Cleanup links to flutter/engine in ci/builders docs (flutter/flutter#166916)
2025-04-14 [email protected] Roll Packages from 4808eff to 853e96a (1 revision) (flutter/flutter#167122)
2025-04-14 [email protected] [skwasm] Use `queueMicrotask` instead of `postMessage` when single-threaded (flutter/flutter#166997)
2025-04-14 [email protected] Remove some unused third party library build scripts (flutter/flutter#166960)
2025-04-14 [email protected] [reland] Fix regression in NDK version checking (flutter/flutter#167011)
2025-04-14 [email protected] Add network permissions information to the dart doc of network image.  (flutter/flutter#167110)
2025-04-14 [email protected] Include 3.29.3 and 3.29.2 changelog entries to master (flutter/flutter#166994)
2025-04-12 [email protected] [Impeller] various iOS cleanups. (flutter/flutter#166859)
2025-04-11 [email protected] [Impeller] reland: defer vulkan context initialization as long as possible. (flutter/flutter#167000)
2025-04-11 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Fix regression in NDK version checking (#166998)" (flutter/flutter#167007)
2025-04-11 [email protected] Fix regression in NDK version checking (flutter/flutter#166998)
2025-04-11 [email protected] [iOS] Infer autocorrect value from autofillHints (flutter/flutter#165637)
2025-04-11 [email protected] [Impeller] fix vulkan/gl color space decode. (flutter/flutter#166957)
2025-04-11 [email protected] modify toggle mode style with DatePickerTheme (flutter/flutter#164102)
2025-04-11 [email protected] [iOS/macOS] Add Xcode error if dev dependencies are incorrect (flutter/flutter#165916)
2025-04-11 98614782+auto-submit[bot]@users.noreply.github.com Reverts "[Impeller] defer vulkan context initialization as long as possible. (#166941)" (flutter/flutter#166990)
2025-04-11 [email protected] Roll Packages from b2c45f9 to 4808eff (2 revisions) (flutter/flutter#166982)
2025-04-11 [email protected] [Impeller] defer vulkan context initialization as long as possible. (flutter/flutter#166941)
2025-04-11 [email protected] Reland "[ Widget Preview ] Add initial support for communications over the Dart Tooling Daemon (DTD) (#166698)" (flutter/flutter#166877)
2025-04-11 [email protected] [native assets] Use workspace pubspec for user-defines (flutter/flutter#166977)
2025-04-11 [email protected] [native assets] Roll dependencies (flutter/flutter#166969)
2025-04-11 [email protected] Roll Skia from 98deb838d3b8 to e7aa93f33a20 (1 revision) (flutter/flutter#166966)
2025-04-11 [email protected] Roll Fuchsia Linux SDK from vYisSsIgqw0mqFRVJ... to 91RIHvX0YC3wzD7qj... (flutter/flutter#166963)
2025-04-11 [email protected] [native assets] Support user-defines in pubspec (flutter/flutter#166940)
2025-04-11 [email protected] [Impeller] correct render pass bariers when resolve has mips. (flutter/flutter#166892)
2025-04-11 [email protected] [Impeller] re-make AHB swapchain lazy and allow usage on < 34 (flutter/flutter#166943)
2025-04-11 [email protected] Reland "SliverEnsureSemantics (#165589)" (flutter/flutter#166889)
2025-04-11 [email protected] Roll Skia from 171b2bf1e496 to 98deb838d3b8 (2 revisions) (flutter/flutter#166955)
...
androidseb pushed a commit to androidseb/packages that referenced this pull request Jun 8, 2025
@engine-flutter-autoroll @androidseb
Manual roll Flutter from 30e53b0 to db68c950c599 (98 revisions) (flut…
b21d593 
…ter#9092)

Manual roll Flutter from 30e53b0 to db68c950c599 (98 revisions)

Manual roll requested by [email protected]

flutter/flutter@30e53b0...db68c95

2025-04-15 [email protected] [customer_testing] Pick up the fix for issue found by flutter/dart hh. (flutter/flutter#167212)
2025-04-15 [email protected] Roll Packages from f26b681 to 2fcc403 (4 revisions) (flutter/flutter#167218)
2025-04-15 [email protected] Fix: Update sheet route bottom padding with top padding (flutter/flutter#164473)
2025-04-15 [email protected] Add Irish(ga) to Flutter (flutter/flutter#167129)
2025-04-15 [email protected] Roll Fuchsia Linux SDK from 91RIHvX0YC3wzD7qj... to 7bWzHwIPBTyU6R9nO... (flutter/flutter#167213)
2025-04-15 [email protected] Change saturation calculation for HSLColor.fromColor (flutter/flutter#166639)
2025-04-15 [email protected] fix: Update time picker dialog input size (flutter/flutter#163184)
2025-04-15 [email protected] Clarify how/when `FLUTTER_PREBUILT_ENGINE_VERSION` is passed in Flutter's CI (flutter/flutter#167204)
2025-04-15 [email protected] [ Widget Preview ] Add support for `theme` and `brightness` properties on `Preview` (flutter/flutter#167001)
2025-04-15 [email protected] Update `tests.version` to fix `customer_testing`. (flutter/flutter#167206)
2025-04-15 [email protected] Persistent CupertinoListTile leading and trailing (flutter/flutter#166799)
2025-04-15 [email protected] Add buildroot compatibility for HWASAN. (flutter/flutter#167133)
2025-04-15 [email protected] Correct max height calculation to fade and animate insets on scroll in CupertinoSearchTextField (flutter/flutter#166569)
2025-04-15 [email protected] Clip bottom widgets in nav bar transition (flutter/flutter#166705)
2025-04-14 [email protected] Roll Skia from e7aa93f33a20 to 76cb5d4fba27 (13 revisions) (flutter/flutter#167132)
2025-04-14 [email protected] [fuchsia] Uprev test-scripts with FUCHSIA_READELF env (flutter/flutter#166929)
2025-04-14 [email protected] Cleanup links to flutter/engine in ci/builders docs (flutter/flutter#166916)
2025-04-14 [email protected] Roll Packages from 465bcff to f26b681 (1 revision) (flutter/flutter#167122)
2025-04-14 [email protected] [skwasm] Use `queueMicrotask` instead of `postMessage` when single-threaded (flutter/flutter#166997)
2025-04-14 [email protected] Remove some unused third party library build scripts (flutter/flutter#166960)
2025-04-14 [email protected] [reland] Fix regression in NDK version checking (flutter/flutter#167011)
2025-04-14 [email protected] Add network permissions information to the dart doc of network image.  (flutter/flutter#167110)
2025-04-14 [email protected] Include 3.29.3 and 3.29.2 changelog entries to master (flutter/flutter#166994)
2025-04-12 [email protected] [Impeller] various iOS cleanups. (flutter/flutter#166859)
2025-04-11 [email protected] [Impeller] reland: defer vulkan context initialization as long as possible. (flutter/flutter#167000)
2025-04-11 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Fix regression in NDK version checking (#166998)" (flutter/flutter#167007)
2025-04-11 [email protected] Fix regression in NDK version checking (flutter/flutter#166998)
2025-04-11 [email protected] [iOS] Infer autocorrect value from autofillHints (flutter/flutter#165637)
2025-04-11 [email protected] [Impeller] fix vulkan/gl color space decode. (flutter/flutter#166957)
2025-04-11 [email protected] modify toggle mode style with DatePickerTheme (flutter/flutter#164102)
2025-04-11 [email protected] [iOS/macOS] Add Xcode error if dev dependencies are incorrect (flutter/flutter#165916)
2025-04-11 98614782+auto-submit[bot]@users.noreply.github.com Reverts "[Impeller] defer vulkan context initialization as long as possible. (#166941)" (flutter/flutter#166990)
2025-04-11 [email protected] Roll Packages from 431dc61 to 465bcff (2 revisions) (flutter/flutter#166982)
2025-04-11 [email protected] [Impeller] defer vulkan context initialization as long as possible. (flutter/flutter#166941)
2025-04-11 [email protected] Reland "[ Widget Preview ] Add initial support for communications over the Dart Tooling Daemon (DTD) (#166698)" (flutter/flutter#166877)
2025-04-11 [email protected] [native assets] Use workspace pubspec for user-defines (flutter/flutter#166977)
2025-04-11 [email protected] [native assets] Roll dependencies (flutter/flutter#166969)
2025-04-11 [email protected] Roll Skia from 98deb838d3b8 to e7aa93f33a20 (1 revision) (flutter/flutter#166966)
2025-04-11 [email protected] Roll Fuchsia Linux SDK from vYisSsIgqw0mqFRVJ... to 91RIHvX0YC3wzD7qj... (flutter/flutter#166963)
2025-04-11 [email protected] [native assets] Support user-defines in pubspec (flutter/flutter#166940)
2025-04-11 [email protected] [Impeller] correct render pass bariers when resolve has mips. (flutter/flutter#166892)
2025-04-11 [email protected] [Impeller] re-make AHB swapchain lazy and allow usage on < 34 (flutter/flutter#166943)
2025-04-11 [email protected] Reland "SliverEnsureSemantics (#165589)" (flutter/flutter#166889)
2025-04-11 [email protected] Roll Skia from 171b2bf1e496 to 98deb838d3b8 (2 revisions) (flutter/flutter#166955)
...
FMorschel pushed a commit to FMorschel/packages that referenced this pull request Jun 9, 2025
@engine-flutter-autoroll @FMorschel
Manual roll Flutter from 30e53b0 to db68c950c599 (98 revisions) (flut…
9ee6018 
…ter#9092)

Manual roll Flutter from 30e53b0 to db68c950c599 (98 revisions)

Manual roll requested by [email protected]

flutter/flutter@30e53b0...db68c95

2025-04-15 [email protected] [customer_testing] Pick up the fix for issue found by flutter/dart hh. (flutter/flutter#167212)
2025-04-15 [email protected] Roll Packages from f26b681 to 2fcc403 (4 revisions) (flutter/flutter#167218)
2025-04-15 [email protected] Fix: Update sheet route bottom padding with top padding (flutter/flutter#164473)
2025-04-15 [email protected] Add Irish(ga) to Flutter (flutter/flutter#167129)
2025-04-15 [email protected] Roll Fuchsia Linux SDK from 91RIHvX0YC3wzD7qj... to 7bWzHwIPBTyU6R9nO... (flutter/flutter#167213)
2025-04-15 [email protected] Change saturation calculation for HSLColor.fromColor (flutter/flutter#166639)
2025-04-15 [email protected] fix: Update time picker dialog input size (flutter/flutter#163184)
2025-04-15 [email protected] Clarify how/when `FLUTTER_PREBUILT_ENGINE_VERSION` is passed in Flutter's CI (flutter/flutter#167204)
2025-04-15 [email protected] [ Widget Preview ] Add support for `theme` and `brightness` properties on `Preview` (flutter/flutter#167001)
2025-04-15 [email protected] Update `tests.version` to fix `customer_testing`. (flutter/flutter#167206)
2025-04-15 [email protected] Persistent CupertinoListTile leading and trailing (flutter/flutter#166799)
2025-04-15 [email protected] Add buildroot compatibility for HWASAN. (flutter/flutter#167133)
2025-04-15 [email protected] Correct max height calculation to fade and animate insets on scroll in CupertinoSearchTextField (flutter/flutter#166569)
2025-04-15 [email protected] Clip bottom widgets in nav bar transition (flutter/flutter#166705)
2025-04-14 [email protected] Roll Skia from e7aa93f33a20 to 76cb5d4fba27 (13 revisions) (flutter/flutter#167132)
2025-04-14 [email protected] [fuchsia] Uprev test-scripts with FUCHSIA_READELF env (flutter/flutter#166929)
2025-04-14 [email protected] Cleanup links to flutter/engine in ci/builders docs (flutter/flutter#166916)
2025-04-14 [email protected] Roll Packages from 465bcff to f26b681 (1 revision) (flutter/flutter#167122)
2025-04-14 [email protected] [skwasm] Use `queueMicrotask` instead of `postMessage` when single-threaded (flutter/flutter#166997)
2025-04-14 [email protected] Remove some unused third party library build scripts (flutter/flutter#166960)
2025-04-14 [email protected] [reland] Fix regression in NDK version checking (flutter/flutter#167011)
2025-04-14 [email protected] Add network permissions information to the dart doc of network image.  (flutter/flutter#167110)
2025-04-14 [email protected] Include 3.29.3 and 3.29.2 changelog entries to master (flutter/flutter#166994)
2025-04-12 [email protected] [Impeller] various iOS cleanups. (flutter/flutter#166859)
2025-04-11 [email protected] [Impeller] reland: defer vulkan context initialization as long as possible. (flutter/flutter#167000)
2025-04-11 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Fix regression in NDK version checking (#166998)" (flutter/flutter#167007)
2025-04-11 [email protected] Fix regression in NDK version checking (flutter/flutter#166998)
2025-04-11 [email protected] [iOS] Infer autocorrect value from autofillHints (flutter/flutter#165637)
2025-04-11 [email protected] [Impeller] fix vulkan/gl color space decode. (flutter/flutter#166957)
2025-04-11 [email protected] modify toggle mode style with DatePickerTheme (flutter/flutter#164102)
2025-04-11 [email protected] [iOS/macOS] Add Xcode error if dev dependencies are incorrect (flutter/flutter#165916)
2025-04-11 98614782+auto-submit[bot]@users.noreply.github.com Reverts "[Impeller] defer vulkan context initialization as long as possible. (#166941)" (flutter/flutter#166990)
2025-04-11 [email protected] Roll Packages from 431dc61 to 465bcff (2 revisions) (flutter/flutter#166982)
2025-04-11 [email protected] [Impeller] defer vulkan context initialization as long as possible. (flutter/flutter#166941)
2025-04-11 [email protected] Reland "[ Widget Preview ] Add initial support for communications over the Dart Tooling Daemon (DTD) (#166698)" (flutter/flutter#166877)
2025-04-11 [email protected] [native assets] Use workspace pubspec for user-defines (flutter/flutter#166977)
2025-04-11 [email protected] [native assets] Roll dependencies (flutter/flutter#166969)
2025-04-11 [email protected] Roll Skia from 98deb838d3b8 to e7aa93f33a20 (1 revision) (flutter/flutter#166966)
2025-04-11 [email protected] Roll Fuchsia Linux SDK from vYisSsIgqw0mqFRVJ... to 91RIHvX0YC3wzD7qj... (flutter/flutter#166963)
2025-04-11 [email protected] [native assets] Support user-defines in pubspec (flutter/flutter#166940)
2025-04-11 [email protected] [Impeller] correct render pass bariers when resolve has mips. (flutter/flutter#166892)
2025-04-11 [email protected] [Impeller] re-make AHB swapchain lazy and allow usage on < 34 (flutter/flutter#166943)
2025-04-11 [email protected] Reland "SliverEnsureSemantics (#165589)" (flutter/flutter#166889)
2025-04-11 [email protected] Roll Skia from 171b2bf1e496 to 98deb838d3b8 (2 revisions) (flutter/flutter#166955)
...
Ortes pushed a commit to Ortes/packages that referenced this pull request Jun 25, 2025
@engine-flutter-autoroll @Ortes
Manual roll Flutter from 30e53b0 to db68c950c599 (98 revisions) (flut…
35ba046 
…ter#9092)

Manual roll Flutter from 30e53b0 to db68c950c599 (98 revisions)

Manual roll requested by [email protected]

flutter/flutter@30e53b0...db68c95

2025-04-15 [email protected] [customer_testing] Pick up the fix for issue found by flutter/dart hh. (flutter/flutter#167212)
2025-04-15 [email protected] Roll Packages from f26b681 to 2fcc403 (4 revisions) (flutter/flutter#167218)
2025-04-15 [email protected] Fix: Update sheet route bottom padding with top padding (flutter/flutter#164473)
2025-04-15 [email protected] Add Irish(ga) to Flutter (flutter/flutter#167129)
2025-04-15 [email protected] Roll Fuchsia Linux SDK from 91RIHvX0YC3wzD7qj... to 7bWzHwIPBTyU6R9nO... (flutter/flutter#167213)
2025-04-15 [email protected] Change saturation calculation for HSLColor.fromColor (flutter/flutter#166639)
2025-04-15 [email protected] fix: Update time picker dialog input size (flutter/flutter#163184)
2025-04-15 [email protected] Clarify how/when `FLUTTER_PREBUILT_ENGINE_VERSION` is passed in Flutter's CI (flutter/flutter#167204)
2025-04-15 [email protected] [ Widget Preview ] Add support for `theme` and `brightness` properties on `Preview` (flutter/flutter#167001)
2025-04-15 [email protected] Update `tests.version` to fix `customer_testing`. (flutter/flutter#167206)
2025-04-15 [email protected] Persistent CupertinoListTile leading and trailing (flutter/flutter#166799)
2025-04-15 [email protected] Add buildroot compatibility for HWASAN. (flutter/flutter#167133)
2025-04-15 [email protected] Correct max height calculation to fade and animate insets on scroll in CupertinoSearchTextField (flutter/flutter#166569)
2025-04-15 [email protected] Clip bottom widgets in nav bar transition (flutter/flutter#166705)
2025-04-14 [email protected] Roll Skia from e7aa93f33a20 to 76cb5d4fba27 (13 revisions) (flutter/flutter#167132)
2025-04-14 [email protected] [fuchsia] Uprev test-scripts with FUCHSIA_READELF env (flutter/flutter#166929)
2025-04-14 [email protected] Cleanup links to flutter/engine in ci/builders docs (flutter/flutter#166916)
2025-04-14 [email protected] Roll Packages from 465bcff to f26b681 (1 revision) (flutter/flutter#167122)
2025-04-14 [email protected] [skwasm] Use `queueMicrotask` instead of `postMessage` when single-threaded (flutter/flutter#166997)
2025-04-14 [email protected] Remove some unused third party library build scripts (flutter/flutter#166960)
2025-04-14 [email protected] [reland] Fix regression in NDK version checking (flutter/flutter#167011)
2025-04-14 [email protected] Add network permissions information to the dart doc of network image.  (flutter/flutter#167110)
2025-04-14 [email protected] Include 3.29.3 and 3.29.2 changelog entries to master (flutter/flutter#166994)
2025-04-12 [email protected] [Impeller] various iOS cleanups. (flutter/flutter#166859)
2025-04-11 [email protected] [Impeller] reland: defer vulkan context initialization as long as possible. (flutter/flutter#167000)
2025-04-11 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Fix regression in NDK version checking (#166998)" (flutter/flutter#167007)
2025-04-11 [email protected] Fix regression in NDK version checking (flutter/flutter#166998)
2025-04-11 [email protected] [iOS] Infer autocorrect value from autofillHints (flutter/flutter#165637)
2025-04-11 [email protected] [Impeller] fix vulkan/gl color space decode. (flutter/flutter#166957)
2025-04-11 [email protected] modify toggle mode style with DatePickerTheme (flutter/flutter#164102)
2025-04-11 [email protected] [iOS/macOS] Add Xcode error if dev dependencies are incorrect (flutter/flutter#165916)
2025-04-11 98614782+auto-submit[bot]@users.noreply.github.com Reverts "[Impeller] defer vulkan context initialization as long as possible. (#166941)" (flutter/flutter#166990)
2025-04-11 [email protected] Roll Packages from 431dc61 to 465bcff (2 revisions) (flutter/flutter#166982)
2025-04-11 [email protected] [Impeller] defer vulkan context initialization as long as possible. (flutter/flutter#166941)
2025-04-11 [email protected] Reland "[ Widget Preview ] Add initial support for communications over the Dart Tooling Daemon (DTD) (#166698)" (flutter/flutter#166877)
2025-04-11 [email protected] [native assets] Use workspace pubspec for user-defines (flutter/flutter#166977)
2025-04-11 [email protected] [native assets] Roll dependencies (flutter/flutter#166969)
2025-04-11 [email protected] Roll Skia from 98deb838d3b8 to e7aa93f33a20 (1 revision) (flutter/flutter#166966)
2025-04-11 [email protected] Roll Fuchsia Linux SDK from vYisSsIgqw0mqFRVJ... to 91RIHvX0YC3wzD7qj... (flutter/flutter#166963)
2025-04-11 [email protected] [native assets] Support user-defines in pubspec (flutter/flutter#166940)
2025-04-11 [email protected] [Impeller] correct render pass bariers when resolve has mips. (flutter/flutter#166892)
2025-04-11 [email protected] [Impeller] re-make AHB swapchain lazy and allow usage on < 34 (flutter/flutter#166943)
2025-04-11 [email protected] Reland "SliverEnsureSemantics (#165589)" (flutter/flutter#166889)
2025-04-11 [email protected] Roll Skia from 171b2bf1e496 to 98deb838d3b8 (2 revisions) (flutter/flutter#166955)
...
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 14, 2025
@engine-flutter-autoroll
2f6cdc3fe [skwasm] Use queueMicrotask instead of postMessage when…
92336c2 
… single-threaded (flutter/flutter#166997)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 14, 2025
@engine-flutter-autoroll
2f6cdc3fe [skwasm] Use queueMicrotask instead of postMessage when…
44d72a8 
… single-threaded (flutter/flutter#166997)
romanejaquez pushed a commit to romanejaquez/flutter that referenced this pull request Aug 14, 2025
@eyebrowsoffire @romanejaquez
[skwasm] Use queueMicrotask instead of postMessage when single-th…
4978e08 
…readed (flutter#166997)

It turns out `postMessage` is quite a bit more expensive than
`queueMicrotask`. Before dynamic threading, this is what we actually
did, and perf regressed when we started using `postMessage` instead.

This fixes flutter#166905
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 15, 2025
@engine-flutter-autoroll
2f6cdc3fe [skwasm] Use queueMicrotask instead of postMessage when…
3c26a17 
… single-threaded (flutter/flutter#166997)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 15, 2025
@engine-flutter-autoroll
2f6cdc3fe [skwasm] Use queueMicrotask instead of postMessage when…
e91b038 
… single-threaded (flutter/flutter#166997)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 16, 2025
@engine-flutter-autoroll
2f6cdc3fe [skwasm] Use queueMicrotask instead of postMessage when…
4a74286 
… single-threaded (flutter/flutter#166997)
@eyebrowsoffire eyebrowsoffire deleted the skwasm_microtask branch December 12, 2025 21:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yjbanov yjbanov yjbanov approved these changes

Assignees

No one assigned

Labels

cp: beta cherry pick this pull request to beta release candidate branch engine flutter/engine related. See also e: labels. platform-web Web applications specifically

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Web Performance Degredation after landing Reland "[skwasm] Dynamic Threading" (#166454)

2 participants

@eyebrowsoffire @yjbanov