Skip to content

feat(RadioListTile):ensure that 'isThreeLine' can be configured through the #166964

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
auto-submit merged 4 commits into from
May 6, 2025
Merged

feat(RadioListTile):ensure that 'isThreeLine' can be configured through the #166964

auto-submit merged 4 commits into from
May 6, 2025

Conversation

@StanleyCocos
Copy link
Contributor

@StanleyCocos StanleyCocos commented Apr 11, 2025 •
edited
Loading

This PR is a continuation of 165481

Related items also include: SwitchListTile, CheckboxListTile

Pre-launch Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
  • I signed the [CLA].
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is [test-exempt].
  • I followed the [breaking change policy] and added [Data Driven Fixes] where supported.
  • All existing and new tests are passing.

@github-actions github-actions bot added framework flutter/packages/flutter repository. See also f: labels. f: material design flutter/packages/flutter/material repository. labels Apr 11, 2025
@StanleyCocos StanleyCocos marked this pull request as ready for review April 11, 2025 07:12
This was referenced Apr 18, 2025
Merged
Merged
@dkwingsmt dkwingsmt self-requested a review April 23, 2025 18:18
dkwingsmt
dkwingsmt approved these changes Apr 23, 2025
View reviewed changes
Copy link
Contributor

@dkwingsmt dkwingsmt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

justinmc
justinmc approved these changes Apr 24, 2025
View reviewed changes
Copy link
Contributor

@justinmc justinmc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with nits 👍

packages/flutter/lib/src/material/radio_list_tile.dart
Comment on lines 388 to 390
/// If null, the value from [ListTileThemeData.isThreeLine] is used.
/// If that is also null, the value from the [ListTileThemeData] returned by [ThemeData.listTileTheme] is used.
/// If still null, the default value is `false`.
Copy link
Contributor

@justinmc justinmc Apr 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same comment from the other PR about this being more than 80 characters.

Copy link
Contributor Author

@StanleyCocos StanleyCocos Apr 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated, thank you.

packages/flutter/test/material/radio_list_tile_test.dart

Widget buildFrame({bool? themeDataIsThreeLine, bool? themeIsThreeLine, bool? isThreeLine}) {
return MaterialApp(
key: UniqueKey(),
Copy link
Contributor

@justinmc justinmc Apr 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And same comment about a possibly unnecessary UniqueKey here.

Copy link
Contributor Author

@StanleyCocos StanleyCocos Apr 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Similarly。
I believe this key is useful. Since the same widget tree is called multiple times below with slight modifications, a unique key is needed here to prevent reuse-related errors.

@StanleyCocos
Copy link
Contributor Author

StanleyCocos commented Apr 28, 2025

@justinmc @dkwingsmt
Would you mind taking another look?
Thank you.

github-merge-queue bot pushed a commit that referenced this pull request Apr 30, 2025
@StanleyCocos
feat(CheckboxListTile): ensure that 'isThreeLine' can be configured t…
adae8bb 
…hrough the theme. (#166826)

This PR is a continuation of
[165481](#165481)

Related items also include:
[SwitchListTile](#166820),
[RadioListTile](#166964)

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.
@StanleyCocos
Copy link
Contributor Author

StanleyCocos commented May 6, 2025

@dkwingsmt
Thank you. It should now be ready for merging.
Once this request is merged, I will proceed to adjust the other one.

@dkwingsmt dkwingsmt added the autosubmit Merge PR when tree becomes green via auto submit App label May 6, 2025
@auto-submit auto-submit bot added this pull request to the merge queue May 6, 2025
Merged via the queue into flutter:master with commit dfd0a3c May 6, 2025
76 checks passed
@flutter-dashboard flutter-dashboard bot removed the autosubmit Merge PR when tree becomes green via auto submit App label May 6, 2025
github-merge-queue bot pushed a commit that referenced this pull request May 6, 2025
@StanleyCocos
feat(SwitchListTile): ensure that 'isThreeLine' can be configured thr…
c02d22d 
…ough the theme. (#166820)

This PR is a continuation of
[165481](#165481)

Related items also include:
[RadioListTile](#166964),
[CheckboxListTile](#166826)

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 6, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 6, 2025
@engine-flutter-autoroll
dfd0a3cb5 feat(RadioListTile):ensure that 'isThreeLine' can be config…
e5a20be 
…ured through the (flutter/flutter#166964)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 6, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 6, 2025
@engine-flutter-autoroll
dfd0a3cb5 feat(RadioListTile):ensure that 'isThreeLine' can be config…
2724239 
…ured through the (flutter/flutter#166964)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 6, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 6, 2025
@engine-flutter-autoroll
dfd0a3cb5 feat(RadioListTile):ensure that 'isThreeLine' can be config…
c8e1199 
…ured through the (flutter/flutter#166964)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 6, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 6, 2025
@engine-flutter-autoroll
dfd0a3cb5 feat(RadioListTile):ensure that 'isThreeLine' can be config…
4b5c2d9 
…ured through the (flutter/flutter#166964)
mboetger pushed a commit to mboetger/flutter that referenced this pull request May 6, 2025
@StanleyCocos @dkwingsmt @mboetger
feat(RadioListTile):ensure that 'isThreeLine' can be configured throu…
0076160 
…gh the (flutter#166964)

This PR is a continuation of
[165481](flutter#165481)

Related items also include:
[SwitchListTile](flutter#166820),
[CheckboxListTile](flutter#166826)

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.

---------

Co-authored-by: Tong Mu <[email protected]>
mboetger pushed a commit to mboetger/flutter that referenced this pull request May 6, 2025
@StanleyCocos @mboetger
feat(SwitchListTile): ensure that 'isThreeLine' can be configured thr…
6d3aa69 
…ough the theme. (flutter#166820)

This PR is a continuation of
[165481](flutter#165481)

Related items also include:
[RadioListTile](flutter#166964),
[CheckboxListTile](flutter#166826)

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 7, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 7, 2025
@engine-flutter-autoroll
dfd0a3cb5 feat(RadioListTile):ensure that 'isThreeLine' can be config…
902e4b2 
…ured through the (flutter/flutter#166964)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 7, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 7, 2025
@engine-flutter-autoroll
dfd0a3cb5 feat(RadioListTile):ensure that 'isThreeLine' can be config…
7b8f998 
…ured through the (flutter/flutter#166964)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 7, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 7, 2025
@engine-flutter-autoroll
dfd0a3cb5 feat(RadioListTile):ensure that 'isThreeLine' can be config…
7a9ad4e 
…ured through the (flutter/flutter#166964)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 7, 2025
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 7, 2025
@engine-flutter-autoroll
dfd0a3cb5 feat(RadioListTile):ensure that 'isThreeLine' can be config…
773a57d 
…ured through the (flutter/flutter#166964)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 7, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 7, 2025
@engine-flutter-autoroll
dfd0a3cb5 feat(RadioListTile):ensure that 'isThreeLine' can be config…
d25126e 
…ured through the (flutter/flutter#166964)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 7, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 7, 2025
@engine-flutter-autoroll
dfd0a3cb5 feat(RadioListTile):ensure that 'isThreeLine' can be config…
9df5b55 
…ured through the (flutter/flutter#166964)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 7, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 7, 2025
@engine-flutter-autoroll
dfd0a3cb5 feat(RadioListTile):ensure that 'isThreeLine' can be config…
558c534 
…ured through the (flutter/flutter#166964)
@StanleyCocos StanleyCocos deleted the feature/radio_list_tile branch May 8, 2025 01:45
auto-submit bot pushed a commit to flutter/packages that referenced this pull request May 8, 2025
@engine-flutter-autoroll
Roll Flutter from cfb887cd5f41 to b0f5c8ce03e2 (281 revisions) (#9223)
1392e8c 
Roll Flutter from cfb887cd5f41 to b0f5c8ce03e2 (281 revisions)

flutter/flutter@cfb887c...b0f5c8c

2025-05-07 [email protected] Feat: Animate fill for material app bar (flutter/flutter#163913)
2025-05-07 [email protected] Roll Packages from e800da7 to b2ce3b0 (3 revisions) (flutter/flutter#168483)
2025-05-07 [email protected] Allow iOS devicelab tests to run on macOS 15.1 (flutter/flutter#168234)
2025-05-07 [email protected] Roll Skia from c8f54c1bc565 to 14f3e3209b73 (1 revision) (flutter/flutter#168477)
2025-05-07 [email protected] Roll Skia from 55d98def951d to c8f54c1bc565 (1 revision) (flutter/flutter#168452)
2025-05-07 [email protected] Roll Fuchsia Test Scripts from TcALRG6cjvR6RVe4L... to xobrcSN07udKdXOq_... (flutter/flutter#168444)
2025-05-07 [email protected] Roll Skia from 32591be9cd3b to 55d98def951d (2 revisions) (flutter/flutter#168440)
2025-05-07 [email protected] macOS: trailing closures for FlutterRunLoop.perform* (flutter/flutter#168415)
2025-05-07 [email protected] Roll Fuchsia Linux SDK from SOlRUoAtzxSsarx-6... to _GJje-N2Jk51qtBs6... (flutter/flutter#168434)
2025-05-07 [email protected] iOS/macOS: Consistent Flutter copyright headers (flutter/flutter#168390)
2025-05-06 [email protected] Capture errors when running flutter_tools in the entrypoint_dart_registrant devicelab test (flutter/flutter#168411)
2025-05-06 [email protected] Extending timeouts for DDC macrobenchmarks (flutter/flutter#168409)
2025-05-06 [email protected] Roll Skia from 36d1445ad00b to 32591be9cd3b (1 revision) (flutter/flutter#168421)
2025-05-06 [email protected] Ignore pointer on the outgoing route (flutter/flutter#168425)
2025-05-06 [email protected] [skwasm] Dispose underlying picture recorder when ending recording. (flutter/flutter#168384)
2025-05-06 [email protected] [Impeller] libImpeller: Expose access to conservative path bounds. (flutter/flutter#168402)
2025-05-06 [email protected] Roll Skia from 5cf5d0ff46d9 to 36d1445ad00b (1 revision) (flutter/flutter#168401)
2025-05-06 [email protected] Add height and width aspects to MediaQuery. (flutter/flutter#167829)
2025-05-06 [email protected] Roll Packages from e064b04 to e800da7 (2 revisions) (flutter/flutter#168392)
2025-05-06 [email protected] Add `bin/internal/last_engine_commit.sh` and tests. (flutter/flutter#168387)
2025-05-06 [email protected] Update `mac_ios` tests to run on either arm64 or x86 (flutter/flutter#168341)
2025-05-06 [email protected] Roll Skia from 889c5b52227c to 5cf5d0ff46d9 (3 revisions) (flutter/flutter#168378)
2025-05-06 [email protected] Roll Skia from 646573154de6 to 889c5b52227c (1 revision) (flutter/flutter#168363)
2025-05-06 [email protected] Roll Skia from 65fd10118ec2 to 646573154de6 (3 revisions) (flutter/flutter#168360)
2025-05-06 [email protected] feat(SwitchListTile): ensure that 'isThreeLine' can be configured through the theme. (flutter/flutter#166820)
2025-05-06 [email protected] [tool] Refactor WebTemplate to be immutable (flutter/flutter#168201)
2025-05-06 [email protected] Upload `android-arm64-release` treemap to known location (flutter/flutter#168349)
2025-05-06 [email protected] feat(RadioListTile):ensure that 'isThreeLine' can be configured through the (flutter/flutter#166964)
2025-05-06 [email protected] Roll Fuchsia Linux SDK from hjXORaFgiSd6QjK3D... to SOlRUoAtzxSsarx-6... (flutter/flutter#168347)
2025-05-05 [email protected] Revert "Wire up `MenuAnchor`, `MenuBar`, `MenuItem`-related widgets to aria roles (#165596)" (flutter/flutter#168339)
2025-05-05 [email protected] Bumping framework Template Defaults to Android 16 (API 36) (flutter/flutter#166464)
2025-05-05 [email protected] Roll Skia from c0404ac7ea67 to 65fd10118ec2 (3 revisions) (flutter/flutter#168346)
2025-05-05 [email protected] macOS: Support writing Swift in the macOS embedder (flutter/flutter#168174)
2025-05-05 [email protected] Copy Dart SDK _internal/vm/bin sources into the sky_engine package (flutter/flutter#168238)
2025-05-05 [email protected] Using headless=new for Chrome macrobenchmarks (flutter/flutter#168256)
2025-05-05 [email protected] Roll Dart SDK from a1e1e2770c1e to 8dc0ecee5adc (1 revision) (flutter/flutter#168338)
2025-05-05 [email protected] Check for duplicate archive paths in the engine build configuration JSON files (flutter/flutter#168248)
2025-05-05 [email protected] [Widget Inspector] Add on-device button for changing default "tap" behavior  (flutter/flutter#167677)
2025-05-05 [email protected] Adding utf-8 encoding to hello world's html template (flutter/flutter#168162)
2025-05-05 [email protected] Update goldens.dart error to point to moved file (flutter/flutter#168319)
2025-05-05 [email protected] Skwasm heavy (flutter/flutter#166619)
2025-05-05 [email protected] Manual roll of Dart from 5c535a368799 to a1e1e2770c1e (flutter/flutter#168317)
2025-05-05 [email protected] Roll Skia from 9e23a55870e9 to c0404ac7ea67 (1 revision) (flutter/flutter#168321)
2025-05-05 [email protected] Cupertino sheet MediaQuery values (flutter/flutter#168041)
2025-05-05 [email protected] Change FGP unit test `expect` to match on process result instead of exit code (flutter/flutter#168278)
2025-05-05 [email protected] [Impeller] Use StrokeParameters anywhere stroke is described (flutter/flutter#168276)
...
@Piinks Piinks mentioned this pull request May 9, 2025
Open
androidseb pushed a commit to androidseb/packages that referenced this pull request Jun 8, 2025
@engine-flutter-autoroll @androidseb
Roll Flutter from cfb887cd5f41 to b0f5c8ce03e2 (281 revisions) (flutt…
cf1d157 
…er#9223)

Roll Flutter from cfb887cd5f41 to b0f5c8ce03e2 (281 revisions)

flutter/flutter@cfb887c...b0f5c8c

2025-05-07 [email protected] Feat: Animate fill for material app bar (flutter/flutter#163913)
2025-05-07 [email protected] Roll Packages from e800da7 to b2ce3b0 (3 revisions) (flutter/flutter#168483)
2025-05-07 [email protected] Allow iOS devicelab tests to run on macOS 15.1 (flutter/flutter#168234)
2025-05-07 [email protected] Roll Skia from c8f54c1bc565 to 14f3e3209b73 (1 revision) (flutter/flutter#168477)
2025-05-07 [email protected] Roll Skia from 55d98def951d to c8f54c1bc565 (1 revision) (flutter/flutter#168452)
2025-05-07 [email protected] Roll Fuchsia Test Scripts from TcALRG6cjvR6RVe4L... to xobrcSN07udKdXOq_... (flutter/flutter#168444)
2025-05-07 [email protected] Roll Skia from 32591be9cd3b to 55d98def951d (2 revisions) (flutter/flutter#168440)
2025-05-07 [email protected] macOS: trailing closures for FlutterRunLoop.perform* (flutter/flutter#168415)
2025-05-07 [email protected] Roll Fuchsia Linux SDK from SOlRUoAtzxSsarx-6... to _GJje-N2Jk51qtBs6... (flutter/flutter#168434)
2025-05-07 [email protected] iOS/macOS: Consistent Flutter copyright headers (flutter/flutter#168390)
2025-05-06 [email protected] Capture errors when running flutter_tools in the entrypoint_dart_registrant devicelab test (flutter/flutter#168411)
2025-05-06 [email protected] Extending timeouts for DDC macrobenchmarks (flutter/flutter#168409)
2025-05-06 [email protected] Roll Skia from 36d1445ad00b to 32591be9cd3b (1 revision) (flutter/flutter#168421)
2025-05-06 [email protected] Ignore pointer on the outgoing route (flutter/flutter#168425)
2025-05-06 [email protected] [skwasm] Dispose underlying picture recorder when ending recording. (flutter/flutter#168384)
2025-05-06 [email protected] [Impeller] libImpeller: Expose access to conservative path bounds. (flutter/flutter#168402)
2025-05-06 [email protected] Roll Skia from 5cf5d0ff46d9 to 36d1445ad00b (1 revision) (flutter/flutter#168401)
2025-05-06 [email protected] Add height and width aspects to MediaQuery. (flutter/flutter#167829)
2025-05-06 [email protected] Roll Packages from e064b04 to e800da7 (2 revisions) (flutter/flutter#168392)
2025-05-06 [email protected] Add `bin/internal/last_engine_commit.sh` and tests. (flutter/flutter#168387)
2025-05-06 [email protected] Update `mac_ios` tests to run on either arm64 or x86 (flutter/flutter#168341)
2025-05-06 [email protected] Roll Skia from 889c5b52227c to 5cf5d0ff46d9 (3 revisions) (flutter/flutter#168378)
2025-05-06 [email protected] Roll Skia from 646573154de6 to 889c5b52227c (1 revision) (flutter/flutter#168363)
2025-05-06 [email protected] Roll Skia from 65fd10118ec2 to 646573154de6 (3 revisions) (flutter/flutter#168360)
2025-05-06 [email protected] feat(SwitchListTile): ensure that 'isThreeLine' can be configured through the theme. (flutter/flutter#166820)
2025-05-06 [email protected] [tool] Refactor WebTemplate to be immutable (flutter/flutter#168201)
2025-05-06 [email protected] Upload `android-arm64-release` treemap to known location (flutter/flutter#168349)
2025-05-06 [email protected] feat(RadioListTile):ensure that 'isThreeLine' can be configured through the (flutter/flutter#166964)
2025-05-06 [email protected] Roll Fuchsia Linux SDK from hjXORaFgiSd6QjK3D... to SOlRUoAtzxSsarx-6... (flutter/flutter#168347)
2025-05-05 [email protected] Revert "Wire up `MenuAnchor`, `MenuBar`, `MenuItem`-related widgets to aria roles (#165596)" (flutter/flutter#168339)
2025-05-05 [email protected] Bumping framework Template Defaults to Android 16 (API 36) (flutter/flutter#166464)
2025-05-05 [email protected] Roll Skia from c0404ac7ea67 to 65fd10118ec2 (3 revisions) (flutter/flutter#168346)
2025-05-05 [email protected] macOS: Support writing Swift in the macOS embedder (flutter/flutter#168174)
2025-05-05 [email protected] Copy Dart SDK _internal/vm/bin sources into the sky_engine package (flutter/flutter#168238)
2025-05-05 [email protected] Using headless=new for Chrome macrobenchmarks (flutter/flutter#168256)
2025-05-05 [email protected] Roll Dart SDK from a1e1e2770c1e to 8dc0ecee5adc (1 revision) (flutter/flutter#168338)
2025-05-05 [email protected] Check for duplicate archive paths in the engine build configuration JSON files (flutter/flutter#168248)
2025-05-05 [email protected] [Widget Inspector] Add on-device button for changing default "tap" behavior  (flutter/flutter#167677)
2025-05-05 [email protected] Adding utf-8 encoding to hello world's html template (flutter/flutter#168162)
2025-05-05 [email protected] Update goldens.dart error to point to moved file (flutter/flutter#168319)
2025-05-05 [email protected] Skwasm heavy (flutter/flutter#166619)
2025-05-05 [email protected] Manual roll of Dart from 5c535a368799 to a1e1e2770c1e (flutter/flutter#168317)
2025-05-05 [email protected] Roll Skia from 9e23a55870e9 to c0404ac7ea67 (1 revision) (flutter/flutter#168321)
2025-05-05 [email protected] Cupertino sheet MediaQuery values (flutter/flutter#168041)
2025-05-05 [email protected] Change FGP unit test `expect` to match on process result instead of exit code (flutter/flutter#168278)
2025-05-05 [email protected] [Impeller] Use StrokeParameters anywhere stroke is described (flutter/flutter#168276)
...
FMorschel pushed a commit to FMorschel/packages that referenced this pull request Jun 9, 2025
@engine-flutter-autoroll @FMorschel
Roll Flutter from cfb887cd5f41 to b0f5c8ce03e2 (281 revisions) (flutt…
aed46c7 
…er#9223)

Roll Flutter from cfb887cd5f41 to b0f5c8ce03e2 (281 revisions)

flutter/flutter@cfb887c...b0f5c8c

2025-05-07 [email protected] Feat: Animate fill for material app bar (flutter/flutter#163913)
2025-05-07 [email protected] Roll Packages from e800da7 to b2ce3b0 (3 revisions) (flutter/flutter#168483)
2025-05-07 [email protected] Allow iOS devicelab tests to run on macOS 15.1 (flutter/flutter#168234)
2025-05-07 [email protected] Roll Skia from c8f54c1bc565 to 14f3e3209b73 (1 revision) (flutter/flutter#168477)
2025-05-07 [email protected] Roll Skia from 55d98def951d to c8f54c1bc565 (1 revision) (flutter/flutter#168452)
2025-05-07 [email protected] Roll Fuchsia Test Scripts from TcALRG6cjvR6RVe4L... to xobrcSN07udKdXOq_... (flutter/flutter#168444)
2025-05-07 [email protected] Roll Skia from 32591be9cd3b to 55d98def951d (2 revisions) (flutter/flutter#168440)
2025-05-07 [email protected] macOS: trailing closures for FlutterRunLoop.perform* (flutter/flutter#168415)
2025-05-07 [email protected] Roll Fuchsia Linux SDK from SOlRUoAtzxSsarx-6... to _GJje-N2Jk51qtBs6... (flutter/flutter#168434)
2025-05-07 [email protected] iOS/macOS: Consistent Flutter copyright headers (flutter/flutter#168390)
2025-05-06 [email protected] Capture errors when running flutter_tools in the entrypoint_dart_registrant devicelab test (flutter/flutter#168411)
2025-05-06 [email protected] Extending timeouts for DDC macrobenchmarks (flutter/flutter#168409)
2025-05-06 [email protected] Roll Skia from 36d1445ad00b to 32591be9cd3b (1 revision) (flutter/flutter#168421)
2025-05-06 [email protected] Ignore pointer on the outgoing route (flutter/flutter#168425)
2025-05-06 [email protected] [skwasm] Dispose underlying picture recorder when ending recording. (flutter/flutter#168384)
2025-05-06 [email protected] [Impeller] libImpeller: Expose access to conservative path bounds. (flutter/flutter#168402)
2025-05-06 [email protected] Roll Skia from 5cf5d0ff46d9 to 36d1445ad00b (1 revision) (flutter/flutter#168401)
2025-05-06 [email protected] Add height and width aspects to MediaQuery. (flutter/flutter#167829)
2025-05-06 [email protected] Roll Packages from e064b04 to e800da7 (2 revisions) (flutter/flutter#168392)
2025-05-06 [email protected] Add `bin/internal/last_engine_commit.sh` and tests. (flutter/flutter#168387)
2025-05-06 [email protected] Update `mac_ios` tests to run on either arm64 or x86 (flutter/flutter#168341)
2025-05-06 [email protected] Roll Skia from 889c5b52227c to 5cf5d0ff46d9 (3 revisions) (flutter/flutter#168378)
2025-05-06 [email protected] Roll Skia from 646573154de6 to 889c5b52227c (1 revision) (flutter/flutter#168363)
2025-05-06 [email protected] Roll Skia from 65fd10118ec2 to 646573154de6 (3 revisions) (flutter/flutter#168360)
2025-05-06 [email protected] feat(SwitchListTile): ensure that 'isThreeLine' can be configured through the theme. (flutter/flutter#166820)
2025-05-06 [email protected] [tool] Refactor WebTemplate to be immutable (flutter/flutter#168201)
2025-05-06 [email protected] Upload `android-arm64-release` treemap to known location (flutter/flutter#168349)
2025-05-06 [email protected] feat(RadioListTile):ensure that 'isThreeLine' can be configured through the (flutter/flutter#166964)
2025-05-06 [email protected] Roll Fuchsia Linux SDK from hjXORaFgiSd6QjK3D... to SOlRUoAtzxSsarx-6... (flutter/flutter#168347)
2025-05-05 [email protected] Revert "Wire up `MenuAnchor`, `MenuBar`, `MenuItem`-related widgets to aria roles (#165596)" (flutter/flutter#168339)
2025-05-05 [email protected] Bumping framework Template Defaults to Android 16 (API 36) (flutter/flutter#166464)
2025-05-05 [email protected] Roll Skia from c0404ac7ea67 to 65fd10118ec2 (3 revisions) (flutter/flutter#168346)
2025-05-05 [email protected] macOS: Support writing Swift in the macOS embedder (flutter/flutter#168174)
2025-05-05 [email protected] Copy Dart SDK _internal/vm/bin sources into the sky_engine package (flutter/flutter#168238)
2025-05-05 [email protected] Using headless=new for Chrome macrobenchmarks (flutter/flutter#168256)
2025-05-05 [email protected] Roll Dart SDK from a1e1e2770c1e to 8dc0ecee5adc (1 revision) (flutter/flutter#168338)
2025-05-05 [email protected] Check for duplicate archive paths in the engine build configuration JSON files (flutter/flutter#168248)
2025-05-05 [email protected] [Widget Inspector] Add on-device button for changing default "tap" behavior  (flutter/flutter#167677)
2025-05-05 [email protected] Adding utf-8 encoding to hello world's html template (flutter/flutter#168162)
2025-05-05 [email protected] Update goldens.dart error to point to moved file (flutter/flutter#168319)
2025-05-05 [email protected] Skwasm heavy (flutter/flutter#166619)
2025-05-05 [email protected] Manual roll of Dart from 5c535a368799 to a1e1e2770c1e (flutter/flutter#168317)
2025-05-05 [email protected] Roll Skia from 9e23a55870e9 to c0404ac7ea67 (1 revision) (flutter/flutter#168321)
2025-05-05 [email protected] Cupertino sheet MediaQuery values (flutter/flutter#168041)
2025-05-05 [email protected] Change FGP unit test `expect` to match on process result instead of exit code (flutter/flutter#168278)
2025-05-05 [email protected] [Impeller] Use StrokeParameters anywhere stroke is described (flutter/flutter#168276)
...
Ortes pushed a commit to Ortes/packages that referenced this pull request Jun 25, 2025
@engine-flutter-autoroll @Ortes
Roll Flutter from cfb887cd5f41 to b0f5c8ce03e2 (281 revisions) (flutt…
c32f7c3 
…er#9223)

Roll Flutter from cfb887cd5f41 to b0f5c8ce03e2 (281 revisions)

flutter/flutter@cfb887c...b0f5c8c

2025-05-07 [email protected] Feat: Animate fill for material app bar (flutter/flutter#163913)
2025-05-07 [email protected] Roll Packages from e800da7 to b2ce3b0 (3 revisions) (flutter/flutter#168483)
2025-05-07 [email protected] Allow iOS devicelab tests to run on macOS 15.1 (flutter/flutter#168234)
2025-05-07 [email protected] Roll Skia from c8f54c1bc565 to 14f3e3209b73 (1 revision) (flutter/flutter#168477)
2025-05-07 [email protected] Roll Skia from 55d98def951d to c8f54c1bc565 (1 revision) (flutter/flutter#168452)
2025-05-07 [email protected] Roll Fuchsia Test Scripts from TcALRG6cjvR6RVe4L... to xobrcSN07udKdXOq_... (flutter/flutter#168444)
2025-05-07 [email protected] Roll Skia from 32591be9cd3b to 55d98def951d (2 revisions) (flutter/flutter#168440)
2025-05-07 [email protected] macOS: trailing closures for FlutterRunLoop.perform* (flutter/flutter#168415)
2025-05-07 [email protected] Roll Fuchsia Linux SDK from SOlRUoAtzxSsarx-6... to _GJje-N2Jk51qtBs6... (flutter/flutter#168434)
2025-05-07 [email protected] iOS/macOS: Consistent Flutter copyright headers (flutter/flutter#168390)
2025-05-06 [email protected] Capture errors when running flutter_tools in the entrypoint_dart_registrant devicelab test (flutter/flutter#168411)
2025-05-06 [email protected] Extending timeouts for DDC macrobenchmarks (flutter/flutter#168409)
2025-05-06 [email protected] Roll Skia from 36d1445ad00b to 32591be9cd3b (1 revision) (flutter/flutter#168421)
2025-05-06 [email protected] Ignore pointer on the outgoing route (flutter/flutter#168425)
2025-05-06 [email protected] [skwasm] Dispose underlying picture recorder when ending recording. (flutter/flutter#168384)
2025-05-06 [email protected] [Impeller] libImpeller: Expose access to conservative path bounds. (flutter/flutter#168402)
2025-05-06 [email protected] Roll Skia from 5cf5d0ff46d9 to 36d1445ad00b (1 revision) (flutter/flutter#168401)
2025-05-06 [email protected] Add height and width aspects to MediaQuery. (flutter/flutter#167829)
2025-05-06 [email protected] Roll Packages from e064b04 to e800da7 (2 revisions) (flutter/flutter#168392)
2025-05-06 [email protected] Add `bin/internal/last_engine_commit.sh` and tests. (flutter/flutter#168387)
2025-05-06 [email protected] Update `mac_ios` tests to run on either arm64 or x86 (flutter/flutter#168341)
2025-05-06 [email protected] Roll Skia from 889c5b52227c to 5cf5d0ff46d9 (3 revisions) (flutter/flutter#168378)
2025-05-06 [email protected] Roll Skia from 646573154de6 to 889c5b52227c (1 revision) (flutter/flutter#168363)
2025-05-06 [email protected] Roll Skia from 65fd10118ec2 to 646573154de6 (3 revisions) (flutter/flutter#168360)
2025-05-06 [email protected] feat(SwitchListTile): ensure that 'isThreeLine' can be configured through the theme. (flutter/flutter#166820)
2025-05-06 [email protected] [tool] Refactor WebTemplate to be immutable (flutter/flutter#168201)
2025-05-06 [email protected] Upload `android-arm64-release` treemap to known location (flutter/flutter#168349)
2025-05-06 [email protected] feat(RadioListTile):ensure that 'isThreeLine' can be configured through the (flutter/flutter#166964)
2025-05-06 [email protected] Roll Fuchsia Linux SDK from hjXORaFgiSd6QjK3D... to SOlRUoAtzxSsarx-6... (flutter/flutter#168347)
2025-05-05 [email protected] Revert "Wire up `MenuAnchor`, `MenuBar`, `MenuItem`-related widgets to aria roles (#165596)" (flutter/flutter#168339)
2025-05-05 [email protected] Bumping framework Template Defaults to Android 16 (API 36) (flutter/flutter#166464)
2025-05-05 [email protected] Roll Skia from c0404ac7ea67 to 65fd10118ec2 (3 revisions) (flutter/flutter#168346)
2025-05-05 [email protected] macOS: Support writing Swift in the macOS embedder (flutter/flutter#168174)
2025-05-05 [email protected] Copy Dart SDK _internal/vm/bin sources into the sky_engine package (flutter/flutter#168238)
2025-05-05 [email protected] Using headless=new for Chrome macrobenchmarks (flutter/flutter#168256)
2025-05-05 [email protected] Roll Dart SDK from a1e1e2770c1e to 8dc0ecee5adc (1 revision) (flutter/flutter#168338)
2025-05-05 [email protected] Check for duplicate archive paths in the engine build configuration JSON files (flutter/flutter#168248)
2025-05-05 [email protected] [Widget Inspector] Add on-device button for changing default "tap" behavior  (flutter/flutter#167677)
2025-05-05 [email protected] Adding utf-8 encoding to hello world's html template (flutter/flutter#168162)
2025-05-05 [email protected] Update goldens.dart error to point to moved file (flutter/flutter#168319)
2025-05-05 [email protected] Skwasm heavy (flutter/flutter#166619)
2025-05-05 [email protected] Manual roll of Dart from 5c535a368799 to a1e1e2770c1e (flutter/flutter#168317)
2025-05-05 [email protected] Roll Skia from 9e23a55870e9 to c0404ac7ea67 (1 revision) (flutter/flutter#168321)
2025-05-05 [email protected] Cupertino sheet MediaQuery values (flutter/flutter#168041)
2025-05-05 [email protected] Change FGP unit test `expect` to match on process result instead of exit code (flutter/flutter#168278)
2025-05-05 [email protected] [Impeller] Use StrokeParameters anywhere stroke is described (flutter/flutter#168276)
...
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 14, 2025
@engine-flutter-autoroll
dfd0a3cb5 feat(RadioListTile):ensure that 'isThreeLine' can be config…
45c57f0 
…ured through the (flutter/flutter#166964)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 14, 2025
@engine-flutter-autoroll
dfd0a3cb5 feat(RadioListTile):ensure that 'isThreeLine' can be config…
dc039d1 
…ured through the (flutter/flutter#166964)
romanejaquez pushed a commit to romanejaquez/flutter that referenced this pull request Aug 14, 2025
@StanleyCocos @romanejaquez
feat(CheckboxListTile): ensure that 'isThreeLine' can be configured t…
f12c629 
…hrough the theme. (flutter#166826)

This PR is a continuation of
[165481](flutter#165481)

Related items also include:
[SwitchListTile](flutter#166820),
[RadioListTile](flutter#166964)

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 15, 2025
@engine-flutter-autoroll
dfd0a3cb5 feat(RadioListTile):ensure that 'isThreeLine' can be config…
c87271a 
…ured through the (flutter/flutter#166964)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 15, 2025
@engine-flutter-autoroll
dfd0a3cb5 feat(RadioListTile):ensure that 'isThreeLine' can be config…
961dccc 
…ured through the (flutter/flutter#166964)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 16, 2025
@engine-flutter-autoroll
dfd0a3cb5 feat(RadioListTile):ensure that 'isThreeLine' can be config…
0b89a0e 
…ured through the (flutter/flutter#166964)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@justinmc justinmc justinmc approved these changes

@dkwingsmt dkwingsmt dkwingsmt approved these changes

Assignees

No one assigned

Labels

f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@StanleyCocos @justinmc @dkwingsmt