Skip to content

[native assets] Support user-defines in pubspec #166940

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
auto-submit merged 2 commits into from
Apr 11, 2025
Merged

[native assets] Support user-defines in pubspec #166940

auto-submit merged 2 commits into from
Apr 11, 2025

Conversation

@dcharkes
Copy link
Contributor

@dcharkes dcharkes commented Apr 10, 2025

This PR is the dual of https://dart-review.googlesource.com/c/sdk/+/420700 in the Dart SDK.

This PR adds support for user-defines for hooks in the root package pubspec.yaml.

hooks:
  user_defines:
    hook_user_defines: # package name
      magic_value: 1000

For more design considerations see:

Testing

This PR is covered by test/integration.shard/isolated/native_assets_test.dart.

In this PR, we add a new test project dev/integration_tests/hook_user_defines/ and add a dependency on that project in the mentioned test.

The integration test already covers flutter run, flutter test, and flutter build.

@dcharkes dcharkes requested a review from a team as a code owner April 10, 2025 19:49
@github-actions github-actions bot added tool Affects the "flutter" command-line tool. See also t: labels. a: desktop Running on desktop team-ios Owned by iOS platform team labels Apr 10, 2025
@dcharkes dcharkes requested review from bkonyi and mosuem April 10, 2025 19:49
bkonyi
bkonyi approved these changes Apr 10, 2025
View reviewed changes
dev/integration_tests/hook_user_defines/hook/build.dart Outdated

void main(List<String> args) async {
await build(args, (BuildInput input, BuildOutputBuilder output) async {
final dynamic magicValue = input.userDefines['magic_value'];
Copy link
Contributor

@bkonyi bkonyi Apr 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ubernit: can we make this Object? :)

@dcharkes dcharkes added the autosubmit Merge PR when tree becomes green via auto submit App label Apr 11, 2025
@auto-submit auto-submit bot added this pull request to the merge queue Apr 11, 2025
Merged via the queue into master with commit 0d64c72 Apr 11, 2025
154 checks passed
@auto-submit auto-submit bot deleted the hooks-user-defines branch April 11, 2025 06:47
@flutter-dashboard flutter-dashboard bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Apr 11, 2025
@dcharkes dcharkes mentioned this pull request Apr 11, 2025
Merged
github-merge-queue bot pushed a commit that referenced this pull request Apr 11, 2025
@dcharkes
[native assets] Use workspace pubspec for user-defines (#166977)
02008f0 
If pub workspaces are used, then native assets are shared across the
whole pub workspace. Using a different user-define, invalidates the
cache. Therefore, we want to avoid having different user-defines in
different pubspecs belonging to the same workspace. So, only use the
workspace pubspec for user-defines.

Analogous Dart SDK CL:
https://dart-review.googlesource.com/c/sdk/+/422101

### Testing

Covered by the integration tests added in
#166940 for user-defines.

### Design discussion

We could allow adding user-defines in root package pubspecs later, but
this will likely deteriorate caching behavior (either invalidating the
cache often, or requiring a cache directory per root package, which
increases latency for new root packages).

Also, we'd likely add command-line user-defines later, these are
expected to deteriorate caching behavior.

For design discussion, refer to:

* dart-lang/native#39
* dart-lang/native#2187
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 11, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 11, 2025
@engine-flutter-autoroll
0d64c7292 [native assets] Support user-defines in pubspec (flutter/fl…
2a6be74 
…utter#166940)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 11, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 11, 2025
@engine-flutter-autoroll
0d64c7292 [native assets] Support user-defines in pubspec (flutter/fl…
f511536 
…utter#166940)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 11, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 11, 2025
@engine-flutter-autoroll
0d64c7292 [native assets] Support user-defines in pubspec (flutter/fl…
ebb376b 
…utter#166940)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 11, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 11, 2025
@engine-flutter-autoroll
0d64c7292 [native assets] Support user-defines in pubspec (flutter/fl…
8c37f2a 
…utter#166940)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 11, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 11, 2025
@engine-flutter-autoroll
0d64c7292 [native assets] Support user-defines in pubspec (flutter/fl…
080aa56 
…utter#166940)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 11, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 11, 2025
@engine-flutter-autoroll
0d64c7292 [native assets] Support user-defines in pubspec (flutter/fl…
44e4d4a 
…utter#166940)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 12, 2025
Closed
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 14, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 14, 2025
@engine-flutter-autoroll
0d64c7292 [native assets] Support user-defines in pubspec (flutter/fl…
6775ff4 
…utter#166940)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 14, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 14, 2025
@engine-flutter-autoroll
0d64c7292 [native assets] Support user-defines in pubspec (flutter/fl…
87267ad 
…utter#166940)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 14, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 14, 2025
@engine-flutter-autoroll
0d64c7292 [native assets] Support user-defines in pubspec (flutter/fl…
f1a0594 
…utter#166940)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 14, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 14, 2025
@engine-flutter-autoroll
0d64c7292 [native assets] Support user-defines in pubspec (flutter/fl…
ebc36b2 
…utter#166940)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 15, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 15, 2025
@engine-flutter-autoroll
0d64c7292 [native assets] Support user-defines in pubspec (flutter/fl…
ce82651 
…utter#166940)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 15, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 15, 2025
@engine-flutter-autoroll
0d64c7292 [native assets] Support user-defines in pubspec (flutter/fl…
47a020e 
…utter#166940)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 15, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 15, 2025
@engine-flutter-autoroll
0d64c7292 [native assets] Support user-defines in pubspec (flutter/fl…
580d42d 
…utter#166940)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 15, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 15, 2025
@engine-flutter-autoroll
0d64c7292 [native assets] Support user-defines in pubspec (flutter/fl…
f8e7f49 
…utter#166940)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 15, 2025
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 15, 2025
@engine-flutter-autoroll
0d64c7292 [native assets] Support user-defines in pubspec (flutter/fl…
5916ed5 
…utter#166940)
auto-submit bot pushed a commit to flutter/packages that referenced this pull request Apr 16, 2025
@engine-flutter-autoroll
Manual roll Flutter from 30e53b0 to db68c950c599 (98 revisions) (#9092)
1f0a894 
Manual roll Flutter from 30e53b0 to db68c950c599 (98 revisions)

Manual roll requested by [email protected]

flutter/flutter@30e53b0...db68c95

2025-04-15 [email protected] [customer_testing] Pick up the fix for issue found by flutter/dart hh. (flutter/flutter#167212)
2025-04-15 [email protected] Roll Packages from f26b681 to 2fcc403 (4 revisions) (flutter/flutter#167218)
2025-04-15 [email protected] Fix: Update sheet route bottom padding with top padding (flutter/flutter#164473)
2025-04-15 [email protected] Add Irish(ga) to Flutter (flutter/flutter#167129)
2025-04-15 [email protected] Roll Fuchsia Linux SDK from 91RIHvX0YC3wzD7qj... to 7bWzHwIPBTyU6R9nO... (flutter/flutter#167213)
2025-04-15 [email protected] Change saturation calculation for HSLColor.fromColor (flutter/flutter#166639)
2025-04-15 [email protected] fix: Update time picker dialog input size (flutter/flutter#163184)
2025-04-15 [email protected] Clarify how/when `FLUTTER_PREBUILT_ENGINE_VERSION` is passed in Flutter's CI (flutter/flutter#167204)
2025-04-15 [email protected] [ Widget Preview ] Add support for `theme` and `brightness` properties on `Preview` (flutter/flutter#167001)
2025-04-15 [email protected] Update `tests.version` to fix `customer_testing`. (flutter/flutter#167206)
2025-04-15 [email protected] Persistent CupertinoListTile leading and trailing (flutter/flutter#166799)
2025-04-15 [email protected] Add buildroot compatibility for HWASAN. (flutter/flutter#167133)
2025-04-15 [email protected] Correct max height calculation to fade and animate insets on scroll in CupertinoSearchTextField (flutter/flutter#166569)
2025-04-15 [email protected] Clip bottom widgets in nav bar transition (flutter/flutter#166705)
2025-04-14 [email protected] Roll Skia from e7aa93f33a20 to 76cb5d4fba27 (13 revisions) (flutter/flutter#167132)
2025-04-14 [email protected] [fuchsia] Uprev test-scripts with FUCHSIA_READELF env (flutter/flutter#166929)
2025-04-14 [email protected] Cleanup links to flutter/engine in ci/builders docs (flutter/flutter#166916)
2025-04-14 [email protected] Roll Packages from 465bcff to f26b681 (1 revision) (flutter/flutter#167122)
2025-04-14 [email protected] [skwasm] Use `queueMicrotask` instead of `postMessage` when single-threaded (flutter/flutter#166997)
2025-04-14 [email protected] Remove some unused third party library build scripts (flutter/flutter#166960)
2025-04-14 [email protected] [reland] Fix regression in NDK version checking (flutter/flutter#167011)
2025-04-14 [email protected] Add network permissions information to the dart doc of network image.  (flutter/flutter#167110)
2025-04-14 [email protected] Include 3.29.3 and 3.29.2 changelog entries to master (flutter/flutter#166994)
2025-04-12 [email protected] [Impeller] various iOS cleanups. (flutter/flutter#166859)
2025-04-11 [email protected] [Impeller] reland: defer vulkan context initialization as long as possible. (flutter/flutter#167000)
2025-04-11 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Fix regression in NDK version checking (#166998)" (flutter/flutter#167007)
2025-04-11 [email protected] Fix regression in NDK version checking (flutter/flutter#166998)
2025-04-11 [email protected] [iOS] Infer autocorrect value from autofillHints (flutter/flutter#165637)
2025-04-11 [email protected] [Impeller] fix vulkan/gl color space decode. (flutter/flutter#166957)
2025-04-11 [email protected] modify toggle mode style with DatePickerTheme (flutter/flutter#164102)
2025-04-11 [email protected] [iOS/macOS] Add Xcode error if dev dependencies are incorrect (flutter/flutter#165916)
2025-04-11 98614782+auto-submit[bot]@users.noreply.github.com Reverts "[Impeller] defer vulkan context initialization as long as possible. (#166941)" (flutter/flutter#166990)
2025-04-11 [email protected] Roll Packages from 431dc61 to 465bcff (2 revisions) (flutter/flutter#166982)
2025-04-11 [email protected] [Impeller] defer vulkan context initialization as long as possible. (flutter/flutter#166941)
2025-04-11 [email protected] Reland "[ Widget Preview ] Add initial support for communications over the Dart Tooling Daemon (DTD) (#166698)" (flutter/flutter#166877)
2025-04-11 [email protected] [native assets] Use workspace pubspec for user-defines (flutter/flutter#166977)
2025-04-11 [email protected] [native assets] Roll dependencies (flutter/flutter#166969)
2025-04-11 [email protected] Roll Skia from 98deb838d3b8 to e7aa93f33a20 (1 revision) (flutter/flutter#166966)
2025-04-11 [email protected] Roll Fuchsia Linux SDK from vYisSsIgqw0mqFRVJ... to 91RIHvX0YC3wzD7qj... (flutter/flutter#166963)
2025-04-11 [email protected] [native assets] Support user-defines in pubspec (flutter/flutter#166940)
2025-04-11 [email protected] [Impeller] correct render pass bariers when resolve has mips. (flutter/flutter#166892)
2025-04-11 [email protected] [Impeller] re-make AHB swapchain lazy and allow usage on < 34 (flutter/flutter#166943)
2025-04-11 [email protected] Reland "SliverEnsureSemantics (#165589)" (flutter/flutter#166889)
2025-04-11 [email protected] Roll Skia from 171b2bf1e496 to 98deb838d3b8 (2 revisions) (flutter/flutter#166955)
...
CodixNinja pushed a commit to CodixNinja/packages that referenced this pull request May 15, 2025
@engine-flutter-autoroll
Manual roll Flutter from 30e53b0d9caa to db68c950c599 (98 revisions) …
fc4e794 
…(#9092)

Manual roll Flutter from 30e53b0d9caa to db68c950c599 (98 revisions)

Manual roll requested by [email protected]

flutter/flutter@30e53b0...db68c95

2025-04-15 [email protected] [customer_testing] Pick up the fix for issue found by flutter/dart hh. (flutter/flutter#167212)
2025-04-15 [email protected] Roll Packages from 853e96a to a5ed6cb (4 revisions) (flutter/flutter#167218)
2025-04-15 [email protected] Fix: Update sheet route bottom padding with top padding (flutter/flutter#164473)
2025-04-15 [email protected] Add Irish(ga) to Flutter (flutter/flutter#167129)
2025-04-15 [email protected] Roll Fuchsia Linux SDK from 91RIHvX0YC3wzD7qj... to 7bWzHwIPBTyU6R9nO... (flutter/flutter#167213)
2025-04-15 [email protected] Change saturation calculation for HSLColor.fromColor (flutter/flutter#166639)
2025-04-15 [email protected] fix: Update time picker dialog input size (flutter/flutter#163184)
2025-04-15 [email protected] Clarify how/when `FLUTTER_PREBUILT_ENGINE_VERSION` is passed in Flutter's CI (flutter/flutter#167204)
2025-04-15 [email protected] [ Widget Preview ] Add support for `theme` and `brightness` properties on `Preview` (flutter/flutter#167001)
2025-04-15 [email protected] Update `tests.version` to fix `customer_testing`. (flutter/flutter#167206)
2025-04-15 [email protected] Persistent CupertinoListTile leading and trailing (flutter/flutter#166799)
2025-04-15 [email protected] Add buildroot compatibility for HWASAN. (flutter/flutter#167133)
2025-04-15 [email protected] Correct max height calculation to fade and animate insets on scroll in CupertinoSearchTextField (flutter/flutter#166569)
2025-04-15 [email protected] Clip bottom widgets in nav bar transition (flutter/flutter#166705)
2025-04-14 [email protected] Roll Skia from e7aa93f33a20 to 76cb5d4fba27 (13 revisions) (flutter/flutter#167132)
2025-04-14 [email protected] [fuchsia] Uprev test-scripts with FUCHSIA_READELF env (flutter/flutter#166929)
2025-04-14 [email protected] Cleanup links to flutter/engine in ci/builders docs (flutter/flutter#166916)
2025-04-14 [email protected] Roll Packages from 4808eff to 853e96a (1 revision) (flutter/flutter#167122)
2025-04-14 [email protected] [skwasm] Use `queueMicrotask` instead of `postMessage` when single-threaded (flutter/flutter#166997)
2025-04-14 [email protected] Remove some unused third party library build scripts (flutter/flutter#166960)
2025-04-14 [email protected] [reland] Fix regression in NDK version checking (flutter/flutter#167011)
2025-04-14 [email protected] Add network permissions information to the dart doc of network image.  (flutter/flutter#167110)
2025-04-14 [email protected] Include 3.29.3 and 3.29.2 changelog entries to master (flutter/flutter#166994)
2025-04-12 [email protected] [Impeller] various iOS cleanups. (flutter/flutter#166859)
2025-04-11 [email protected] [Impeller] reland: defer vulkan context initialization as long as possible. (flutter/flutter#167000)
2025-04-11 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Fix regression in NDK version checking (#166998)" (flutter/flutter#167007)
2025-04-11 [email protected] Fix regression in NDK version checking (flutter/flutter#166998)
2025-04-11 [email protected] [iOS] Infer autocorrect value from autofillHints (flutter/flutter#165637)
2025-04-11 [email protected] [Impeller] fix vulkan/gl color space decode. (flutter/flutter#166957)
2025-04-11 [email protected] modify toggle mode style with DatePickerTheme (flutter/flutter#164102)
2025-04-11 [email protected] [iOS/macOS] Add Xcode error if dev dependencies are incorrect (flutter/flutter#165916)
2025-04-11 98614782+auto-submit[bot]@users.noreply.github.com Reverts "[Impeller] defer vulkan context initialization as long as possible. (#166941)" (flutter/flutter#166990)
2025-04-11 [email protected] Roll Packages from b2c45f9 to 4808eff (2 revisions) (flutter/flutter#166982)
2025-04-11 [email protected] [Impeller] defer vulkan context initialization as long as possible. (flutter/flutter#166941)
2025-04-11 [email protected] Reland "[ Widget Preview ] Add initial support for communications over the Dart Tooling Daemon (DTD) (#166698)" (flutter/flutter#166877)
2025-04-11 [email protected] [native assets] Use workspace pubspec for user-defines (flutter/flutter#166977)
2025-04-11 [email protected] [native assets] Roll dependencies (flutter/flutter#166969)
2025-04-11 [email protected] Roll Skia from 98deb838d3b8 to e7aa93f33a20 (1 revision) (flutter/flutter#166966)
2025-04-11 [email protected] Roll Fuchsia Linux SDK from vYisSsIgqw0mqFRVJ... to 91RIHvX0YC3wzD7qj... (flutter/flutter#166963)
2025-04-11 [email protected] [native assets] Support user-defines in pubspec (flutter/flutter#166940)
2025-04-11 [email protected] [Impeller] correct render pass bariers when resolve has mips. (flutter/flutter#166892)
2025-04-11 [email protected] [Impeller] re-make AHB swapchain lazy and allow usage on < 34 (flutter/flutter#166943)
2025-04-11 [email protected] Reland "SliverEnsureSemantics (#165589)" (flutter/flutter#166889)
2025-04-11 [email protected] Roll Skia from 171b2bf1e496 to 98deb838d3b8 (2 revisions) (flutter/flutter#166955)
...
androidseb pushed a commit to androidseb/packages that referenced this pull request Jun 8, 2025
@engine-flutter-autoroll @androidseb
Manual roll Flutter from 30e53b0 to db68c950c599 (98 revisions) (flut…
b21d593 
…ter#9092)

Manual roll Flutter from 30e53b0 to db68c950c599 (98 revisions)

Manual roll requested by [email protected]

flutter/flutter@30e53b0...db68c95

2025-04-15 [email protected] [customer_testing] Pick up the fix for issue found by flutter/dart hh. (flutter/flutter#167212)
2025-04-15 [email protected] Roll Packages from f26b681 to 2fcc403 (4 revisions) (flutter/flutter#167218)
2025-04-15 [email protected] Fix: Update sheet route bottom padding with top padding (flutter/flutter#164473)
2025-04-15 [email protected] Add Irish(ga) to Flutter (flutter/flutter#167129)
2025-04-15 [email protected] Roll Fuchsia Linux SDK from 91RIHvX0YC3wzD7qj... to 7bWzHwIPBTyU6R9nO... (flutter/flutter#167213)
2025-04-15 [email protected] Change saturation calculation for HSLColor.fromColor (flutter/flutter#166639)
2025-04-15 [email protected] fix: Update time picker dialog input size (flutter/flutter#163184)
2025-04-15 [email protected] Clarify how/when `FLUTTER_PREBUILT_ENGINE_VERSION` is passed in Flutter's CI (flutter/flutter#167204)
2025-04-15 [email protected] [ Widget Preview ] Add support for `theme` and `brightness` properties on `Preview` (flutter/flutter#167001)
2025-04-15 [email protected] Update `tests.version` to fix `customer_testing`. (flutter/flutter#167206)
2025-04-15 [email protected] Persistent CupertinoListTile leading and trailing (flutter/flutter#166799)
2025-04-15 [email protected] Add buildroot compatibility for HWASAN. (flutter/flutter#167133)
2025-04-15 [email protected] Correct max height calculation to fade and animate insets on scroll in CupertinoSearchTextField (flutter/flutter#166569)
2025-04-15 [email protected] Clip bottom widgets in nav bar transition (flutter/flutter#166705)
2025-04-14 [email protected] Roll Skia from e7aa93f33a20 to 76cb5d4fba27 (13 revisions) (flutter/flutter#167132)
2025-04-14 [email protected] [fuchsia] Uprev test-scripts with FUCHSIA_READELF env (flutter/flutter#166929)
2025-04-14 [email protected] Cleanup links to flutter/engine in ci/builders docs (flutter/flutter#166916)
2025-04-14 [email protected] Roll Packages from 465bcff to f26b681 (1 revision) (flutter/flutter#167122)
2025-04-14 [email protected] [skwasm] Use `queueMicrotask` instead of `postMessage` when single-threaded (flutter/flutter#166997)
2025-04-14 [email protected] Remove some unused third party library build scripts (flutter/flutter#166960)
2025-04-14 [email protected] [reland] Fix regression in NDK version checking (flutter/flutter#167011)
2025-04-14 [email protected] Add network permissions information to the dart doc of network image.  (flutter/flutter#167110)
2025-04-14 [email protected] Include 3.29.3 and 3.29.2 changelog entries to master (flutter/flutter#166994)
2025-04-12 [email protected] [Impeller] various iOS cleanups. (flutter/flutter#166859)
2025-04-11 [email protected] [Impeller] reland: defer vulkan context initialization as long as possible. (flutter/flutter#167000)
2025-04-11 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Fix regression in NDK version checking (#166998)" (flutter/flutter#167007)
2025-04-11 [email protected] Fix regression in NDK version checking (flutter/flutter#166998)
2025-04-11 [email protected] [iOS] Infer autocorrect value from autofillHints (flutter/flutter#165637)
2025-04-11 [email protected] [Impeller] fix vulkan/gl color space decode. (flutter/flutter#166957)
2025-04-11 [email protected] modify toggle mode style with DatePickerTheme (flutter/flutter#164102)
2025-04-11 [email protected] [iOS/macOS] Add Xcode error if dev dependencies are incorrect (flutter/flutter#165916)
2025-04-11 98614782+auto-submit[bot]@users.noreply.github.com Reverts "[Impeller] defer vulkan context initialization as long as possible. (#166941)" (flutter/flutter#166990)
2025-04-11 [email protected] Roll Packages from 431dc61 to 465bcff (2 revisions) (flutter/flutter#166982)
2025-04-11 [email protected] [Impeller] defer vulkan context initialization as long as possible. (flutter/flutter#166941)
2025-04-11 [email protected] Reland "[ Widget Preview ] Add initial support for communications over the Dart Tooling Daemon (DTD) (#166698)" (flutter/flutter#166877)
2025-04-11 [email protected] [native assets] Use workspace pubspec for user-defines (flutter/flutter#166977)
2025-04-11 [email protected] [native assets] Roll dependencies (flutter/flutter#166969)
2025-04-11 [email protected] Roll Skia from 98deb838d3b8 to e7aa93f33a20 (1 revision) (flutter/flutter#166966)
2025-04-11 [email protected] Roll Fuchsia Linux SDK from vYisSsIgqw0mqFRVJ... to 91RIHvX0YC3wzD7qj... (flutter/flutter#166963)
2025-04-11 [email protected] [native assets] Support user-defines in pubspec (flutter/flutter#166940)
2025-04-11 [email protected] [Impeller] correct render pass bariers when resolve has mips. (flutter/flutter#166892)
2025-04-11 [email protected] [Impeller] re-make AHB swapchain lazy and allow usage on < 34 (flutter/flutter#166943)
2025-04-11 [email protected] Reland "SliverEnsureSemantics (#165589)" (flutter/flutter#166889)
2025-04-11 [email protected] Roll Skia from 171b2bf1e496 to 98deb838d3b8 (2 revisions) (flutter/flutter#166955)
...
FMorschel pushed a commit to FMorschel/packages that referenced this pull request Jun 9, 2025
@engine-flutter-autoroll @FMorschel
Manual roll Flutter from 30e53b0 to db68c950c599 (98 revisions) (flut…
9ee6018 
…ter#9092)

Manual roll Flutter from 30e53b0 to db68c950c599 (98 revisions)

Manual roll requested by [email protected]

flutter/flutter@30e53b0...db68c95

2025-04-15 [email protected] [customer_testing] Pick up the fix for issue found by flutter/dart hh. (flutter/flutter#167212)
2025-04-15 [email protected] Roll Packages from f26b681 to 2fcc403 (4 revisions) (flutter/flutter#167218)
2025-04-15 [email protected] Fix: Update sheet route bottom padding with top padding (flutter/flutter#164473)
2025-04-15 [email protected] Add Irish(ga) to Flutter (flutter/flutter#167129)
2025-04-15 [email protected] Roll Fuchsia Linux SDK from 91RIHvX0YC3wzD7qj... to 7bWzHwIPBTyU6R9nO... (flutter/flutter#167213)
2025-04-15 [email protected] Change saturation calculation for HSLColor.fromColor (flutter/flutter#166639)
2025-04-15 [email protected] fix: Update time picker dialog input size (flutter/flutter#163184)
2025-04-15 [email protected] Clarify how/when `FLUTTER_PREBUILT_ENGINE_VERSION` is passed in Flutter's CI (flutter/flutter#167204)
2025-04-15 [email protected] [ Widget Preview ] Add support for `theme` and `brightness` properties on `Preview` (flutter/flutter#167001)
2025-04-15 [email protected] Update `tests.version` to fix `customer_testing`. (flutter/flutter#167206)
2025-04-15 [email protected] Persistent CupertinoListTile leading and trailing (flutter/flutter#166799)
2025-04-15 [email protected] Add buildroot compatibility for HWASAN. (flutter/flutter#167133)
2025-04-15 [email protected] Correct max height calculation to fade and animate insets on scroll in CupertinoSearchTextField (flutter/flutter#166569)
2025-04-15 [email protected] Clip bottom widgets in nav bar transition (flutter/flutter#166705)
2025-04-14 [email protected] Roll Skia from e7aa93f33a20 to 76cb5d4fba27 (13 revisions) (flutter/flutter#167132)
2025-04-14 [email protected] [fuchsia] Uprev test-scripts with FUCHSIA_READELF env (flutter/flutter#166929)
2025-04-14 [email protected] Cleanup links to flutter/engine in ci/builders docs (flutter/flutter#166916)
2025-04-14 [email protected] Roll Packages from 465bcff to f26b681 (1 revision) (flutter/flutter#167122)
2025-04-14 [email protected] [skwasm] Use `queueMicrotask` instead of `postMessage` when single-threaded (flutter/flutter#166997)
2025-04-14 [email protected] Remove some unused third party library build scripts (flutter/flutter#166960)
2025-04-14 [email protected] [reland] Fix regression in NDK version checking (flutter/flutter#167011)
2025-04-14 [email protected] Add network permissions information to the dart doc of network image.  (flutter/flutter#167110)
2025-04-14 [email protected] Include 3.29.3 and 3.29.2 changelog entries to master (flutter/flutter#166994)
2025-04-12 [email protected] [Impeller] various iOS cleanups. (flutter/flutter#166859)
2025-04-11 [email protected] [Impeller] reland: defer vulkan context initialization as long as possible. (flutter/flutter#167000)
2025-04-11 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Fix regression in NDK version checking (#166998)" (flutter/flutter#167007)
2025-04-11 [email protected] Fix regression in NDK version checking (flutter/flutter#166998)
2025-04-11 [email protected] [iOS] Infer autocorrect value from autofillHints (flutter/flutter#165637)
2025-04-11 [email protected] [Impeller] fix vulkan/gl color space decode. (flutter/flutter#166957)
2025-04-11 [email protected] modify toggle mode style with DatePickerTheme (flutter/flutter#164102)
2025-04-11 [email protected] [iOS/macOS] Add Xcode error if dev dependencies are incorrect (flutter/flutter#165916)
2025-04-11 98614782+auto-submit[bot]@users.noreply.github.com Reverts "[Impeller] defer vulkan context initialization as long as possible. (#166941)" (flutter/flutter#166990)
2025-04-11 [email protected] Roll Packages from 431dc61 to 465bcff (2 revisions) (flutter/flutter#166982)
2025-04-11 [email protected] [Impeller] defer vulkan context initialization as long as possible. (flutter/flutter#166941)
2025-04-11 [email protected] Reland "[ Widget Preview ] Add initial support for communications over the Dart Tooling Daemon (DTD) (#166698)" (flutter/flutter#166877)
2025-04-11 [email protected] [native assets] Use workspace pubspec for user-defines (flutter/flutter#166977)
2025-04-11 [email protected] [native assets] Roll dependencies (flutter/flutter#166969)
2025-04-11 [email protected] Roll Skia from 98deb838d3b8 to e7aa93f33a20 (1 revision) (flutter/flutter#166966)
2025-04-11 [email protected] Roll Fuchsia Linux SDK from vYisSsIgqw0mqFRVJ... to 91RIHvX0YC3wzD7qj... (flutter/flutter#166963)
2025-04-11 [email protected] [native assets] Support user-defines in pubspec (flutter/flutter#166940)
2025-04-11 [email protected] [Impeller] correct render pass bariers when resolve has mips. (flutter/flutter#166892)
2025-04-11 [email protected] [Impeller] re-make AHB swapchain lazy and allow usage on < 34 (flutter/flutter#166943)
2025-04-11 [email protected] Reland "SliverEnsureSemantics (#165589)" (flutter/flutter#166889)
2025-04-11 [email protected] Roll Skia from 171b2bf1e496 to 98deb838d3b8 (2 revisions) (flutter/flutter#166955)
...
Ortes pushed a commit to Ortes/packages that referenced this pull request Jun 25, 2025
@engine-flutter-autoroll @Ortes
Manual roll Flutter from 30e53b0 to db68c950c599 (98 revisions) (flut…
35ba046 
…ter#9092)

Manual roll Flutter from 30e53b0 to db68c950c599 (98 revisions)

Manual roll requested by [email protected]

flutter/flutter@30e53b0...db68c95

2025-04-15 [email protected] [customer_testing] Pick up the fix for issue found by flutter/dart hh. (flutter/flutter#167212)
2025-04-15 [email protected] Roll Packages from f26b681 to 2fcc403 (4 revisions) (flutter/flutter#167218)
2025-04-15 [email protected] Fix: Update sheet route bottom padding with top padding (flutter/flutter#164473)
2025-04-15 [email protected] Add Irish(ga) to Flutter (flutter/flutter#167129)
2025-04-15 [email protected] Roll Fuchsia Linux SDK from 91RIHvX0YC3wzD7qj... to 7bWzHwIPBTyU6R9nO... (flutter/flutter#167213)
2025-04-15 [email protected] Change saturation calculation for HSLColor.fromColor (flutter/flutter#166639)
2025-04-15 [email protected] fix: Update time picker dialog input size (flutter/flutter#163184)
2025-04-15 [email protected] Clarify how/when `FLUTTER_PREBUILT_ENGINE_VERSION` is passed in Flutter's CI (flutter/flutter#167204)
2025-04-15 [email protected] [ Widget Preview ] Add support for `theme` and `brightness` properties on `Preview` (flutter/flutter#167001)
2025-04-15 [email protected] Update `tests.version` to fix `customer_testing`. (flutter/flutter#167206)
2025-04-15 [email protected] Persistent CupertinoListTile leading and trailing (flutter/flutter#166799)
2025-04-15 [email protected] Add buildroot compatibility for HWASAN. (flutter/flutter#167133)
2025-04-15 [email protected] Correct max height calculation to fade and animate insets on scroll in CupertinoSearchTextField (flutter/flutter#166569)
2025-04-15 [email protected] Clip bottom widgets in nav bar transition (flutter/flutter#166705)
2025-04-14 [email protected] Roll Skia from e7aa93f33a20 to 76cb5d4fba27 (13 revisions) (flutter/flutter#167132)
2025-04-14 [email protected] [fuchsia] Uprev test-scripts with FUCHSIA_READELF env (flutter/flutter#166929)
2025-04-14 [email protected] Cleanup links to flutter/engine in ci/builders docs (flutter/flutter#166916)
2025-04-14 [email protected] Roll Packages from 465bcff to f26b681 (1 revision) (flutter/flutter#167122)
2025-04-14 [email protected] [skwasm] Use `queueMicrotask` instead of `postMessage` when single-threaded (flutter/flutter#166997)
2025-04-14 [email protected] Remove some unused third party library build scripts (flutter/flutter#166960)
2025-04-14 [email protected] [reland] Fix regression in NDK version checking (flutter/flutter#167011)
2025-04-14 [email protected] Add network permissions information to the dart doc of network image.  (flutter/flutter#167110)
2025-04-14 [email protected] Include 3.29.3 and 3.29.2 changelog entries to master (flutter/flutter#166994)
2025-04-12 [email protected] [Impeller] various iOS cleanups. (flutter/flutter#166859)
2025-04-11 [email protected] [Impeller] reland: defer vulkan context initialization as long as possible. (flutter/flutter#167000)
2025-04-11 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Fix regression in NDK version checking (#166998)" (flutter/flutter#167007)
2025-04-11 [email protected] Fix regression in NDK version checking (flutter/flutter#166998)
2025-04-11 [email protected] [iOS] Infer autocorrect value from autofillHints (flutter/flutter#165637)
2025-04-11 [email protected] [Impeller] fix vulkan/gl color space decode. (flutter/flutter#166957)
2025-04-11 [email protected] modify toggle mode style with DatePickerTheme (flutter/flutter#164102)
2025-04-11 [email protected] [iOS/macOS] Add Xcode error if dev dependencies are incorrect (flutter/flutter#165916)
2025-04-11 98614782+auto-submit[bot]@users.noreply.github.com Reverts "[Impeller] defer vulkan context initialization as long as possible. (#166941)" (flutter/flutter#166990)
2025-04-11 [email protected] Roll Packages from 431dc61 to 465bcff (2 revisions) (flutter/flutter#166982)
2025-04-11 [email protected] [Impeller] defer vulkan context initialization as long as possible. (flutter/flutter#166941)
2025-04-11 [email protected] Reland "[ Widget Preview ] Add initial support for communications over the Dart Tooling Daemon (DTD) (#166698)" (flutter/flutter#166877)
2025-04-11 [email protected] [native assets] Use workspace pubspec for user-defines (flutter/flutter#166977)
2025-04-11 [email protected] [native assets] Roll dependencies (flutter/flutter#166969)
2025-04-11 [email protected] Roll Skia from 98deb838d3b8 to e7aa93f33a20 (1 revision) (flutter/flutter#166966)
2025-04-11 [email protected] Roll Fuchsia Linux SDK from vYisSsIgqw0mqFRVJ... to 91RIHvX0YC3wzD7qj... (flutter/flutter#166963)
2025-04-11 [email protected] [native assets] Support user-defines in pubspec (flutter/flutter#166940)
2025-04-11 [email protected] [Impeller] correct render pass bariers when resolve has mips. (flutter/flutter#166892)
2025-04-11 [email protected] [Impeller] re-make AHB swapchain lazy and allow usage on < 34 (flutter/flutter#166943)
2025-04-11 [email protected] Reland "SliverEnsureSemantics (#165589)" (flutter/flutter#166889)
2025-04-11 [email protected] Roll Skia from 171b2bf1e496 to 98deb838d3b8 (2 revisions) (flutter/flutter#166955)
...
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 14, 2025
@engine-flutter-autoroll
0d64c7292 [native assets] Support user-defines in pubspec (flutter/fl…
de0bf70 
…utter#166940)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 14, 2025
@engine-flutter-autoroll
0d64c7292 [native assets] Support user-defines in pubspec (flutter/fl…
7e14a52 
…utter#166940)
romanejaquez pushed a commit to romanejaquez/flutter that referenced this pull request Aug 14, 2025
@dcharkes @romanejaquez
[native assets] Support user-defines in pubspec (flutter#166940)
95d1eaa 
This PR is the dual of
https://dart-review.googlesource.com/c/sdk/+/420700 in the Dart SDK.

This PR adds support for user-defines for hooks in the root package
`pubspec.yaml`.

```yaml
hooks:
  user_defines:
    hook_user_defines: # package name
      magic_value: 1000
```

For more design considerations see:

* dart-lang/native#39

### Testing

This PR is covered by
`test/integration.shard/isolated/native_assets_test.dart`.

In this PR, we add a new test project
`dev/integration_tests/hook_user_defines/` and add a dependency on that
project in the mentioned test.

The integration test already covers `flutter run`, `flutter test`, and
`flutter build`.
romanejaquez pushed a commit to romanejaquez/flutter that referenced this pull request Aug 14, 2025
@dcharkes @romanejaquez
[native assets] Use workspace pubspec for user-defines (flutter#166977)
998e7cf 
If pub workspaces are used, then native assets are shared across the
whole pub workspace. Using a different user-define, invalidates the
cache. Therefore, we want to avoid having different user-defines in
different pubspecs belonging to the same workspace. So, only use the
workspace pubspec for user-defines.

Analogous Dart SDK CL:
https://dart-review.googlesource.com/c/sdk/+/422101

### Testing

Covered by the integration tests added in
flutter#166940 for user-defines.

### Design discussion

We could allow adding user-defines in root package pubspecs later, but
this will likely deteriorate caching behavior (either invalidating the
cache often, or requiring a cache directory per root package, which
increases latency for new root packages).

Also, we'd likely add command-line user-defines later, these are
expected to deteriorate caching behavior.

For design discussion, refer to:

* dart-lang/native#39
* dart-lang/native#2187
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 15, 2025
@engine-flutter-autoroll
0d64c7292 [native assets] Support user-defines in pubspec (flutter/fl…
94487a2 
…utter#166940)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 15, 2025
@engine-flutter-autoroll
0d64c7292 [native assets] Support user-defines in pubspec (flutter/fl…
3d40625 
…utter#166940)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 16, 2025
@engine-flutter-autoroll
0d64c7292 [native assets] Support user-defines in pubspec (flutter/fl…
4d257b1 
…utter#166940)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bkonyi bkonyi bkonyi approved these changes

@mosuem mosuem Awaiting requested review from mosuem

Assignees

No one assigned

Labels

a: desktop Running on desktop team-ios Owned by iOS platform team tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@dcharkes @bkonyi