Skip to content

Roll forward "Content aware hash moved..." with fix #166873

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
auto-submit merged 2 commits into from
Apr 9, 2025
Merged

Roll forward "Content aware hash moved..." with fix #166873

auto-submit merged 2 commits into from
Apr 9, 2025

Conversation

@matanlurey
Copy link
Contributor

@matanlurey matanlurey commented Apr 9, 2025

Rolls forward #166717.

Does not copy the README or DEPS files, and instead uses synthetic scratch files.

These files can change, so we can't possibly know how to hash them consistently.

@matanlurey matanlurey requested a review from jtmcdole April 9, 2025 18:41
@github-actions github-actions bot added tool Affects the "flutter" command-line tool. See also t: labels. team-tool Owned by Flutter Tool team d: docs/ flutter/flutter/docs, for contributors labels Apr 9, 2025
jtmcdole
jtmcdole approved these changes Apr 9, 2025
View reviewed changes
Copy link
Member

@jtmcdole jtmcdole left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm-seinfeld

@matanlurey matanlurey added the autosubmit Merge PR when tree becomes green via auto submit App label Apr 9, 2025
@auto-submit auto-submit bot added this pull request to the merge queue Apr 9, 2025
Merged via the queue into flutter:master with commit d2de6c6 Apr 9, 2025
150 checks passed
@flutter-dashboard flutter-dashboard bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Apr 9, 2025
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 10, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 10, 2025
@engine-flutter-autoroll
d2de6c65e Roll forward "Content aware hash moved..." with fix (flutte…
0a8561e 
…r/flutter#166873)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 10, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 10, 2025
@engine-flutter-autoroll
d2de6c65e Roll forward "Content aware hash moved..." with fix (flutte…
841540d 
…r/flutter#166873)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 10, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 10, 2025
@engine-flutter-autoroll
d2de6c65e Roll forward "Content aware hash moved..." with fix (flutte…
2fcb923 
…r/flutter#166873)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 10, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 10, 2025
@engine-flutter-autoroll
d2de6c65e Roll forward "Content aware hash moved..." with fix (flutte…
c7a4dfc 
…r/flutter#166873)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 10, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 10, 2025
@engine-flutter-autoroll
d2de6c65e Roll forward "Content aware hash moved..." with fix (flutte…
bf06b7b 
…r/flutter#166873)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 10, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 10, 2025
@engine-flutter-autoroll
d2de6c65e Roll forward "Content aware hash moved..." with fix (flutte…
4e784c3 
…r/flutter#166873)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 10, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 10, 2025
@engine-flutter-autoroll
d2de6c65e Roll forward "Content aware hash moved..." with fix (flutte…
ebe0fc4 
…r/flutter#166873)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 10, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 10, 2025
@engine-flutter-autoroll
d2de6c65e Roll forward "Content aware hash moved..." with fix (flutte…
6a6ca74 
…r/flutter#166873)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 10, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 10, 2025
@engine-flutter-autoroll
d2de6c65e Roll forward "Content aware hash moved..." with fix (flutte…
8f6e8e3 
…r/flutter#166873)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 11, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 11, 2025
@engine-flutter-autoroll
d2de6c65e Roll forward "Content aware hash moved..." with fix (flutte…
acbf596 
…r/flutter#166873)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 11, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 11, 2025
@engine-flutter-autoroll
d2de6c65e Roll forward "Content aware hash moved..." with fix (flutte…
dda5246 
…r/flutter#166873)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 11, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 11, 2025
@engine-flutter-autoroll
d2de6c65e Roll forward "Content aware hash moved..." with fix (flutte…
d92592a 
…r/flutter#166873)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 11, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 11, 2025
@engine-flutter-autoroll
d2de6c65e Roll forward "Content aware hash moved..." with fix (flutte…
288a01d 
…r/flutter#166873)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 12, 2025
@engine-flutter-autoroll
d2de6c65e Roll forward "Content aware hash moved..." with fix (flutte…
7860755 
…r/flutter#166873)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 12, 2025
@engine-flutter-autoroll
d2de6c65e Roll forward "Content aware hash moved..." with fix (flutte…
dfca53c 
…r/flutter#166873)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 13, 2025
@engine-flutter-autoroll
d2de6c65e Roll forward "Content aware hash moved..." with fix (flutte…
feab210 
…r/flutter#166873)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 14, 2025
@engine-flutter-autoroll
d2de6c65e Roll forward "Content aware hash moved..." with fix (flutte…
91d9314 
…r/flutter#166873)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 14, 2025
@engine-flutter-autoroll
d2de6c65e Roll forward "Content aware hash moved..." with fix (flutte…
5679044 
…r/flutter#166873)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 14, 2025
@engine-flutter-autoroll
d2de6c65e Roll forward "Content aware hash moved..." with fix (flutte…
8882612 
…r/flutter#166873)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 14, 2025
@engine-flutter-autoroll
d2de6c65e Roll forward "Content aware hash moved..." with fix (flutte…
727fc86 
…r/flutter#166873)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 14, 2025
@engine-flutter-autoroll
d2de6c65e Roll forward "Content aware hash moved..." with fix (flutte…
ec83a1b 
…r/flutter#166873)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 14, 2025
@engine-flutter-autoroll
d2de6c65e Roll forward "Content aware hash moved..." with fix (flutte…
4322e32 
…r/flutter#166873)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 14, 2025
@engine-flutter-autoroll
d2de6c65e Roll forward "Content aware hash moved..." with fix (flutte…
c029d07 
…r/flutter#166873)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 14, 2025
@engine-flutter-autoroll
d2de6c65e Roll forward "Content aware hash moved..." with fix (flutte…
1123625 
…r/flutter#166873)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 15, 2025
@engine-flutter-autoroll
d2de6c65e Roll forward "Content aware hash moved..." with fix (flutte…
fcab073 
…r/flutter#166873)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 15, 2025
@engine-flutter-autoroll
d2de6c65e Roll forward "Content aware hash moved..." with fix (flutte…
99b42be 
…r/flutter#166873)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 15, 2025
@engine-flutter-autoroll
d2de6c65e Roll forward "Content aware hash moved..." with fix (flutte…
7adf552 
…r/flutter#166873)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 15, 2025
@engine-flutter-autoroll
d2de6c65e Roll forward "Content aware hash moved..." with fix (flutte…
76c623a 
…r/flutter#166873)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 15, 2025
@engine-flutter-autoroll
d2de6c65e Roll forward "Content aware hash moved..." with fix (flutte…
f776ecb 
…r/flutter#166873)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 14, 2025
@engine-flutter-autoroll
d2de6c65e Roll forward "Content aware hash moved..." with fix (flutte…
089b95b 
…r/flutter#166873)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 14, 2025
@engine-flutter-autoroll
d2de6c65e Roll forward "Content aware hash moved..." with fix (flutte…
07bb8a4 
…r/flutter#166873)
romanejaquez pushed a commit to romanejaquez/flutter that referenced this pull request Aug 14, 2025
@matanlurey @romanejaquez
Roll forward "Content aware hash moved..." with fix (flutter#166873)
f7f767a 
Rolls forward flutter#166717.

Does not copy the `README` or `DEPS` files, and instead uses synthetic
scratch files.

These files can change, so we can't possibly know how to hash them
consistently.
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 15, 2025
@engine-flutter-autoroll
d2de6c65e Roll forward "Content aware hash moved..." with fix (flutte…
941abfe 
…r/flutter#166873)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 15, 2025
@engine-flutter-autoroll
d2de6c65e Roll forward "Content aware hash moved..." with fix (flutte…
b912699 
…r/flutter#166873)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 16, 2025
@engine-flutter-autoroll
d2de6c65e Roll forward "Content aware hash moved..." with fix (flutte…
047c8c8 
…r/flutter#166873)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jtmcdole jtmcdole jtmcdole approved these changes

Assignees

No one assigned

Labels

d: docs/ flutter/flutter/docs, for contributors team-tool Owned by Flutter Tool team tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@matanlurey @jtmcdole