-
Notifications
You must be signed in to change notification settings - Fork 29.7k
Persistent CupertinoListTile leading and trailing #166799
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
It looks like this pull request may not have tests. Please make sure to add tests or get an explicit test exemption before merging. If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.If you believe this PR qualifies for a test exemption, contact "@test-exemption-reviewer" in the #hackers channel in Discord (don't just cc them here, they won't see it!). The test exemption team is a small volunteer group, so all reviewers should feel empowered to ask for tests, without delegating that responsibility entirely to the test exemption group. |
|
This pull request has been changed to a draft. The currently pending flutter-gold status will not be able to resolve until a new commit is pushed or the change is marked ready for review again. For more guidance, visit Writing a golden file test for Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
|
Could you add an explanation as to why the states were lost without the global keys? Is it because of the Container? |
LongCatIsLooong
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Manual roll Flutter from 30e53b0 to db68c950c599 (98 revisions) Manual roll requested by [email protected] flutter/flutter@30e53b0...db68c95 2025-04-15 [email protected] [customer_testing] Pick up the fix for issue found by flutter/dart hh. (flutter/flutter#167212) 2025-04-15 [email protected] Roll Packages from f26b681 to 2fcc403 (4 revisions) (flutter/flutter#167218) 2025-04-15 [email protected] Fix: Update sheet route bottom padding with top padding (flutter/flutter#164473) 2025-04-15 [email protected] Add Irish(ga) to Flutter (flutter/flutter#167129) 2025-04-15 [email protected] Roll Fuchsia Linux SDK from 91RIHvX0YC3wzD7qj... to 7bWzHwIPBTyU6R9nO... (flutter/flutter#167213) 2025-04-15 [email protected] Change saturation calculation for HSLColor.fromColor (flutter/flutter#166639) 2025-04-15 [email protected] fix: Update time picker dialog input size (flutter/flutter#163184) 2025-04-15 [email protected] Clarify how/when `FLUTTER_PREBUILT_ENGINE_VERSION` is passed in Flutter's CI (flutter/flutter#167204) 2025-04-15 [email protected] [ Widget Preview ] Add support for `theme` and `brightness` properties on `Preview` (flutter/flutter#167001) 2025-04-15 [email protected] Update `tests.version` to fix `customer_testing`. (flutter/flutter#167206) 2025-04-15 [email protected] Persistent CupertinoListTile leading and trailing (flutter/flutter#166799) 2025-04-15 [email protected] Add buildroot compatibility for HWASAN. (flutter/flutter#167133) 2025-04-15 [email protected] Correct max height calculation to fade and animate insets on scroll in CupertinoSearchTextField (flutter/flutter#166569) 2025-04-15 [email protected] Clip bottom widgets in nav bar transition (flutter/flutter#166705) 2025-04-14 [email protected] Roll Skia from e7aa93f33a20 to 76cb5d4fba27 (13 revisions) (flutter/flutter#167132) 2025-04-14 [email protected] [fuchsia] Uprev test-scripts with FUCHSIA_READELF env (flutter/flutter#166929) 2025-04-14 [email protected] Cleanup links to flutter/engine in ci/builders docs (flutter/flutter#166916) 2025-04-14 [email protected] Roll Packages from 465bcff to f26b681 (1 revision) (flutter/flutter#167122) 2025-04-14 [email protected] [skwasm] Use `queueMicrotask` instead of `postMessage` when single-threaded (flutter/flutter#166997) 2025-04-14 [email protected] Remove some unused third party library build scripts (flutter/flutter#166960) 2025-04-14 [email protected] [reland] Fix regression in NDK version checking (flutter/flutter#167011) 2025-04-14 [email protected] Add network permissions information to the dart doc of network image. (flutter/flutter#167110) 2025-04-14 [email protected] Include 3.29.3 and 3.29.2 changelog entries to master (flutter/flutter#166994) 2025-04-12 [email protected] [Impeller] various iOS cleanups. (flutter/flutter#166859) 2025-04-11 [email protected] [Impeller] reland: defer vulkan context initialization as long as possible. (flutter/flutter#167000) 2025-04-11 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Fix regression in NDK version checking (#166998)" (flutter/flutter#167007) 2025-04-11 [email protected] Fix regression in NDK version checking (flutter/flutter#166998) 2025-04-11 [email protected] [iOS] Infer autocorrect value from autofillHints (flutter/flutter#165637) 2025-04-11 [email protected] [Impeller] fix vulkan/gl color space decode. (flutter/flutter#166957) 2025-04-11 [email protected] modify toggle mode style with DatePickerTheme (flutter/flutter#164102) 2025-04-11 [email protected] [iOS/macOS] Add Xcode error if dev dependencies are incorrect (flutter/flutter#165916) 2025-04-11 98614782+auto-submit[bot]@users.noreply.github.com Reverts "[Impeller] defer vulkan context initialization as long as possible. (#166941)" (flutter/flutter#166990) 2025-04-11 [email protected] Roll Packages from 431dc61 to 465bcff (2 revisions) (flutter/flutter#166982) 2025-04-11 [email protected] [Impeller] defer vulkan context initialization as long as possible. (flutter/flutter#166941) 2025-04-11 [email protected] Reland "[ Widget Preview ] Add initial support for communications over the Dart Tooling Daemon (DTD) (#166698)" (flutter/flutter#166877) 2025-04-11 [email protected] [native assets] Use workspace pubspec for user-defines (flutter/flutter#166977) 2025-04-11 [email protected] [native assets] Roll dependencies (flutter/flutter#166969) 2025-04-11 [email protected] Roll Skia from 98deb838d3b8 to e7aa93f33a20 (1 revision) (flutter/flutter#166966) 2025-04-11 [email protected] Roll Fuchsia Linux SDK from vYisSsIgqw0mqFRVJ... to 91RIHvX0YC3wzD7qj... (flutter/flutter#166963) 2025-04-11 [email protected] [native assets] Support user-defines in pubspec (flutter/flutter#166940) 2025-04-11 [email protected] [Impeller] correct render pass bariers when resolve has mips. (flutter/flutter#166892) 2025-04-11 [email protected] [Impeller] re-make AHB swapchain lazy and allow usage on < 34 (flutter/flutter#166943) 2025-04-11 [email protected] Reland "SliverEnsureSemantics (#165589)" (flutter/flutter#166889) 2025-04-11 [email protected] Roll Skia from 171b2bf1e496 to 98deb838d3b8 (2 revisions) (flutter/flutter#166955) ...
The bug occurs because the background color passed into the underlying `Container` changes from null to `backgroundColorActivated`. Under the hood, the `Container` wraps its child in a `ColoredBox` only if the color is non-null. So the extra wrapping with a `ColoredBox` happening mid-animation breaks reparenting, causing the widgets to be replaced/inflated instead of updated. ### Before https://github.com/user-attachments/assets/ca0b657a-1340-405f-8c1d-34b34366b994 ### After https://github.com/user-attachments/assets/8445c55c-0d5d-4b5f-96d2-4f12d908bdec Fixes [CupertinoListTile animations are not running when pressing longer](flutter#153225) <details> <summary>Sample code</summary> ```dart import 'package:flutter/cupertino.dart'; void main() => runApp(const ListTileApp()); class ListTileApp extends StatelessWidget { const ListTileApp({super.key}); @OverRide Widget build(BuildContext context) { return CupertinoApp(home: const ListTileExample()); } } class ListTileExample extends StatefulWidget { const ListTileExample({super.key}); @OverRide State<ListTileExample> createState() => _ListTileExampleState(); } class _ListTileExampleState extends State<ListTileExample> { bool _pushedToggle = false; void _toggle() { setState(() { _pushedToggle = !_pushedToggle; }); } @OverRide Widget build(BuildContext context) { return CupertinoPageScaffold( child: Center( child: SizedBox( height: 40, child: CupertinoListTile( onTap: _toggle, title: Center( child: Text( 'Toggle', ), ), leading: CupertinoSwitch( value: _pushedToggle, onChanged: (_) {}, ), trailing: CupertinoSwitch( value: _pushedToggle, onChanged: (_) {}, )), ), ), ); } } ``` </details>
…(#9092) Manual roll Flutter from 30e53b0d9caa to db68c950c599 (98 revisions) Manual roll requested by [email protected] flutter/flutter@30e53b0...db68c95 2025-04-15 [email protected] [customer_testing] Pick up the fix for issue found by flutter/dart hh. (flutter/flutter#167212) 2025-04-15 [email protected] Roll Packages from 853e96a to a5ed6cb (4 revisions) (flutter/flutter#167218) 2025-04-15 [email protected] Fix: Update sheet route bottom padding with top padding (flutter/flutter#164473) 2025-04-15 [email protected] Add Irish(ga) to Flutter (flutter/flutter#167129) 2025-04-15 [email protected] Roll Fuchsia Linux SDK from 91RIHvX0YC3wzD7qj... to 7bWzHwIPBTyU6R9nO... (flutter/flutter#167213) 2025-04-15 [email protected] Change saturation calculation for HSLColor.fromColor (flutter/flutter#166639) 2025-04-15 [email protected] fix: Update time picker dialog input size (flutter/flutter#163184) 2025-04-15 [email protected] Clarify how/when `FLUTTER_PREBUILT_ENGINE_VERSION` is passed in Flutter's CI (flutter/flutter#167204) 2025-04-15 [email protected] [ Widget Preview ] Add support for `theme` and `brightness` properties on `Preview` (flutter/flutter#167001) 2025-04-15 [email protected] Update `tests.version` to fix `customer_testing`. (flutter/flutter#167206) 2025-04-15 [email protected] Persistent CupertinoListTile leading and trailing (flutter/flutter#166799) 2025-04-15 [email protected] Add buildroot compatibility for HWASAN. (flutter/flutter#167133) 2025-04-15 [email protected] Correct max height calculation to fade and animate insets on scroll in CupertinoSearchTextField (flutter/flutter#166569) 2025-04-15 [email protected] Clip bottom widgets in nav bar transition (flutter/flutter#166705) 2025-04-14 [email protected] Roll Skia from e7aa93f33a20 to 76cb5d4fba27 (13 revisions) (flutter/flutter#167132) 2025-04-14 [email protected] [fuchsia] Uprev test-scripts with FUCHSIA_READELF env (flutter/flutter#166929) 2025-04-14 [email protected] Cleanup links to flutter/engine in ci/builders docs (flutter/flutter#166916) 2025-04-14 [email protected] Roll Packages from 4808eff to 853e96a (1 revision) (flutter/flutter#167122) 2025-04-14 [email protected] [skwasm] Use `queueMicrotask` instead of `postMessage` when single-threaded (flutter/flutter#166997) 2025-04-14 [email protected] Remove some unused third party library build scripts (flutter/flutter#166960) 2025-04-14 [email protected] [reland] Fix regression in NDK version checking (flutter/flutter#167011) 2025-04-14 [email protected] Add network permissions information to the dart doc of network image. (flutter/flutter#167110) 2025-04-14 [email protected] Include 3.29.3 and 3.29.2 changelog entries to master (flutter/flutter#166994) 2025-04-12 [email protected] [Impeller] various iOS cleanups. (flutter/flutter#166859) 2025-04-11 [email protected] [Impeller] reland: defer vulkan context initialization as long as possible. (flutter/flutter#167000) 2025-04-11 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Fix regression in NDK version checking (#166998)" (flutter/flutter#167007) 2025-04-11 [email protected] Fix regression in NDK version checking (flutter/flutter#166998) 2025-04-11 [email protected] [iOS] Infer autocorrect value from autofillHints (flutter/flutter#165637) 2025-04-11 [email protected] [Impeller] fix vulkan/gl color space decode. (flutter/flutter#166957) 2025-04-11 [email protected] modify toggle mode style with DatePickerTheme (flutter/flutter#164102) 2025-04-11 [email protected] [iOS/macOS] Add Xcode error if dev dependencies are incorrect (flutter/flutter#165916) 2025-04-11 98614782+auto-submit[bot]@users.noreply.github.com Reverts "[Impeller] defer vulkan context initialization as long as possible. (#166941)" (flutter/flutter#166990) 2025-04-11 [email protected] Roll Packages from b2c45f9 to 4808eff (2 revisions) (flutter/flutter#166982) 2025-04-11 [email protected] [Impeller] defer vulkan context initialization as long as possible. (flutter/flutter#166941) 2025-04-11 [email protected] Reland "[ Widget Preview ] Add initial support for communications over the Dart Tooling Daemon (DTD) (#166698)" (flutter/flutter#166877) 2025-04-11 [email protected] [native assets] Use workspace pubspec for user-defines (flutter/flutter#166977) 2025-04-11 [email protected] [native assets] Roll dependencies (flutter/flutter#166969) 2025-04-11 [email protected] Roll Skia from 98deb838d3b8 to e7aa93f33a20 (1 revision) (flutter/flutter#166966) 2025-04-11 [email protected] Roll Fuchsia Linux SDK from vYisSsIgqw0mqFRVJ... to 91RIHvX0YC3wzD7qj... (flutter/flutter#166963) 2025-04-11 [email protected] [native assets] Support user-defines in pubspec (flutter/flutter#166940) 2025-04-11 [email protected] [Impeller] correct render pass bariers when resolve has mips. (flutter/flutter#166892) 2025-04-11 [email protected] [Impeller] re-make AHB swapchain lazy and allow usage on < 34 (flutter/flutter#166943) 2025-04-11 [email protected] Reland "SliverEnsureSemantics (#165589)" (flutter/flutter#166889) 2025-04-11 [email protected] Roll Skia from 171b2bf1e496 to 98deb838d3b8 (2 revisions) (flutter/flutter#166955) ...
…ter#9092) Manual roll Flutter from 30e53b0 to db68c950c599 (98 revisions) Manual roll requested by [email protected] flutter/flutter@30e53b0...db68c95 2025-04-15 [email protected] [customer_testing] Pick up the fix for issue found by flutter/dart hh. (flutter/flutter#167212) 2025-04-15 [email protected] Roll Packages from f26b681 to 2fcc403 (4 revisions) (flutter/flutter#167218) 2025-04-15 [email protected] Fix: Update sheet route bottom padding with top padding (flutter/flutter#164473) 2025-04-15 [email protected] Add Irish(ga) to Flutter (flutter/flutter#167129) 2025-04-15 [email protected] Roll Fuchsia Linux SDK from 91RIHvX0YC3wzD7qj... to 7bWzHwIPBTyU6R9nO... (flutter/flutter#167213) 2025-04-15 [email protected] Change saturation calculation for HSLColor.fromColor (flutter/flutter#166639) 2025-04-15 [email protected] fix: Update time picker dialog input size (flutter/flutter#163184) 2025-04-15 [email protected] Clarify how/when `FLUTTER_PREBUILT_ENGINE_VERSION` is passed in Flutter's CI (flutter/flutter#167204) 2025-04-15 [email protected] [ Widget Preview ] Add support for `theme` and `brightness` properties on `Preview` (flutter/flutter#167001) 2025-04-15 [email protected] Update `tests.version` to fix `customer_testing`. (flutter/flutter#167206) 2025-04-15 [email protected] Persistent CupertinoListTile leading and trailing (flutter/flutter#166799) 2025-04-15 [email protected] Add buildroot compatibility for HWASAN. (flutter/flutter#167133) 2025-04-15 [email protected] Correct max height calculation to fade and animate insets on scroll in CupertinoSearchTextField (flutter/flutter#166569) 2025-04-15 [email protected] Clip bottom widgets in nav bar transition (flutter/flutter#166705) 2025-04-14 [email protected] Roll Skia from e7aa93f33a20 to 76cb5d4fba27 (13 revisions) (flutter/flutter#167132) 2025-04-14 [email protected] [fuchsia] Uprev test-scripts with FUCHSIA_READELF env (flutter/flutter#166929) 2025-04-14 [email protected] Cleanup links to flutter/engine in ci/builders docs (flutter/flutter#166916) 2025-04-14 [email protected] Roll Packages from 465bcff to f26b681 (1 revision) (flutter/flutter#167122) 2025-04-14 [email protected] [skwasm] Use `queueMicrotask` instead of `postMessage` when single-threaded (flutter/flutter#166997) 2025-04-14 [email protected] Remove some unused third party library build scripts (flutter/flutter#166960) 2025-04-14 [email protected] [reland] Fix regression in NDK version checking (flutter/flutter#167011) 2025-04-14 [email protected] Add network permissions information to the dart doc of network image. (flutter/flutter#167110) 2025-04-14 [email protected] Include 3.29.3 and 3.29.2 changelog entries to master (flutter/flutter#166994) 2025-04-12 [email protected] [Impeller] various iOS cleanups. (flutter/flutter#166859) 2025-04-11 [email protected] [Impeller] reland: defer vulkan context initialization as long as possible. (flutter/flutter#167000) 2025-04-11 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Fix regression in NDK version checking (#166998)" (flutter/flutter#167007) 2025-04-11 [email protected] Fix regression in NDK version checking (flutter/flutter#166998) 2025-04-11 [email protected] [iOS] Infer autocorrect value from autofillHints (flutter/flutter#165637) 2025-04-11 [email protected] [Impeller] fix vulkan/gl color space decode. (flutter/flutter#166957) 2025-04-11 [email protected] modify toggle mode style with DatePickerTheme (flutter/flutter#164102) 2025-04-11 [email protected] [iOS/macOS] Add Xcode error if dev dependencies are incorrect (flutter/flutter#165916) 2025-04-11 98614782+auto-submit[bot]@users.noreply.github.com Reverts "[Impeller] defer vulkan context initialization as long as possible. (#166941)" (flutter/flutter#166990) 2025-04-11 [email protected] Roll Packages from 431dc61 to 465bcff (2 revisions) (flutter/flutter#166982) 2025-04-11 [email protected] [Impeller] defer vulkan context initialization as long as possible. (flutter/flutter#166941) 2025-04-11 [email protected] Reland "[ Widget Preview ] Add initial support for communications over the Dart Tooling Daemon (DTD) (#166698)" (flutter/flutter#166877) 2025-04-11 [email protected] [native assets] Use workspace pubspec for user-defines (flutter/flutter#166977) 2025-04-11 [email protected] [native assets] Roll dependencies (flutter/flutter#166969) 2025-04-11 [email protected] Roll Skia from 98deb838d3b8 to e7aa93f33a20 (1 revision) (flutter/flutter#166966) 2025-04-11 [email protected] Roll Fuchsia Linux SDK from vYisSsIgqw0mqFRVJ... to 91RIHvX0YC3wzD7qj... (flutter/flutter#166963) 2025-04-11 [email protected] [native assets] Support user-defines in pubspec (flutter/flutter#166940) 2025-04-11 [email protected] [Impeller] correct render pass bariers when resolve has mips. (flutter/flutter#166892) 2025-04-11 [email protected] [Impeller] re-make AHB swapchain lazy and allow usage on < 34 (flutter/flutter#166943) 2025-04-11 [email protected] Reland "SliverEnsureSemantics (#165589)" (flutter/flutter#166889) 2025-04-11 [email protected] Roll Skia from 171b2bf1e496 to 98deb838d3b8 (2 revisions) (flutter/flutter#166955) ...
…ter#9092) Manual roll Flutter from 30e53b0 to db68c950c599 (98 revisions) Manual roll requested by [email protected] flutter/flutter@30e53b0...db68c95 2025-04-15 [email protected] [customer_testing] Pick up the fix for issue found by flutter/dart hh. (flutter/flutter#167212) 2025-04-15 [email protected] Roll Packages from f26b681 to 2fcc403 (4 revisions) (flutter/flutter#167218) 2025-04-15 [email protected] Fix: Update sheet route bottom padding with top padding (flutter/flutter#164473) 2025-04-15 [email protected] Add Irish(ga) to Flutter (flutter/flutter#167129) 2025-04-15 [email protected] Roll Fuchsia Linux SDK from 91RIHvX0YC3wzD7qj... to 7bWzHwIPBTyU6R9nO... (flutter/flutter#167213) 2025-04-15 [email protected] Change saturation calculation for HSLColor.fromColor (flutter/flutter#166639) 2025-04-15 [email protected] fix: Update time picker dialog input size (flutter/flutter#163184) 2025-04-15 [email protected] Clarify how/when `FLUTTER_PREBUILT_ENGINE_VERSION` is passed in Flutter's CI (flutter/flutter#167204) 2025-04-15 [email protected] [ Widget Preview ] Add support for `theme` and `brightness` properties on `Preview` (flutter/flutter#167001) 2025-04-15 [email protected] Update `tests.version` to fix `customer_testing`. (flutter/flutter#167206) 2025-04-15 [email protected] Persistent CupertinoListTile leading and trailing (flutter/flutter#166799) 2025-04-15 [email protected] Add buildroot compatibility for HWASAN. (flutter/flutter#167133) 2025-04-15 [email protected] Correct max height calculation to fade and animate insets on scroll in CupertinoSearchTextField (flutter/flutter#166569) 2025-04-15 [email protected] Clip bottom widgets in nav bar transition (flutter/flutter#166705) 2025-04-14 [email protected] Roll Skia from e7aa93f33a20 to 76cb5d4fba27 (13 revisions) (flutter/flutter#167132) 2025-04-14 [email protected] [fuchsia] Uprev test-scripts with FUCHSIA_READELF env (flutter/flutter#166929) 2025-04-14 [email protected] Cleanup links to flutter/engine in ci/builders docs (flutter/flutter#166916) 2025-04-14 [email protected] Roll Packages from 465bcff to f26b681 (1 revision) (flutter/flutter#167122) 2025-04-14 [email protected] [skwasm] Use `queueMicrotask` instead of `postMessage` when single-threaded (flutter/flutter#166997) 2025-04-14 [email protected] Remove some unused third party library build scripts (flutter/flutter#166960) 2025-04-14 [email protected] [reland] Fix regression in NDK version checking (flutter/flutter#167011) 2025-04-14 [email protected] Add network permissions information to the dart doc of network image. (flutter/flutter#167110) 2025-04-14 [email protected] Include 3.29.3 and 3.29.2 changelog entries to master (flutter/flutter#166994) 2025-04-12 [email protected] [Impeller] various iOS cleanups. (flutter/flutter#166859) 2025-04-11 [email protected] [Impeller] reland: defer vulkan context initialization as long as possible. (flutter/flutter#167000) 2025-04-11 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Fix regression in NDK version checking (#166998)" (flutter/flutter#167007) 2025-04-11 [email protected] Fix regression in NDK version checking (flutter/flutter#166998) 2025-04-11 [email protected] [iOS] Infer autocorrect value from autofillHints (flutter/flutter#165637) 2025-04-11 [email protected] [Impeller] fix vulkan/gl color space decode. (flutter/flutter#166957) 2025-04-11 [email protected] modify toggle mode style with DatePickerTheme (flutter/flutter#164102) 2025-04-11 [email protected] [iOS/macOS] Add Xcode error if dev dependencies are incorrect (flutter/flutter#165916) 2025-04-11 98614782+auto-submit[bot]@users.noreply.github.com Reverts "[Impeller] defer vulkan context initialization as long as possible. (#166941)" (flutter/flutter#166990) 2025-04-11 [email protected] Roll Packages from 431dc61 to 465bcff (2 revisions) (flutter/flutter#166982) 2025-04-11 [email protected] [Impeller] defer vulkan context initialization as long as possible. (flutter/flutter#166941) 2025-04-11 [email protected] Reland "[ Widget Preview ] Add initial support for communications over the Dart Tooling Daemon (DTD) (#166698)" (flutter/flutter#166877) 2025-04-11 [email protected] [native assets] Use workspace pubspec for user-defines (flutter/flutter#166977) 2025-04-11 [email protected] [native assets] Roll dependencies (flutter/flutter#166969) 2025-04-11 [email protected] Roll Skia from 98deb838d3b8 to e7aa93f33a20 (1 revision) (flutter/flutter#166966) 2025-04-11 [email protected] Roll Fuchsia Linux SDK from vYisSsIgqw0mqFRVJ... to 91RIHvX0YC3wzD7qj... (flutter/flutter#166963) 2025-04-11 [email protected] [native assets] Support user-defines in pubspec (flutter/flutter#166940) 2025-04-11 [email protected] [Impeller] correct render pass bariers when resolve has mips. (flutter/flutter#166892) 2025-04-11 [email protected] [Impeller] re-make AHB swapchain lazy and allow usage on < 34 (flutter/flutter#166943) 2025-04-11 [email protected] Reland "SliverEnsureSemantics (#165589)" (flutter/flutter#166889) 2025-04-11 [email protected] Roll Skia from 171b2bf1e496 to 98deb838d3b8 (2 revisions) (flutter/flutter#166955) ...
…ter#9092) Manual roll Flutter from 30e53b0 to db68c950c599 (98 revisions) Manual roll requested by [email protected] flutter/flutter@30e53b0...db68c95 2025-04-15 [email protected] [customer_testing] Pick up the fix for issue found by flutter/dart hh. (flutter/flutter#167212) 2025-04-15 [email protected] Roll Packages from f26b681 to 2fcc403 (4 revisions) (flutter/flutter#167218) 2025-04-15 [email protected] Fix: Update sheet route bottom padding with top padding (flutter/flutter#164473) 2025-04-15 [email protected] Add Irish(ga) to Flutter (flutter/flutter#167129) 2025-04-15 [email protected] Roll Fuchsia Linux SDK from 91RIHvX0YC3wzD7qj... to 7bWzHwIPBTyU6R9nO... (flutter/flutter#167213) 2025-04-15 [email protected] Change saturation calculation for HSLColor.fromColor (flutter/flutter#166639) 2025-04-15 [email protected] fix: Update time picker dialog input size (flutter/flutter#163184) 2025-04-15 [email protected] Clarify how/when `FLUTTER_PREBUILT_ENGINE_VERSION` is passed in Flutter's CI (flutter/flutter#167204) 2025-04-15 [email protected] [ Widget Preview ] Add support for `theme` and `brightness` properties on `Preview` (flutter/flutter#167001) 2025-04-15 [email protected] Update `tests.version` to fix `customer_testing`. (flutter/flutter#167206) 2025-04-15 [email protected] Persistent CupertinoListTile leading and trailing (flutter/flutter#166799) 2025-04-15 [email protected] Add buildroot compatibility for HWASAN. (flutter/flutter#167133) 2025-04-15 [email protected] Correct max height calculation to fade and animate insets on scroll in CupertinoSearchTextField (flutter/flutter#166569) 2025-04-15 [email protected] Clip bottom widgets in nav bar transition (flutter/flutter#166705) 2025-04-14 [email protected] Roll Skia from e7aa93f33a20 to 76cb5d4fba27 (13 revisions) (flutter/flutter#167132) 2025-04-14 [email protected] [fuchsia] Uprev test-scripts with FUCHSIA_READELF env (flutter/flutter#166929) 2025-04-14 [email protected] Cleanup links to flutter/engine in ci/builders docs (flutter/flutter#166916) 2025-04-14 [email protected] Roll Packages from 465bcff to f26b681 (1 revision) (flutter/flutter#167122) 2025-04-14 [email protected] [skwasm] Use `queueMicrotask` instead of `postMessage` when single-threaded (flutter/flutter#166997) 2025-04-14 [email protected] Remove some unused third party library build scripts (flutter/flutter#166960) 2025-04-14 [email protected] [reland] Fix regression in NDK version checking (flutter/flutter#167011) 2025-04-14 [email protected] Add network permissions information to the dart doc of network image. (flutter/flutter#167110) 2025-04-14 [email protected] Include 3.29.3 and 3.29.2 changelog entries to master (flutter/flutter#166994) 2025-04-12 [email protected] [Impeller] various iOS cleanups. (flutter/flutter#166859) 2025-04-11 [email protected] [Impeller] reland: defer vulkan context initialization as long as possible. (flutter/flutter#167000) 2025-04-11 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Fix regression in NDK version checking (#166998)" (flutter/flutter#167007) 2025-04-11 [email protected] Fix regression in NDK version checking (flutter/flutter#166998) 2025-04-11 [email protected] [iOS] Infer autocorrect value from autofillHints (flutter/flutter#165637) 2025-04-11 [email protected] [Impeller] fix vulkan/gl color space decode. (flutter/flutter#166957) 2025-04-11 [email protected] modify toggle mode style with DatePickerTheme (flutter/flutter#164102) 2025-04-11 [email protected] [iOS/macOS] Add Xcode error if dev dependencies are incorrect (flutter/flutter#165916) 2025-04-11 98614782+auto-submit[bot]@users.noreply.github.com Reverts "[Impeller] defer vulkan context initialization as long as possible. (#166941)" (flutter/flutter#166990) 2025-04-11 [email protected] Roll Packages from 431dc61 to 465bcff (2 revisions) (flutter/flutter#166982) 2025-04-11 [email protected] [Impeller] defer vulkan context initialization as long as possible. (flutter/flutter#166941) 2025-04-11 [email protected] Reland "[ Widget Preview ] Add initial support for communications over the Dart Tooling Daemon (DTD) (#166698)" (flutter/flutter#166877) 2025-04-11 [email protected] [native assets] Use workspace pubspec for user-defines (flutter/flutter#166977) 2025-04-11 [email protected] [native assets] Roll dependencies (flutter/flutter#166969) 2025-04-11 [email protected] Roll Skia from 98deb838d3b8 to e7aa93f33a20 (1 revision) (flutter/flutter#166966) 2025-04-11 [email protected] Roll Fuchsia Linux SDK from vYisSsIgqw0mqFRVJ... to 91RIHvX0YC3wzD7qj... (flutter/flutter#166963) 2025-04-11 [email protected] [native assets] Support user-defines in pubspec (flutter/flutter#166940) 2025-04-11 [email protected] [Impeller] correct render pass bariers when resolve has mips. (flutter/flutter#166892) 2025-04-11 [email protected] [Impeller] re-make AHB swapchain lazy and allow usage on < 34 (flutter/flutter#166943) 2025-04-11 [email protected] Reland "SliverEnsureSemantics (#165589)" (flutter/flutter#166889) 2025-04-11 [email protected] Roll Skia from 171b2bf1e496 to 98deb838d3b8 (2 revisions) (flutter/flutter#166955) ...
The bug occurs because the background color passed into the underlying `Container` changes from null to `backgroundColorActivated`. Under the hood, the `Container` wraps its child in a `ColoredBox` only if the color is non-null. So the extra wrapping with a `ColoredBox` happening mid-animation breaks reparenting, causing the widgets to be replaced/inflated instead of updated. ### Before https://github.com/user-attachments/assets/ca0b657a-1340-405f-8c1d-34b34366b994 ### After https://github.com/user-attachments/assets/8445c55c-0d5d-4b5f-96d2-4f12d908bdec Fixes [CupertinoListTile animations are not running when pressing longer](flutter#153225) <details> <summary>Sample code</summary> ```dart import 'package:flutter/cupertino.dart'; void main() => runApp(const ListTileApp()); class ListTileApp extends StatelessWidget { const ListTileApp({super.key}); @OverRide Widget build(BuildContext context) { return CupertinoApp(home: const ListTileExample()); } } class ListTileExample extends StatefulWidget { const ListTileExample({super.key}); @OverRide State<ListTileExample> createState() => _ListTileExampleState(); } class _ListTileExampleState extends State<ListTileExample> { bool _pushedToggle = false; void _toggle() { setState(() { _pushedToggle = !_pushedToggle; }); } @OverRide Widget build(BuildContext context) { return CupertinoPageScaffold( child: Center( child: SizedBox( height: 40, child: CupertinoListTile( onTap: _toggle, title: Center( child: Text( 'Toggle', ), ), leading: CupertinoSwitch( value: _pushedToggle, onChanged: (_) {}, ), trailing: CupertinoSwitch( value: _pushedToggle, onChanged: (_) {}, )), ), ), ); } } ``` </details>
The bug occurs because the background color passed into the underlying
Containerchanges from null tobackgroundColorActivated. Under the hood, theContainerwraps its child in aColoredBoxonly if the color is non-null. So the extra wrapping with aColoredBoxhappening mid-animation breaks reparenting, causing the widgets to be replaced/inflated instead of updated.Before
list_tile_before.mov
After
list_tile_after.mov
Fixes CupertinoListTile animations are not running when pressing longer
Sample code