-
Notifications
You must be signed in to change notification settings - Fork 29.7k
[Impeller] Speed up vulkan startup time by re-using existing vulkan context. #166784
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
CI had a failure that stopped further tests from running. We need to investigate to determine the root cause. SHA at time of execution: 66ae828. Possible causes:
A blank commit, or merging to head, will be required to resume running CI for this PR. Error Details: Stack trace: |
|
autosubmit label was removed for flutter/flutter/166784, because - The status or check suite Google testing has failed. Please fix the issues identified (or deflake) before re-applying this label. |
…ontext. (flutter#166784) Once we've created the Vulkan context, lets just use it - creating it isn't free. See numbers. Also change AHB swapchain to lazily create images, which will also improve startup and will be added to an opt in list to test startup performance. ``` ════════════════════════════╡ ••• Raw results ••• ╞═════════════════════════════ timeToFirstFrameMicros: A: 371525.00 225155.00 B: 254054.00 254668.00 timeToFirstFrameRasterizedMicros: A: 781015.00 555791.00 B: 527163.00 526827.00 ═════════════════════════╡ ••• Final A/B results ••• ╞══════════════════════════ Score Average A (noise) Average B (noise) Speed-up timeToFirstFrameMicros 298340.00 (24.53%) 254361.00 (0.12%) 1.17x timeToFirstFrameRasterizedMicros 668403.00 (16.85%) 526995.00 (0.03%) 1.27x ```
… vulkan context. (flutter#166784)" (flutter#166938) <!-- start_original_pr_link --> Reverts: flutter#166784 <!-- end_original_pr_link --> <!-- start_initiating_author --> Initiated by: jonahwilliams <!-- end_initiating_author --> <!-- start_revert_reason --> Reason for reverting: didn't do enough, going to try something different. <!-- end_revert_reason --> <!-- start_original_pr_author --> Original PR Author: jonahwilliams <!-- end_original_pr_author --> <!-- start_reviewers --> Reviewed By: {matanlurey} <!-- end_reviewers --> <!-- start_revert_body --> This change reverts the following previous change: Once we've created the Vulkan context, lets just use it - creating it isn't free. See numbers. Also change AHB swapchain to lazily create images, which will also improve startup and will be added to an opt in list to test startup performance. ``` ════════════════════════════╡ ••• Raw results ••• ╞═════════════════════════════ timeToFirstFrameMicros: A: 371525.00 225155.00 B: 254054.00 254668.00 timeToFirstFrameRasterizedMicros: A: 781015.00 555791.00 B: 527163.00 526827.00 ═════════════════════════╡ ••• Final A/B results ••• ╞══════════════════════════ Score Average A (noise) Average B (noise) Speed-up timeToFirstFrameMicros 298340.00 (24.53%) 254361.00 (0.12%) 1.17x timeToFirstFrameRasterizedMicros 668403.00 (16.85%) 526995.00 (0.03%) 1.27x ``` <!-- end_revert_body --> Co-authored-by: auto-submit[bot] <[email protected]>
Once we've created the Vulkan context, lets just use it - creating it isn't free. See numbers. Also change AHB swapchain to lazily create images, which will also improve startup and will be added to an opt in list to test startup performance.