Skip to content

Conversation

@jonahwilliams
Copy link
Contributor

@jonahwilliams jonahwilliams commented Apr 8, 2025

Once we've created the Vulkan context, lets just use it - creating it isn't free. See numbers. Also change AHB swapchain to lazily create images, which will also improve startup and will be added to an opt in list to test startup performance.

════════════════════════════╡ ••• Raw results ••• ╞═════════════════════════════

timeToFirstFrameMicros:
  A:	371525.00	225155.00	
  B:	254054.00	254668.00	
timeToFirstFrameRasterizedMicros:
  A:	781015.00	555791.00	
  B:	527163.00	526827.00	



═════════════════════════╡ ••• Final A/B results ••• ╞══════════════════════════

Score	            Average A (noise)	Average B (noise)	Speed-up
timeToFirstFrameMicros	298340.00 (24.53%)	254361.00 (0.12%)	1.17x	
timeToFirstFrameRasterizedMicros	668403.00 (16.85%)	526995.00 (0.03%)	1.27x	

@github-actions github-actions bot added platform-android Android applications specifically engine flutter/engine related. See also e: labels. e: impeller Impeller rendering backend issues and features requests labels Apr 8, 2025
@jonahwilliams jonahwilliams requested a review from matanlurey April 8, 2025 22:07
@flutter-dashboard
Copy link

CI had a failure that stopped further tests from running. We need to investigate to determine the root cause.

SHA at time of execution: 66ae828.

Possible causes:

  • Configuration Changes: The .ci.yaml file might have been modified between the creation of this pull request and the start of this test run. This can lead to ci yaml validation errors.
  • Infrastructure Issues: Problems with the CI environment itself (e.g., quota) could have caused the failure.

A blank commit, or merging to head, will be required to resume running CI for this PR.

Error Details:

DetailedApiRequestError(status: 502, message: No error details. HTTP status was: 502.)

Stack trace:

#0      validateResponse (package:_discoveryapis_commons/src/api_requester.dart:310:5)
#1      ApiRequester.request (package:_discoveryapis_commons/src/api_requester.dart:72:22)
<asynchronous suspension>
#2      ProjectsTopicsResource.publish (package:googleapis/pubsub/v1.dart:2090:23)
<asynchronous suspension>
#3      PubSub.publish (package:cocoon_service/src/request_handling/pubsub.dart:33:22)
<asynchronous suspension>
#4      LuciBuildService.scheduleTryBuilds (package:cocoon_service/src/service/luci_build_service.dart:381:7)
<asynchronous suspension>
#5      Scheduler._runCiTestingStage (package:cocoon_service/src/service/scheduler.dart:1294:9)
<asynchronous suspension>
#6      Scheduler.proceedToCiTestingStage (package:cocoon_service/src/service/scheduler.dart:1359:7)
<asynchronous suspension>
#7      Scheduler._closeSuccessfulEngineBuildStage (package:cocoon_service/src/service/scheduler.dart:1184:5)
<asynchronous suspension>
#8      Scheduler.processCheckRunCompletion (package:cocoon_service/src/service/scheduler.dart:1132:9)
<asynchronous suspension>
#9      Scheduler.processCheckRun (package:cocoon_service/src/service/scheduler.dart:1444:9)
<asynchronous suspension>
#10     GithubWebhookSubscription.post (package:cocoon_service/src/request_handlers/github/webhook_subscription.dart:115:24)
<asynchronous suspension>
#11     RequestHandler.service.<anonymous closure> (package:cocoon_service/src/request_handling/request_handler.dart:49:24)
<asynchronous suspension>
#12     SubscriptionHandler.service (package:cocoon_service/src/request_handling/subscription_handler.dart:142:5)
<asynchronous suspension>
#13     createServer.<anonymous closure> (package:cocoon_service/server.dart:294:7)
<asynchronous suspension>

@jonahwilliams jonahwilliams added the autosubmit Merge PR when tree becomes green via auto submit App label Apr 9, 2025
@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Apr 9, 2025
@auto-submit
Copy link
Contributor

auto-submit bot commented Apr 9, 2025

autosubmit label was removed for flutter/flutter/166784, because - The status or check suite Google testing has failed. Please fix the issues identified (or deflake) before re-applying this label.

@jonahwilliams jonahwilliams added the autosubmit Merge PR when tree becomes green via auto submit App label Apr 9, 2025
@auto-submit auto-submit bot added this pull request to the merge queue Apr 9, 2025
Merged via the queue into flutter:master with commit b55ffbf Apr 9, 2025
180 checks passed
@flutter-dashboard flutter-dashboard bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Apr 9, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 10, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 10, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 10, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 11, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 12, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 12, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 13, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 14, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 14, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 14, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 14, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 14, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 14, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 14, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 14, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 15, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 15, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 15, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 15, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 15, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 14, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 14, 2025
romanejaquez pushed a commit to romanejaquez/flutter that referenced this pull request Aug 14, 2025
…ontext. (flutter#166784)

Once we've created the Vulkan context, lets just use it - creating it
isn't free. See numbers. Also change AHB swapchain to lazily create
images, which will also improve startup and will be added to an opt in
list to test startup performance.

```
════════════════════════════╡ ••• Raw results ••• ╞═════════════════════════════

timeToFirstFrameMicros:
  A:	371525.00	225155.00	
  B:	254054.00	254668.00	
timeToFirstFrameRasterizedMicros:
  A:	781015.00	555791.00	
  B:	527163.00	526827.00	



═════════════════════════╡ ••• Final A/B results ••• ╞══════════════════════════

Score	            Average A (noise)	Average B (noise)	Speed-up
timeToFirstFrameMicros	298340.00 (24.53%)	254361.00 (0.12%)	1.17x	
timeToFirstFrameRasterizedMicros	668403.00 (16.85%)	526995.00 (0.03%)	1.27x	
```
romanejaquez pushed a commit to romanejaquez/flutter that referenced this pull request Aug 14, 2025
… vulkan context. (flutter#166784)" (flutter#166938)

<!-- start_original_pr_link -->
Reverts: flutter#166784
<!-- end_original_pr_link -->
<!-- start_initiating_author -->
Initiated by: jonahwilliams
<!-- end_initiating_author -->
<!-- start_revert_reason -->
Reason for reverting: didn't do enough, going to try something
different.
<!-- end_revert_reason -->
<!-- start_original_pr_author -->
Original PR Author: jonahwilliams
<!-- end_original_pr_author -->

<!-- start_reviewers -->
Reviewed By: {matanlurey}
<!-- end_reviewers -->

<!-- start_revert_body -->
This change reverts the following previous change:
Once we've created the Vulkan context, lets just use it - creating it
isn't free. See numbers. Also change AHB swapchain to lazily create
images, which will also improve startup and will be added to an opt in
list to test startup performance.

```
════════════════════════════╡ ••• Raw results ••• ╞═════════════════════════════

timeToFirstFrameMicros:
  A:	371525.00	225155.00	
  B:	254054.00	254668.00	
timeToFirstFrameRasterizedMicros:
  A:	781015.00	555791.00	
  B:	527163.00	526827.00	



═════════════════════════╡ ••• Final A/B results ••• ╞══════════════════════════

Score	            Average A (noise)	Average B (noise)	Speed-up
timeToFirstFrameMicros	298340.00 (24.53%)	254361.00 (0.12%)	1.17x	
timeToFirstFrameRasterizedMicros	668403.00 (16.85%)	526995.00 (0.03%)	1.27x	
```
<!-- end_revert_body -->

Co-authored-by: auto-submit[bot] <[email protected]>
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 15, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 15, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

e: impeller Impeller rendering backend issues and features requests engine flutter/engine related. See also e: labels. platform-android Android applications specifically

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants