-
Notifications
You must be signed in to change notification settings - Fork 29.7k
Hide error on mDNS registration failure and print warning in flutter attach #166782
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hide error on mDNS registration failure and print warning in flutter attach #166782
Conversation
|
@cbracken Any ideas on how to test the engine part ( |
Does it mean we can't debug Dart VM anymore? |
We can still debug the Dart VM, but when doing |
| if (device is IOSSimulator) { | ||
| // mDNS on simulators stopped working in macOS 15.4. | ||
| // See https://github.com/flutter/flutter/issues/166333. | ||
| return 'The Dart VM Service was not discovered after 30 seconds. ' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do we also wanna ask user to click "allow" like the iOS device case? or is the permission implicitly allowed for simulator case?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Permission is implicitly disallowed for simulators. It will always fail on macOS 15 (from what I can tell). There is no settings you can change or button you can click to make it work.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Permission is implicitly disallowed for simulators.
For macOS 15 only?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For macOS 15 only?
It appears so
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
so for users on macOS 14-, will they be prompt? do we wanna provide them with instructions?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mmm so I'm not 100% confident that it's solely due to macOS 15.4. There are some conflicting reports in the issue: #166333. I updated the instructions here to give both
| << "Could not register as server for FlutterDartVMServicePublisher, permission " | ||
| << "denied. Check your 'Local Network' permissions for this app in the Privacy section of " | ||
| << "the system Settings."; | ||
| #endif // TARGET_IPHONE_SIMULATOR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do we wanna print out the simulator case, in case developers are looking at the xcode and not the terminal? )
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure what you mean here? What would we print out?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Related to my other comment, i was thinking about something like "click allow", but I probably got it wrong.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I updated this so when targeting a simulator, it'll print a warning if debugging with verbose logs.
|
Golden file changes have been found for this pull request. Click here to view and triage (e.g. because this is an intentional change). If you are still iterating on this change and are not ready to resolve the images on the Flutter Gold dashboard, consider marking this PR as a draft pull request above. You will still be able to view image results on the dashboard, commenting will be silenced, and the check will not try to resolve itself until marked ready for review. For more guidance, visit Writing a golden file test for Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
flutter/flutter@aef4718...ecabb1a 2025-04-17 [email protected] Hide error on mDNS registration failure and print warning in flutter attach (flutter/flutter#166782) 2025-04-17 [email protected] Add support for language hints in TextFields (Android only) (flutter/flutter#165554) 2025-04-17 [email protected] Roll Skia from d8f13372549d to cc2b57434651 (1 revision) (flutter/flutter#167331) 2025-04-17 [email protected] Add DropdownMenu.restorationId (flutter/flutter#166684) 2025-04-17 [email protected] Roll Skia from 3d6165b70199 to d8f13372549d (14 revisions) (flutter/flutter#167325) 2025-04-17 [email protected] fix(CircularProgressIndicator.adaptive): strokeWidth default value (flutter/flutter#165370) 2025-04-17 [email protected] Remove unnecessary builder (flutter/flutter#166623) 2025-04-17 [email protected] Add a `gradle_errors.dart`entry for missing NDK source.properties file (flutter/flutter#167320) 2025-04-17 [email protected] Roll Skia from 6627deb65939 to 3d6165b70199 (1 revision) (flutter/flutter#167255) 2025-04-17 [email protected] Manual roll Dart SDK from 87965ab4864e to 992221a362ec (35 revisions) (flutter/flutter#167243) 2025-04-16 [email protected] Roll Fuchsia Linux SDK from 7bWzHwIPBTyU6R9nO... to m8Aln7fTF_8zy1V9N... (flutter/flutter#167312) 2025-04-16 [email protected] Don't throw on error for mDNS when searching for Dart VML url on core devices (flutter/flutter#167135) 2025-04-16 [email protected] Fix: Localization for non zero time in 24 hours format (flutter/flutter#164885) 2025-04-16 [email protected] Updated docstrings for TextureContents (flutter/flutter#167221) 2025-04-16 [email protected] Broke cyclical dependency with dlpath and typographer. (flutter/flutter#167293) 2025-04-16 [email protected] Set an additional CMake arg in `forceNdkDownload` to make the task name align with the `BuildType` (flutter/flutter#167240) 2025-04-16 [email protected] Fix Carousel crashes when using PageStorageKey (flutter/flutter#166817) 2025-04-16 [email protected] Revert "Removed superfluous copy in license checker (#167146)" (flutter/flutter#167246) 2025-04-16 [email protected] [native assets] Roll dependencies (flutter/flutter#167287) 2025-04-16 [email protected] Marks Linux_pixel_7pro static_path_stroke_tessellation_perf__timeline_summary to be unflaky (flutter/flutter#167259) 2025-04-16 [email protected] Feat: Add carousel view theme (flutter/flutter#164769) 2025-04-16 [email protected] Marks Mac_ios dynamic_path_stroke_tessellation_perf_ios__timeline_summary to be unflaky (flutter/flutter#167261) 2025-04-16 [email protected] When using --local-web-sdk, use a locally built Dart SDK if one is available (flutter/flutter#166732) 2025-04-16 [email protected] Added emulator version to doctor (flutter/flutter#167236) 2025-04-16 [email protected] Marks Mac_ios static_path_stroke_tessellation_perf_ios__timeline_summary to be unflaky (flutter/flutter#167260) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
…attach (flutter#166782) Publishing an mDNS service stopped working on macOS 15.4 for the iOS Simulator. `DNSServiceRegister` always returns a callback with error code `kDNSServiceErr_PolicyDenied`, as if the user had rejected the permissions popup (except no popup is ever shown). mDNS is used to discover the Dart VM when running `flutter attach`. This PR does not display the error message when `DNSServiceRegister` fails for iOS Simulators. Instead, it prints a warning if `flutter attach` takes too long with instructions to either use `--debug-url` or to run `flutter attach` before running the app. If `DNSServiceRegister` works again in a future macOS update, mDNS will continue to work the way it did previously. Workaround for flutter#166333. ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [x] I listed at least one issue that this PR fixes in the description above. - [x] I updated/added relevant documentation (doc comments with `///`). - [x] I added new tests to check the change I am making, or this PR is [test-exempt]. - [x] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [x] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord]. <!-- Links --> [Contributor Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview [Tree Hygiene]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md [test-exempt]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests [Flutter Style Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md [Features we expect every widget to implement]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md [Data Driven Fixes]: https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
flutter/flutter@aef4718...ecabb1a 2025-04-17 [email protected] Hide error on mDNS registration failure and print warning in flutter attach (flutter/flutter#166782) 2025-04-17 [email protected] Add support for language hints in TextFields (Android only) (flutter/flutter#165554) 2025-04-17 [email protected] Roll Skia from d8f13372549d to cc2b57434651 (1 revision) (flutter/flutter#167331) 2025-04-17 [email protected] Add DropdownMenu.restorationId (flutter/flutter#166684) 2025-04-17 [email protected] Roll Skia from 3d6165b70199 to d8f13372549d (14 revisions) (flutter/flutter#167325) 2025-04-17 [email protected] fix(CircularProgressIndicator.adaptive): strokeWidth default value (flutter/flutter#165370) 2025-04-17 [email protected] Remove unnecessary builder (flutter/flutter#166623) 2025-04-17 [email protected] Add a `gradle_errors.dart`entry for missing NDK source.properties file (flutter/flutter#167320) 2025-04-17 [email protected] Roll Skia from 6627deb65939 to 3d6165b70199 (1 revision) (flutter/flutter#167255) 2025-04-17 [email protected] Manual roll Dart SDK from 87965ab4864e to 992221a362ec (35 revisions) (flutter/flutter#167243) 2025-04-16 [email protected] Roll Fuchsia Linux SDK from 7bWzHwIPBTyU6R9nO... to m8Aln7fTF_8zy1V9N... (flutter/flutter#167312) 2025-04-16 [email protected] Don't throw on error for mDNS when searching for Dart VML url on core devices (flutter/flutter#167135) 2025-04-16 [email protected] Fix: Localization for non zero time in 24 hours format (flutter/flutter#164885) 2025-04-16 [email protected] Updated docstrings for TextureContents (flutter/flutter#167221) 2025-04-16 [email protected] Broke cyclical dependency with dlpath and typographer. (flutter/flutter#167293) 2025-04-16 [email protected] Set an additional CMake arg in `forceNdkDownload` to make the task name align with the `BuildType` (flutter/flutter#167240) 2025-04-16 [email protected] Fix Carousel crashes when using PageStorageKey (flutter/flutter#166817) 2025-04-16 [email protected] Revert "Removed superfluous copy in license checker (#167146)" (flutter/flutter#167246) 2025-04-16 [email protected] [native assets] Roll dependencies (flutter/flutter#167287) 2025-04-16 [email protected] Marks Linux_pixel_7pro static_path_stroke_tessellation_perf__timeline_summary to be unflaky (flutter/flutter#167259) 2025-04-16 [email protected] Feat: Add carousel view theme (flutter/flutter#164769) 2025-04-16 [email protected] Marks Mac_ios dynamic_path_stroke_tessellation_perf_ios__timeline_summary to be unflaky (flutter/flutter#167261) 2025-04-16 [email protected] When using --local-web-sdk, use a locally built Dart SDK if one is available (flutter/flutter#166732) 2025-04-16 [email protected] Added emulator version to doctor (flutter/flutter#167236) 2025-04-16 [email protected] Marks Mac_ios static_path_stroke_tessellation_perf_ios__timeline_summary to be unflaky (flutter/flutter#167260) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
…r#9104) flutter/flutter@aef4718...ecabb1a 2025-04-17 [email protected] Hide error on mDNS registration failure and print warning in flutter attach (flutter/flutter#166782) 2025-04-17 [email protected] Add support for language hints in TextFields (Android only) (flutter/flutter#165554) 2025-04-17 [email protected] Roll Skia from d8f13372549d to cc2b57434651 (1 revision) (flutter/flutter#167331) 2025-04-17 [email protected] Add DropdownMenu.restorationId (flutter/flutter#166684) 2025-04-17 [email protected] Roll Skia from 3d6165b70199 to d8f13372549d (14 revisions) (flutter/flutter#167325) 2025-04-17 [email protected] fix(CircularProgressIndicator.adaptive): strokeWidth default value (flutter/flutter#165370) 2025-04-17 [email protected] Remove unnecessary builder (flutter/flutter#166623) 2025-04-17 [email protected] Add a `gradle_errors.dart`entry for missing NDK source.properties file (flutter/flutter#167320) 2025-04-17 [email protected] Roll Skia from 6627deb65939 to 3d6165b70199 (1 revision) (flutter/flutter#167255) 2025-04-17 [email protected] Manual roll Dart SDK from 87965ab4864e to 992221a362ec (35 revisions) (flutter/flutter#167243) 2025-04-16 [email protected] Roll Fuchsia Linux SDK from 7bWzHwIPBTyU6R9nO... to m8Aln7fTF_8zy1V9N... (flutter/flutter#167312) 2025-04-16 [email protected] Don't throw on error for mDNS when searching for Dart VML url on core devices (flutter/flutter#167135) 2025-04-16 [email protected] Fix: Localization for non zero time in 24 hours format (flutter/flutter#164885) 2025-04-16 [email protected] Updated docstrings for TextureContents (flutter/flutter#167221) 2025-04-16 [email protected] Broke cyclical dependency with dlpath and typographer. (flutter/flutter#167293) 2025-04-16 [email protected] Set an additional CMake arg in `forceNdkDownload` to make the task name align with the `BuildType` (flutter/flutter#167240) 2025-04-16 [email protected] Fix Carousel crashes when using PageStorageKey (flutter/flutter#166817) 2025-04-16 [email protected] Revert "Removed superfluous copy in license checker (#167146)" (flutter/flutter#167246) 2025-04-16 [email protected] [native assets] Roll dependencies (flutter/flutter#167287) 2025-04-16 [email protected] Marks Linux_pixel_7pro static_path_stroke_tessellation_perf__timeline_summary to be unflaky (flutter/flutter#167259) 2025-04-16 [email protected] Feat: Add carousel view theme (flutter/flutter#164769) 2025-04-16 [email protected] Marks Mac_ios dynamic_path_stroke_tessellation_perf_ios__timeline_summary to be unflaky (flutter/flutter#167261) 2025-04-16 [email protected] When using --local-web-sdk, use a locally built Dart SDK if one is available (flutter/flutter#166732) 2025-04-16 [email protected] Added emulator version to doctor (flutter/flutter#167236) 2025-04-16 [email protected] Marks Mac_ios static_path_stroke_tessellation_perf_ios__timeline_summary to be unflaky (flutter/flutter#167260) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
…r#9104) flutter/flutter@aef4718...ecabb1a 2025-04-17 [email protected] Hide error on mDNS registration failure and print warning in flutter attach (flutter/flutter#166782) 2025-04-17 [email protected] Add support for language hints in TextFields (Android only) (flutter/flutter#165554) 2025-04-17 [email protected] Roll Skia from d8f13372549d to cc2b57434651 (1 revision) (flutter/flutter#167331) 2025-04-17 [email protected] Add DropdownMenu.restorationId (flutter/flutter#166684) 2025-04-17 [email protected] Roll Skia from 3d6165b70199 to d8f13372549d (14 revisions) (flutter/flutter#167325) 2025-04-17 [email protected] fix(CircularProgressIndicator.adaptive): strokeWidth default value (flutter/flutter#165370) 2025-04-17 [email protected] Remove unnecessary builder (flutter/flutter#166623) 2025-04-17 [email protected] Add a `gradle_errors.dart`entry for missing NDK source.properties file (flutter/flutter#167320) 2025-04-17 [email protected] Roll Skia from 6627deb65939 to 3d6165b70199 (1 revision) (flutter/flutter#167255) 2025-04-17 [email protected] Manual roll Dart SDK from 87965ab4864e to 992221a362ec (35 revisions) (flutter/flutter#167243) 2025-04-16 [email protected] Roll Fuchsia Linux SDK from 7bWzHwIPBTyU6R9nO... to m8Aln7fTF_8zy1V9N... (flutter/flutter#167312) 2025-04-16 [email protected] Don't throw on error for mDNS when searching for Dart VML url on core devices (flutter/flutter#167135) 2025-04-16 [email protected] Fix: Localization for non zero time in 24 hours format (flutter/flutter#164885) 2025-04-16 [email protected] Updated docstrings for TextureContents (flutter/flutter#167221) 2025-04-16 [email protected] Broke cyclical dependency with dlpath and typographer. (flutter/flutter#167293) 2025-04-16 [email protected] Set an additional CMake arg in `forceNdkDownload` to make the task name align with the `BuildType` (flutter/flutter#167240) 2025-04-16 [email protected] Fix Carousel crashes when using PageStorageKey (flutter/flutter#166817) 2025-04-16 [email protected] Revert "Removed superfluous copy in license checker (#167146)" (flutter/flutter#167246) 2025-04-16 [email protected] [native assets] Roll dependencies (flutter/flutter#167287) 2025-04-16 [email protected] Marks Linux_pixel_7pro static_path_stroke_tessellation_perf__timeline_summary to be unflaky (flutter/flutter#167259) 2025-04-16 [email protected] Feat: Add carousel view theme (flutter/flutter#164769) 2025-04-16 [email protected] Marks Mac_ios dynamic_path_stroke_tessellation_perf_ios__timeline_summary to be unflaky (flutter/flutter#167261) 2025-04-16 [email protected] When using --local-web-sdk, use a locally built Dart SDK if one is available (flutter/flutter#166732) 2025-04-16 [email protected] Added emulator version to doctor (flutter/flutter#167236) 2025-04-16 [email protected] Marks Mac_ios static_path_stroke_tessellation_perf_ios__timeline_summary to be unflaky (flutter/flutter#167260) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
…r#9104) flutter/flutter@aef4718...ecabb1a 2025-04-17 [email protected] Hide error on mDNS registration failure and print warning in flutter attach (flutter/flutter#166782) 2025-04-17 [email protected] Add support for language hints in TextFields (Android only) (flutter/flutter#165554) 2025-04-17 [email protected] Roll Skia from d8f13372549d to cc2b57434651 (1 revision) (flutter/flutter#167331) 2025-04-17 [email protected] Add DropdownMenu.restorationId (flutter/flutter#166684) 2025-04-17 [email protected] Roll Skia from 3d6165b70199 to d8f13372549d (14 revisions) (flutter/flutter#167325) 2025-04-17 [email protected] fix(CircularProgressIndicator.adaptive): strokeWidth default value (flutter/flutter#165370) 2025-04-17 [email protected] Remove unnecessary builder (flutter/flutter#166623) 2025-04-17 [email protected] Add a `gradle_errors.dart`entry for missing NDK source.properties file (flutter/flutter#167320) 2025-04-17 [email protected] Roll Skia from 6627deb65939 to 3d6165b70199 (1 revision) (flutter/flutter#167255) 2025-04-17 [email protected] Manual roll Dart SDK from 87965ab4864e to 992221a362ec (35 revisions) (flutter/flutter#167243) 2025-04-16 [email protected] Roll Fuchsia Linux SDK from 7bWzHwIPBTyU6R9nO... to m8Aln7fTF_8zy1V9N... (flutter/flutter#167312) 2025-04-16 [email protected] Don't throw on error for mDNS when searching for Dart VML url on core devices (flutter/flutter#167135) 2025-04-16 [email protected] Fix: Localization for non zero time in 24 hours format (flutter/flutter#164885) 2025-04-16 [email protected] Updated docstrings for TextureContents (flutter/flutter#167221) 2025-04-16 [email protected] Broke cyclical dependency with dlpath and typographer. (flutter/flutter#167293) 2025-04-16 [email protected] Set an additional CMake arg in `forceNdkDownload` to make the task name align with the `BuildType` (flutter/flutter#167240) 2025-04-16 [email protected] Fix Carousel crashes when using PageStorageKey (flutter/flutter#166817) 2025-04-16 [email protected] Revert "Removed superfluous copy in license checker (#167146)" (flutter/flutter#167246) 2025-04-16 [email protected] [native assets] Roll dependencies (flutter/flutter#167287) 2025-04-16 [email protected] Marks Linux_pixel_7pro static_path_stroke_tessellation_perf__timeline_summary to be unflaky (flutter/flutter#167259) 2025-04-16 [email protected] Feat: Add carousel view theme (flutter/flutter#164769) 2025-04-16 [email protected] Marks Mac_ios dynamic_path_stroke_tessellation_perf_ios__timeline_summary to be unflaky (flutter/flutter#167261) 2025-04-16 [email protected] When using --local-web-sdk, use a locally built Dart SDK if one is available (flutter/flutter#166732) 2025-04-16 [email protected] Added emulator version to doctor (flutter/flutter#167236) 2025-04-16 [email protected] Marks Mac_ios static_path_stroke_tessellation_perf_ios__timeline_summary to be unflaky (flutter/flutter#167260) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
…attach (flutter#166782) Publishing an mDNS service stopped working on macOS 15.4 for the iOS Simulator. `DNSServiceRegister` always returns a callback with error code `kDNSServiceErr_PolicyDenied`, as if the user had rejected the permissions popup (except no popup is ever shown). mDNS is used to discover the Dart VM when running `flutter attach`. This PR does not display the error message when `DNSServiceRegister` fails for iOS Simulators. Instead, it prints a warning if `flutter attach` takes too long with instructions to either use `--debug-url` or to run `flutter attach` before running the app. If `DNSServiceRegister` works again in a future macOS update, mDNS will continue to work the way it did previously. Workaround for flutter#166333. ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [x] I listed at least one issue that this PR fixes in the description above. - [x] I updated/added relevant documentation (doc comments with `///`). - [x] I added new tests to check the change I am making, or this PR is [test-exempt]. - [x] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [x] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord]. <!-- Links --> [Contributor Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview [Tree Hygiene]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md [test-exempt]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests [Flutter Style Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md [Features we expect every widget to implement]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md [Data Driven Fixes]: https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
Publishing an mDNS service stopped working on macOS 15.4 for the iOS Simulator.
DNSServiceRegisteralways returns a callback with error codekDNSServiceErr_PolicyDenied, as if the user had rejected the permissions popup (except no popup is ever shown). mDNS is used to discover the Dart VM when runningflutter attach.This PR does not display the error message when
DNSServiceRegisterfails for iOS Simulators. Instead, it prints a warning ifflutter attachtakes too long with instructions to either use--debug-urlor to runflutter attachbefore running the app.If
DNSServiceRegisterworks again in a future macOS update, mDNS will continue to work the way it did previously.Workaround for #166333.
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.