Skip to content

Add a test to run on iPhone 16 #166781

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
zanderso wants to merge 2 commits into from
Closed

Add a test to run on iPhone 16 #166781

zanderso wants to merge 2 commits into from

Conversation

@zanderso
Copy link
Member

@zanderso zanderso commented Apr 8, 2025 •
edited
Loading

iPhone 16 is only hooked up in the try pool at the moment, so this will fail in the staging pool after landing, following which we can run the test in a second PR in presubmit by changing presubmit to true.

Next step of #163002

@zanderso
Add a test to run on iPhone 16
a3981c3 
iPhone 16 is only hooked up in the try pool at the moment, so this will fail in the staging pool after landing, following which we can run the test in a second PR in presubmit by changing presubmit to true.
zanderso
zanderso commented Apr 8, 2025
View reviewed changes
.ci.yaml Outdated
{
"sdk_version": "16c5032a"
}
mac_arm64_new_ios:
Copy link
Member Author

@zanderso zanderso Apr 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vashworth Feel free to suggest a better name here. Previously, we've been adding the device name in this string, but iOS can do that or something different.

@vashworth
Copy link
Contributor

vashworth commented Apr 8, 2025 •
edited
Loading

@zanderso Are you just trying to confirm that the device is set up properly? I believe you can just alter the properties of an existing test if you're just one-off testing

  - name: Mac_ios animated_advanced_blend_perf_ios__timeline_summary
    recipe: devicelab/devicelab_drone
    presubmit: true
    timeout: 60
    properties:
      os: Mac-15
      cpu: arm64
      device_os: iOS-18
      tags: >
        ["devicelab", "ios", "mac"]
      task_name: animated_advanced_blend_perf_ios__timeline_summary

@zanderso
Copy link
Member Author

zanderso commented Apr 8, 2025

@zanderso Are you just trying to confirm that the device is set up properly? I believe you can just alter the properties of an existing test if you're just one-off testing

Oh, yeah, good idea. We can start with that. Updated.

@zanderso
Copy link
Member Author

zanderso commented Apr 8, 2025

https://ci.chromium.org/ui/p/flutter/builders/try/Mac_ios%20animated_advanced_blend_perf_ios__timeline_summary/48/overview

@zanderso
Copy link
Member Author

zanderso commented Apr 8, 2025

Need a recipe change to add an identifier string: https://flutter-review.googlesource.com/c/recipes/+/64580

@zanderso
Copy link
Member Author

zanderso commented Apr 8, 2025

The recipe change landed. The test runs and fails with

https://ci.chromium.org/ui/p/flutter/builders/try/Mac_ios%20animated_advanced_blend_perf_ios__timeline_summary/50/infra

[2025-04-08 15:25:56.004714] [STDOUT] stderr: [   +9 ms] Flutter could not connect to the Dart VM service.
 [2025-04-08 15:25:56.004727] [STDOUT] stderr: 
 [2025-04-08 15:25:56.004730] [STDOUT] stderr:            Please ensure your IDE or terminal app has permission to access devices on the local network. This allows Flutter to connect to the Dart VM.
 [2025-04-08 15:25:56.004733] [STDOUT] stderr: 
 [2025-04-08 15:25:56.004734] [STDOUT] stderr:            You can grant this permission in System Settings > Privacy & Security > Local Network.
 [2025-04-08 15:25:56.004736] [STDOUT] stderr: 
 [2025-04-08 15:25:56.004737] [STDOUT] stderr:            SocketException: Send failed (OS Error: No route to host, errno = 65), address = 0.0.0.0, port = 5353
 [2025-04-08 15:25:56.004739] [STDOUT] stderr: [        ] 
 [2025-04-08 15:25:56.004904] [STDOUT] stderr:            #0      throwToolExit (package:flutter_tools/src/base/common.dart:34:3)
 [2025-04-08 15:25:56.004930] [STDOUT] stderr:            #1      MDnsVmServiceDiscovery._pollingVmService (package:flutter_tools/src/mdns_discovery.dart:256:7)
 [2025-04-08 15:25:56.004932] [STDOUT] stderr:            <asynchronous suspension>
 [2025-04-08 15:25:56.004934] [STDOUT] stderr:            #2      MDnsVmServiceDiscovery.firstMatchingVmService (package:flutter_tools/src/mdns_discovery.dart:188:56)
 [2025-04-08 15:25:56.004938] [STDOUT] stderr:            <asynchronous suspension>
 [2025-04-08 15:25:56.004939] [STDOUT] stderr:            #3      MDnsVmServiceDiscovery.getVMServiceUriForLaunch (package:flutter_tools/src/mdns_discovery.dart:500:50)
 [2025-04-08 15:25:56.004941] [STDOUT] stderr:            <asynchronous suspension>
 [2025-04-08 15:25:56.004942] [STDOUT] stderr:            #4      Future.any.onValue (dart:async/future.dart:616:5)
 [2025-04-08 15:25:56.004944] [STDOUT] stderr:            <asynchronous suspension>

@vashworth
Copy link
Contributor

vashworth commented Apr 8, 2025

The recipe change landed. The test runs and fails with

https://ci.chromium.org/ui/p/flutter/builders/try/Mac_ios%20animated_advanced_blend_perf_ios__timeline_summary/50/infra

Looks like macOS 15 issue: #161846

I will need to brainstorm how to fix this in CI 🤔

@jonahwilliams
Copy link
Contributor

jonahwilliams commented Apr 8, 2025

multicast issues as in mDNS? Can we disable the mDNS client - its not used by flutter run (only attach - which itself is less than useful)

@vashworth
Copy link
Contributor

vashworth commented Apr 9, 2025

multicast issues as in mDNS? Can we disable the mDNS client - its not used by flutter run (only attach - which itself is less than useful)

Unfortunately, it's also used in flutter run. We usually get the Dart VM url from the device logs, which we get from either ios-deploy or idevicesyslog, depending on the iOS version. However, both of those tools are flakey so we use mDNS as a fallback for discovering the Dart VM url. We also have been considering using mDNS as the primary discovery method so we can reduce usage of iproxy.

@vashworth vashworth mentioned this pull request Apr 9, 2025
Open
@vashworth
Copy link
Contributor

vashworth commented Apr 9, 2025

@zanderso I've filed an issue to investigate this: #166843

Have all the new bots been added to pools? If so, I can take over from here

@zanderso
Copy link
Member Author

zanderso commented Apr 9, 2025 •
edited
Loading

@vashworth Yes, after https://chrome-internal-review.googlesource.com/c/infradata/config/+/8176175 lands (and a little propagation time), all three pools will have iPhone 16 devices available. Thanks!

@vashworth
Copy link
Contributor

vashworth commented Apr 15, 2025

I'm going to go ahead and close this while I'm resolving #166843

@vashworth vashworth closed this Apr 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jonahwilliams jonahwilliams Awaiting requested review from jonahwilliams

@vashworth vashworth Awaiting requested review from vashworth

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@zanderso @vashworth @jonahwilliams