Skip to content

[Impeller] disable no decal metal test. #166771

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
auto-submit merged 1 commit into from
Apr 9, 2025
Merged

[Impeller] disable no decal metal test. #166771

auto-submit merged 1 commit into from
Apr 9, 2025

Conversation

@jonahwilliams
Copy link
Contributor

@jonahwilliams jonahwilliams commented Apr 8, 2025

Fixes #166020

This test is invalid because the renderer assumes metal/vulkan will always have decal support (they do, its in base 1.0 for both). DIsabling decal causes this test to attempt to use a GLES only shader that is not available on the metal backend.

@jonahwilliams jonahwilliams requested a review from flar April 8, 2025 17:59
@github-actions github-actions bot added engine flutter/engine related. See also e: labels. e: impeller Impeller rendering backend issues and features requests labels Apr 8, 2025
flar
flar approved these changes Apr 8, 2025
View reviewed changes
Copy link
Contributor

@flar flar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SGTM

@jonahwilliams jonahwilliams added the autosubmit Merge PR when tree becomes green via auto submit App label Apr 9, 2025
@auto-submit auto-submit bot added this pull request to the merge queue Apr 9, 2025
Merged via the queue into flutter:master with commit fda7ffb Apr 9, 2025
179 checks passed
@flutter-dashboard flutter-dashboard bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Apr 9, 2025
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 9, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 9, 2025
@engine-flutter-autoroll
fda7ffbd9 [Impeller] disable no decal metal test. (flutter/flutter#16…
7326637 
…6771)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 9, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 9, 2025
@engine-flutter-autoroll
fda7ffbd9 [Impeller] disable no decal metal test. (flutter/flutter#16…
4c3166a 
…6771)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 9, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 9, 2025
@engine-flutter-autoroll
fda7ffbd9 [Impeller] disable no decal metal test. (flutter/flutter#16…
9764372 
…6771)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 9, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 9, 2025
@engine-flutter-autoroll
fda7ffbd9 [Impeller] disable no decal metal test. (flutter/flutter#16…
fb1d27e 
…6771)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 9, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 9, 2025
@engine-flutter-autoroll
fda7ffbd9 [Impeller] disable no decal metal test. (flutter/flutter#16…
91a2d5d 
…6771)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 9, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 9, 2025
@engine-flutter-autoroll
fda7ffbd9 [Impeller] disable no decal metal test. (flutter/flutter#16…
e52669f 
…6771)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 10, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 10, 2025
@engine-flutter-autoroll
fda7ffbd9 [Impeller] disable no decal metal test. (flutter/flutter#16…
69d1166 
…6771)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 10, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 10, 2025
@engine-flutter-autoroll
fda7ffbd9 [Impeller] disable no decal metal test. (flutter/flutter#16…
7d6c7d2 
…6771)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 10, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 10, 2025
@engine-flutter-autoroll
fda7ffbd9 [Impeller] disable no decal metal test. (flutter/flutter#16…
3e79165 
…6771)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 10, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 10, 2025
@engine-flutter-autoroll
fda7ffbd9 [Impeller] disable no decal metal test. (flutter/flutter#16…
61a2976 
…6771)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 10, 2025
@engine-flutter-autoroll
fda7ffbd9 [Impeller] disable no decal metal test. (flutter/flutter#16…
fef0f3e 
…6771)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 11, 2025
@engine-flutter-autoroll
fda7ffbd9 [Impeller] disable no decal metal test. (flutter/flutter#16…
5d60783 
…6771)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 11, 2025
@engine-flutter-autoroll
fda7ffbd9 [Impeller] disable no decal metal test. (flutter/flutter#16…
8b98259 
…6771)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 11, 2025
@engine-flutter-autoroll
fda7ffbd9 [Impeller] disable no decal metal test. (flutter/flutter#16…
eb17aca 
…6771)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 11, 2025
@engine-flutter-autoroll
fda7ffbd9 [Impeller] disable no decal metal test. (flutter/flutter#16…
48a1f87 
…6771)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 11, 2025
@engine-flutter-autoroll
fda7ffbd9 [Impeller] disable no decal metal test. (flutter/flutter#16…
470f88d 
…6771)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 11, 2025
@engine-flutter-autoroll
fda7ffbd9 [Impeller] disable no decal metal test. (flutter/flutter#16…
efe407e 
…6771)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 11, 2025
@engine-flutter-autoroll
fda7ffbd9 [Impeller] disable no decal metal test. (flutter/flutter#16…
f6ba031 
…6771)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 12, 2025
@engine-flutter-autoroll
fda7ffbd9 [Impeller] disable no decal metal test. (flutter/flutter#16…
08e8e43 
…6771)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 12, 2025
@engine-flutter-autoroll
fda7ffbd9 [Impeller] disable no decal metal test. (flutter/flutter#16…
5076d23 
…6771)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 13, 2025
@engine-flutter-autoroll
fda7ffbd9 [Impeller] disable no decal metal test. (flutter/flutter#16…
530f805 
…6771)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 14, 2025
@engine-flutter-autoroll
fda7ffbd9 [Impeller] disable no decal metal test. (flutter/flutter#16…
b6ca1f1 
…6771)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 14, 2025
@engine-flutter-autoroll
fda7ffbd9 [Impeller] disable no decal metal test. (flutter/flutter#16…
8df841c 
…6771)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 14, 2025
@engine-flutter-autoroll
fda7ffbd9 [Impeller] disable no decal metal test. (flutter/flutter#16…
724fe0e 
…6771)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 14, 2025
@engine-flutter-autoroll
fda7ffbd9 [Impeller] disable no decal metal test. (flutter/flutter#16…
f2d6d72 
…6771)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 14, 2025
@engine-flutter-autoroll
fda7ffbd9 [Impeller] disable no decal metal test. (flutter/flutter#16…
0f40c5c 
…6771)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 14, 2025
@engine-flutter-autoroll
fda7ffbd9 [Impeller] disable no decal metal test. (flutter/flutter#16…
4bf5c49 
…6771)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 14, 2025
@engine-flutter-autoroll
fda7ffbd9 [Impeller] disable no decal metal test. (flutter/flutter#16…
d5f6ac2 
…6771)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 14, 2025
@engine-flutter-autoroll
fda7ffbd9 [Impeller] disable no decal metal test. (flutter/flutter#16…
0cbec95 
…6771)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 15, 2025
@engine-flutter-autoroll
fda7ffbd9 [Impeller] disable no decal metal test. (flutter/flutter#16…
bea283e 
…6771)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 15, 2025
@engine-flutter-autoroll
fda7ffbd9 [Impeller] disable no decal metal test. (flutter/flutter#16…
399cf47 
…6771)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 15, 2025
@engine-flutter-autoroll
fda7ffbd9 [Impeller] disable no decal metal test. (flutter/flutter#16…
80d06b7 
…6771)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 15, 2025
@engine-flutter-autoroll
fda7ffbd9 [Impeller] disable no decal metal test. (flutter/flutter#16…
f0dd138 
…6771)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 15, 2025
@engine-flutter-autoroll
fda7ffbd9 [Impeller] disable no decal metal test. (flutter/flutter#16…
03c8e9e 
…6771)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 14, 2025
@engine-flutter-autoroll
fda7ffbd9 [Impeller] disable no decal metal test. (flutter/flutter#16…
7611ad0 
…6771)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 14, 2025
@engine-flutter-autoroll
fda7ffbd9 [Impeller] disable no decal metal test. (flutter/flutter#16…
a5ca2e5 
…6771)
romanejaquez pushed a commit to romanejaquez/flutter that referenced this pull request Aug 14, 2025
@romanejaquez
[Impeller] disable no decal metal test. (flutter#166771)
78a33ae 
Fixes flutter#166020

This test is invalid because the renderer assumes metal/vulkan will
always have decal support (they do, its in base 1.0 for both). DIsabling
decal causes this test to attempt to use a GLES only shader that is not
available on the metal backend.
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 15, 2025
@engine-flutter-autoroll
fda7ffbd9 [Impeller] disable no decal metal test. (flutter/flutter#16…
45c4d27 
…6771)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 15, 2025
@engine-flutter-autoroll
fda7ffbd9 [Impeller] disable no decal metal test. (flutter/flutter#16…
3eb49c7 
…6771)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 16, 2025
@engine-flutter-autoroll
fda7ffbd9 [Impeller] disable no decal metal test. (flutter/flutter#16…
95846f7 
…6771)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@flar flar flar approved these changes

Assignees

No one assigned

Labels

e: impeller Impeller rendering backend issues and features requests engine flutter/engine related. See also e: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Impeller] Golden tests fail on a host_debug_unopt_arm64 build

2 participants

@jonahwilliams @flar