Skip to content

Remove package:macros and package:_macros from pubspec.yaml #166749

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
auto-submit merged 1 commit into from
Apr 9, 2025
Merged

Remove package:macros and package:_macros from pubspec.yaml #166749

auto-submit merged 1 commit into from
Apr 9, 2025

Conversation

@alexmarkov
Copy link
Contributor

@alexmarkov alexmarkov commented Apr 8, 2025

Update Flutter for the upcoming removal of pkg/_macros and pkg/macros from Dart SDK: https://dart-review.googlesource.com/c/sdk/+/420680.

@github-actions github-actions bot added engine flutter/engine related. See also e: labels. platform-web Web applications specifically labels Apr 8, 2025
jonahwilliams
jonahwilliams approved these changes Apr 8, 2025
View reviewed changes
Copy link
Contributor

@jonahwilliams jonahwilliams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alexmarkov alexmarkov marked this pull request as ready for review April 8, 2025 15:14
@alexmarkov alexmarkov added the autosubmit Merge PR when tree becomes green via auto submit App label Apr 8, 2025
@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Apr 8, 2025
@auto-submit
Copy link
Contributor

auto-submit bot commented Apr 8, 2025

autosubmit label was removed for flutter/flutter/166749, because - The status or check suite Google testing has failed. Please fix the issues identified (or deflake) before re-applying this label.

@alexmarkov alexmarkov force-pushed the remove-macros-from-pubspec branch from 5f1b8af to 292d1e8 Compare April 8, 2025 18:02
@alexmarkov alexmarkov added the autosubmit Merge PR when tree becomes green via auto submit App label Apr 8, 2025
@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Apr 8, 2025
@auto-submit
Copy link
Contributor

auto-submit bot commented Apr 8, 2025

autosubmit label was removed for flutter/flutter/166749, because - The status or check suite Google testing has failed. Please fix the issues identified (or deflake) before re-applying this label.

@alexmarkov alexmarkov added the autosubmit Merge PR when tree becomes green via auto submit App label Apr 8, 2025
@auto-submit auto-submit bot added this pull request to the merge queue Apr 9, 2025
Merged via the queue into flutter:master with commit 41c32eb Apr 9, 2025
178 checks passed
@flutter-dashboard flutter-dashboard bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Apr 9, 2025
@alexmarkov alexmarkov deleted the remove-macros-from-pubspec branch April 9, 2025 03:09
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 9, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 9, 2025
@engine-flutter-autoroll
41c32eb57 Remove package:macros and package:_macros from pubspec.yaml (…
fdaa817 
…flutter/flutter#166749)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 9, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 9, 2025
@engine-flutter-autoroll
41c32eb57 Remove package:macros and package:_macros from pubspec.yaml (…
07c914d 
…flutter/flutter#166749)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 9, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 9, 2025
@engine-flutter-autoroll
41c32eb57 Remove package:macros and package:_macros from pubspec.yaml (…
7ab6c70 
…flutter/flutter#166749)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 9, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 9, 2025
@engine-flutter-autoroll
41c32eb57 Remove package:macros and package:_macros from pubspec.yaml (…
4c12ce0 
…flutter/flutter#166749)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 9, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 9, 2025
@engine-flutter-autoroll
41c32eb57 Remove package:macros and package:_macros from pubspec.yaml (…
9113d82 
…flutter/flutter#166749)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 9, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 9, 2025
@engine-flutter-autoroll
41c32eb57 Remove package:macros and package:_macros from pubspec.yaml (…
f7067ef 
…flutter/flutter#166749)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 10, 2025
@engine-flutter-autoroll
41c32eb57 Remove package:macros and package:_macros from pubspec.yaml (…
4d26c6f 
…flutter/flutter#166749)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 11, 2025
@engine-flutter-autoroll
41c32eb57 Remove package:macros and package:_macros from pubspec.yaml (…
55431bf 
…flutter/flutter#166749)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 11, 2025
@engine-flutter-autoroll
41c32eb57 Remove package:macros and package:_macros from pubspec.yaml (…
fdf92b5 
…flutter/flutter#166749)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 11, 2025
@engine-flutter-autoroll
41c32eb57 Remove package:macros and package:_macros from pubspec.yaml (…
a3fa34c 
…flutter/flutter#166749)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 11, 2025
@engine-flutter-autoroll
41c32eb57 Remove package:macros and package:_macros from pubspec.yaml (…
118e99d 
…flutter/flutter#166749)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 11, 2025
@engine-flutter-autoroll
41c32eb57 Remove package:macros and package:_macros from pubspec.yaml (…
44b12e1 
…flutter/flutter#166749)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 11, 2025
@engine-flutter-autoroll
41c32eb57 Remove package:macros and package:_macros from pubspec.yaml (…
44043a8 
…flutter/flutter#166749)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 11, 2025
@engine-flutter-autoroll
41c32eb57 Remove package:macros and package:_macros from pubspec.yaml (…
cfea2d8 
…flutter/flutter#166749)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 12, 2025
@engine-flutter-autoroll
41c32eb57 Remove package:macros and package:_macros from pubspec.yaml (…
84cce53 
…flutter/flutter#166749)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 12, 2025
@engine-flutter-autoroll
41c32eb57 Remove package:macros and package:_macros from pubspec.yaml (…
420d645 
…flutter/flutter#166749)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 13, 2025
@engine-flutter-autoroll
41c32eb57 Remove package:macros and package:_macros from pubspec.yaml (…
b77bb45 
…flutter/flutter#166749)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 14, 2025
@engine-flutter-autoroll
41c32eb57 Remove package:macros and package:_macros from pubspec.yaml (…
2a2cfd8 
…flutter/flutter#166749)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 14, 2025
@engine-flutter-autoroll
41c32eb57 Remove package:macros and package:_macros from pubspec.yaml (…
958beca 
…flutter/flutter#166749)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 14, 2025
@engine-flutter-autoroll
41c32eb57 Remove package:macros and package:_macros from pubspec.yaml (…
ddaf36d 
…flutter/flutter#166749)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 14, 2025
@engine-flutter-autoroll
41c32eb57 Remove package:macros and package:_macros from pubspec.yaml (…
a598934 
…flutter/flutter#166749)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 14, 2025
@engine-flutter-autoroll
41c32eb57 Remove package:macros and package:_macros from pubspec.yaml (…
b407d32 
…flutter/flutter#166749)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 14, 2025
@engine-flutter-autoroll
41c32eb57 Remove package:macros and package:_macros from pubspec.yaml (…
28e2da4 
…flutter/flutter#166749)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 14, 2025
@engine-flutter-autoroll
41c32eb57 Remove package:macros and package:_macros from pubspec.yaml (…
95cf08b 
…flutter/flutter#166749)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 14, 2025
@engine-flutter-autoroll
41c32eb57 Remove package:macros and package:_macros from pubspec.yaml (…
e340a19 
…flutter/flutter#166749)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 15, 2025
@engine-flutter-autoroll
41c32eb57 Remove package:macros and package:_macros from pubspec.yaml (…
7b5aa4a 
…flutter/flutter#166749)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 15, 2025
@engine-flutter-autoroll
41c32eb57 Remove package:macros and package:_macros from pubspec.yaml (…
cbd425a 
…flutter/flutter#166749)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 15, 2025
@engine-flutter-autoroll
41c32eb57 Remove package:macros and package:_macros from pubspec.yaml (…
6c87bbb 
…flutter/flutter#166749)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 15, 2025
@engine-flutter-autoroll
41c32eb57 Remove package:macros and package:_macros from pubspec.yaml (…
e6370af 
…flutter/flutter#166749)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 15, 2025
@engine-flutter-autoroll
41c32eb57 Remove package:macros and package:_macros from pubspec.yaml (…
b837fa2 
…flutter/flutter#166749)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 14, 2025
@engine-flutter-autoroll
41c32eb57 Remove package:macros and package:_macros from pubspec.yaml (…
8537bb8 
…flutter/flutter#166749)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 14, 2025
@engine-flutter-autoroll
41c32eb57 Remove package:macros and package:_macros from pubspec.yaml (…
a3192bf 
…flutter/flutter#166749)
romanejaquez pushed a commit to romanejaquez/flutter that referenced this pull request Aug 14, 2025
@alexmarkov @romanejaquez
Remove package:macros and package:_macros from pubspec.yaml (flutter#…
1b5f653 
…166749)

Update Flutter for the upcoming removal of pkg/_macros and pkg/macros
from Dart SDK: https://dart-review.googlesource.com/c/sdk/+/420680.
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 15, 2025
@engine-flutter-autoroll
41c32eb57 Remove package:macros and package:_macros from pubspec.yaml (…
16c11a5 
…flutter/flutter#166749)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 15, 2025
@engine-flutter-autoroll
41c32eb57 Remove package:macros and package:_macros from pubspec.yaml (…
0c4540c 
…flutter/flutter#166749)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 16, 2025
@engine-flutter-autoroll
41c32eb57 Remove package:macros and package:_macros from pubspec.yaml (…
71bf3f8 
…flutter/flutter#166749)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@jonahwilliams jonahwilliams jonahwilliams approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

engine flutter/engine related. See also e: labels. platform-web Web applications specifically

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@alexmarkov @jonahwilliams