-
Notifications
You must be signed in to change notification settings - Fork 29.7k
[ Widget Preview ] Add initial support for communications over the Dart Tooling Daemon (DTD) #166698
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rt Tooling Daemon (DTD) This will eventually be used as the main communication channel between the widget preview scaffold, the Flutter tool, and other developer tooling (e.g., IDEs). Fixes #166417
jyameo
approved these changes
Apr 8, 2025
Contributor
jyameo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Contributor
|
autosubmit label was removed for flutter/flutter/166698, because - The status or check suite Google testing has failed. Please fix the issues identified (or deflake) before re-applying this label. |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Apr 8, 2025
…r the Dart Tooling Daemon (DTD) (flutter/flutter#166698)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Apr 9, 2025
…r the Dart Tooling Daemon (DTD) (flutter/flutter#166698)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Apr 9, 2025
…r the Dart Tooling Daemon (DTD) (flutter/flutter#166698)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Apr 9, 2025
…r the Dart Tooling Daemon (DTD) (flutter/flutter#166698)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Apr 9, 2025
…r the Dart Tooling Daemon (DTD) (flutter/flutter#166698)
Contributor
Contributor
|
reason for revert: tests are timing out in presubmit |
matanlurey
pushed a commit
to matanlurey/flutter
that referenced
this pull request
Apr 9, 2025
…er the Dart Tooling Daemon (DTD) (flutter#166698)" (flutter#166866) <!-- start_original_pr_link --> Reverts: flutter#166698 <!-- end_original_pr_link --> <!-- start_initiating_author --> Initiated by: jonahwilliams <!-- end_initiating_author --> <!-- start_revert_reason --> Reason for reverting: tests are timing out in presubmit <!-- end_revert_reason --> <!-- start_original_pr_author --> Original PR Author: bkonyi <!-- end_original_pr_author --> <!-- start_reviewers --> Reviewed By: {jyameo} <!-- end_reviewers --> <!-- start_revert_body --> This change reverts the following previous change: This will eventually be used as the main communication channel between the widget preview scaffold, the Flutter tool, and other developer tooling (e.g., IDEs). Fixes flutter#166417 <!-- end_revert_body --> Co-authored-by: auto-submit[bot] <[email protected]>
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Apr 10, 2025
…r the Dart Tooling Daemon (DTD) (flutter/flutter#166698)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Apr 10, 2025
…r the Dart Tooling Daemon (DTD) (flutter/flutter#166698)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Apr 10, 2025
…r the Dart Tooling Daemon (DTD) (flutter/flutter#166698)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Apr 10, 2025
…r the Dart Tooling Daemon (DTD) (flutter/flutter#166698)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Apr 10, 2025
…r the Dart Tooling Daemon (DTD) (flutter/flutter#166698)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Apr 10, 2025
…r the Dart Tooling Daemon (DTD) (flutter/flutter#166698)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Apr 10, 2025
…r the Dart Tooling Daemon (DTD) (flutter/flutter#166698)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Apr 10, 2025
…r the Dart Tooling Daemon (DTD) (flutter/flutter#166698)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Apr 10, 2025
…r the Dart Tooling Daemon (DTD) (flutter/flutter#166698)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Apr 10, 2025
…r the Dart Tooling Daemon (DTD) (flutter/flutter#166698)
auto-submit bot
pushed a commit
to flutter/packages
that referenced
this pull request
Apr 11, 2025
Manual roll requested by [email protected] flutter/flutter@9bf18f0...30e53b0 2025-04-08 [email protected] [ Widget Preview ] Add initial support for communications over the Dart Tooling Daemon (DTD) (flutter/flutter#166698) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
nick-llewellyn
pushed a commit
to labrystechnology/flutter_packages
that referenced
this pull request
Apr 23, 2025
Manual roll requested by [email protected] flutter/flutter@9bf18f0...30e53b0 2025-04-08 [email protected] [ Widget Preview ] Add initial support for communications over the Dart Tooling Daemon (DTD) (flutter/flutter#166698) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
CodixNinja
pushed a commit
to CodixNinja/packages
that referenced
this pull request
May 15, 2025
…9053) Manual roll requested by [email protected] flutter/flutter@9bf18f0...30e53b0 2025-04-08 [email protected] [ Widget Preview ] Add initial support for communications over the Dart Tooling Daemon (DTD) (flutter/flutter#166698) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
May 20, 2025
…r the Dart Tooling Daemon (DTD) (flutter/flutter#166698)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
May 20, 2025
…r the Dart Tooling Daemon (DTD) (flutter/flutter#166698)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
May 21, 2025
…r the Dart Tooling Daemon (DTD) (flutter/flutter#166698)
androidseb
pushed a commit
to androidseb/packages
that referenced
this pull request
Jun 8, 2025
Manual roll requested by [email protected] flutter/flutter@9bf18f0...30e53b0 2025-04-08 [email protected] [ Widget Preview ] Add initial support for communications over the Dart Tooling Daemon (DTD) (flutter/flutter#166698) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
FMorschel
pushed a commit
to FMorschel/packages
that referenced
this pull request
Jun 9, 2025
Manual roll requested by [email protected] flutter/flutter@9bf18f0...30e53b0 2025-04-08 [email protected] [ Widget Preview ] Add initial support for communications over the Dart Tooling Daemon (DTD) (flutter/flutter#166698) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Ortes
pushed a commit
to Ortes/packages
that referenced
this pull request
Jun 25, 2025
Manual roll requested by [email protected] flutter/flutter@9bf18f0...30e53b0 2025-04-08 [email protected] [ Widget Preview ] Add initial support for communications over the Dart Tooling Daemon (DTD) (flutter/flutter#166698) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
romanejaquez
pushed a commit
to romanejaquez/flutter
that referenced
this pull request
Aug 14, 2025
…rt Tooling Daemon (DTD) (flutter#166698) This will eventually be used as the main communication channel between the widget preview scaffold, the Flutter tool, and other developer tooling (e.g., IDEs). Fixes flutter#166417
romanejaquez
pushed a commit
to romanejaquez/flutter
that referenced
this pull request
Aug 14, 2025
…er the Dart Tooling Daemon (DTD) (flutter#166698)" (flutter#166866) <!-- start_original_pr_link --> Reverts: flutter#166698 <!-- end_original_pr_link --> <!-- start_initiating_author --> Initiated by: jonahwilliams <!-- end_initiating_author --> <!-- start_revert_reason --> Reason for reverting: tests are timing out in presubmit <!-- end_revert_reason --> <!-- start_original_pr_author --> Original PR Author: bkonyi <!-- end_original_pr_author --> <!-- start_reviewers --> Reviewed By: {jyameo} <!-- end_reviewers --> <!-- start_revert_body --> This change reverts the following previous change: This will eventually be used as the main communication channel between the widget preview scaffold, the Flutter tool, and other developer tooling (e.g., IDEs). Fixes flutter#166417 <!-- end_revert_body --> Co-authored-by: auto-submit[bot] <[email protected]>
romanejaquez
pushed a commit
to romanejaquez/flutter
that referenced
this pull request
Aug 14, 2025
…r the Dart Tooling Daemon (DTD) (flutter#166698)" (flutter#166877) This reverts commit 059326d and updates the `widget-preview` command to always spawn the previewer using a local canvaskit binary. Fixes flutter#166865
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will eventually be used as the main communication channel between the widget preview scaffold, the Flutter tool, and other developer tooling (e.g., IDEs).
Fixes #166417