Skip to content

Feat: Add equality to NoDefaultCupertinoThemeData #166655

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
auto-submit merged 1 commit into from
Apr 17, 2025
Merged

Feat: Add equality to NoDefaultCupertinoThemeData #166655

auto-submit merged 1 commit into from
Apr 17, 2025

Conversation

@rkishan516
Copy link
Contributor

@rkishan516 rkishan516 commented Apr 6, 2025

Feat: Add equality to NoDefaultCupertinoThemeData
fixes: #165455

Pre-launch Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
  • I signed the [CLA].
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is [test-exempt].
  • I followed the [breaking change policy] and added [Data Driven Fixes] where supported.
  • All existing and new tests are passing.

@github-actions github-actions bot added framework flutter/packages/flutter repository. See also f: labels. f: cupertino flutter/packages/flutter/cupertino repository labels Apr 6, 2025
@dkwingsmt dkwingsmt self-requested a review April 9, 2025 18:25
dkwingsmt
dkwingsmt approved these changes Apr 17, 2025
View reviewed changes
Copy link
Contributor

@dkwingsmt dkwingsmt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you!

@dkwingsmt dkwingsmt added the autosubmit Merge PR when tree becomes green via auto submit App label Apr 17, 2025
@auto-submit auto-submit bot added this pull request to the merge queue Apr 17, 2025
Merged via the queue into flutter:master with commit 434cb54 Apr 17, 2025
75 checks passed
@flutter-dashboard flutter-dashboard bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Apr 17, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 18, 2025
@engine-flutter-autoroll
434cb54e7 Feat: Add equality to NoDefaultCupertinoThemeData (flutter/…
a9c72dd 
…flutter#166655)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 18, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 18, 2025
@engine-flutter-autoroll
434cb54e7 Feat: Add equality to NoDefaultCupertinoThemeData (flutter/…
1e418bc 
…flutter#166655)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 18, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 18, 2025
@engine-flutter-autoroll
434cb54e7 Feat: Add equality to NoDefaultCupertinoThemeData (flutter/…
5ad4b93 
…flutter#166655)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 18, 2025
Merged
auto-submit bot pushed a commit to flutter/packages that referenced this pull request Apr 18, 2025
@engine-flutter-autoroll
Roll Flutter from ecabb1a05212 to 3ed38e24528a (23 revisions) (#9114)
bfb42a6 
flutter/flutter@ecabb1a...3ed38e2

2025-04-18 [email protected] Update `led` docs (flutter/flutter#167380)
2025-04-18 [email protected] Throw an error if --local-engine-host is used without --local-engine (flutter/flutter#166948)
2025-04-18 [email protected] Add kotlin compatability to build file validation (flutter/flutter#167143)
2025-04-18 [email protected] Roll Skia from 844496884aa0 to 6c4595124690 (2 revisions) (flutter/flutter#167400)
2025-04-18 [email protected] Fix CarouselView crashes when initlal viewportDimension is 0.0 (flutter/flutter#167271)
2025-04-18 [email protected] Roll Dart SDK from b1eb743f97f5 to ab60afc99bcb (1 revision) (flutter/flutter#167396)
2025-04-18 [email protected] Add InputDecoration.visualDensity and InputDecorationTheme.visualDensity (flutter/flutter#166834)
2025-04-18 [email protected] Roll Skia from acc910544da7 to 844496884aa0 (1 revision) (flutter/flutter#167389)
2025-04-18 [email protected] Roll Skia from a409d685a711 to acc910544da7 (10 revisions) (flutter/flutter#167388)
2025-04-18 [email protected] Roll Dart SDK from 2bb85834e77e to b1eb743f97f5 (2 revisions) (flutter/flutter#167387)
2025-04-18 [email protected] Roll Fuchsia Linux SDK from m8Aln7fTF_8zy1V9N... to MwYckh5OvwwmIYLx0... (flutter/flutter#167385)
2025-04-17 [email protected] Roll Skia from cc2b57434651 to a409d685a711 (3 revisions) (flutter/flutter#167347)
2025-04-17 [email protected] Reduce app startup latency by initializing the engine on a separate thread (flutter/flutter#166918)
2025-04-17 [email protected] Roll Dart SDK from 992221a362ec to 2bb85834e77e (7 revisions) (flutter/flutter#167361)
2025-04-17 [email protected] Added docstring for FilterInput::GetSnapshot (flutter/flutter#167226)
2025-04-17 [email protected] adds Entity docstrings (flutter/flutter#167228)
2025-04-17 [email protected] fixed impeller golden content scale (flutter/flutter#167308)
2025-04-17 [email protected] Added docstring for FilterContents::RenderFilter (flutter/flutter#167227)
2025-04-17 [email protected] Feat: Add equality to NoDefaultCupertinoThemeData (flutter/flutter#166655)
2025-04-17 [email protected] Fix link to engine docs (flutter/flutter#167346)
2025-04-17 [email protected] [macOS] Enable merged platform and UI thread by default (flutter/flutter#166536)
2025-04-17 [email protected] [Windows] Enable merged platform and UI thread by default (flutter/flutter#163726)
2025-04-17 [email protected] Update `CHANGELOG.md` (flutter/flutter#167225)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
CodixNinja pushed a commit to CodixNinja/packages that referenced this pull request May 15, 2025
@engine-flutter-autoroll
Roll Flutter from ecabb1a05212 to 3ed38e24528a (23 revisions) (#9114)
83531f2 
flutter/flutter@ecabb1a...3ed38e2

2025-04-18 [email protected] Update `led` docs (flutter/flutter#167380)
2025-04-18 [email protected] Throw an error if --local-engine-host is used without --local-engine (flutter/flutter#166948)
2025-04-18 [email protected] Add kotlin compatability to build file validation (flutter/flutter#167143)
2025-04-18 [email protected] Roll Skia from 844496884aa0 to 6c4595124690 (2 revisions) (flutter/flutter#167400)
2025-04-18 [email protected] Fix CarouselView crashes when initlal viewportDimension is 0.0 (flutter/flutter#167271)
2025-04-18 [email protected] Roll Dart SDK from b1eb743f97f5 to ab60afc99bcb (1 revision) (flutter/flutter#167396)
2025-04-18 [email protected] Add InputDecoration.visualDensity and InputDecorationTheme.visualDensity (flutter/flutter#166834)
2025-04-18 [email protected] Roll Skia from acc910544da7 to 844496884aa0 (1 revision) (flutter/flutter#167389)
2025-04-18 [email protected] Roll Skia from a409d685a711 to acc910544da7 (10 revisions) (flutter/flutter#167388)
2025-04-18 [email protected] Roll Dart SDK from 2bb85834e77e to b1eb743f97f5 (2 revisions) (flutter/flutter#167387)
2025-04-18 [email protected] Roll Fuchsia Linux SDK from m8Aln7fTF_8zy1V9N... to MwYckh5OvwwmIYLx0... (flutter/flutter#167385)
2025-04-17 [email protected] Roll Skia from cc2b57434651 to a409d685a711 (3 revisions) (flutter/flutter#167347)
2025-04-17 [email protected] Reduce app startup latency by initializing the engine on a separate thread (flutter/flutter#166918)
2025-04-17 [email protected] Roll Dart SDK from 992221a362ec to 2bb85834e77e (7 revisions) (flutter/flutter#167361)
2025-04-17 [email protected] Added docstring for FilterInput::GetSnapshot (flutter/flutter#167226)
2025-04-17 [email protected] adds Entity docstrings (flutter/flutter#167228)
2025-04-17 [email protected] fixed impeller golden content scale (flutter/flutter#167308)
2025-04-17 [email protected] Added docstring for FilterContents::RenderFilter (flutter/flutter#167227)
2025-04-17 [email protected] Feat: Add equality to NoDefaultCupertinoThemeData (flutter/flutter#166655)
2025-04-17 [email protected] Fix link to engine docs (flutter/flutter#167346)
2025-04-17 [email protected] [macOS] Enable merged platform and UI thread by default (flutter/flutter#166536)
2025-04-17 [email protected] [Windows] Enable merged platform and UI thread by default (flutter/flutter#163726)
2025-04-17 [email protected] Update `CHANGELOG.md` (flutter/flutter#167225)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
androidseb pushed a commit to androidseb/packages that referenced this pull request Jun 8, 2025
@engine-flutter-autoroll @androidseb
Roll Flutter from ecabb1a05212 to 3ed38e24528a (23 revisions) (flutte…
04ead92 
…r#9114)

flutter/flutter@ecabb1a...3ed38e2

2025-04-18 [email protected] Update `led` docs (flutter/flutter#167380)
2025-04-18 [email protected] Throw an error if --local-engine-host is used without --local-engine (flutter/flutter#166948)
2025-04-18 [email protected] Add kotlin compatability to build file validation (flutter/flutter#167143)
2025-04-18 [email protected] Roll Skia from 844496884aa0 to 6c4595124690 (2 revisions) (flutter/flutter#167400)
2025-04-18 [email protected] Fix CarouselView crashes when initlal viewportDimension is 0.0 (flutter/flutter#167271)
2025-04-18 [email protected] Roll Dart SDK from b1eb743f97f5 to ab60afc99bcb (1 revision) (flutter/flutter#167396)
2025-04-18 [email protected] Add InputDecoration.visualDensity and InputDecorationTheme.visualDensity (flutter/flutter#166834)
2025-04-18 [email protected] Roll Skia from acc910544da7 to 844496884aa0 (1 revision) (flutter/flutter#167389)
2025-04-18 [email protected] Roll Skia from a409d685a711 to acc910544da7 (10 revisions) (flutter/flutter#167388)
2025-04-18 [email protected] Roll Dart SDK from 2bb85834e77e to b1eb743f97f5 (2 revisions) (flutter/flutter#167387)
2025-04-18 [email protected] Roll Fuchsia Linux SDK from m8Aln7fTF_8zy1V9N... to MwYckh5OvwwmIYLx0... (flutter/flutter#167385)
2025-04-17 [email protected] Roll Skia from cc2b57434651 to a409d685a711 (3 revisions) (flutter/flutter#167347)
2025-04-17 [email protected] Reduce app startup latency by initializing the engine on a separate thread (flutter/flutter#166918)
2025-04-17 [email protected] Roll Dart SDK from 992221a362ec to 2bb85834e77e (7 revisions) (flutter/flutter#167361)
2025-04-17 [email protected] Added docstring for FilterInput::GetSnapshot (flutter/flutter#167226)
2025-04-17 [email protected] adds Entity docstrings (flutter/flutter#167228)
2025-04-17 [email protected] fixed impeller golden content scale (flutter/flutter#167308)
2025-04-17 [email protected] Added docstring for FilterContents::RenderFilter (flutter/flutter#167227)
2025-04-17 [email protected] Feat: Add equality to NoDefaultCupertinoThemeData (flutter/flutter#166655)
2025-04-17 [email protected] Fix link to engine docs (flutter/flutter#167346)
2025-04-17 [email protected] [macOS] Enable merged platform and UI thread by default (flutter/flutter#166536)
2025-04-17 [email protected] [Windows] Enable merged platform and UI thread by default (flutter/flutter#163726)
2025-04-17 [email protected] Update `CHANGELOG.md` (flutter/flutter#167225)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
FMorschel pushed a commit to FMorschel/packages that referenced this pull request Jun 9, 2025
@engine-flutter-autoroll @FMorschel
Roll Flutter from ecabb1a05212 to 3ed38e24528a (23 revisions) (flutte…
993466f 
…r#9114)

flutter/flutter@ecabb1a...3ed38e2

2025-04-18 [email protected] Update `led` docs (flutter/flutter#167380)
2025-04-18 [email protected] Throw an error if --local-engine-host is used without --local-engine (flutter/flutter#166948)
2025-04-18 [email protected] Add kotlin compatability to build file validation (flutter/flutter#167143)
2025-04-18 [email protected] Roll Skia from 844496884aa0 to 6c4595124690 (2 revisions) (flutter/flutter#167400)
2025-04-18 [email protected] Fix CarouselView crashes when initlal viewportDimension is 0.0 (flutter/flutter#167271)
2025-04-18 [email protected] Roll Dart SDK from b1eb743f97f5 to ab60afc99bcb (1 revision) (flutter/flutter#167396)
2025-04-18 [email protected] Add InputDecoration.visualDensity and InputDecorationTheme.visualDensity (flutter/flutter#166834)
2025-04-18 [email protected] Roll Skia from acc910544da7 to 844496884aa0 (1 revision) (flutter/flutter#167389)
2025-04-18 [email protected] Roll Skia from a409d685a711 to acc910544da7 (10 revisions) (flutter/flutter#167388)
2025-04-18 [email protected] Roll Dart SDK from 2bb85834e77e to b1eb743f97f5 (2 revisions) (flutter/flutter#167387)
2025-04-18 [email protected] Roll Fuchsia Linux SDK from m8Aln7fTF_8zy1V9N... to MwYckh5OvwwmIYLx0... (flutter/flutter#167385)
2025-04-17 [email protected] Roll Skia from cc2b57434651 to a409d685a711 (3 revisions) (flutter/flutter#167347)
2025-04-17 [email protected] Reduce app startup latency by initializing the engine on a separate thread (flutter/flutter#166918)
2025-04-17 [email protected] Roll Dart SDK from 992221a362ec to 2bb85834e77e (7 revisions) (flutter/flutter#167361)
2025-04-17 [email protected] Added docstring for FilterInput::GetSnapshot (flutter/flutter#167226)
2025-04-17 [email protected] adds Entity docstrings (flutter/flutter#167228)
2025-04-17 [email protected] fixed impeller golden content scale (flutter/flutter#167308)
2025-04-17 [email protected] Added docstring for FilterContents::RenderFilter (flutter/flutter#167227)
2025-04-17 [email protected] Feat: Add equality to NoDefaultCupertinoThemeData (flutter/flutter#166655)
2025-04-17 [email protected] Fix link to engine docs (flutter/flutter#167346)
2025-04-17 [email protected] [macOS] Enable merged platform and UI thread by default (flutter/flutter#166536)
2025-04-17 [email protected] [Windows] Enable merged platform and UI thread by default (flutter/flutter#163726)
2025-04-17 [email protected] Update `CHANGELOG.md` (flutter/flutter#167225)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Ortes pushed a commit to Ortes/packages that referenced this pull request Jun 25, 2025
@engine-flutter-autoroll @Ortes
Roll Flutter from ecabb1a05212 to 3ed38e24528a (23 revisions) (flutte…
b319071 
…r#9114)

flutter/flutter@ecabb1a...3ed38e2

2025-04-18 [email protected] Update `led` docs (flutter/flutter#167380)
2025-04-18 [email protected] Throw an error if --local-engine-host is used without --local-engine (flutter/flutter#166948)
2025-04-18 [email protected] Add kotlin compatability to build file validation (flutter/flutter#167143)
2025-04-18 [email protected] Roll Skia from 844496884aa0 to 6c4595124690 (2 revisions) (flutter/flutter#167400)
2025-04-18 [email protected] Fix CarouselView crashes when initlal viewportDimension is 0.0 (flutter/flutter#167271)
2025-04-18 [email protected] Roll Dart SDK from b1eb743f97f5 to ab60afc99bcb (1 revision) (flutter/flutter#167396)
2025-04-18 [email protected] Add InputDecoration.visualDensity and InputDecorationTheme.visualDensity (flutter/flutter#166834)
2025-04-18 [email protected] Roll Skia from acc910544da7 to 844496884aa0 (1 revision) (flutter/flutter#167389)
2025-04-18 [email protected] Roll Skia from a409d685a711 to acc910544da7 (10 revisions) (flutter/flutter#167388)
2025-04-18 [email protected] Roll Dart SDK from 2bb85834e77e to b1eb743f97f5 (2 revisions) (flutter/flutter#167387)
2025-04-18 [email protected] Roll Fuchsia Linux SDK from m8Aln7fTF_8zy1V9N... to MwYckh5OvwwmIYLx0... (flutter/flutter#167385)
2025-04-17 [email protected] Roll Skia from cc2b57434651 to a409d685a711 (3 revisions) (flutter/flutter#167347)
2025-04-17 [email protected] Reduce app startup latency by initializing the engine on a separate thread (flutter/flutter#166918)
2025-04-17 [email protected] Roll Dart SDK from 992221a362ec to 2bb85834e77e (7 revisions) (flutter/flutter#167361)
2025-04-17 [email protected] Added docstring for FilterInput::GetSnapshot (flutter/flutter#167226)
2025-04-17 [email protected] adds Entity docstrings (flutter/flutter#167228)
2025-04-17 [email protected] fixed impeller golden content scale (flutter/flutter#167308)
2025-04-17 [email protected] Added docstring for FilterContents::RenderFilter (flutter/flutter#167227)
2025-04-17 [email protected] Feat: Add equality to NoDefaultCupertinoThemeData (flutter/flutter#166655)
2025-04-17 [email protected] Fix link to engine docs (flutter/flutter#167346)
2025-04-17 [email protected] [macOS] Enable merged platform and UI thread by default (flutter/flutter#166536)
2025-04-17 [email protected] [Windows] Enable merged platform and UI thread by default (flutter/flutter#163726)
2025-04-17 [email protected] Update `CHANGELOG.md` (flutter/flutter#167225)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 14, 2025
@engine-flutter-autoroll
434cb54e7 Feat: Add equality to NoDefaultCupertinoThemeData (flutter/…
9f38e38 
…flutter#166655)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 14, 2025
@engine-flutter-autoroll
434cb54e7 Feat: Add equality to NoDefaultCupertinoThemeData (flutter/…
306dcb7 
…flutter#166655)
romanejaquez pushed a commit to romanejaquez/flutter that referenced this pull request Aug 14, 2025
@rkishan516 @romanejaquez
Feat: Add equality to NoDefaultCupertinoThemeData (flutter#166655)
0254e82 
Feat: Add equality to NoDefaultCupertinoThemeData
fixes: flutter#165455 

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 15, 2025
@engine-flutter-autoroll
434cb54e7 Feat: Add equality to NoDefaultCupertinoThemeData (flutter/…
960da99 
…flutter#166655)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 15, 2025
@engine-flutter-autoroll
434cb54e7 Feat: Add equality to NoDefaultCupertinoThemeData (flutter/…
d170e82 
…flutter#166655)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 16, 2025
@engine-flutter-autoroll
434cb54e7 Feat: Add equality to NoDefaultCupertinoThemeData (flutter/…
33db445 
…flutter#166655)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@reidbaker reidbaker reidbaker approved these changes

@dkwingsmt dkwingsmt dkwingsmt approved these changes

Assignees

No one assigned

Labels

f: cupertino flutter/packages/flutter/cupertino repository framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Setting ThemeData.cupertinoOverrideTheme breaks themes equality and causes multiple rebuilds

3 participants

@rkishan516 @reidbaker @dkwingsmt