-
Notifications
You must be signed in to change notification settings - Fork 29.7k
Adding macrobenchmarks for DDC #166617
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Adding macrobenchmarks for DDC #166617
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@yjbanov PTAL - and lemme know if it's okay to stick you as a test owner. I don't mind owning this as well. |
yjbanov
reviewed
Apr 4, 2025
yjbanov
reviewed
Apr 9, 2025
yjbanov
approved these changes
Apr 11, 2025
Contributor
yjbanov
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
matanlurey
approved these changes
Apr 16, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Apr 16, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Apr 16, 2025
mboetger
pushed a commit
to mboetger/flutter
that referenced
this pull request
Apr 16, 2025
We're adding macrobenchmark support to DDC (AMD modules and our new hot-reload-capable module system) to be aware of any current/future performance regressions. I'm not terribly aware of the metrics collection pipeline; please let me know if we need to do any more work to see these tests run/report numbers to the proper dashboards.
auto-submit bot
pushed a commit
to flutter/packages
that referenced
this pull request
Apr 16, 2025
flutter/flutter@db68c95...aef4718 2025-04-16 [email protected] [Web] Remove `webOnlyUniformRadii` from `RRect` (flutter/flutter#167237) 2025-04-16 [email protected] Roll Skia from 76cb5d4fba27 to 6627deb65939 (10 revisions) (flutter/flutter#167249) 2025-04-16 [email protected] Adding macrobenchmarks for DDC (flutter/flutter#166617) 2025-04-15 [email protected] Add button icon support for animation duration (flutter/flutter#162667) 2025-04-15 [email protected] Roll Dartdoc to 8.3.3 (flutter/flutter#167231) 2025-04-15 [email protected] Removed superfluous copy in license checker (flutter/flutter#167146) 2025-04-15 [email protected] license checker: ignore git sha in dart license (flutter/flutter#167153) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
ash2moon
pushed a commit
to ash2moon/flutter
that referenced
this pull request
Apr 21, 2025
We're adding macrobenchmark support to DDC (AMD modules and our new hot-reload-capable module system) to be aware of any current/future performance regressions. I'm not terribly aware of the metrics collection pipeline; please let me know if we need to do any more work to see these tests run/report numbers to the proper dashboards.
CodixNinja
pushed a commit
to CodixNinja/packages
that referenced
this pull request
May 15, 2025
flutter/flutter@db68c95...aef4718 2025-04-16 [email protected] [Web] Remove `webOnlyUniformRadii` from `RRect` (flutter/flutter#167237) 2025-04-16 [email protected] Roll Skia from 76cb5d4fba27 to 6627deb65939 (10 revisions) (flutter/flutter#167249) 2025-04-16 [email protected] Adding macrobenchmarks for DDC (flutter/flutter#166617) 2025-04-15 [email protected] Add button icon support for animation duration (flutter/flutter#162667) 2025-04-15 [email protected] Roll Dartdoc to 8.3.3 (flutter/flutter#167231) 2025-04-15 [email protected] Removed superfluous copy in license checker (flutter/flutter#167146) 2025-04-15 [email protected] license checker: ignore git sha in dart license (flutter/flutter#167153) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
androidseb
pushed a commit
to androidseb/packages
that referenced
this pull request
Jun 8, 2025
…#9098) flutter/flutter@db68c95...aef4718 2025-04-16 [email protected] [Web] Remove `webOnlyUniformRadii` from `RRect` (flutter/flutter#167237) 2025-04-16 [email protected] Roll Skia from 76cb5d4fba27 to 6627deb65939 (10 revisions) (flutter/flutter#167249) 2025-04-16 [email protected] Adding macrobenchmarks for DDC (flutter/flutter#166617) 2025-04-15 [email protected] Add button icon support for animation duration (flutter/flutter#162667) 2025-04-15 [email protected] Roll Dartdoc to 8.3.3 (flutter/flutter#167231) 2025-04-15 [email protected] Removed superfluous copy in license checker (flutter/flutter#167146) 2025-04-15 [email protected] license checker: ignore git sha in dart license (flutter/flutter#167153) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
FMorschel
pushed a commit
to FMorschel/packages
that referenced
this pull request
Jun 9, 2025
…#9098) flutter/flutter@db68c95...aef4718 2025-04-16 [email protected] [Web] Remove `webOnlyUniformRadii` from `RRect` (flutter/flutter#167237) 2025-04-16 [email protected] Roll Skia from 76cb5d4fba27 to 6627deb65939 (10 revisions) (flutter/flutter#167249) 2025-04-16 [email protected] Adding macrobenchmarks for DDC (flutter/flutter#166617) 2025-04-15 [email protected] Add button icon support for animation duration (flutter/flutter#162667) 2025-04-15 [email protected] Roll Dartdoc to 8.3.3 (flutter/flutter#167231) 2025-04-15 [email protected] Removed superfluous copy in license checker (flutter/flutter#167146) 2025-04-15 [email protected] license checker: ignore git sha in dart license (flutter/flutter#167153) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Ortes
pushed a commit
to Ortes/packages
that referenced
this pull request
Jun 25, 2025
…#9098) flutter/flutter@db68c95...aef4718 2025-04-16 [email protected] [Web] Remove `webOnlyUniformRadii` from `RRect` (flutter/flutter#167237) 2025-04-16 [email protected] Roll Skia from 76cb5d4fba27 to 6627deb65939 (10 revisions) (flutter/flutter#167249) 2025-04-16 [email protected] Adding macrobenchmarks for DDC (flutter/flutter#166617) 2025-04-15 [email protected] Add button icon support for animation duration (flutter/flutter#162667) 2025-04-15 [email protected] Roll Dartdoc to 8.3.3 (flutter/flutter#167231) 2025-04-15 [email protected] Removed superfluous copy in license checker (flutter/flutter#167146) 2025-04-15 [email protected] license checker: ignore git sha in dart license (flutter/flutter#167153) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 14, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 14, 2025
romanejaquez
pushed a commit
to romanejaquez/flutter
that referenced
this pull request
Aug 14, 2025
We're adding macrobenchmark support to DDC (AMD modules and our new hot-reload-capable module system) to be aware of any current/future performance regressions. I'm not terribly aware of the metrics collection pipeline; please let me know if we need to do any more work to see these tests run/report numbers to the proper dashboards.
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 15, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 15, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.

We're adding macrobenchmark support to DDC (AMD modules and our new hot-reload-capable module system) to be aware of any current/future performance regressions. I'm not terribly aware of the metrics collection pipeline; please let me know if we need to do any more work to see these tests run/report numbers to the proper dashboards.