Skip to content

Reverts "[Impeller] Render conics without conversion from Flutter apps (#166305)" #166591

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
auto-submit merged 1 commit into from
Apr 4, 2025
Merged

Reverts "[Impeller] Render conics without conversion from Flutter apps (#166305)" #166591

auto-submit merged 1 commit into from
Apr 4, 2025

Conversation

@auto-submit
Copy link
Contributor

@auto-submit auto-submit bot commented Apr 4, 2025

Reverts: #166305

Initiated by: gaaclarke

Reason for reverting: Integration golden test failures. Please reland it this and address golden diffs.

Original PR Author: flar

Reviewed By: {jonahwilliams}

This change reverts the following previous change:
Now that Impeller performs high fidelity tessellation of Conic curves we will no longer convert Flutter app's conic curves into approximated quadratic curves.

@auto-submit auto-submit bot added the revert of Bot Only: Tracking label for bot. Tracks new revert of pull requests. label Apr 4, 2025
@github-actions github-actions bot added engine flutter/engine related. See also e: labels. e: impeller Impeller rendering backend issues and features requests labels Apr 4, 2025
@auto-submit auto-submit bot added this pull request to the merge queue Apr 4, 2025
eyebrowsoffire
eyebrowsoffire approved these changes Apr 4, 2025
View reviewed changes
Copy link
Contributor

@eyebrowsoffire eyebrowsoffire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Merged via the queue into master with commit b1c0809 Apr 4, 2025
8 of 11 checks passed
@auto-submit auto-submit bot deleted the revert_cb0e649e78368082b1b16ecabef0b5ba14b32ae3 branch April 4, 2025 17:40
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 4, 2025
@engine-flutter-autoroll
b1c0809 Reverts "[Impeller] Render conics without conversion from Flu…
85fb878 
…tter apps (#166305)" (flutter/flutter#166591)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 4, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 4, 2025
@engine-flutter-autoroll
b1c0809 Reverts "[Impeller] Render conics without conversion from Flu…
59f3c2d 
…tter apps (#166305)" (flutter/flutter#166591)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 4, 2025
Closed
@flar flar mentioned this pull request Apr 4, 2025
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 4, 2025
@engine-flutter-autoroll
b1c0809 Reverts "[Impeller] Render conics without conversion from Flu…
445b2c3 
…tter apps (#166305)" (flutter/flutter#166591)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 4, 2025
Closed
github-merge-queue bot pushed a commit that referenced this pull request Apr 4, 2025
@flar
Relands "[Impeller] Render conics without conversion from Flutter apps (
790d1b1 
#166305)" (#166598)

Reverts #166591

Golden diffs were not discovered the first time this was submitted.
Re-submitting to double check the goldens.
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 5, 2025
@engine-flutter-autoroll
b1c0809 Reverts "[Impeller] Render conics without conversion from Flu…
681e77d 
…tter apps (#166305)" (flutter/flutter#166591)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 5, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 5, 2025
@engine-flutter-autoroll
b1c0809 Reverts "[Impeller] Render conics without conversion from Flu…
a06a083 
…tter apps (#166305)" (flutter/flutter#166591)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 5, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 5, 2025
@engine-flutter-autoroll
b1c0809 Reverts "[Impeller] Render conics without conversion from Flu…
0c2fc79 
…tter apps (#166305)" (flutter/flutter#166591)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 5, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 6, 2025
@engine-flutter-autoroll
b1c0809 Reverts "[Impeller] Render conics without conversion from Flu…
a520f6b 
…tter apps (#166305)" (flutter/flutter#166591)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 6, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 6, 2025
@engine-flutter-autoroll
b1c0809 Reverts "[Impeller] Render conics without conversion from Flu…
bee42ce 
…tter apps (#166305)" (flutter/flutter#166591)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 6, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 8, 2025
@engine-flutter-autoroll
b1c0809 Reverts "[Impeller] Render conics without conversion from Flu…
598cc1a 
…tter apps (#166305)" (flutter/flutter#166591)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 8, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 8, 2025
@engine-flutter-autoroll
b1c0809 Reverts "[Impeller] Render conics without conversion from Flu…
fc7c4ad 
…tter apps (#166305)" (flutter/flutter#166591)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 8, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 8, 2025
@engine-flutter-autoroll
b1c0809 Reverts "[Impeller] Render conics without conversion from Flu…
b73a552 
…tter apps (#166305)" (flutter/flutter#166591)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 8, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 8, 2025
@engine-flutter-autoroll
b1c0809 Reverts "[Impeller] Render conics without conversion from Flu…
f374c6b 
…tter apps (#166305)" (flutter/flutter#166591)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 8, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 8, 2025
@engine-flutter-autoroll
b1c0809 Reverts "[Impeller] Render conics without conversion from Flu…
7677d05 
…tter apps (#166305)" (flutter/flutter#166591)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 8, 2025
@engine-flutter-autoroll
b1c0809 Reverts "[Impeller] Render conics without conversion from Flu…
a58c550 
…tter apps (#166305)" (flutter/flutter#166591)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 9, 2025
@engine-flutter-autoroll
b1c0809 Reverts "[Impeller] Render conics without conversion from Flu…
3ba154a 
…tter apps (#166305)" (flutter/flutter#166591)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 9, 2025
@engine-flutter-autoroll
b1c0809 Reverts "[Impeller] Render conics without conversion from Flu…
f323e77 
…tter apps (#166305)" (flutter/flutter#166591)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 9, 2025
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 9, 2025
@engine-flutter-autoroll
b1c0809 Reverts "[Impeller] Render conics without conversion from Flu…
3ecd1a4 
…tter apps (#166305)" (flutter/flutter#166591)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 9, 2025
@engine-flutter-autoroll
b1c0809 Reverts "[Impeller] Render conics without conversion from Flu…
7e0b77f 
…tter apps (#166305)" (flutter/flutter#166591)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 9, 2025
@engine-flutter-autoroll
b1c0809 Reverts "[Impeller] Render conics without conversion from Flu…
9d77bc2 
…tter apps (#166305)" (flutter/flutter#166591)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 9, 2025
@engine-flutter-autoroll
b1c0809 Reverts "[Impeller] Render conics without conversion from Flu…
4788c1b 
…tter apps (#166305)" (flutter/flutter#166591)
auto-submit bot pushed a commit to flutter/packages that referenced this pull request Apr 9, 2025
@engine-flutter-autoroll
Manual roll Flutter from 02f13c3 to 212064a (21 revisions) (#9036)
431dc61 
Manual roll requested by [email protected]

flutter/flutter@02f13c3...212064a

2025-04-06 [email protected] Roll Skia from 8f1638231e34 to da7929d79c28 (1 revision) (flutter/flutter#166657)
2025-04-06 [email protected] Roll Skia from 943df306bc3a to 8f1638231e34 (2 revisions) (flutter/flutter#166647)
2025-04-05 98614782+auto-submit[bot]@users.noreply.github.com Reverts "[web] fix text selection offset in multi-line fields (#166565)" (flutter/flutter#166644)
2025-04-04 [email protected] Roll Skia from a7da13848085 to 943df306bc3a (8 revisions) (flutter/flutter#166609)
2025-04-04 [email protected] Adds semantics input type (flutter/flutter#165925)
2025-04-04 [email protected] Relands "[Impeller] Render conics without conversion from Flutter apps (#166305)" (flutter/flutter#166598)
2025-04-04 [email protected] [web] fix text selection offset in multi-line fields (flutter/flutter#166565)
2025-04-04 [email protected] [Impeller] if drawTextFrame scale is massive, convert to Path. (flutter/flutter#166234)
2025-04-04 [email protected] [ Widget Previews ] Add `widget_preview_scaffold.shard` to test the `widget_preview_scaffold` template contents (flutter/flutter#166358)
2025-04-04 [email protected] [Embedder] Only call removeview callback when raster thread is done with the view (flutter/flutter#164571)
2025-04-04 [email protected] Roll Packages from 4a36dc6 to 267ac7b (2 revisions) (flutter/flutter#166583)
2025-04-04 [email protected] Roll Dart SDK from 4293d50dd30d to 87965ab4864e (3 revisions) (flutter/flutter#166571)
2025-04-04 [email protected] Disable firefox image_to_byte_data_test as a group. (flutter/flutter#166559)
2025-04-04 [email protected] Add x64 ddm variants (flutter/flutter#166511)
2025-04-04 [email protected] Roll Skia from af7ff0e98c4e to a7da13848085 (3 revisions) (flutter/flutter#166560)
2025-04-04 98614782+auto-submit[bot]@users.noreply.github.com Reverts "[Impeller] Render conics without conversion from Flutter apps (#166305)" (flutter/flutter#166591)
2025-04-03 [email protected] Roll Dart SDK from d174ec16c3ea to 4293d50dd30d (1 revision) (flutter/flutter#166557)
2025-04-03 [email protected] Roll Skia from 5f65df75febd to af7ff0e98c4e (7 revisions) (flutter/flutter#166551)
2025-04-03 [email protected] [Impeller] Render conics without conversion from Flutter apps (flutter/flutter#166305)
2025-04-03 [email protected] Update localizations from console (flutter/flutter#166496)
2025-04-03 [email protected] Roll Fuchsia GN SDK from K_1kHDN1WfObPYHya... to jsZSHIOmQAs3URvWU... (flutter/flutter#166544)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
nick-llewellyn pushed a commit to labrystechnology/flutter_packages that referenced this pull request Apr 23, 2025
@engine-flutter-autoroll @nick-llewellyn
Manual roll Flutter from 02f13c3 to 212064a (21 revisions) (flutter#9036
26190fa 
)

Manual roll requested by [email protected]

flutter/flutter@02f13c3...212064a

2025-04-06 [email protected] Roll Skia from 8f1638231e34 to da7929d79c28 (1 revision) (flutter/flutter#166657)
2025-04-06 [email protected] Roll Skia from 943df306bc3a to 8f1638231e34 (2 revisions) (flutter/flutter#166647)
2025-04-05 98614782+auto-submit[bot]@users.noreply.github.com Reverts "[web] fix text selection offset in multi-line fields (#166565)" (flutter/flutter#166644)
2025-04-04 [email protected] Roll Skia from a7da13848085 to 943df306bc3a (8 revisions) (flutter/flutter#166609)
2025-04-04 [email protected] Adds semantics input type (flutter/flutter#165925)
2025-04-04 [email protected] Relands "[Impeller] Render conics without conversion from Flutter apps (#166305)" (flutter/flutter#166598)
2025-04-04 [email protected] [web] fix text selection offset in multi-line fields (flutter/flutter#166565)
2025-04-04 [email protected] [Impeller] if drawTextFrame scale is massive, convert to Path. (flutter/flutter#166234)
2025-04-04 [email protected] [ Widget Previews ] Add `widget_preview_scaffold.shard` to test the `widget_preview_scaffold` template contents (flutter/flutter#166358)
2025-04-04 [email protected] [Embedder] Only call removeview callback when raster thread is done with the view (flutter/flutter#164571)
2025-04-04 [email protected] Roll Packages from 4a36dc6 to 267ac7b (2 revisions) (flutter/flutter#166583)
2025-04-04 [email protected] Roll Dart SDK from 4293d50dd30d to 87965ab4864e (3 revisions) (flutter/flutter#166571)
2025-04-04 [email protected] Disable firefox image_to_byte_data_test as a group. (flutter/flutter#166559)
2025-04-04 [email protected] Add x64 ddm variants (flutter/flutter#166511)
2025-04-04 [email protected] Roll Skia from af7ff0e98c4e to a7da13848085 (3 revisions) (flutter/flutter#166560)
2025-04-04 98614782+auto-submit[bot]@users.noreply.github.com Reverts "[Impeller] Render conics without conversion from Flutter apps (#166305)" (flutter/flutter#166591)
2025-04-03 [email protected] Roll Dart SDK from d174ec16c3ea to 4293d50dd30d (1 revision) (flutter/flutter#166557)
2025-04-03 [email protected] Roll Skia from 5f65df75febd to af7ff0e98c4e (7 revisions) (flutter/flutter#166551)
2025-04-03 [email protected] [Impeller] Render conics without conversion from Flutter apps (flutter/flutter#166305)
2025-04-03 [email protected] Update localizations from console (flutter/flutter#166496)
2025-04-03 [email protected] Roll Fuchsia GN SDK from K_1kHDN1WfObPYHya... to jsZSHIOmQAs3URvWU... (flutter/flutter#166544)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
CodixNinja pushed a commit to CodixNinja/packages that referenced this pull request May 15, 2025
@engine-flutter-autoroll
Manual roll Flutter from 02f13c37841f to 212064a3e558 (21 revisions) …
b2c45f9 
…(#9036)

Manual roll requested by [email protected]

flutter/flutter@02f13c3...212064a

2025-04-06 [email protected] Roll Skia from 8f1638231e34 to da7929d79c28 (1 revision) (flutter/flutter#166657)
2025-04-06 [email protected] Roll Skia from 943df306bc3a to 8f1638231e34 (2 revisions) (flutter/flutter#166647)
2025-04-05 98614782+auto-submit[bot]@users.noreply.github.com Reverts "[web] fix text selection offset in multi-line fields (#166565)" (flutter/flutter#166644)
2025-04-04 [email protected] Roll Skia from a7da13848085 to 943df306bc3a (8 revisions) (flutter/flutter#166609)
2025-04-04 [email protected] Adds semantics input type (flutter/flutter#165925)
2025-04-04 [email protected] Relands "[Impeller] Render conics without conversion from Flutter apps (#166305)" (flutter/flutter#166598)
2025-04-04 [email protected] [web] fix text selection offset in multi-line fields (flutter/flutter#166565)
2025-04-04 [email protected] [Impeller] if drawTextFrame scale is massive, convert to Path. (flutter/flutter#166234)
2025-04-04 [email protected] [ Widget Previews ] Add `widget_preview_scaffold.shard` to test the `widget_preview_scaffold` template contents (flutter/flutter#166358)
2025-04-04 [email protected] [Embedder] Only call removeview callback when raster thread is done with the view (flutter/flutter#164571)
2025-04-04 [email protected] Roll Packages from 95f8e65 to 57f42e1 (2 revisions) (flutter/flutter#166583)
2025-04-04 [email protected] Roll Dart SDK from 4293d50dd30d to 87965ab4864e (3 revisions) (flutter/flutter#166571)
2025-04-04 [email protected] Disable firefox image_to_byte_data_test as a group. (flutter/flutter#166559)
2025-04-04 [email protected] Add x64 ddm variants (flutter/flutter#166511)
2025-04-04 [email protected] Roll Skia from af7ff0e98c4e to a7da13848085 (3 revisions) (flutter/flutter#166560)
2025-04-04 98614782+auto-submit[bot]@users.noreply.github.com Reverts "[Impeller] Render conics without conversion from Flutter apps (#166305)" (flutter/flutter#166591)
2025-04-03 [email protected] Roll Dart SDK from d174ec16c3ea to 4293d50dd30d (1 revision) (flutter/flutter#166557)
2025-04-03 [email protected] Roll Skia from 5f65df75febd to af7ff0e98c4e (7 revisions) (flutter/flutter#166551)
2025-04-03 [email protected] [Impeller] Render conics without conversion from Flutter apps (flutter/flutter#166305)
2025-04-03 [email protected] Update localizations from console (flutter/flutter#166496)
2025-04-03 [email protected] Roll Fuchsia GN SDK from K_1kHDN1WfObPYHya... to jsZSHIOmQAs3URvWU... (flutter/flutter#166544)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 20, 2025
@engine-flutter-autoroll
b1c0809 Reverts "[Impeller] Render conics without conversion from Flu…
eceb0f3 
…tter apps (#166305)" (flutter/flutter#166591)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 20, 2025
@engine-flutter-autoroll
b1c0809 Reverts "[Impeller] Render conics without conversion from Flu…
d081856 
…tter apps (#166305)" (flutter/flutter#166591)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 21, 2025
@engine-flutter-autoroll
b1c0809 Reverts "[Impeller] Render conics without conversion from Flu…
9c07079 
…tter apps (#166305)" (flutter/flutter#166591)
androidseb pushed a commit to androidseb/packages that referenced this pull request Jun 8, 2025
@engine-flutter-autoroll @androidseb
Manual roll Flutter from 02f13c3 to 212064a (21 revisions) (flutter#9036
772704a 
)

Manual roll requested by [email protected]

flutter/flutter@02f13c3...212064a

2025-04-06 [email protected] Roll Skia from 8f1638231e34 to da7929d79c28 (1 revision) (flutter/flutter#166657)
2025-04-06 [email protected] Roll Skia from 943df306bc3a to 8f1638231e34 (2 revisions) (flutter/flutter#166647)
2025-04-05 98614782+auto-submit[bot]@users.noreply.github.com Reverts "[web] fix text selection offset in multi-line fields (#166565)" (flutter/flutter#166644)
2025-04-04 [email protected] Roll Skia from a7da13848085 to 943df306bc3a (8 revisions) (flutter/flutter#166609)
2025-04-04 [email protected] Adds semantics input type (flutter/flutter#165925)
2025-04-04 [email protected] Relands "[Impeller] Render conics without conversion from Flutter apps (#166305)" (flutter/flutter#166598)
2025-04-04 [email protected] [web] fix text selection offset in multi-line fields (flutter/flutter#166565)
2025-04-04 [email protected] [Impeller] if drawTextFrame scale is massive, convert to Path. (flutter/flutter#166234)
2025-04-04 [email protected] [ Widget Previews ] Add `widget_preview_scaffold.shard` to test the `widget_preview_scaffold` template contents (flutter/flutter#166358)
2025-04-04 [email protected] [Embedder] Only call removeview callback when raster thread is done with the view (flutter/flutter#164571)
2025-04-04 [email protected] Roll Packages from 4a36dc6 to 267ac7b (2 revisions) (flutter/flutter#166583)
2025-04-04 [email protected] Roll Dart SDK from 4293d50dd30d to 87965ab4864e (3 revisions) (flutter/flutter#166571)
2025-04-04 [email protected] Disable firefox image_to_byte_data_test as a group. (flutter/flutter#166559)
2025-04-04 [email protected] Add x64 ddm variants (flutter/flutter#166511)
2025-04-04 [email protected] Roll Skia from af7ff0e98c4e to a7da13848085 (3 revisions) (flutter/flutter#166560)
2025-04-04 98614782+auto-submit[bot]@users.noreply.github.com Reverts "[Impeller] Render conics without conversion from Flutter apps (#166305)" (flutter/flutter#166591)
2025-04-03 [email protected] Roll Dart SDK from d174ec16c3ea to 4293d50dd30d (1 revision) (flutter/flutter#166557)
2025-04-03 [email protected] Roll Skia from 5f65df75febd to af7ff0e98c4e (7 revisions) (flutter/flutter#166551)
2025-04-03 [email protected] [Impeller] Render conics without conversion from Flutter apps (flutter/flutter#166305)
2025-04-03 [email protected] Update localizations from console (flutter/flutter#166496)
2025-04-03 [email protected] Roll Fuchsia GN SDK from K_1kHDN1WfObPYHya... to jsZSHIOmQAs3URvWU... (flutter/flutter#166544)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
zhangyuang pushed a commit to zhangyuang/flutter-fork that referenced this pull request Jun 9, 2025
@auto-submit
Reverts "[Impeller] Render conics without conversion from Flutter apps (
53bba3c 
flutter#166305)" (flutter#166591)

<!-- start_original_pr_link -->
Reverts: flutter#166305
<!-- end_original_pr_link -->
<!-- start_initiating_author -->
Initiated by: gaaclarke
<!-- end_initiating_author -->
<!-- start_revert_reason -->
Reason for reverting: Integration golden test failures. Please reland it
this and address golden diffs.
<!-- end_revert_reason -->
<!-- start_original_pr_author -->
Original PR Author: flar
<!-- end_original_pr_author -->

<!-- start_reviewers -->
Reviewed By: {jonahwilliams}
<!-- end_reviewers -->

<!-- start_revert_body -->
This change reverts the following previous change:
Now that Impeller performs high fidelity tessellation of Conic curves we
will no longer convert Flutter app's conic curves into approximated
quadratic curves.
<!-- end_revert_body -->

Co-authored-by: auto-submit[bot] <[email protected]>
zhangyuang pushed a commit to zhangyuang/flutter-fork that referenced this pull request Jun 9, 2025
@flar
Relands "[Impeller] Render conics without conversion from Flutter apps (
64172ac 
flutter#166305)" (flutter#166598)

Reverts flutter#166591

Golden diffs were not discovered the first time this was submitted.
Re-submitting to double check the goldens.
FMorschel pushed a commit to FMorschel/packages that referenced this pull request Jun 9, 2025
@engine-flutter-autoroll @FMorschel
Manual roll Flutter from 02f13c3 to 212064a (21 revisions) (flutter#9036
a222ab8 
)

Manual roll requested by [email protected]

flutter/flutter@02f13c3...212064a

2025-04-06 [email protected] Roll Skia from 8f1638231e34 to da7929d79c28 (1 revision) (flutter/flutter#166657)
2025-04-06 [email protected] Roll Skia from 943df306bc3a to 8f1638231e34 (2 revisions) (flutter/flutter#166647)
2025-04-05 98614782+auto-submit[bot]@users.noreply.github.com Reverts "[web] fix text selection offset in multi-line fields (#166565)" (flutter/flutter#166644)
2025-04-04 [email protected] Roll Skia from a7da13848085 to 943df306bc3a (8 revisions) (flutter/flutter#166609)
2025-04-04 [email protected] Adds semantics input type (flutter/flutter#165925)
2025-04-04 [email protected] Relands "[Impeller] Render conics without conversion from Flutter apps (#166305)" (flutter/flutter#166598)
2025-04-04 [email protected] [web] fix text selection offset in multi-line fields (flutter/flutter#166565)
2025-04-04 [email protected] [Impeller] if drawTextFrame scale is massive, convert to Path. (flutter/flutter#166234)
2025-04-04 [email protected] [ Widget Previews ] Add `widget_preview_scaffold.shard` to test the `widget_preview_scaffold` template contents (flutter/flutter#166358)
2025-04-04 [email protected] [Embedder] Only call removeview callback when raster thread is done with the view (flutter/flutter#164571)
2025-04-04 [email protected] Roll Packages from 4a36dc6 to 267ac7b (2 revisions) (flutter/flutter#166583)
2025-04-04 [email protected] Roll Dart SDK from 4293d50dd30d to 87965ab4864e (3 revisions) (flutter/flutter#166571)
2025-04-04 [email protected] Disable firefox image_to_byte_data_test as a group. (flutter/flutter#166559)
2025-04-04 [email protected] Add x64 ddm variants (flutter/flutter#166511)
2025-04-04 [email protected] Roll Skia from af7ff0e98c4e to a7da13848085 (3 revisions) (flutter/flutter#166560)
2025-04-04 98614782+auto-submit[bot]@users.noreply.github.com Reverts "[Impeller] Render conics without conversion from Flutter apps (#166305)" (flutter/flutter#166591)
2025-04-03 [email protected] Roll Dart SDK from d174ec16c3ea to 4293d50dd30d (1 revision) (flutter/flutter#166557)
2025-04-03 [email protected] Roll Skia from 5f65df75febd to af7ff0e98c4e (7 revisions) (flutter/flutter#166551)
2025-04-03 [email protected] [Impeller] Render conics without conversion from Flutter apps (flutter/flutter#166305)
2025-04-03 [email protected] Update localizations from console (flutter/flutter#166496)
2025-04-03 [email protected] Roll Fuchsia GN SDK from K_1kHDN1WfObPYHya... to jsZSHIOmQAs3URvWU... (flutter/flutter#166544)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Ortes pushed a commit to Ortes/packages that referenced this pull request Jun 25, 2025
@engine-flutter-autoroll @Ortes
Manual roll Flutter from 02f13c3 to 212064a (21 revisions) (flutter#9036
c3facb2 
)

Manual roll requested by [email protected]

flutter/flutter@02f13c3...212064a

2025-04-06 [email protected] Roll Skia from 8f1638231e34 to da7929d79c28 (1 revision) (flutter/flutter#166657)
2025-04-06 [email protected] Roll Skia from 943df306bc3a to 8f1638231e34 (2 revisions) (flutter/flutter#166647)
2025-04-05 98614782+auto-submit[bot]@users.noreply.github.com Reverts "[web] fix text selection offset in multi-line fields (#166565)" (flutter/flutter#166644)
2025-04-04 [email protected] Roll Skia from a7da13848085 to 943df306bc3a (8 revisions) (flutter/flutter#166609)
2025-04-04 [email protected] Adds semantics input type (flutter/flutter#165925)
2025-04-04 [email protected] Relands "[Impeller] Render conics without conversion from Flutter apps (#166305)" (flutter/flutter#166598)
2025-04-04 [email protected] [web] fix text selection offset in multi-line fields (flutter/flutter#166565)
2025-04-04 [email protected] [Impeller] if drawTextFrame scale is massive, convert to Path. (flutter/flutter#166234)
2025-04-04 [email protected] [ Widget Previews ] Add `widget_preview_scaffold.shard` to test the `widget_preview_scaffold` template contents (flutter/flutter#166358)
2025-04-04 [email protected] [Embedder] Only call removeview callback when raster thread is done with the view (flutter/flutter#164571)
2025-04-04 [email protected] Roll Packages from 4a36dc6 to 267ac7b (2 revisions) (flutter/flutter#166583)
2025-04-04 [email protected] Roll Dart SDK from 4293d50dd30d to 87965ab4864e (3 revisions) (flutter/flutter#166571)
2025-04-04 [email protected] Disable firefox image_to_byte_data_test as a group. (flutter/flutter#166559)
2025-04-04 [email protected] Add x64 ddm variants (flutter/flutter#166511)
2025-04-04 [email protected] Roll Skia from af7ff0e98c4e to a7da13848085 (3 revisions) (flutter/flutter#166560)
2025-04-04 98614782+auto-submit[bot]@users.noreply.github.com Reverts "[Impeller] Render conics without conversion from Flutter apps (#166305)" (flutter/flutter#166591)
2025-04-03 [email protected] Roll Dart SDK from d174ec16c3ea to 4293d50dd30d (1 revision) (flutter/flutter#166557)
2025-04-03 [email protected] Roll Skia from 5f65df75febd to af7ff0e98c4e (7 revisions) (flutter/flutter#166551)
2025-04-03 [email protected] [Impeller] Render conics without conversion from Flutter apps (flutter/flutter#166305)
2025-04-03 [email protected] Update localizations from console (flutter/flutter#166496)
2025-04-03 [email protected] Roll Fuchsia GN SDK from K_1kHDN1WfObPYHya... to jsZSHIOmQAs3URvWU... (flutter/flutter#166544)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
romanejaquez pushed a commit to romanejaquez/flutter that referenced this pull request Aug 14, 2025
@auto-submit @romanejaquez
Reverts "[Impeller] Render conics without conversion from Flutter apps (
f1fe3c3 
flutter#166305)" (flutter#166591)

<!-- start_original_pr_link -->
Reverts: flutter#166305
<!-- end_original_pr_link -->
<!-- start_initiating_author -->
Initiated by: gaaclarke
<!-- end_initiating_author -->
<!-- start_revert_reason -->
Reason for reverting: Integration golden test failures. Please reland it
this and address golden diffs.
<!-- end_revert_reason -->
<!-- start_original_pr_author -->
Original PR Author: flar
<!-- end_original_pr_author -->

<!-- start_reviewers -->
Reviewed By: {jonahwilliams}
<!-- end_reviewers -->

<!-- start_revert_body -->
This change reverts the following previous change:
Now that Impeller performs high fidelity tessellation of Conic curves we
will no longer convert Flutter app's conic curves into approximated
quadratic curves.
<!-- end_revert_body -->

Co-authored-by: auto-submit[bot] <[email protected]>
romanejaquez pushed a commit to romanejaquez/flutter that referenced this pull request Aug 14, 2025
@flar @romanejaquez
Relands "[Impeller] Render conics without conversion from Flutter apps (
dbf7f47 
flutter#166305)" (flutter#166598)

Reverts flutter#166591

Golden diffs were not discovered the first time this was submitted.
Re-submitting to double check the goldens.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@eyebrowsoffire eyebrowsoffire eyebrowsoffire approved these changes

@gaaclarke gaaclarke gaaclarke approved these changes

@fluttergithubbot fluttergithubbot fluttergithubbot approved these changes

Assignees

@gaaclarke gaaclarke

Labels

e: impeller Impeller rendering backend issues and features requests engine flutter/engine related. See also e: labels. revert of Bot Only: Tracking label for bot. Tracks new revert of pull requests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@eyebrowsoffire @gaaclarke @fluttergithubbot