Skip to content

[macOS] Enable merged platform and UI thread by default #166536

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
knopp merged 2 commits into from
Apr 17, 2025
Merged

[macOS] Enable merged platform and UI thread by default #166536

knopp merged 2 commits into from
Apr 17, 2025

Conversation

@knopp
Copy link
Member

@knopp knopp commented Apr 3, 2025

This enables running UI isolate on platform thread by default.

Pre-launch Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@knopp
Copy link
Member Author

knopp commented Apr 3, 2025

Ideally, this should be merged same time as #163726.

@github-actions github-actions bot added engine flutter/engine related. See also e: labels. a: desktop Running on desktop platform-macos labels Apr 3, 2025
@knopp knopp changed the title WIP: [macOS] Enable merged platform and UI thread by default [macOS] Enable merged platform and UI thread by default Apr 3, 2025
jonahwilliams
jonahwilliams approved these changes Apr 9, 2025
View reviewed changes
Copy link
Contributor

@jonahwilliams jonahwilliams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@knopp knopp force-pushed the macos_enable_merged_threads_by_default branch 4 times, most recently from be9c9d9 to 1341372 Compare April 16, 2025 10:10
@flutter-dashboard
Copy link

flutter-dashboard bot commented Apr 16, 2025

Golden file changes have been found for this pull request. Click here to view and triage (e.g. because this is an intentional change).

If you are still iterating on this change and are not ready to resolve the images on the Flutter Gold dashboard, consider marking this PR as a draft pull request above. You will still be able to view image results on the dashboard, commenting will be silenced, and the check will not try to resolve itself until marked ready for review.

For more guidance, visit Writing a golden file test for package:flutter.

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

Changes reported for pull request #166536 at sha 1341372

@flutter-dashboard flutter-dashboard bot added the will affect goldens Changes to golden files label Apr 16, 2025
@knopp
Copy link
Member Author

knopp commented Apr 16, 2025

Can we get this in? I think the goldens is a fluke and google testing seems still broken.

@knopp knopp force-pushed the macos_enable_merged_threads_by_default branch from 1341372 to b6129e4 Compare April 17, 2025 14:12
@knopp knopp added this pull request to the merge queue Apr 17, 2025
Merged via the queue into flutter:master with commit 9d3d0dc Apr 17, 2025
176 of 177 checks passed
@knopp knopp deleted the macos_enable_merged_threads_by_default branch April 17, 2025 16:16
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 18, 2025
@engine-flutter-autoroll
9d3d0dc0e [macOS] Enable merged platform and UI thread by default (fl…
78abe6d 
…utter/flutter#166536)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 18, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 18, 2025
@engine-flutter-autoroll
9d3d0dc0e [macOS] Enable merged platform and UI thread by default (fl…
a42084a 
…utter/flutter#166536)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 18, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 18, 2025
@engine-flutter-autoroll
9d3d0dc0e [macOS] Enable merged platform and UI thread by default (fl…
6819338 
…utter/flutter#166536)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 18, 2025
Merged
auto-submit bot pushed a commit to flutter/packages that referenced this pull request Apr 18, 2025
@engine-flutter-autoroll
Roll Flutter from ecabb1a05212 to 3ed38e24528a (23 revisions) (#9114)
bfb42a6 
flutter/flutter@ecabb1a...3ed38e2

2025-04-18 [email protected] Update `led` docs (flutter/flutter#167380)
2025-04-18 [email protected] Throw an error if --local-engine-host is used without --local-engine (flutter/flutter#166948)
2025-04-18 [email protected] Add kotlin compatability to build file validation (flutter/flutter#167143)
2025-04-18 [email protected] Roll Skia from 844496884aa0 to 6c4595124690 (2 revisions) (flutter/flutter#167400)
2025-04-18 [email protected] Fix CarouselView crashes when initlal viewportDimension is 0.0 (flutter/flutter#167271)
2025-04-18 [email protected] Roll Dart SDK from b1eb743f97f5 to ab60afc99bcb (1 revision) (flutter/flutter#167396)
2025-04-18 [email protected] Add InputDecoration.visualDensity and InputDecorationTheme.visualDensity (flutter/flutter#166834)
2025-04-18 [email protected] Roll Skia from acc910544da7 to 844496884aa0 (1 revision) (flutter/flutter#167389)
2025-04-18 [email protected] Roll Skia from a409d685a711 to acc910544da7 (10 revisions) (flutter/flutter#167388)
2025-04-18 [email protected] Roll Dart SDK from 2bb85834e77e to b1eb743f97f5 (2 revisions) (flutter/flutter#167387)
2025-04-18 [email protected] Roll Fuchsia Linux SDK from m8Aln7fTF_8zy1V9N... to MwYckh5OvwwmIYLx0... (flutter/flutter#167385)
2025-04-17 [email protected] Roll Skia from cc2b57434651 to a409d685a711 (3 revisions) (flutter/flutter#167347)
2025-04-17 [email protected] Reduce app startup latency by initializing the engine on a separate thread (flutter/flutter#166918)
2025-04-17 [email protected] Roll Dart SDK from 992221a362ec to 2bb85834e77e (7 revisions) (flutter/flutter#167361)
2025-04-17 [email protected] Added docstring for FilterInput::GetSnapshot (flutter/flutter#167226)
2025-04-17 [email protected] adds Entity docstrings (flutter/flutter#167228)
2025-04-17 [email protected] fixed impeller golden content scale (flutter/flutter#167308)
2025-04-17 [email protected] Added docstring for FilterContents::RenderFilter (flutter/flutter#167227)
2025-04-17 [email protected] Feat: Add equality to NoDefaultCupertinoThemeData (flutter/flutter#166655)
2025-04-17 [email protected] Fix link to engine docs (flutter/flutter#167346)
2025-04-17 [email protected] [macOS] Enable merged platform and UI thread by default (flutter/flutter#166536)
2025-04-17 [email protected] [Windows] Enable merged platform and UI thread by default (flutter/flutter#163726)
2025-04-17 [email protected] Update `CHANGELOG.md` (flutter/flutter#167225)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
ash2moon pushed a commit to ash2moon/flutter that referenced this pull request Apr 21, 2025
@knopp @ash2moon
[macOS] Enable merged platform and UI thread by default (flutter#166536)
669140b 
This enables running UI isolate on platform thread by default.

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
CodixNinja pushed a commit to CodixNinja/packages that referenced this pull request May 15, 2025
@engine-flutter-autoroll
Roll Flutter from ecabb1a05212 to 3ed38e24528a (23 revisions) (#9114)
83531f2 
flutter/flutter@ecabb1a...3ed38e2

2025-04-18 [email protected] Update `led` docs (flutter/flutter#167380)
2025-04-18 [email protected] Throw an error if --local-engine-host is used without --local-engine (flutter/flutter#166948)
2025-04-18 [email protected] Add kotlin compatability to build file validation (flutter/flutter#167143)
2025-04-18 [email protected] Roll Skia from 844496884aa0 to 6c4595124690 (2 revisions) (flutter/flutter#167400)
2025-04-18 [email protected] Fix CarouselView crashes when initlal viewportDimension is 0.0 (flutter/flutter#167271)
2025-04-18 [email protected] Roll Dart SDK from b1eb743f97f5 to ab60afc99bcb (1 revision) (flutter/flutter#167396)
2025-04-18 [email protected] Add InputDecoration.visualDensity and InputDecorationTheme.visualDensity (flutter/flutter#166834)
2025-04-18 [email protected] Roll Skia from acc910544da7 to 844496884aa0 (1 revision) (flutter/flutter#167389)
2025-04-18 [email protected] Roll Skia from a409d685a711 to acc910544da7 (10 revisions) (flutter/flutter#167388)
2025-04-18 [email protected] Roll Dart SDK from 2bb85834e77e to b1eb743f97f5 (2 revisions) (flutter/flutter#167387)
2025-04-18 [email protected] Roll Fuchsia Linux SDK from m8Aln7fTF_8zy1V9N... to MwYckh5OvwwmIYLx0... (flutter/flutter#167385)
2025-04-17 [email protected] Roll Skia from cc2b57434651 to a409d685a711 (3 revisions) (flutter/flutter#167347)
2025-04-17 [email protected] Reduce app startup latency by initializing the engine on a separate thread (flutter/flutter#166918)
2025-04-17 [email protected] Roll Dart SDK from 992221a362ec to 2bb85834e77e (7 revisions) (flutter/flutter#167361)
2025-04-17 [email protected] Added docstring for FilterInput::GetSnapshot (flutter/flutter#167226)
2025-04-17 [email protected] adds Entity docstrings (flutter/flutter#167228)
2025-04-17 [email protected] fixed impeller golden content scale (flutter/flutter#167308)
2025-04-17 [email protected] Added docstring for FilterContents::RenderFilter (flutter/flutter#167227)
2025-04-17 [email protected] Feat: Add equality to NoDefaultCupertinoThemeData (flutter/flutter#166655)
2025-04-17 [email protected] Fix link to engine docs (flutter/flutter#167346)
2025-04-17 [email protected] [macOS] Enable merged platform and UI thread by default (flutter/flutter#166536)
2025-04-17 [email protected] [Windows] Enable merged platform and UI thread by default (flutter/flutter#163726)
2025-04-17 [email protected] Update `CHANGELOG.md` (flutter/flutter#167225)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
androidseb pushed a commit to androidseb/packages that referenced this pull request Jun 8, 2025
@engine-flutter-autoroll @androidseb
Roll Flutter from ecabb1a05212 to 3ed38e24528a (23 revisions) (flutte…
04ead92 
…r#9114)

flutter/flutter@ecabb1a...3ed38e2

2025-04-18 [email protected] Update `led` docs (flutter/flutter#167380)
2025-04-18 [email protected] Throw an error if --local-engine-host is used without --local-engine (flutter/flutter#166948)
2025-04-18 [email protected] Add kotlin compatability to build file validation (flutter/flutter#167143)
2025-04-18 [email protected] Roll Skia from 844496884aa0 to 6c4595124690 (2 revisions) (flutter/flutter#167400)
2025-04-18 [email protected] Fix CarouselView crashes when initlal viewportDimension is 0.0 (flutter/flutter#167271)
2025-04-18 [email protected] Roll Dart SDK from b1eb743f97f5 to ab60afc99bcb (1 revision) (flutter/flutter#167396)
2025-04-18 [email protected] Add InputDecoration.visualDensity and InputDecorationTheme.visualDensity (flutter/flutter#166834)
2025-04-18 [email protected] Roll Skia from acc910544da7 to 844496884aa0 (1 revision) (flutter/flutter#167389)
2025-04-18 [email protected] Roll Skia from a409d685a711 to acc910544da7 (10 revisions) (flutter/flutter#167388)
2025-04-18 [email protected] Roll Dart SDK from 2bb85834e77e to b1eb743f97f5 (2 revisions) (flutter/flutter#167387)
2025-04-18 [email protected] Roll Fuchsia Linux SDK from m8Aln7fTF_8zy1V9N... to MwYckh5OvwwmIYLx0... (flutter/flutter#167385)
2025-04-17 [email protected] Roll Skia from cc2b57434651 to a409d685a711 (3 revisions) (flutter/flutter#167347)
2025-04-17 [email protected] Reduce app startup latency by initializing the engine on a separate thread (flutter/flutter#166918)
2025-04-17 [email protected] Roll Dart SDK from 992221a362ec to 2bb85834e77e (7 revisions) (flutter/flutter#167361)
2025-04-17 [email protected] Added docstring for FilterInput::GetSnapshot (flutter/flutter#167226)
2025-04-17 [email protected] adds Entity docstrings (flutter/flutter#167228)
2025-04-17 [email protected] fixed impeller golden content scale (flutter/flutter#167308)
2025-04-17 [email protected] Added docstring for FilterContents::RenderFilter (flutter/flutter#167227)
2025-04-17 [email protected] Feat: Add equality to NoDefaultCupertinoThemeData (flutter/flutter#166655)
2025-04-17 [email protected] Fix link to engine docs (flutter/flutter#167346)
2025-04-17 [email protected] [macOS] Enable merged platform and UI thread by default (flutter/flutter#166536)
2025-04-17 [email protected] [Windows] Enable merged platform and UI thread by default (flutter/flutter#163726)
2025-04-17 [email protected] Update `CHANGELOG.md` (flutter/flutter#167225)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
FMorschel pushed a commit to FMorschel/packages that referenced this pull request Jun 9, 2025
@engine-flutter-autoroll @FMorschel
Roll Flutter from ecabb1a05212 to 3ed38e24528a (23 revisions) (flutte…
993466f 
…r#9114)

flutter/flutter@ecabb1a...3ed38e2

2025-04-18 [email protected] Update `led` docs (flutter/flutter#167380)
2025-04-18 [email protected] Throw an error if --local-engine-host is used without --local-engine (flutter/flutter#166948)
2025-04-18 [email protected] Add kotlin compatability to build file validation (flutter/flutter#167143)
2025-04-18 [email protected] Roll Skia from 844496884aa0 to 6c4595124690 (2 revisions) (flutter/flutter#167400)
2025-04-18 [email protected] Fix CarouselView crashes when initlal viewportDimension is 0.0 (flutter/flutter#167271)
2025-04-18 [email protected] Roll Dart SDK from b1eb743f97f5 to ab60afc99bcb (1 revision) (flutter/flutter#167396)
2025-04-18 [email protected] Add InputDecoration.visualDensity and InputDecorationTheme.visualDensity (flutter/flutter#166834)
2025-04-18 [email protected] Roll Skia from acc910544da7 to 844496884aa0 (1 revision) (flutter/flutter#167389)
2025-04-18 [email protected] Roll Skia from a409d685a711 to acc910544da7 (10 revisions) (flutter/flutter#167388)
2025-04-18 [email protected] Roll Dart SDK from 2bb85834e77e to b1eb743f97f5 (2 revisions) (flutter/flutter#167387)
2025-04-18 [email protected] Roll Fuchsia Linux SDK from m8Aln7fTF_8zy1V9N... to MwYckh5OvwwmIYLx0... (flutter/flutter#167385)
2025-04-17 [email protected] Roll Skia from cc2b57434651 to a409d685a711 (3 revisions) (flutter/flutter#167347)
2025-04-17 [email protected] Reduce app startup latency by initializing the engine on a separate thread (flutter/flutter#166918)
2025-04-17 [email protected] Roll Dart SDK from 992221a362ec to 2bb85834e77e (7 revisions) (flutter/flutter#167361)
2025-04-17 [email protected] Added docstring for FilterInput::GetSnapshot (flutter/flutter#167226)
2025-04-17 [email protected] adds Entity docstrings (flutter/flutter#167228)
2025-04-17 [email protected] fixed impeller golden content scale (flutter/flutter#167308)
2025-04-17 [email protected] Added docstring for FilterContents::RenderFilter (flutter/flutter#167227)
2025-04-17 [email protected] Feat: Add equality to NoDefaultCupertinoThemeData (flutter/flutter#166655)
2025-04-17 [email protected] Fix link to engine docs (flutter/flutter#167346)
2025-04-17 [email protected] [macOS] Enable merged platform and UI thread by default (flutter/flutter#166536)
2025-04-17 [email protected] [Windows] Enable merged platform and UI thread by default (flutter/flutter#163726)
2025-04-17 [email protected] Update `CHANGELOG.md` (flutter/flutter#167225)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Ortes pushed a commit to Ortes/packages that referenced this pull request Jun 25, 2025
@engine-flutter-autoroll @Ortes
Roll Flutter from ecabb1a05212 to 3ed38e24528a (23 revisions) (flutte…
b319071 
…r#9114)

flutter/flutter@ecabb1a...3ed38e2

2025-04-18 [email protected] Update `led` docs (flutter/flutter#167380)
2025-04-18 [email protected] Throw an error if --local-engine-host is used without --local-engine (flutter/flutter#166948)
2025-04-18 [email protected] Add kotlin compatability to build file validation (flutter/flutter#167143)
2025-04-18 [email protected] Roll Skia from 844496884aa0 to 6c4595124690 (2 revisions) (flutter/flutter#167400)
2025-04-18 [email protected] Fix CarouselView crashes when initlal viewportDimension is 0.0 (flutter/flutter#167271)
2025-04-18 [email protected] Roll Dart SDK from b1eb743f97f5 to ab60afc99bcb (1 revision) (flutter/flutter#167396)
2025-04-18 [email protected] Add InputDecoration.visualDensity and InputDecorationTheme.visualDensity (flutter/flutter#166834)
2025-04-18 [email protected] Roll Skia from acc910544da7 to 844496884aa0 (1 revision) (flutter/flutter#167389)
2025-04-18 [email protected] Roll Skia from a409d685a711 to acc910544da7 (10 revisions) (flutter/flutter#167388)
2025-04-18 [email protected] Roll Dart SDK from 2bb85834e77e to b1eb743f97f5 (2 revisions) (flutter/flutter#167387)
2025-04-18 [email protected] Roll Fuchsia Linux SDK from m8Aln7fTF_8zy1V9N... to MwYckh5OvwwmIYLx0... (flutter/flutter#167385)
2025-04-17 [email protected] Roll Skia from cc2b57434651 to a409d685a711 (3 revisions) (flutter/flutter#167347)
2025-04-17 [email protected] Reduce app startup latency by initializing the engine on a separate thread (flutter/flutter#166918)
2025-04-17 [email protected] Roll Dart SDK from 992221a362ec to 2bb85834e77e (7 revisions) (flutter/flutter#167361)
2025-04-17 [email protected] Added docstring for FilterInput::GetSnapshot (flutter/flutter#167226)
2025-04-17 [email protected] adds Entity docstrings (flutter/flutter#167228)
2025-04-17 [email protected] fixed impeller golden content scale (flutter/flutter#167308)
2025-04-17 [email protected] Added docstring for FilterContents::RenderFilter (flutter/flutter#167227)
2025-04-17 [email protected] Feat: Add equality to NoDefaultCupertinoThemeData (flutter/flutter#166655)
2025-04-17 [email protected] Fix link to engine docs (flutter/flutter#167346)
2025-04-17 [email protected] [macOS] Enable merged platform and UI thread by default (flutter/flutter#166536)
2025-04-17 [email protected] [Windows] Enable merged platform and UI thread by default (flutter/flutter#163726)
2025-04-17 [email protected] Update `CHANGELOG.md` (flutter/flutter#167225)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 14, 2025
@engine-flutter-autoroll
9d3d0dc0e [macOS] Enable merged platform and UI thread by default (fl…
4c8e1bc 
…utter/flutter#166536)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 14, 2025
@engine-flutter-autoroll
9d3d0dc0e [macOS] Enable merged platform and UI thread by default (fl…
7bb6678 
…utter/flutter#166536)
romanejaquez pushed a commit to romanejaquez/flutter that referenced this pull request Aug 14, 2025
@knopp @romanejaquez
[macOS] Enable merged platform and UI thread by default (flutter#166536)
9430f5b 
This enables running UI isolate on platform thread by default.

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 15, 2025
@engine-flutter-autoroll
9d3d0dc0e [macOS] Enable merged platform and UI thread by default (fl…
4907ddc 
…utter/flutter#166536)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 15, 2025
@engine-flutter-autoroll
9d3d0dc0e [macOS] Enable merged platform and UI thread by default (fl…
36db7e3 
…utter/flutter#166536)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 16, 2025
@engine-flutter-autoroll
9d3d0dc0e [macOS] Enable merged platform and UI thread by default (fl…
68894f2 
…utter/flutter#166536)
@tirth-patel-nc tirth-patel-nc mentioned this pull request Oct 13, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@loic-sharma loic-sharma loic-sharma approved these changes

@cbracken cbracken Awaiting requested review from cbracken

+1 more reviewer

@jonahwilliams jonahwilliams jonahwilliams approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

a: desktop Running on desktop engine flutter/engine related. See also e: labels. platform-macos will affect goldens Changes to golden files

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@knopp @loic-sharma @jonahwilliams