Skip to content

Make coverage collection aware of workspaces #166389

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
liamappelbe merged 10 commits into from
Apr 6, 2025
Merged

Make coverage collection aware of workspaces #166389

liamappelbe merged 10 commits into from
Apr 6, 2025

Conversation

@liamappelbe
Copy link
Contributor

@liamappelbe liamappelbe commented Apr 2, 2025

By default, CoverageCollector.libraryNames was being set to the name of the current FlutterProject. This means that only tests in the current project are included in the coverage report. So if the project is a workspace, tests in its subprojects were being excluded. I've changed it so that it also allows tests that are part of any of the subprojects.

Fixes #159390

@liamappelbe liamappelbe requested a review from bkonyi April 2, 2025 05:03
@github-actions github-actions bot added the tool Affects the "flutter" command-line tool. See also t: labels. label Apr 2, 2025
@bkonyi
Copy link
Contributor

bkonyi commented Apr 2, 2025

Thanks for the quick fix!

Just confirming, flutter test in the root workspace directory will run tests in each of the children and flutter test in a one of the children will only run tests for the child project, correct?

@liamappelbe
Copy link
Contributor Author

liamappelbe commented Apr 2, 2025

Just confirming, flutter test in the root workspace directory will run tests in each of the children and flutter test in a one of the children will only run tests for the child project, correct?

No, I'm not changing that logic at all, I'm only changing the coverage filtering logic. At the moment it looks like running flutter test in the root will only run the root's tests (in fact it will throw an error in the typical case where the root itself has no tests). I think your suggestion would be a good idea though.

@bkonyi
Copy link
Contributor

bkonyi commented Apr 4, 2025

Just confirming, flutter test in the root workspace directory will run tests in each of the children and flutter test in a one of the children will only run tests for the child project, correct?

No, I'm not changing that logic at all, I'm only changing the coverage filtering logic. At the moment it looks like running flutter test in the root will only run the root's tests (in fact it will throw an error in the typical case where the root itself has no tests). I think your suggestion would be a good idea though.

Okay, so this fix is making sure that code coverage for functionality in the workspace packages are also included when running tests on the root project? Just making sure I understand 😄

@liamappelbe liamappelbe added this pull request to the merge queue Apr 6, 2025
@liamappelbe
Copy link
Contributor Author

liamappelbe commented Apr 6, 2025

Okay, so this fix is making sure that code coverage for functionality in the workspace packages are also included when running tests on the root project? Just making sure I understand 😄

Yeah. When building a coverage report, lots of files are filtered out of the report (eg files from other packages). That logic was broken for workspaces. When running tests from the root directory of the workspace, it was filtering all the subproject's files too.

Merged via the queue into flutter:master with commit 09367ad Apr 6, 2025
135 of 136 checks passed
@liamappelbe liamappelbe deleted the coverage_workspaces branch April 6, 2025 22:54
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 7, 2025
@engine-flutter-autoroll
09367ad Make coverage collection aware of workspaces (flutter/flutter…
4af0763 
…#166389)
This was referenced Apr 7, 2025
Closed
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 7, 2025
@engine-flutter-autoroll
09367ad Make coverage collection aware of workspaces (flutter/flutter…
4fe43a3 
…#166389)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 7, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 7, 2025
@engine-flutter-autoroll
09367ad Make coverage collection aware of workspaces (flutter/flutter…
751f4ed 
…#166389)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 7, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 7, 2025
@engine-flutter-autoroll
09367ad Make coverage collection aware of workspaces (flutter/flutter…
8fdcf97 
…#166389)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 7, 2025
Closed
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 8, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 8, 2025
@engine-flutter-autoroll
09367ad Make coverage collection aware of workspaces (flutter/flutter…
e8715e2 
…#166389)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 9, 2025
@engine-flutter-autoroll
09367ad Make coverage collection aware of workspaces (flutter/flutter…
51a4a77 
…#166389)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 9, 2025
@engine-flutter-autoroll
09367ad Make coverage collection aware of workspaces (flutter/flutter…
dc438bf 
…#166389)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 9, 2025
@engine-flutter-autoroll
09367ad Make coverage collection aware of workspaces (flutter/flutter…
7f9c86b 
…#166389)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 9, 2025
@engine-flutter-autoroll
09367ad Make coverage collection aware of workspaces (flutter/flutter…
fc0abbd 
…#166389)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 9, 2025
@engine-flutter-autoroll
09367ad Make coverage collection aware of workspaces (flutter/flutter…
c28d530 
…#166389)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 9, 2025
@engine-flutter-autoroll
09367ad Make coverage collection aware of workspaces (flutter/flutter…
e2f12ce 
…#166389)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 9, 2025
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 9, 2025
@engine-flutter-autoroll
09367ad Make coverage collection aware of workspaces (flutter/flutter…
fcb8298 
…#166389)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 10, 2025
@engine-flutter-autoroll
09367ad Make coverage collection aware of workspaces (flutter/flutter…
8ee2cf8 
…#166389)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 10, 2025
@engine-flutter-autoroll
09367ad Make coverage collection aware of workspaces (flutter/flutter…
f8ae1e2 
…#166389)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 10, 2025
@engine-flutter-autoroll
09367ad Make coverage collection aware of workspaces (flutter/flutter…
4048452 
…#166389)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 10, 2025
@engine-flutter-autoroll
09367ad Make coverage collection aware of workspaces (flutter/flutter…
bc3b5ec 
…#166389)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 10, 2025
@engine-flutter-autoroll
09367ad Make coverage collection aware of workspaces (flutter/flutter…
77a7f8e 
…#166389)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 10, 2025
@engine-flutter-autoroll
09367ad Make coverage collection aware of workspaces (flutter/flutter…
efb7a5b 
…#166389)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 10, 2025
@engine-flutter-autoroll
09367ad Make coverage collection aware of workspaces (flutter/flutter…
274234b 
…#166389)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 10, 2025
@engine-flutter-autoroll
09367ad Make coverage collection aware of workspaces (flutter/flutter…
c69d642 
…#166389)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 10, 2025
@engine-flutter-autoroll
09367ad Make coverage collection aware of workspaces (flutter/flutter…
912af52 
…#166389)
auto-submit bot pushed a commit to flutter/packages that referenced this pull request Apr 10, 2025
@engine-flutter-autoroll
Manual roll Flutter from 212064a to 9bf18f0 (32 revisions) (#9041)
5faf596 
Manual roll Flutter from 212064a to 9bf18f0 (32 revisions)

Manual roll requested by [email protected]

flutter/flutter@212064a...9bf18f0

2025-04-08 [email protected] bump warn agp version from 7.3 to 8.3 (flutter/flutter#166555)
2025-04-08 [email protected] Roll Skia from 57a1644f0f8f to 7b929584566c (1 revision) (flutter/flutter#166760)
2025-04-08 [email protected] Enable a swath of `bringup: true` builds that were forgotten to the void. (flutter/flutter#166757)
2025-04-08 [email protected] add check for announcement support per platform (flutter/flutter#166099)
2025-04-08 [email protected] Roll Skia from 515eb6238867 to 57a1644f0f8f (1 revision) (flutter/flutter#166748)
2025-04-08 [email protected] Roll Skia from 3ea44c88d37b to 515eb6238867 (1 revision) (flutter/flutter#166742)
2025-04-08 [email protected] Roll Skia from 7d56b9cc7ce9 to 3ea44c88d37b (1 revision) (flutter/flutter#166741)
2025-04-08 [email protected] Roll Skia from 245d2b8fb042 to 7d56b9cc7ce9 (2 revisions) (flutter/flutter#166737)
2025-04-08 [email protected] Fix `DropdownMenu` keyboard navigation on filtered entries (flutter/flutter#165868)
2025-04-08 [email protected] Fix: DraggableScrollableSheet may not close if snapping is enabled (flutter/flutter#165557)
2025-04-08 [email protected] Roll pub packages (flutter/flutter#166503)
2025-04-08 [email protected] Add `RoundedSuperellipseBorder` and apply it to `CupertinoActionSheet` (flutter/flutter#166303)
2025-04-07 [email protected] Roll Skia from f493d403c01b to 245d2b8fb042 (3 revisions) (flutter/flutter#166720)
2025-04-07 [email protected] [web] reland fix text selection offset in multi-line fields (flutter/flutter#166714)
2025-04-07 [email protected] [flutter_tools] Update dwds version to 24.3.10 (flutter/flutter#166699)
2025-04-07 [email protected] Roll Skia from 5f0f9b76b975 to f493d403c01b (3 revisions) (flutter/flutter#166710)
2025-04-07 [email protected] Roll HarfBuzz to 11.0.0 (flutter/flutter#166596)
2025-04-07 [email protected] Fix: CupertinoSheetTransition moves SystemUIOverlayStyle to outside of delegatedTransition and only changes top bar (flutter/flutter#164680)
2025-04-07 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Reverts "Remove `bringup:true` from Linux tool_tests_widget_preview_scaffold (#166687)" (#166700)" (flutter/flutter#166711)
2025-04-07 [email protected] [ Widget Preview ] Update generated test files (flutter/flutter#166701)
2025-04-07 [email protected] Roll Skia from 339ef4f48c29 to 5f0f9b76b975 (1 revision) (flutter/flutter#166690)
2025-04-07 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Remove `bringup:true` from Linux tool_tests_widget_preview_scaffold (#166687)" (flutter/flutter#166700)
2025-04-07 [email protected] [reland] Convert the Flutter Gradle Plugin entirely to Kotlin source (flutter/flutter#166676)
2025-04-07 [email protected] Remove `bringup:true` from Linux tool_tests_widget_preview_scaffold (flutter/flutter#166687)
2025-04-07 [email protected] [Widget Preview] implemented gridview and listview layouts  (flutter/flutter#166150)
2025-04-07 [email protected] Roll Skia from 966d9c665eed to 339ef4f48c29 (1 revision) (flutter/flutter#166680)
2025-04-07 [email protected] Roll Skia from 8505be5b584e to 966d9c665eed (2 revisions) (flutter/flutter#166675)
2025-04-07 [email protected] Feat: Add yearShape property to DatePickerThemeData (flutter/flutter#163909)
2025-04-07 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Convert the Flutter Gradle Plugin entirely to Kotlin source (#166114)" (flutter/flutter#166666)
2025-04-07 [email protected] Convert the Flutter Gradle Plugin entirely to Kotlin source (flutter/flutter#166114)
2025-04-06 [email protected] Make coverage collection aware of workspaces (flutter/flutter#166389)
2025-04-06 [email protected] Roll Skia from da7929d79c28 to 8505be5b584e (1 revision) (flutter/flutter#166661)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

...
nick-llewellyn pushed a commit to labrystechnology/flutter_packages that referenced this pull request Apr 23, 2025
@engine-flutter-autoroll @nick-llewellyn
Manual roll Flutter from 212064a to 9bf18f0 (32 revisions) (flutter#9041
a7e131c 
)

Manual roll Flutter from 212064a to 9bf18f0 (32 revisions)

Manual roll requested by [email protected]

flutter/flutter@212064a...9bf18f0

2025-04-08 [email protected] bump warn agp version from 7.3 to 8.3 (flutter/flutter#166555)
2025-04-08 [email protected] Roll Skia from 57a1644f0f8f to 7b929584566c (1 revision) (flutter/flutter#166760)
2025-04-08 [email protected] Enable a swath of `bringup: true` builds that were forgotten to the void. (flutter/flutter#166757)
2025-04-08 [email protected] add check for announcement support per platform (flutter/flutter#166099)
2025-04-08 [email protected] Roll Skia from 515eb6238867 to 57a1644f0f8f (1 revision) (flutter/flutter#166748)
2025-04-08 [email protected] Roll Skia from 3ea44c88d37b to 515eb6238867 (1 revision) (flutter/flutter#166742)
2025-04-08 [email protected] Roll Skia from 7d56b9cc7ce9 to 3ea44c88d37b (1 revision) (flutter/flutter#166741)
2025-04-08 [email protected] Roll Skia from 245d2b8fb042 to 7d56b9cc7ce9 (2 revisions) (flutter/flutter#166737)
2025-04-08 [email protected] Fix `DropdownMenu` keyboard navigation on filtered entries (flutter/flutter#165868)
2025-04-08 [email protected] Fix: DraggableScrollableSheet may not close if snapping is enabled (flutter/flutter#165557)
2025-04-08 [email protected] Roll pub packages (flutter/flutter#166503)
2025-04-08 [email protected] Add `RoundedSuperellipseBorder` and apply it to `CupertinoActionSheet` (flutter/flutter#166303)
2025-04-07 [email protected] Roll Skia from f493d403c01b to 245d2b8fb042 (3 revisions) (flutter/flutter#166720)
2025-04-07 [email protected] [web] reland fix text selection offset in multi-line fields (flutter/flutter#166714)
2025-04-07 [email protected] [flutter_tools] Update dwds version to 24.3.10 (flutter/flutter#166699)
2025-04-07 [email protected] Roll Skia from 5f0f9b76b975 to f493d403c01b (3 revisions) (flutter/flutter#166710)
2025-04-07 [email protected] Roll HarfBuzz to 11.0.0 (flutter/flutter#166596)
2025-04-07 [email protected] Fix: CupertinoSheetTransition moves SystemUIOverlayStyle to outside of delegatedTransition and only changes top bar (flutter/flutter#164680)
2025-04-07 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Reverts "Remove `bringup:true` from Linux tool_tests_widget_preview_scaffold (#166687)" (#166700)" (flutter/flutter#166711)
2025-04-07 [email protected] [ Widget Preview ] Update generated test files (flutter/flutter#166701)
2025-04-07 [email protected] Roll Skia from 339ef4f48c29 to 5f0f9b76b975 (1 revision) (flutter/flutter#166690)
2025-04-07 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Remove `bringup:true` from Linux tool_tests_widget_preview_scaffold (#166687)" (flutter/flutter#166700)
2025-04-07 [email protected] [reland] Convert the Flutter Gradle Plugin entirely to Kotlin source (flutter/flutter#166676)
2025-04-07 [email protected] Remove `bringup:true` from Linux tool_tests_widget_preview_scaffold (flutter/flutter#166687)
2025-04-07 [email protected] [Widget Preview] implemented gridview and listview layouts  (flutter/flutter#166150)
2025-04-07 [email protected] Roll Skia from 966d9c665eed to 339ef4f48c29 (1 revision) (flutter/flutter#166680)
2025-04-07 [email protected] Roll Skia from 8505be5b584e to 966d9c665eed (2 revisions) (flutter/flutter#166675)
2025-04-07 [email protected] Feat: Add yearShape property to DatePickerThemeData (flutter/flutter#163909)
2025-04-07 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Convert the Flutter Gradle Plugin entirely to Kotlin source (#166114)" (flutter/flutter#166666)
2025-04-07 [email protected] Convert the Flutter Gradle Plugin entirely to Kotlin source (flutter/flutter#166114)
2025-04-06 [email protected] Make coverage collection aware of workspaces (flutter/flutter#166389)
2025-04-06 [email protected] Roll Skia from da7929d79c28 to 8505be5b584e (1 revision) (flutter/flutter#166661)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

...
CodixNinja pushed a commit to CodixNinja/packages that referenced this pull request May 15, 2025
@engine-flutter-autoroll
Manual roll Flutter from 212064a3e558 to 9bf18f097137 (32 revisions) …
8f5e6a5 
…(#9041)

Manual roll Flutter from 212064a3e558 to 9bf18f097137 (32 revisions)

Manual roll requested by [email protected]

flutter/flutter@212064a...9bf18f0

2025-04-08 [email protected] bump warn agp version from 7.3 to 8.3 (flutter/flutter#166555)
2025-04-08 [email protected] Roll Skia from 57a1644f0f8f to 7b929584566c (1 revision) (flutter/flutter#166760)
2025-04-08 [email protected] Enable a swath of `bringup: true` builds that were forgotten to the void. (flutter/flutter#166757)
2025-04-08 [email protected] add check for announcement support per platform (flutter/flutter#166099)
2025-04-08 [email protected] Roll Skia from 515eb6238867 to 57a1644f0f8f (1 revision) (flutter/flutter#166748)
2025-04-08 [email protected] Roll Skia from 3ea44c88d37b to 515eb6238867 (1 revision) (flutter/flutter#166742)
2025-04-08 [email protected] Roll Skia from 7d56b9cc7ce9 to 3ea44c88d37b (1 revision) (flutter/flutter#166741)
2025-04-08 [email protected] Roll Skia from 245d2b8fb042 to 7d56b9cc7ce9 (2 revisions) (flutter/flutter#166737)
2025-04-08 [email protected] Fix `DropdownMenu` keyboard navigation on filtered entries (flutter/flutter#165868)
2025-04-08 [email protected] Fix: DraggableScrollableSheet may not close if snapping is enabled (flutter/flutter#165557)
2025-04-08 [email protected] Roll pub packages (flutter/flutter#166503)
2025-04-08 [email protected] Add `RoundedSuperellipseBorder` and apply it to `CupertinoActionSheet` (flutter/flutter#166303)
2025-04-07 [email protected] Roll Skia from f493d403c01b to 245d2b8fb042 (3 revisions) (flutter/flutter#166720)
2025-04-07 [email protected] [web] reland fix text selection offset in multi-line fields (flutter/flutter#166714)
2025-04-07 [email protected] [flutter_tools] Update dwds version to 24.3.10 (flutter/flutter#166699)
2025-04-07 [email protected] Roll Skia from 5f0f9b76b975 to f493d403c01b (3 revisions) (flutter/flutter#166710)
2025-04-07 [email protected] Roll HarfBuzz to 11.0.0 (flutter/flutter#166596)
2025-04-07 [email protected] Fix: CupertinoSheetTransition moves SystemUIOverlayStyle to outside of delegatedTransition and only changes top bar (flutter/flutter#164680)
2025-04-07 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Reverts "Remove `bringup:true` from Linux tool_tests_widget_preview_scaffold (#166687)" (#166700)" (flutter/flutter#166711)
2025-04-07 [email protected] [ Widget Preview ] Update generated test files (flutter/flutter#166701)
2025-04-07 [email protected] Roll Skia from 339ef4f48c29 to 5f0f9b76b975 (1 revision) (flutter/flutter#166690)
2025-04-07 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Remove `bringup:true` from Linux tool_tests_widget_preview_scaffold (#166687)" (flutter/flutter#166700)
2025-04-07 [email protected] [reland] Convert the Flutter Gradle Plugin entirely to Kotlin source (flutter/flutter#166676)
2025-04-07 [email protected] Remove `bringup:true` from Linux tool_tests_widget_preview_scaffold (flutter/flutter#166687)
2025-04-07 [email protected] [Widget Preview] implemented gridview and listview layouts  (flutter/flutter#166150)
2025-04-07 [email protected] Roll Skia from 966d9c665eed to 339ef4f48c29 (1 revision) (flutter/flutter#166680)
2025-04-07 [email protected] Roll Skia from 8505be5b584e to 966d9c665eed (2 revisions) (flutter/flutter#166675)
2025-04-07 [email protected] Feat: Add yearShape property to DatePickerThemeData (flutter/flutter#163909)
2025-04-07 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Convert the Flutter Gradle Plugin entirely to Kotlin source (#166114)" (flutter/flutter#166666)
2025-04-07 [email protected] Convert the Flutter Gradle Plugin entirely to Kotlin source (flutter/flutter#166114)
2025-04-06 [email protected] Make coverage collection aware of workspaces (flutter/flutter#166389)
2025-04-06 [email protected] Roll Skia from da7929d79c28 to 8505be5b584e (1 revision) (flutter/flutter#166661)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

...
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 20, 2025
@engine-flutter-autoroll
09367ad Make coverage collection aware of workspaces (flutter/flutter…
fdc5e58 
…#166389)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 20, 2025
@engine-flutter-autoroll
09367ad Make coverage collection aware of workspaces (flutter/flutter…
d6753ff 
…#166389)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 21, 2025
@engine-flutter-autoroll
09367ad Make coverage collection aware of workspaces (flutter/flutter…
d8bcf40 
…#166389)
androidseb pushed a commit to androidseb/packages that referenced this pull request Jun 8, 2025
@engine-flutter-autoroll @androidseb
Manual roll Flutter from 212064a to 9bf18f0 (32 revisions) (flutter#9041
e8d24f5 
)

Manual roll Flutter from 212064a to 9bf18f0 (32 revisions)

Manual roll requested by [email protected]

flutter/flutter@212064a...9bf18f0

2025-04-08 [email protected] bump warn agp version from 7.3 to 8.3 (flutter/flutter#166555)
2025-04-08 [email protected] Roll Skia from 57a1644f0f8f to 7b929584566c (1 revision) (flutter/flutter#166760)
2025-04-08 [email protected] Enable a swath of `bringup: true` builds that were forgotten to the void. (flutter/flutter#166757)
2025-04-08 [email protected] add check for announcement support per platform (flutter/flutter#166099)
2025-04-08 [email protected] Roll Skia from 515eb6238867 to 57a1644f0f8f (1 revision) (flutter/flutter#166748)
2025-04-08 [email protected] Roll Skia from 3ea44c88d37b to 515eb6238867 (1 revision) (flutter/flutter#166742)
2025-04-08 [email protected] Roll Skia from 7d56b9cc7ce9 to 3ea44c88d37b (1 revision) (flutter/flutter#166741)
2025-04-08 [email protected] Roll Skia from 245d2b8fb042 to 7d56b9cc7ce9 (2 revisions) (flutter/flutter#166737)
2025-04-08 [email protected] Fix `DropdownMenu` keyboard navigation on filtered entries (flutter/flutter#165868)
2025-04-08 [email protected] Fix: DraggableScrollableSheet may not close if snapping is enabled (flutter/flutter#165557)
2025-04-08 [email protected] Roll pub packages (flutter/flutter#166503)
2025-04-08 [email protected] Add `RoundedSuperellipseBorder` and apply it to `CupertinoActionSheet` (flutter/flutter#166303)
2025-04-07 [email protected] Roll Skia from f493d403c01b to 245d2b8fb042 (3 revisions) (flutter/flutter#166720)
2025-04-07 [email protected] [web] reland fix text selection offset in multi-line fields (flutter/flutter#166714)
2025-04-07 [email protected] [flutter_tools] Update dwds version to 24.3.10 (flutter/flutter#166699)
2025-04-07 [email protected] Roll Skia from 5f0f9b76b975 to f493d403c01b (3 revisions) (flutter/flutter#166710)
2025-04-07 [email protected] Roll HarfBuzz to 11.0.0 (flutter/flutter#166596)
2025-04-07 [email protected] Fix: CupertinoSheetTransition moves SystemUIOverlayStyle to outside of delegatedTransition and only changes top bar (flutter/flutter#164680)
2025-04-07 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Reverts "Remove `bringup:true` from Linux tool_tests_widget_preview_scaffold (#166687)" (#166700)" (flutter/flutter#166711)
2025-04-07 [email protected] [ Widget Preview ] Update generated test files (flutter/flutter#166701)
2025-04-07 [email protected] Roll Skia from 339ef4f48c29 to 5f0f9b76b975 (1 revision) (flutter/flutter#166690)
2025-04-07 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Remove `bringup:true` from Linux tool_tests_widget_preview_scaffold (#166687)" (flutter/flutter#166700)
2025-04-07 [email protected] [reland] Convert the Flutter Gradle Plugin entirely to Kotlin source (flutter/flutter#166676)
2025-04-07 [email protected] Remove `bringup:true` from Linux tool_tests_widget_preview_scaffold (flutter/flutter#166687)
2025-04-07 [email protected] [Widget Preview] implemented gridview and listview layouts  (flutter/flutter#166150)
2025-04-07 [email protected] Roll Skia from 966d9c665eed to 339ef4f48c29 (1 revision) (flutter/flutter#166680)
2025-04-07 [email protected] Roll Skia from 8505be5b584e to 966d9c665eed (2 revisions) (flutter/flutter#166675)
2025-04-07 [email protected] Feat: Add yearShape property to DatePickerThemeData (flutter/flutter#163909)
2025-04-07 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Convert the Flutter Gradle Plugin entirely to Kotlin source (#166114)" (flutter/flutter#166666)
2025-04-07 [email protected] Convert the Flutter Gradle Plugin entirely to Kotlin source (flutter/flutter#166114)
2025-04-06 [email protected] Make coverage collection aware of workspaces (flutter/flutter#166389)
2025-04-06 [email protected] Roll Skia from da7929d79c28 to 8505be5b584e (1 revision) (flutter/flutter#166661)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

...
zhangyuang pushed a commit to zhangyuang/flutter-fork that referenced this pull request Jun 9, 2025
@liamappelbe
Make coverage collection aware of workspaces (flutter#166389)
8dc427c 
By default, `CoverageCollector.libraryNames` was being set to the name
of the current `FlutterProject`. This means that only tests in the
current project are included in the coverage report. So if the project
is a workspace, tests in its subprojects were being excluded. I've
changed it so that it also allows tests that are part of any of the
subprojects.

Fixes flutter#159390
FMorschel pushed a commit to FMorschel/packages that referenced this pull request Jun 9, 2025
@engine-flutter-autoroll @FMorschel
Manual roll Flutter from 212064a to 9bf18f0 (32 revisions) (flutter#9041
ad840f8 
)

Manual roll Flutter from 212064a to 9bf18f0 (32 revisions)

Manual roll requested by [email protected]

flutter/flutter@212064a...9bf18f0

2025-04-08 [email protected] bump warn agp version from 7.3 to 8.3 (flutter/flutter#166555)
2025-04-08 [email protected] Roll Skia from 57a1644f0f8f to 7b929584566c (1 revision) (flutter/flutter#166760)
2025-04-08 [email protected] Enable a swath of `bringup: true` builds that were forgotten to the void. (flutter/flutter#166757)
2025-04-08 [email protected] add check for announcement support per platform (flutter/flutter#166099)
2025-04-08 [email protected] Roll Skia from 515eb6238867 to 57a1644f0f8f (1 revision) (flutter/flutter#166748)
2025-04-08 [email protected] Roll Skia from 3ea44c88d37b to 515eb6238867 (1 revision) (flutter/flutter#166742)
2025-04-08 [email protected] Roll Skia from 7d56b9cc7ce9 to 3ea44c88d37b (1 revision) (flutter/flutter#166741)
2025-04-08 [email protected] Roll Skia from 245d2b8fb042 to 7d56b9cc7ce9 (2 revisions) (flutter/flutter#166737)
2025-04-08 [email protected] Fix `DropdownMenu` keyboard navigation on filtered entries (flutter/flutter#165868)
2025-04-08 [email protected] Fix: DraggableScrollableSheet may not close if snapping is enabled (flutter/flutter#165557)
2025-04-08 [email protected] Roll pub packages (flutter/flutter#166503)
2025-04-08 [email protected] Add `RoundedSuperellipseBorder` and apply it to `CupertinoActionSheet` (flutter/flutter#166303)
2025-04-07 [email protected] Roll Skia from f493d403c01b to 245d2b8fb042 (3 revisions) (flutter/flutter#166720)
2025-04-07 [email protected] [web] reland fix text selection offset in multi-line fields (flutter/flutter#166714)
2025-04-07 [email protected] [flutter_tools] Update dwds version to 24.3.10 (flutter/flutter#166699)
2025-04-07 [email protected] Roll Skia from 5f0f9b76b975 to f493d403c01b (3 revisions) (flutter/flutter#166710)
2025-04-07 [email protected] Roll HarfBuzz to 11.0.0 (flutter/flutter#166596)
2025-04-07 [email protected] Fix: CupertinoSheetTransition moves SystemUIOverlayStyle to outside of delegatedTransition and only changes top bar (flutter/flutter#164680)
2025-04-07 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Reverts "Remove `bringup:true` from Linux tool_tests_widget_preview_scaffold (#166687)" (#166700)" (flutter/flutter#166711)
2025-04-07 [email protected] [ Widget Preview ] Update generated test files (flutter/flutter#166701)
2025-04-07 [email protected] Roll Skia from 339ef4f48c29 to 5f0f9b76b975 (1 revision) (flutter/flutter#166690)
2025-04-07 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Remove `bringup:true` from Linux tool_tests_widget_preview_scaffold (#166687)" (flutter/flutter#166700)
2025-04-07 [email protected] [reland] Convert the Flutter Gradle Plugin entirely to Kotlin source (flutter/flutter#166676)
2025-04-07 [email protected] Remove `bringup:true` from Linux tool_tests_widget_preview_scaffold (flutter/flutter#166687)
2025-04-07 [email protected] [Widget Preview] implemented gridview and listview layouts  (flutter/flutter#166150)
2025-04-07 [email protected] Roll Skia from 966d9c665eed to 339ef4f48c29 (1 revision) (flutter/flutter#166680)
2025-04-07 [email protected] Roll Skia from 8505be5b584e to 966d9c665eed (2 revisions) (flutter/flutter#166675)
2025-04-07 [email protected] Feat: Add yearShape property to DatePickerThemeData (flutter/flutter#163909)
2025-04-07 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Convert the Flutter Gradle Plugin entirely to Kotlin source (#166114)" (flutter/flutter#166666)
2025-04-07 [email protected] Convert the Flutter Gradle Plugin entirely to Kotlin source (flutter/flutter#166114)
2025-04-06 [email protected] Make coverage collection aware of workspaces (flutter/flutter#166389)
2025-04-06 [email protected] Roll Skia from da7929d79c28 to 8505be5b584e (1 revision) (flutter/flutter#166661)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

...
Ortes pushed a commit to Ortes/packages that referenced this pull request Jun 25, 2025
@engine-flutter-autoroll @Ortes
Manual roll Flutter from 212064a to 9bf18f0 (32 revisions) (flutter#9041
aae1da3 
)

Manual roll Flutter from 212064a to 9bf18f0 (32 revisions)

Manual roll requested by [email protected]

flutter/flutter@212064a...9bf18f0

2025-04-08 [email protected] bump warn agp version from 7.3 to 8.3 (flutter/flutter#166555)
2025-04-08 [email protected] Roll Skia from 57a1644f0f8f to 7b929584566c (1 revision) (flutter/flutter#166760)
2025-04-08 [email protected] Enable a swath of `bringup: true` builds that were forgotten to the void. (flutter/flutter#166757)
2025-04-08 [email protected] add check for announcement support per platform (flutter/flutter#166099)
2025-04-08 [email protected] Roll Skia from 515eb6238867 to 57a1644f0f8f (1 revision) (flutter/flutter#166748)
2025-04-08 [email protected] Roll Skia from 3ea44c88d37b to 515eb6238867 (1 revision) (flutter/flutter#166742)
2025-04-08 [email protected] Roll Skia from 7d56b9cc7ce9 to 3ea44c88d37b (1 revision) (flutter/flutter#166741)
2025-04-08 [email protected] Roll Skia from 245d2b8fb042 to 7d56b9cc7ce9 (2 revisions) (flutter/flutter#166737)
2025-04-08 [email protected] Fix `DropdownMenu` keyboard navigation on filtered entries (flutter/flutter#165868)
2025-04-08 [email protected] Fix: DraggableScrollableSheet may not close if snapping is enabled (flutter/flutter#165557)
2025-04-08 [email protected] Roll pub packages (flutter/flutter#166503)
2025-04-08 [email protected] Add `RoundedSuperellipseBorder` and apply it to `CupertinoActionSheet` (flutter/flutter#166303)
2025-04-07 [email protected] Roll Skia from f493d403c01b to 245d2b8fb042 (3 revisions) (flutter/flutter#166720)
2025-04-07 [email protected] [web] reland fix text selection offset in multi-line fields (flutter/flutter#166714)
2025-04-07 [email protected] [flutter_tools] Update dwds version to 24.3.10 (flutter/flutter#166699)
2025-04-07 [email protected] Roll Skia from 5f0f9b76b975 to f493d403c01b (3 revisions) (flutter/flutter#166710)
2025-04-07 [email protected] Roll HarfBuzz to 11.0.0 (flutter/flutter#166596)
2025-04-07 [email protected] Fix: CupertinoSheetTransition moves SystemUIOverlayStyle to outside of delegatedTransition and only changes top bar (flutter/flutter#164680)
2025-04-07 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Reverts "Remove `bringup:true` from Linux tool_tests_widget_preview_scaffold (#166687)" (#166700)" (flutter/flutter#166711)
2025-04-07 [email protected] [ Widget Preview ] Update generated test files (flutter/flutter#166701)
2025-04-07 [email protected] Roll Skia from 339ef4f48c29 to 5f0f9b76b975 (1 revision) (flutter/flutter#166690)
2025-04-07 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Remove `bringup:true` from Linux tool_tests_widget_preview_scaffold (#166687)" (flutter/flutter#166700)
2025-04-07 [email protected] [reland] Convert the Flutter Gradle Plugin entirely to Kotlin source (flutter/flutter#166676)
2025-04-07 [email protected] Remove `bringup:true` from Linux tool_tests_widget_preview_scaffold (flutter/flutter#166687)
2025-04-07 [email protected] [Widget Preview] implemented gridview and listview layouts  (flutter/flutter#166150)
2025-04-07 [email protected] Roll Skia from 966d9c665eed to 339ef4f48c29 (1 revision) (flutter/flutter#166680)
2025-04-07 [email protected] Roll Skia from 8505be5b584e to 966d9c665eed (2 revisions) (flutter/flutter#166675)
2025-04-07 [email protected] Feat: Add yearShape property to DatePickerThemeData (flutter/flutter#163909)
2025-04-07 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Convert the Flutter Gradle Plugin entirely to Kotlin source (#166114)" (flutter/flutter#166666)
2025-04-07 [email protected] Convert the Flutter Gradle Plugin entirely to Kotlin source (flutter/flutter#166114)
2025-04-06 [email protected] Make coverage collection aware of workspaces (flutter/flutter#166389)
2025-04-06 [email protected] Roll Skia from da7929d79c28 to 8505be5b584e (1 revision) (flutter/flutter#166661)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

...
romanejaquez pushed a commit to romanejaquez/flutter that referenced this pull request Aug 14, 2025
@liamappelbe @romanejaquez
Make coverage collection aware of workspaces (flutter#166389)
bc425c4 
By default, `CoverageCollector.libraryNames` was being set to the name
of the current `FlutterProject`. This means that only tests in the
current project are included in the coverage report. So if the project
is a workspace, tests in its subprojects were being excluded. I've
changed it so that it also allows tests that are part of any of the
subprojects.

Fixes flutter#159390
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bkonyi bkonyi bkonyi approved these changes

Assignees

No one assigned

Labels

tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

When using workspaces the code coverage is broken

2 participants

@liamappelbe @bkonyi