Skip to content

Revert "[ Device Lab ] Upgrade Device Lab projects to Java 18" #166016

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
matanlurey merged 1 commit into from
Mar 26, 2025
Merged

Revert "[ Device Lab ] Upgrade Device Lab projects to Java 18" #166016

matanlurey merged 1 commit into from
Mar 26, 2025

Conversation

@bkonyi
Copy link
Contributor

@bkonyi bkonyi commented Mar 26, 2025

Reverts #165987

Reason for revert: multiple gradlew failures on devicelab tests

@bkonyi bkonyi requested a review from matanlurey as a code owner March 26, 2025 20:49
matanlurey
matanlurey approved these changes Mar 26, 2025
View reviewed changes
Copy link
Contributor

@matanlurey matanlurey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@matanlurey matanlurey added the emergency Jump the queue; land PR in front of all others; only use for emergencies label Mar 26, 2025
@flutter-dashboard
Copy link

flutter-dashboard bot commented Mar 26, 2025

Detected the emergency label.

If you add the autosubmit label, the bot will wait until all presubmits pass but ignore the tree status, allowing fixes for tree breakages while still validating that they don't break any existing presubmits.

The "Merge" button is also unlocked. To bypass presubmits as well as the tree status, press the GitHub "Add to Merge Queue".

@matanlurey matanlurey added this pull request to the merge queue Mar 26, 2025
@bkonyi bkonyi mentioned this pull request Mar 26, 2025
Closed
Merged via the queue into master with commit 8dccbc3 Mar 26, 2025
147 of 149 checks passed
@matanlurey matanlurey deleted the revert-165987-fix_source_value_8 branch March 26, 2025 21:24
bkonyi added a commit that referenced this pull request Mar 27, 2025
@bkonyi
Reapply "[ Device Lab ] Upgrade Device Lab projects to Java 18" (#166016
27cd5dc 
)

This reverts commit 8dccbc3.
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 27, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 27, 2025
@engine-flutter-autoroll
8dccbc3 Revert "[ Device Lab ] Upgrade Device Lab projects to Java 18" (
609161a 
flutter/flutter#166016)
github-merge-queue bot pushed a commit that referenced this pull request Mar 27, 2025
@bkonyi
Reapply "[ Device Lab ] Upgrade Device Lab projects to Java 18" (#166016
7cb926a 
) (#166059)

This reverts commit
8dccbc3.

Find/replace didn't catch the use of `jvmTarget = "1.8"` in
`dev/integration_tests/android_engine_test/android/app/build.gradle` and
`android_engine_test` needed to have `"com.android.application"`
updated.
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 27, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 27, 2025
@engine-flutter-autoroll
8dccbc3 Revert "[ Device Lab ] Upgrade Device Lab projects to Java 18" (
9024226 
flutter/flutter#166016)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 27, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 27, 2025
@engine-flutter-autoroll
8dccbc3 Revert "[ Device Lab ] Upgrade Device Lab projects to Java 18" (
c2a0667 
flutter/flutter#166016)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 27, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 27, 2025
@engine-flutter-autoroll
8dccbc3 Revert "[ Device Lab ] Upgrade Device Lab projects to Java 18" (
85f52c5 
flutter/flutter#166016)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 27, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 27, 2025
@engine-flutter-autoroll
8dccbc3 Revert "[ Device Lab ] Upgrade Device Lab projects to Java 18" (
5d8355b 
flutter/flutter#166016)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 27, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 27, 2025
@engine-flutter-autoroll
8dccbc3 Revert "[ Device Lab ] Upgrade Device Lab projects to Java 18" (
f089dd7 
flutter/flutter#166016)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 28, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 28, 2025
@engine-flutter-autoroll
8dccbc3 Revert "[ Device Lab ] Upgrade Device Lab projects to Java 18" (
2554104 
flutter/flutter#166016)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 28, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 28, 2025
@engine-flutter-autoroll
8dccbc3 Revert "[ Device Lab ] Upgrade Device Lab projects to Java 18" (
731f411 
flutter/flutter#166016)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 28, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 28, 2025
@engine-flutter-autoroll
8dccbc3 Revert "[ Device Lab ] Upgrade Device Lab projects to Java 18" (
52739e5 
flutter/flutter#166016)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 28, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 28, 2025
@engine-flutter-autoroll
8dccbc3 Revert "[ Device Lab ] Upgrade Device Lab projects to Java 18" (
a2ada0e 
flutter/flutter#166016)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 29, 2025
@engine-flutter-autoroll
8dccbc3 Revert "[ Device Lab ] Upgrade Device Lab projects to Java 18" (
3dca68e 
flutter/flutter#166016)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 29, 2025
@engine-flutter-autoroll
8dccbc3 Revert "[ Device Lab ] Upgrade Device Lab projects to Java 18" (
23fc7d8 
flutter/flutter#166016)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 30, 2025
@engine-flutter-autoroll
8dccbc3 Revert "[ Device Lab ] Upgrade Device Lab projects to Java 18" (
4e7b352 
flutter/flutter#166016)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 30, 2025
@engine-flutter-autoroll
8dccbc3 Revert "[ Device Lab ] Upgrade Device Lab projects to Java 18" (
6ab59dd 
flutter/flutter#166016)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 31, 2025
@engine-flutter-autoroll
8dccbc3 Revert "[ Device Lab ] Upgrade Device Lab projects to Java 18" (
aed1b0c 
flutter/flutter#166016)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 31, 2025
@engine-flutter-autoroll
8dccbc3 Revert "[ Device Lab ] Upgrade Device Lab projects to Java 18" (
1c8c973 
flutter/flutter#166016)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 31, 2025
@engine-flutter-autoroll
8dccbc3 Revert "[ Device Lab ] Upgrade Device Lab projects to Java 18" (
5eee470 
flutter/flutter#166016)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 31, 2025
@engine-flutter-autoroll
8dccbc3 Revert "[ Device Lab ] Upgrade Device Lab projects to Java 18" (
38c01d4 
flutter/flutter#166016)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 31, 2025
@engine-flutter-autoroll
8dccbc3 Revert "[ Device Lab ] Upgrade Device Lab projects to Java 18" (
5ac66e1 
flutter/flutter#166016)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 31, 2025
@engine-flutter-autoroll
8dccbc3 Revert "[ Device Lab ] Upgrade Device Lab projects to Java 18" (
4e4e935 
flutter/flutter#166016)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 31, 2025
@engine-flutter-autoroll
8dccbc3 Revert "[ Device Lab ] Upgrade Device Lab projects to Java 18" (
f25e84c 
flutter/flutter#166016)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 1, 2025
@engine-flutter-autoroll
8dccbc3 Revert "[ Device Lab ] Upgrade Device Lab projects to Java 18" (
d85275a 
flutter/flutter#166016)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 1, 2025
@engine-flutter-autoroll
8dccbc3 Revert "[ Device Lab ] Upgrade Device Lab projects to Java 18" (
f524f5d 
flutter/flutter#166016)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 1, 2025
@engine-flutter-autoroll
8dccbc3 Revert "[ Device Lab ] Upgrade Device Lab projects to Java 18" (
7cfc9f1 
flutter/flutter#166016)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 1, 2025
@engine-flutter-autoroll
8dccbc3 Revert "[ Device Lab ] Upgrade Device Lab projects to Java 18" (
07f05c5 
flutter/flutter#166016)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 20, 2025
@engine-flutter-autoroll
8dccbc3 Revert "[ Device Lab ] Upgrade Device Lab projects to Java 18" (
66ff46e 
flutter/flutter#166016)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 20, 2025
@engine-flutter-autoroll
8dccbc3 Revert "[ Device Lab ] Upgrade Device Lab projects to Java 18" (
43f7d20 
flutter/flutter#166016)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 21, 2025
@engine-flutter-autoroll
8dccbc3 Revert "[ Device Lab ] Upgrade Device Lab projects to Java 18" (
391839b 
flutter/flutter#166016)
zhangyuang pushed a commit to zhangyuang/flutter-fork that referenced this pull request Jun 9, 2025
@bkonyi
Revert "[ Device Lab ] Upgrade Device Lab projects to Java 18" (flutt…
326c953 
…er#166016)

Reverts flutter#165987

Reason for revert: multiple gradlew failures on devicelab tests
zhangyuang pushed a commit to zhangyuang/flutter-fork that referenced this pull request Jun 9, 2025
@bkonyi
Reapply "[ Device Lab ] Upgrade Device Lab projects to Java 18" (flut…
560f086 
…ter#166016) (flutter#166059)

This reverts commit
flutter@8dccbc3.

Find/replace didn't catch the use of `jvmTarget = "1.8"` in
`dev/integration_tests/android_engine_test/android/app/build.gradle` and
`android_engine_test` needed to have `"com.android.application"`
updated.
romanejaquez pushed a commit to romanejaquez/flutter that referenced this pull request Aug 14, 2025
@bkonyi @romanejaquez
Revert "[ Device Lab ] Upgrade Device Lab projects to Java 18" (flutt…
d764306 
…er#166016)

Reverts flutter#165987

Reason for revert: multiple gradlew failures on devicelab tests
romanejaquez pushed a commit to romanejaquez/flutter that referenced this pull request Aug 14, 2025
@bkonyi @romanejaquez
Reapply "[ Device Lab ] Upgrade Device Lab projects to Java 18" (flut…
42f712d 
…ter#166016) (flutter#166059)

This reverts commit
flutter@8dccbc3.

Find/replace didn't catch the use of `jvmTarget = "1.8"` in
`dev/integration_tests/android_engine_test/android/app/build.gradle` and
`android_engine_test` needed to have `"com.android.application"`
updated.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@matanlurey matanlurey matanlurey approved these changes

Assignees

No one assigned

Labels

emergency Jump the queue; land PR in front of all others; only use for emergencies

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@bkonyi @matanlurey