Skip to content

[Impeller] split vertices uber into 2 shaders. #165938

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
auto-submit merged 5 commits into from
Mar 28, 2025
Merged

[Impeller] split vertices uber into 2 shaders. #165938

auto-submit merged 5 commits into from
Mar 28, 2025

Conversation

@jonahwilliams
Copy link
Contributor

@jonahwilliams jonahwilliams commented Mar 26, 2025 •
edited
Loading

Works around compilation error on newer phone (ask me offline). Required for #162033

@github-actions github-actions bot added engine flutter/engine related. See also e: labels. e: impeller Impeller rendering backend issues and features requests labels Mar 26, 2025
@jonahwilliams jonahwilliams marked this pull request as ready for review March 27, 2025 15:47
@jonahwilliams jonahwilliams requested a review from gaaclarke March 27, 2025 15:47
@flutter-dashboard
Copy link

flutter-dashboard bot commented Mar 27, 2025

It looks like this pull request may not have tests. Please make sure to add tests or get an explicit test exemption before merging.

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.If you believe this PR qualifies for a test exemption, contact "@test-exemption-reviewer" in the #hackers channel in Discord (don't just cc them here, they won't see it!). The test exemption team is a small volunteer group, so all reviewers should feel empowered to ask for tests, without delegating that responsibility entirely to the test exemption group.

gaaclarke
gaaclarke reviewed Mar 27, 2025
View reviewed changes
engine/src/flutter/impeller/entity/contents/atlas_contents.cc Outdated
Comment on lines 137 to 143
if (blend_mode <= BlendMode::kSoftLight) {
pass.SetPipeline(
renderer.GetDrawVerticesUber1Pipeline(OptionsFromPass(pass)));
} else {
pass.SetPipeline(
renderer.GetDrawVerticesUber2Pipeline(OptionsFromPass(pass)));
}
Copy link
Member

@gaaclarke gaaclarke Mar 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you put this if inside of the content contents. So it's GetDrawVerticesUber1Pipeline(options, blend_mode). It's duplicated in a couple of places.

Copy link
Contributor Author

@jonahwilliams jonahwilliams Mar 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

engine/src/flutter/impeller/entity/shaders/blending/vertices_uber_2.frag Outdated
Comment on lines 12 to 36
uniform FragInfo {
float16_t alpha;
float16_t blend_mode;
float tmx;
float tmy;
}
frag_info;

uniform f16sampler2D texture_sampler;

in mediump vec2 v_texture_coords;
in mediump f16vec4 v_color;

out f16vec4 frag_color;

f16vec4 Sample(f16sampler2D texture_sampler,
vec2 texture_coords,
float tmx,
float tmy) {
if (supports_decal > 0.0) {
return texture(texture_sampler, texture_coords);
}
return IPHalfSampleWithTileMode(texture_sampler, texture_coords, tmx, tmy);
}

Copy link
Member

@gaaclarke gaaclarke Mar 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you put this in a glsl file that is shared across the vertex shaders?

Copy link
Contributor Author

@jonahwilliams jonahwilliams Mar 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@jonahwilliams jonahwilliams requested a review from gaaclarke March 27, 2025 16:14
gaaclarke
gaaclarke approved these changes Mar 27, 2025
View reviewed changes
Copy link
Member

@gaaclarke gaaclarke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks

engine/src/flutter/impeller/entity/shaders/blending/vertices_uber_2.frag
Comment on lines +12 to +18
f16vec4 dst = IPHalfUnpremultiply(v_color);
f16vec4 src = IPHalfUnpremultiply(
Sample(texture_sampler, v_texture_coords, frag_info.tmx, frag_info.tmy));
f16vec3 blend_result =
AdvancedBlendHalf2(dst.rgb, src.rgb, int(frag_info.blend_mode - 14.0));
frag_color = IPApplyBlendedColor(dst, src, blend_result);
frag_color *= frag_info.alpha;
Copy link
Member

@gaaclarke gaaclarke Mar 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this can mostly be moved into the glsl file too.

Copy link
Contributor Author

@jonahwilliams jonahwilliams Mar 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

going to leave this for now

@jonahwilliams jonahwilliams added the autosubmit Merge PR when tree becomes green via auto submit App label Mar 28, 2025
@auto-submit auto-submit bot added this pull request to the merge queue Mar 28, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Mar 28, 2025
@flutter-dashboard flutter-dashboard bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Mar 28, 2025
@jonahwilliams jonahwilliams added the autosubmit Merge PR when tree becomes green via auto submit App label Mar 28, 2025
@auto-submit auto-submit bot added this pull request to the merge queue Mar 28, 2025
Merged via the queue into flutter:master with commit 7bbcfe0 Mar 28, 2025
173 checks passed
@flutter-dashboard flutter-dashboard bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Mar 28, 2025
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 28, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 28, 2025
@engine-flutter-autoroll
7bbcfe0 [Impeller] split vertices uber into 2 shaders. (flutter/flutt…
cc3c3d1 
…er#165938)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 28, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 28, 2025
@engine-flutter-autoroll
7bbcfe0 [Impeller] split vertices uber into 2 shaders. (flutter/flutt…
c10f0d7 
…er#165938)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 29, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 29, 2025
@engine-flutter-autoroll
7bbcfe0 [Impeller] split vertices uber into 2 shaders. (flutter/flutt…
1d2576d 
…er#165938)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 29, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 29, 2025
@engine-flutter-autoroll
7bbcfe0 [Impeller] split vertices uber into 2 shaders. (flutter/flutt…
4eefef7 
…er#165938)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 30, 2025
@engine-flutter-autoroll
7bbcfe0 [Impeller] split vertices uber into 2 shaders. (flutter/flutt…
09afc8b 
…er#165938)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 30, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 30, 2025
@engine-flutter-autoroll
7bbcfe0 [Impeller] split vertices uber into 2 shaders. (flutter/flutt…
5ac82ac 
…er#165938)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 31, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 31, 2025
@engine-flutter-autoroll
7bbcfe0 [Impeller] split vertices uber into 2 shaders. (flutter/flutt…
c5683f2 
…er#165938)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 31, 2025
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 31, 2025
@engine-flutter-autoroll
7bbcfe0 [Impeller] split vertices uber into 2 shaders. (flutter/flutt…
2b9ed03 
…er#165938)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 31, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 31, 2025
@engine-flutter-autoroll
7bbcfe0 [Impeller] split vertices uber into 2 shaders. (flutter/flutt…
3956904 
…er#165938)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 31, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 31, 2025
@engine-flutter-autoroll
7bbcfe0 [Impeller] split vertices uber into 2 shaders. (flutter/flutt…
74ee48b 
…er#165938)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 31, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 31, 2025
@engine-flutter-autoroll
7bbcfe0 [Impeller] split vertices uber into 2 shaders. (flutter/flutt…
0f5447b 
…er#165938)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 31, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 31, 2025
@engine-flutter-autoroll
7bbcfe0 [Impeller] split vertices uber into 2 shaders. (flutter/flutt…
652291e 
…er#165938)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 31, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 31, 2025
@engine-flutter-autoroll
7bbcfe0 [Impeller] split vertices uber into 2 shaders. (flutter/flutt…
e43ee46 
…er#165938)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 1, 2025
@engine-flutter-autoroll
7bbcfe0 [Impeller] split vertices uber into 2 shaders. (flutter/flutt…
caea6e7 
…er#165938)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 1, 2025
@engine-flutter-autoroll
7bbcfe0 [Impeller] split vertices uber into 2 shaders. (flutter/flutt…
65c89cb 
…er#165938)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 1, 2025
@engine-flutter-autoroll
7bbcfe0 [Impeller] split vertices uber into 2 shaders. (flutter/flutt…
51c5a0b 
…er#165938)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 1, 2025
@engine-flutter-autoroll
7bbcfe0 [Impeller] split vertices uber into 2 shaders. (flutter/flutt…
900771f 
…er#165938)
auto-submit bot pushed a commit to flutter/packages that referenced this pull request Apr 1, 2025
@engine-flutter-autoroll
Manual roll Flutter from 1d954f4 to 05b5e79 (225 revisions) (#8960)
84ef201 
Manual roll Flutter from 1d954f4 to 05b5e79 (225 revisions)

Manual roll requested by [email protected]

flutter/flutter@1d954f4...05b5e79

2025-03-29 [email protected] Roll Dart SDK from bcb7649e965a to b9c35e05feb5 (1 revision) (flutter/flutter#166202)
2025-03-29 [email protected] Roll Dart SDK from a7701559f616 to bcb7649e965a (1 revision) (flutter/flutter#166189)
2025-03-29 [email protected] Roll Dart SDK from 30ea8c4e622f to a7701559f616 (1 revision) (flutter/flutter#166185)
2025-03-29 [email protected] [fuchsia][sysmem2] switch to sysmem2 tokens (flutter/flutter#166120)
2025-03-29 [email protected] Roll Dart SDK from 65fe9906a916 to 30ea8c4e622f (2 revisions) (flutter/flutter#166181)
2025-03-29 [email protected] move around shaders in vertices uber 1/2 (flutter/flutter#166180)
2025-03-29 [email protected] [Impeller] optimize drawImageRect with blend and matrix color filter. (flutter/flutter#165998)
2025-03-28 [email protected] Add drawRSuperellipse support to mock_canvas. (flutter/flutter#165744)
2025-03-28 [email protected] Started clamping scaled antialias lines size (flutter/flutter#166149)
2025-03-28 [email protected] Roll Dart SDK from 4494ffead9af to 65fe9906a916 (7 revisions) (flutter/flutter#166162)
2025-03-28 [email protected] Remove bringup flag for customer tests (flutter/flutter#166161)
2025-03-28 [email protected] Add the ios-reviewers review team (flutter/flutter#166034)
2025-03-28 [email protected] [impeller] refactored LineContents to make it more testable, added tests (flutter/flutter#166035)
2025-03-28 [email protected] [Widget Inspector] Jump to source code of implementation widgets from Flutter Inspector (flutter/flutter#165924)
2025-03-28 [email protected] Make sure `LayoutBuilder` rebuild in an inactive route (flutter/flutter#154681)
2025-03-28 [email protected] [Impeller] allow newer powervr gpu to use Vulkan. (flutter/flutter#165520)
2025-03-28 [email protected] [web] Remove package:js in favor of dart:js_interop (flutter/flutter#165324)
2025-03-28 [email protected] [ Widget Previews ] Default to using Flutter Web for the widget preview environment (flutter/flutter#166091)
2025-03-28 [email protected] Mark Linux coverage as bringup (flutter/flutter#166144)
2025-03-28 [email protected] Roll Fuchsia Linux SDK from djUjSTaAtl0ETQSBR... to v7PGvypiiWLO8PbsZ... (flutter/flutter#166136)
2025-03-28 [email protected] [Impeller] split vertices uber into 2 shaders. (flutter/flutter#165938)
2025-03-28 [email protected] [flutter_tools] Fix VS Code package.json path on macOS with case-sensitive file system (flutter/flutter#163409)
2025-03-28 [email protected] Delete some verbose vm service logging (flutter/flutter#162709)
2025-03-28 [email protected] Get analytics welcome message under test (flutter/flutter#162627)
2025-03-28 [email protected] [ios][pv]fully revert the UIScreen.main deprecated API change (flutter/flutter#166080)
2025-03-28 [email protected] Roll Skia from b5b6f29d690f to 10f4cf9a817d (8 revisions) (flutter/flutter#166111)
2025-03-28 [email protected] [CI] remove check for exact golden files. (flutter/flutter#166031)
2025-03-28 [email protected] Move OpenGL context management to FlOpenGLManager (flutter/flutter#166025)
2025-03-27 [email protected] [android] only release background image readers on Android 14. (flutter/flutter#165942)
2025-03-27 [email protected] Refactor: Migrate Date picker from MaterialState and MaterialStateProperty (flutter/flutter#164972)
2025-03-27 [email protected] Mark Linux customer tests as flaky (flutter/flutter#166103)
2025-03-27 [email protected] Move app link settings task configuration to kotlin (flutter/flutter#165819)
2025-03-27 [email protected] Make iOS Flutter framework extension-safe (flutter/flutter#165346)
2025-03-27 [email protected] [ Widget Preview ] Display an error widget when an exception is thrown while defining the widget tree (flutter/flutter#166005)
2025-03-27 [email protected] Removed not working hyperlinks to ScriptCategory values (flutter/flutter#165395)
2025-03-27 [email protected] add PointerDeviceKind to ScaleStartDetails (flutter/flutter#165096)
2025-03-27 [email protected] Fix build_android_host_app_with_module_source device lab tests (flutter/flutter#166077)
2025-03-27 [email protected] Roll Skia from 11375a498f6b to b5b6f29d690f (4 revisions) (flutter/flutter#166060)
2025-03-27 [email protected] [Impeller] Move to the new location before rendering a stroke path contour containing only one point (flutter/flutter#165940)
2025-03-27 [email protected] Scale aa lines (flutter/flutter#165917)
2025-03-27 [email protected] Reapply "[ Device Lab ] Upgrade Device Lab projects to Java 18" (#166016) (flutter/flutter#166059)
2025-03-27 [email protected] Roll Fuchsia Linux SDK from iScQOaYHg2aJcF1LX... to djUjSTaAtl0ETQSBR... (flutter/flutter#166055)
2025-03-27 [email protected] Roll Skia from 67a236832d64 to 11375a498f6b (2 revisions) (flutter/flutter#166046)
2025-03-27 [email protected] [flutter_tool] Handle RPCErrorKind.kConnectionDisposed (flutter/flutter#164299)
...
CodixNinja pushed a commit to CodixNinja/packages that referenced this pull request May 15, 2025
@engine-flutter-autoroll
Manual roll Flutter from 1d954f4e96bd to 05b5e7910544 (225 revisions)…
c5e236f 
… (#8960)

Manual roll Flutter from 1d954f4e96bd to 05b5e7910544 (225 revisions)

Manual roll requested by [email protected]

flutter/flutter@1d954f4...05b5e79

2025-03-29 [email protected] Roll Dart SDK from bcb7649e965a to b9c35e05feb5 (1 revision) (flutter/flutter#166202)
2025-03-29 [email protected] Roll Dart SDK from a7701559f616 to bcb7649e965a (1 revision) (flutter/flutter#166189)
2025-03-29 [email protected] Roll Dart SDK from 30ea8c4e622f to a7701559f616 (1 revision) (flutter/flutter#166185)
2025-03-29 [email protected] [fuchsia][sysmem2] switch to sysmem2 tokens (flutter/flutter#166120)
2025-03-29 [email protected] Roll Dart SDK from 65fe9906a916 to 30ea8c4e622f (2 revisions) (flutter/flutter#166181)
2025-03-29 [email protected] move around shaders in vertices uber 1/2 (flutter/flutter#166180)
2025-03-29 [email protected] [Impeller] optimize drawImageRect with blend and matrix color filter. (flutter/flutter#165998)
2025-03-28 [email protected] Add drawRSuperellipse support to mock_canvas. (flutter/flutter#165744)
2025-03-28 [email protected] Started clamping scaled antialias lines size (flutter/flutter#166149)
2025-03-28 [email protected] Roll Dart SDK from 4494ffead9af to 65fe9906a916 (7 revisions) (flutter/flutter#166162)
2025-03-28 [email protected] Remove bringup flag for customer tests (flutter/flutter#166161)
2025-03-28 [email protected] Add the ios-reviewers review team (flutter/flutter#166034)
2025-03-28 [email protected] [impeller] refactored LineContents to make it more testable, added tests (flutter/flutter#166035)
2025-03-28 [email protected] [Widget Inspector] Jump to source code of implementation widgets from Flutter Inspector (flutter/flutter#165924)
2025-03-28 [email protected] Make sure `LayoutBuilder` rebuild in an inactive route (flutter/flutter#154681)
2025-03-28 [email protected] [Impeller] allow newer powervr gpu to use Vulkan. (flutter/flutter#165520)
2025-03-28 [email protected] [web] Remove package:js in favor of dart:js_interop (flutter/flutter#165324)
2025-03-28 [email protected] [ Widget Previews ] Default to using Flutter Web for the widget preview environment (flutter/flutter#166091)
2025-03-28 [email protected] Mark Linux coverage as bringup (flutter/flutter#166144)
2025-03-28 [email protected] Roll Fuchsia Linux SDK from djUjSTaAtl0ETQSBR... to v7PGvypiiWLO8PbsZ... (flutter/flutter#166136)
2025-03-28 [email protected] [Impeller] split vertices uber into 2 shaders. (flutter/flutter#165938)
2025-03-28 [email protected] [flutter_tools] Fix VS Code package.json path on macOS with case-sensitive file system (flutter/flutter#163409)
2025-03-28 [email protected] Delete some verbose vm service logging (flutter/flutter#162709)
2025-03-28 [email protected] Get analytics welcome message under test (flutter/flutter#162627)
2025-03-28 [email protected] [ios][pv]fully revert the UIScreen.main deprecated API change (flutter/flutter#166080)
2025-03-28 [email protected] Roll Skia from b5b6f29d690f to 10f4cf9a817d (8 revisions) (flutter/flutter#166111)
2025-03-28 [email protected] [CI] remove check for exact golden files. (flutter/flutter#166031)
2025-03-28 [email protected] Move OpenGL context management to FlOpenGLManager (flutter/flutter#166025)
2025-03-27 [email protected] [android] only release background image readers on Android 14. (flutter/flutter#165942)
2025-03-27 [email protected] Refactor: Migrate Date picker from MaterialState and MaterialStateProperty (flutter/flutter#164972)
2025-03-27 [email protected] Mark Linux customer tests as flaky (flutter/flutter#166103)
2025-03-27 [email protected] Move app link settings task configuration to kotlin (flutter/flutter#165819)
2025-03-27 [email protected] Make iOS Flutter framework extension-safe (flutter/flutter#165346)
2025-03-27 [email protected] [ Widget Preview ] Display an error widget when an exception is thrown while defining the widget tree (flutter/flutter#166005)
2025-03-27 [email protected] Removed not working hyperlinks to ScriptCategory values (flutter/flutter#165395)
2025-03-27 [email protected] add PointerDeviceKind to ScaleStartDetails (flutter/flutter#165096)
2025-03-27 [email protected] Fix build_android_host_app_with_module_source device lab tests (flutter/flutter#166077)
2025-03-27 [email protected] Roll Skia from 11375a498f6b to b5b6f29d690f (4 revisions) (flutter/flutter#166060)
2025-03-27 [email protected] [Impeller] Move to the new location before rendering a stroke path contour containing only one point (flutter/flutter#165940)
2025-03-27 [email protected] Scale aa lines (flutter/flutter#165917)
2025-03-27 [email protected] Reapply "[ Device Lab ] Upgrade Device Lab projects to Java 18" (#166016) (flutter/flutter#166059)
2025-03-27 [email protected] Roll Fuchsia Linux SDK from iScQOaYHg2aJcF1LX... to djUjSTaAtl0ETQSBR... (flutter/flutter#166055)
2025-03-27 [email protected] Roll Skia from 67a236832d64 to 11375a498f6b (2 revisions) (flutter/flutter#166046)
2025-03-27 [email protected] [flutter_tool] Handle RPCErrorKind.kConnectionDisposed (flutter/flutter#164299)
...
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 20, 2025
@engine-flutter-autoroll
7bbcfe0 [Impeller] split vertices uber into 2 shaders. (flutter/flutt…
ae6969b 
…er#165938)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 20, 2025
@engine-flutter-autoroll
7bbcfe0 [Impeller] split vertices uber into 2 shaders. (flutter/flutt…
46aab52 
…er#165938)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 21, 2025
@engine-flutter-autoroll
7bbcfe0 [Impeller] split vertices uber into 2 shaders. (flutter/flutt…
4df8666 
…er#165938)
androidseb pushed a commit to androidseb/packages that referenced this pull request Jun 8, 2025
@engine-flutter-autoroll @androidseb
Manual roll Flutter from 1d954f4 to 05b5e79 (225 revisions) (flutter#…
166c443 
…8960)

Manual roll Flutter from 1d954f4 to 05b5e79 (225 revisions)

Manual roll requested by [email protected]

flutter/flutter@1d954f4...05b5e79

2025-03-29 [email protected] Roll Dart SDK from bcb7649e965a to b9c35e05feb5 (1 revision) (flutter/flutter#166202)
2025-03-29 [email protected] Roll Dart SDK from a7701559f616 to bcb7649e965a (1 revision) (flutter/flutter#166189)
2025-03-29 [email protected] Roll Dart SDK from 30ea8c4e622f to a7701559f616 (1 revision) (flutter/flutter#166185)
2025-03-29 [email protected] [fuchsia][sysmem2] switch to sysmem2 tokens (flutter/flutter#166120)
2025-03-29 [email protected] Roll Dart SDK from 65fe9906a916 to 30ea8c4e622f (2 revisions) (flutter/flutter#166181)
2025-03-29 [email protected] move around shaders in vertices uber 1/2 (flutter/flutter#166180)
2025-03-29 [email protected] [Impeller] optimize drawImageRect with blend and matrix color filter. (flutter/flutter#165998)
2025-03-28 [email protected] Add drawRSuperellipse support to mock_canvas. (flutter/flutter#165744)
2025-03-28 [email protected] Started clamping scaled antialias lines size (flutter/flutter#166149)
2025-03-28 [email protected] Roll Dart SDK from 4494ffead9af to 65fe9906a916 (7 revisions) (flutter/flutter#166162)
2025-03-28 [email protected] Remove bringup flag for customer tests (flutter/flutter#166161)
2025-03-28 [email protected] Add the ios-reviewers review team (flutter/flutter#166034)
2025-03-28 [email protected] [impeller] refactored LineContents to make it more testable, added tests (flutter/flutter#166035)
2025-03-28 [email protected] [Widget Inspector] Jump to source code of implementation widgets from Flutter Inspector (flutter/flutter#165924)
2025-03-28 [email protected] Make sure `LayoutBuilder` rebuild in an inactive route (flutter/flutter#154681)
2025-03-28 [email protected] [Impeller] allow newer powervr gpu to use Vulkan. (flutter/flutter#165520)
2025-03-28 [email protected] [web] Remove package:js in favor of dart:js_interop (flutter/flutter#165324)
2025-03-28 [email protected] [ Widget Previews ] Default to using Flutter Web for the widget preview environment (flutter/flutter#166091)
2025-03-28 [email protected] Mark Linux coverage as bringup (flutter/flutter#166144)
2025-03-28 [email protected] Roll Fuchsia Linux SDK from djUjSTaAtl0ETQSBR... to v7PGvypiiWLO8PbsZ... (flutter/flutter#166136)
2025-03-28 [email protected] [Impeller] split vertices uber into 2 shaders. (flutter/flutter#165938)
2025-03-28 [email protected] [flutter_tools] Fix VS Code package.json path on macOS with case-sensitive file system (flutter/flutter#163409)
2025-03-28 [email protected] Delete some verbose vm service logging (flutter/flutter#162709)
2025-03-28 [email protected] Get analytics welcome message under test (flutter/flutter#162627)
2025-03-28 [email protected] [ios][pv]fully revert the UIScreen.main deprecated API change (flutter/flutter#166080)
2025-03-28 [email protected] Roll Skia from b5b6f29d690f to 10f4cf9a817d (8 revisions) (flutter/flutter#166111)
2025-03-28 [email protected] [CI] remove check for exact golden files. (flutter/flutter#166031)
2025-03-28 [email protected] Move OpenGL context management to FlOpenGLManager (flutter/flutter#166025)
2025-03-27 [email protected] [android] only release background image readers on Android 14. (flutter/flutter#165942)
2025-03-27 [email protected] Refactor: Migrate Date picker from MaterialState and MaterialStateProperty (flutter/flutter#164972)
2025-03-27 [email protected] Mark Linux customer tests as flaky (flutter/flutter#166103)
2025-03-27 [email protected] Move app link settings task configuration to kotlin (flutter/flutter#165819)
2025-03-27 [email protected] Make iOS Flutter framework extension-safe (flutter/flutter#165346)
2025-03-27 [email protected] [ Widget Preview ] Display an error widget when an exception is thrown while defining the widget tree (flutter/flutter#166005)
2025-03-27 [email protected] Removed not working hyperlinks to ScriptCategory values (flutter/flutter#165395)
2025-03-27 [email protected] add PointerDeviceKind to ScaleStartDetails (flutter/flutter#165096)
2025-03-27 [email protected] Fix build_android_host_app_with_module_source device lab tests (flutter/flutter#166077)
2025-03-27 [email protected] Roll Skia from 11375a498f6b to b5b6f29d690f (4 revisions) (flutter/flutter#166060)
2025-03-27 [email protected] [Impeller] Move to the new location before rendering a stroke path contour containing only one point (flutter/flutter#165940)
2025-03-27 [email protected] Scale aa lines (flutter/flutter#165917)
2025-03-27 [email protected] Reapply "[ Device Lab ] Upgrade Device Lab projects to Java 18" (#166016) (flutter/flutter#166059)
2025-03-27 [email protected] Roll Fuchsia Linux SDK from iScQOaYHg2aJcF1LX... to djUjSTaAtl0ETQSBR... (flutter/flutter#166055)
2025-03-27 [email protected] Roll Skia from 67a236832d64 to 11375a498f6b (2 revisions) (flutter/flutter#166046)
2025-03-27 [email protected] [flutter_tool] Handle RPCErrorKind.kConnectionDisposed (flutter/flutter#164299)
...
zhangyuang pushed a commit to zhangyuang/flutter-fork that referenced this pull request Jun 9, 2025
[Impeller] split vertices uber into 2 shaders. (flutter#165938)
94288f8 
Works around compilation error on newer phone (ask me offline). Required
for flutter#162033
FMorschel pushed a commit to FMorschel/packages that referenced this pull request Jun 9, 2025
@engine-flutter-autoroll @FMorschel
Manual roll Flutter from 1d954f4 to 05b5e79 (225 revisions) (flutter#…
0dc8f54 
…8960)

Manual roll Flutter from 1d954f4 to 05b5e79 (225 revisions)

Manual roll requested by [email protected]

flutter/flutter@1d954f4...05b5e79

2025-03-29 [email protected] Roll Dart SDK from bcb7649e965a to b9c35e05feb5 (1 revision) (flutter/flutter#166202)
2025-03-29 [email protected] Roll Dart SDK from a7701559f616 to bcb7649e965a (1 revision) (flutter/flutter#166189)
2025-03-29 [email protected] Roll Dart SDK from 30ea8c4e622f to a7701559f616 (1 revision) (flutter/flutter#166185)
2025-03-29 [email protected] [fuchsia][sysmem2] switch to sysmem2 tokens (flutter/flutter#166120)
2025-03-29 [email protected] Roll Dart SDK from 65fe9906a916 to 30ea8c4e622f (2 revisions) (flutter/flutter#166181)
2025-03-29 [email protected] move around shaders in vertices uber 1/2 (flutter/flutter#166180)
2025-03-29 [email protected] [Impeller] optimize drawImageRect with blend and matrix color filter. (flutter/flutter#165998)
2025-03-28 [email protected] Add drawRSuperellipse support to mock_canvas. (flutter/flutter#165744)
2025-03-28 [email protected] Started clamping scaled antialias lines size (flutter/flutter#166149)
2025-03-28 [email protected] Roll Dart SDK from 4494ffead9af to 65fe9906a916 (7 revisions) (flutter/flutter#166162)
2025-03-28 [email protected] Remove bringup flag for customer tests (flutter/flutter#166161)
2025-03-28 [email protected] Add the ios-reviewers review team (flutter/flutter#166034)
2025-03-28 [email protected] [impeller] refactored LineContents to make it more testable, added tests (flutter/flutter#166035)
2025-03-28 [email protected] [Widget Inspector] Jump to source code of implementation widgets from Flutter Inspector (flutter/flutter#165924)
2025-03-28 [email protected] Make sure `LayoutBuilder` rebuild in an inactive route (flutter/flutter#154681)
2025-03-28 [email protected] [Impeller] allow newer powervr gpu to use Vulkan. (flutter/flutter#165520)
2025-03-28 [email protected] [web] Remove package:js in favor of dart:js_interop (flutter/flutter#165324)
2025-03-28 [email protected] [ Widget Previews ] Default to using Flutter Web for the widget preview environment (flutter/flutter#166091)
2025-03-28 [email protected] Mark Linux coverage as bringup (flutter/flutter#166144)
2025-03-28 [email protected] Roll Fuchsia Linux SDK from djUjSTaAtl0ETQSBR... to v7PGvypiiWLO8PbsZ... (flutter/flutter#166136)
2025-03-28 [email protected] [Impeller] split vertices uber into 2 shaders. (flutter/flutter#165938)
2025-03-28 [email protected] [flutter_tools] Fix VS Code package.json path on macOS with case-sensitive file system (flutter/flutter#163409)
2025-03-28 [email protected] Delete some verbose vm service logging (flutter/flutter#162709)
2025-03-28 [email protected] Get analytics welcome message under test (flutter/flutter#162627)
2025-03-28 [email protected] [ios][pv]fully revert the UIScreen.main deprecated API change (flutter/flutter#166080)
2025-03-28 [email protected] Roll Skia from b5b6f29d690f to 10f4cf9a817d (8 revisions) (flutter/flutter#166111)
2025-03-28 [email protected] [CI] remove check for exact golden files. (flutter/flutter#166031)
2025-03-28 [email protected] Move OpenGL context management to FlOpenGLManager (flutter/flutter#166025)
2025-03-27 [email protected] [android] only release background image readers on Android 14. (flutter/flutter#165942)
2025-03-27 [email protected] Refactor: Migrate Date picker from MaterialState and MaterialStateProperty (flutter/flutter#164972)
2025-03-27 [email protected] Mark Linux customer tests as flaky (flutter/flutter#166103)
2025-03-27 [email protected] Move app link settings task configuration to kotlin (flutter/flutter#165819)
2025-03-27 [email protected] Make iOS Flutter framework extension-safe (flutter/flutter#165346)
2025-03-27 [email protected] [ Widget Preview ] Display an error widget when an exception is thrown while defining the widget tree (flutter/flutter#166005)
2025-03-27 [email protected] Removed not working hyperlinks to ScriptCategory values (flutter/flutter#165395)
2025-03-27 [email protected] add PointerDeviceKind to ScaleStartDetails (flutter/flutter#165096)
2025-03-27 [email protected] Fix build_android_host_app_with_module_source device lab tests (flutter/flutter#166077)
2025-03-27 [email protected] Roll Skia from 11375a498f6b to b5b6f29d690f (4 revisions) (flutter/flutter#166060)
2025-03-27 [email protected] [Impeller] Move to the new location before rendering a stroke path contour containing only one point (flutter/flutter#165940)
2025-03-27 [email protected] Scale aa lines (flutter/flutter#165917)
2025-03-27 [email protected] Reapply "[ Device Lab ] Upgrade Device Lab projects to Java 18" (#166016) (flutter/flutter#166059)
2025-03-27 [email protected] Roll Fuchsia Linux SDK from iScQOaYHg2aJcF1LX... to djUjSTaAtl0ETQSBR... (flutter/flutter#166055)
2025-03-27 [email protected] Roll Skia from 67a236832d64 to 11375a498f6b (2 revisions) (flutter/flutter#166046)
2025-03-27 [email protected] [flutter_tool] Handle RPCErrorKind.kConnectionDisposed (flutter/flutter#164299)
...
romanejaquez pushed a commit to romanejaquez/flutter that referenced this pull request Aug 14, 2025
@romanejaquez
[Impeller] split vertices uber into 2 shaders. (flutter#165938)
551f65a 
Works around compilation error on newer phone (ask me offline). Required
for flutter#162033
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gaaclarke gaaclarke gaaclarke approved these changes

Assignees

No one assigned

Labels

e: impeller Impeller rendering backend issues and features requests engine flutter/engine related. See also e: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jonahwilliams @gaaclarke