Skip to content

[Impeller] reland: tighten up the graphics on level 3. #165912

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
auto-submit merged 7 commits into from
Mar 26, 2025
Merged

[Impeller] reland: tighten up the graphics on level 3. #165912

auto-submit merged 7 commits into from
Mar 26, 2025

Conversation

@jonahwilliams
Copy link
Contributor

@jonahwilliams jonahwilliams commented Mar 25, 2025 •
edited by gaaclarke
Loading

relands #165584

We can't have separate barriers for onscreen because it makes the render pass incompatible.

@jonahwilliams jonahwilliams requested a review from gaaclarke March 25, 2025 19:34
@github-actions github-actions bot added a: text input Entering text in a text field or keyboard related problems engine flutter/engine related. See also e: labels. e: impeller Impeller rendering backend issues and features requests labels Mar 25, 2025
gaaclarke
gaaclarke reviewed Mar 25, 2025
View reviewed changes
engine/src/flutter/impeller/entity/contents/text_shadow_cache.h Outdated
Copy link
Member

@gaaclarke gaaclarke Mar 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you mean to check this in?

Copy link
Contributor Author

@jonahwilliams jonahwilliams Mar 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nope lol goddamn it

@github-actions github-actions bot removed the a: text input Entering text in a text field or keyboard related problems label Mar 25, 2025
@jonahwilliams jonahwilliams requested a review from gaaclarke March 25, 2025 21:52
gaaclarke
gaaclarke reviewed Mar 25, 2025
View reviewed changes
engine/src/flutter/impeller/renderer/backend/vulkan/render_pass_builder_vk.h Outdated
Comment on lines 31 to 34
/// Whether this builder should configure barriers for the onscreen render
/// pass.
void SetSwapchain(bool value);

Copy link
Member

@gaaclarke gaaclarke Mar 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you meant to get rid of this. There is no implementation for it.

Copy link
Contributor Author

@jonahwilliams jonahwilliams Mar 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

got it

gaaclarke
gaaclarke approved these changes Mar 25, 2025
View reviewed changes
Copy link
Member

@gaaclarke gaaclarke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jonahwilliams jonahwilliams added the autosubmit Merge PR when tree becomes green via auto submit App label Mar 25, 2025
@auto-submit auto-submit bot added this pull request to the merge queue Mar 26, 2025
Merged via the queue into flutter:master with commit 416af99 Mar 26, 2025
173 checks passed
@flutter-dashboard flutter-dashboard bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Mar 26, 2025
@jonahwilliams jonahwilliams deleted the tighten_up_barriers branch March 26, 2025 01:00
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 26, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 26, 2025
@engine-flutter-autoroll
416af99 [Impeller] reland: tighten up the graphics on level 3. (flutt…
1b6a53c 
…er/flutter#165912)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 26, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 26, 2025
@engine-flutter-autoroll
416af99 [Impeller] reland: tighten up the graphics on level 3. (flutt…
3af8c0b 
…er/flutter#165912)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 26, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 26, 2025
@engine-flutter-autoroll
416af99 [Impeller] reland: tighten up the graphics on level 3. (flutt…
d7e13cc 
…er/flutter#165912)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 26, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 26, 2025
@engine-flutter-autoroll
416af99 [Impeller] reland: tighten up the graphics on level 3. (flutt…
82a7eb3 
…er/flutter#165912)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 27, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 27, 2025
@engine-flutter-autoroll
416af99 [Impeller] reland: tighten up the graphics on level 3. (flutt…
9e5089b 
…er/flutter#165912)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 27, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 27, 2025
@engine-flutter-autoroll
416af99 [Impeller] reland: tighten up the graphics on level 3. (flutt…
8275ae1 
…er/flutter#165912)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 27, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 27, 2025
@engine-flutter-autoroll
416af99 [Impeller] reland: tighten up the graphics on level 3. (flutt…
6305ec5 
…er/flutter#165912)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 28, 2025
@engine-flutter-autoroll
416af99 [Impeller] reland: tighten up the graphics on level 3. (flutt…
6749824 
…er/flutter#165912)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 28, 2025
@engine-flutter-autoroll
416af99 [Impeller] reland: tighten up the graphics on level 3. (flutt…
0623e89 
…er/flutter#165912)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 28, 2025
@engine-flutter-autoroll
416af99 [Impeller] reland: tighten up the graphics on level 3. (flutt…
95bfd71 
…er/flutter#165912)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 28, 2025
@engine-flutter-autoroll
416af99 [Impeller] reland: tighten up the graphics on level 3. (flutt…
5af6b2c 
…er/flutter#165912)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 29, 2025
@engine-flutter-autoroll
416af99 [Impeller] reland: tighten up the graphics on level 3. (flutt…
88db3af 
…er/flutter#165912)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 29, 2025
@engine-flutter-autoroll
416af99 [Impeller] reland: tighten up the graphics on level 3. (flutt…
491cd66 
…er/flutter#165912)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 30, 2025
@engine-flutter-autoroll
416af99 [Impeller] reland: tighten up the graphics on level 3. (flutt…
41c0193 
…er/flutter#165912)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 30, 2025
@engine-flutter-autoroll
416af99 [Impeller] reland: tighten up the graphics on level 3. (flutt…
f36cd60 
…er/flutter#165912)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 31, 2025
@engine-flutter-autoroll
416af99 [Impeller] reland: tighten up the graphics on level 3. (flutt…
fe64d40 
…er/flutter#165912)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 31, 2025
@engine-flutter-autoroll
416af99 [Impeller] reland: tighten up the graphics on level 3. (flutt…
efbbe24 
…er/flutter#165912)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 31, 2025
@engine-flutter-autoroll
416af99 [Impeller] reland: tighten up the graphics on level 3. (flutt…
7f7ea5d 
…er/flutter#165912)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 31, 2025
@engine-flutter-autoroll
416af99 [Impeller] reland: tighten up the graphics on level 3. (flutt…
9f0d886 
…er/flutter#165912)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 31, 2025
@engine-flutter-autoroll
416af99 [Impeller] reland: tighten up the graphics on level 3. (flutt…
7564c8c 
…er/flutter#165912)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 31, 2025
@engine-flutter-autoroll
416af99 [Impeller] reland: tighten up the graphics on level 3. (flutt…
e9f0cdc 
…er/flutter#165912)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 31, 2025
@engine-flutter-autoroll
416af99 [Impeller] reland: tighten up the graphics on level 3. (flutt…
c5de23a 
…er/flutter#165912)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 1, 2025
@engine-flutter-autoroll
416af99 [Impeller] reland: tighten up the graphics on level 3. (flutt…
1e39f2b 
…er/flutter#165912)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 1, 2025
@engine-flutter-autoroll
416af99 [Impeller] reland: tighten up the graphics on level 3. (flutt…
4a88c10 
…er/flutter#165912)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 1, 2025
@engine-flutter-autoroll
416af99 [Impeller] reland: tighten up the graphics on level 3. (flutt…
cd8692a 
…er/flutter#165912)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 1, 2025
@engine-flutter-autoroll
416af99 [Impeller] reland: tighten up the graphics on level 3. (flutt…
a1a485b 
…er/flutter#165912)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 20, 2025
@engine-flutter-autoroll
416af99 [Impeller] reland: tighten up the graphics on level 3. (flutt…
8bc635e 
…er/flutter#165912)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 20, 2025
@engine-flutter-autoroll
416af99 [Impeller] reland: tighten up the graphics on level 3. (flutt…
25ddb82 
…er/flutter#165912)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 21, 2025
@engine-flutter-autoroll
416af99 [Impeller] reland: tighten up the graphics on level 3. (flutt…
e87dfaf 
…er/flutter#165912)
zhangyuang pushed a commit to zhangyuang/flutter-fork that referenced this pull request Jun 9, 2025
[Impeller] reland: tighten up the graphics on level 3. (flutter#165912)
0f5d0be 
relands flutter#165584

We can't have separate barriers for onscreen because it makes the render
pass incompatible.
romanejaquez pushed a commit to romanejaquez/flutter that referenced this pull request Aug 14, 2025
@romanejaquez
[Impeller] reland: tighten up the graphics on level 3. (flutter#165912)
e0f7817 
relands flutter#165584

We can't have separate barriers for onscreen because it makes the render
pass incompatible.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gaaclarke gaaclarke gaaclarke approved these changes

Assignees

No one assigned

Labels

e: impeller Impeller rendering backend issues and features requests engine flutter/engine related. See also e: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jonahwilliams @gaaclarke