[Impeller] remove overriding of sampler mode to decal. #165908
Conversation
|
It looks like this pull request may not have tests. Please make sure to add tests or get an explicit test exemption before merging. If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.If you believe this PR qualifies for a test exemption, contact "@test-exemption-reviewer" in the #hackers channel in Discord (don't just cc them here, they won't see it!). The test exemption team is a small volunteer group, so all reviewers should feel empowered to ask for tests, without delegating that responsibility entirely to the test exemption group. |
github-actions
bot
added
engine
| auto src_sampler_descriptor = SamplerDescriptor{}; | ||
| SamplerDescriptor src_sampler_descriptor = SamplerDescriptor{}; | ||
| if (renderer.GetDeviceCapabilities().SupportsDecalSamplerAddressMode()) { | ||
| src_sampler_descriptor.width_address_mode = SamplerAddressMode::kDecal; |
There was a problem hiding this comment.
Should this also be removed?
There was a problem hiding this comment.
Changed this to use the snapshot descriptor, unless we didn't use a snapshot then it just uses a default descriptor.
|
Golden file changes have been found for this pull request. Click here to view and triage (e.g. because this is an intentional change). If you are still iterating on this change and are not ready to resolve the images on the Flutter Gold dashboard, consider marking this PR as a draft pull request above. You will still be able to view image results on the dashboard, commenting will be silenced, and the check will not try to resolve itself until marked ready for review. For more guidance, visit Writing a golden file test for Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
jonahwilliams
added
the
autosubmit
flutter-dashboard
bot
removed
the
autosubmit
Fixes flutter#165788 We can't remember why we did this.
Fixes flutter#165788 We can't remember why we did this.
2 participants
Fixes #165788
We can't remember why we did this.