Skip to content

Re-enable bash_entrypoint_test.dart #165809

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
auto-submit merged 2 commits into from
Mar 24, 2025
Merged

Re-enable bash_entrypoint_test.dart #165809

auto-submit merged 2 commits into from
Mar 24, 2025

Conversation

@bkonyi
Copy link
Contributor

@bkonyi bkonyi commented Mar 24, 2025 •
edited
Loading

The test was fixed in d443df0 but never re-enabled.

Fixes #160689

@bkonyi
Re-enable bash_entrypoint_test.dart
1fbf5d5 
The test was fixed in
d443df0
but never re-enabled.

Fixes #160689
@bkonyi bkonyi requested a review from jtmcdole March 24, 2025 15:27
@github-actions github-actions bot added the tool Affects the "flutter" command-line tool. See also t: labels. label Mar 24, 2025
@bkonyi bkonyi added autosubmit Merge PR when tree becomes green via auto submit App and removed tool Affects the "flutter" command-line tool. See also t: labels. labels Mar 24, 2025
@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Mar 24, 2025
@auto-submit
Copy link
Contributor

auto-submit bot commented Mar 24, 2025

autosubmit label was removed for flutter/flutter/165809, because - The status or check suite Windows tool_integration_tests_3_9 has failed. Please fix the issues identified (or deflake) before re-applying this label.

@bkonyi bkonyi added the autosubmit Merge PR when tree becomes green via auto submit App label Mar 24, 2025
@github-actions github-actions bot added the tool Affects the "flutter" command-line tool. See also t: labels. label Mar 24, 2025
jtmcdole
jtmcdole approved these changes Mar 24, 2025
View reviewed changes
Copy link
Member

@jtmcdole jtmcdole left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm-cat-shake

@auto-submit
Copy link
Contributor

auto-submit bot commented Mar 24, 2025

autosubmit label was removed for flutter/flutter/165809, because - The status or check suite Google testing has failed. Please fix the issues identified (or deflake) before re-applying this label.

@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Mar 24, 2025
@bkonyi bkonyi added the autosubmit Merge PR when tree becomes green via auto submit App label Mar 24, 2025
@auto-submit auto-submit bot added this pull request to the merge queue Mar 24, 2025
Merged via the queue into master with commit a664992 Mar 24, 2025
142 checks passed
@auto-submit auto-submit bot deleted the reenable_bash_entrypoint_test branch March 24, 2025 19:27
@flutter-dashboard flutter-dashboard bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Mar 24, 2025
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 25, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 25, 2025
@engine-flutter-autoroll
a664992 Re-enable bash_entrypoint_test.dart (flutter/flutter#165809)
eb25583
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 25, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 25, 2025
@engine-flutter-autoroll
a664992 Re-enable bash_entrypoint_test.dart (flutter/flutter#165809)
6aa0eb6
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 26, 2025
@engine-flutter-autoroll
a664992 Re-enable bash_entrypoint_test.dart (flutter/flutter#165809)
7af2767
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 26, 2025
@engine-flutter-autoroll
a664992 Re-enable bash_entrypoint_test.dart (flutter/flutter#165809)
4b58737
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 26, 2025
@engine-flutter-autoroll
a664992 Re-enable bash_entrypoint_test.dart (flutter/flutter#165809)
175d3e1
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 26, 2025
@engine-flutter-autoroll
a664992 Re-enable bash_entrypoint_test.dart (flutter/flutter#165809)
7886da3
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 26, 2025
@engine-flutter-autoroll
a664992 Re-enable bash_entrypoint_test.dart (flutter/flutter#165809)
f08a74d
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 26, 2025
@engine-flutter-autoroll
a664992 Re-enable bash_entrypoint_test.dart (flutter/flutter#165809)
9902e82
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 26, 2025
@engine-flutter-autoroll
a664992 Re-enable bash_entrypoint_test.dart (flutter/flutter#165809)
bb2c698
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 27, 2025
@engine-flutter-autoroll
a664992 Re-enable bash_entrypoint_test.dart (flutter/flutter#165809)
d5c9520
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 27, 2025
@engine-flutter-autoroll
a664992 Re-enable bash_entrypoint_test.dart (flutter/flutter#165809)
6d53374
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 27, 2025
@engine-flutter-autoroll
a664992 Re-enable bash_entrypoint_test.dart (flutter/flutter#165809)
7c4ffda
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 27, 2025
@engine-flutter-autoroll
a664992 Re-enable bash_entrypoint_test.dart (flutter/flutter#165809)
3be3da0
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 27, 2025
@engine-flutter-autoroll
a664992 Re-enable bash_entrypoint_test.dart (flutter/flutter#165809)
d7c3c04
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 27, 2025
@engine-flutter-autoroll
a664992 Re-enable bash_entrypoint_test.dart (flutter/flutter#165809)
d700c66
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 28, 2025
@engine-flutter-autoroll
a664992 Re-enable bash_entrypoint_test.dart (flutter/flutter#165809)
be4039a
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 28, 2025
@engine-flutter-autoroll
a664992 Re-enable bash_entrypoint_test.dart (flutter/flutter#165809)
c2f343b
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 28, 2025
@engine-flutter-autoroll
a664992 Re-enable bash_entrypoint_test.dart (flutter/flutter#165809)
0bb2bb3
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 28, 2025
@engine-flutter-autoroll
a664992 Re-enable bash_entrypoint_test.dart (flutter/flutter#165809)
83dd766
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 29, 2025
@engine-flutter-autoroll
a664992 Re-enable bash_entrypoint_test.dart (flutter/flutter#165809)
f1d3360
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 29, 2025
@engine-flutter-autoroll
a664992 Re-enable bash_entrypoint_test.dart (flutter/flutter#165809)
3ebdc8a
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 30, 2025
@engine-flutter-autoroll
a664992 Re-enable bash_entrypoint_test.dart (flutter/flutter#165809)
fb89b0d
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 30, 2025
@engine-flutter-autoroll
a664992 Re-enable bash_entrypoint_test.dart (flutter/flutter#165809)
5c044cd
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 31, 2025
@engine-flutter-autoroll
a664992 Re-enable bash_entrypoint_test.dart (flutter/flutter#165809)
4830c21
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 31, 2025
@engine-flutter-autoroll
a664992 Re-enable bash_entrypoint_test.dart (flutter/flutter#165809)
f6b522e
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 31, 2025
@engine-flutter-autoroll
a664992 Re-enable bash_entrypoint_test.dart (flutter/flutter#165809)
89aedc6
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 31, 2025
@engine-flutter-autoroll
a664992 Re-enable bash_entrypoint_test.dart (flutter/flutter#165809)
57b9eb1
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 31, 2025
@engine-flutter-autoroll
a664992 Re-enable bash_entrypoint_test.dart (flutter/flutter#165809)
62220a3
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 31, 2025
@engine-flutter-autoroll
a664992 Re-enable bash_entrypoint_test.dart (flutter/flutter#165809)
0ea560f
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 31, 2025
@engine-flutter-autoroll
a664992 Re-enable bash_entrypoint_test.dart (flutter/flutter#165809)
6b71205
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 1, 2025
@engine-flutter-autoroll
a664992 Re-enable bash_entrypoint_test.dart (flutter/flutter#165809)
a7952d5
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 1, 2025
@engine-flutter-autoroll
a664992 Re-enable bash_entrypoint_test.dart (flutter/flutter#165809)
a40d44f
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 1, 2025
@engine-flutter-autoroll
a664992 Re-enable bash_entrypoint_test.dart (flutter/flutter#165809)
9d0ca31
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 1, 2025
@engine-flutter-autoroll
a664992 Re-enable bash_entrypoint_test.dart (flutter/flutter#165809)
1ad37e4
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 20, 2025
@engine-flutter-autoroll
a664992 Re-enable bash_entrypoint_test.dart (flutter/flutter#165809)
e6c1851
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 20, 2025
@engine-flutter-autoroll
a664992 Re-enable bash_entrypoint_test.dart (flutter/flutter#165809)
8ab6312
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 21, 2025
@engine-flutter-autoroll
a664992 Re-enable bash_entrypoint_test.dart (flutter/flutter#165809)
46bb2e3
zhangyuang pushed a commit to zhangyuang/flutter-fork that referenced this pull request Jun 9, 2025
@bkonyi
Re-enable bash_entrypoint_test.dart (flutter#165809)
05a4b58 
The test was fixed in
flutter@d443df0
but never re-enabled.

Fixes flutter#160689
romanejaquez pushed a commit to romanejaquez/flutter that referenced this pull request Aug 14, 2025
@bkonyi @romanejaquez
Re-enable bash_entrypoint_test.dart (flutter#165809)
0c63902 
The test was fixed in
flutter@d443df0
but never re-enabled.

Fixes flutter#160689
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jtmcdole jtmcdole jtmcdole approved these changes

Assignees

No one assigned

Labels

tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

bash_entrypoint_test.dart breaking after change to shared.sh

2 participants

@bkonyi @jtmcdole