Skip to content

Animate a CupertinoButton based on tap move events only if the move happens between a tap down and a tap up #165729

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
auto-submit merged 4 commits into from
Mar 25, 2025
Merged

Animate a CupertinoButton based on tap move events only if the move happens between a tap down and a tap up #165729

auto-submit merged 4 commits into from
Mar 25, 2025

Conversation

@jason-simmons
Copy link
Member

@jason-simmons jason-simmons commented Mar 22, 2025

Fixes #165724

@jason-simmons jason-simmons requested a review from dkwingsmt March 22, 2025 01:00
@github-actions github-actions bot added framework flutter/packages/flutter repository. See also f: labels. f: cupertino flutter/packages/flutter/cupertino repository labels Mar 22, 2025
@dkwingsmt
Copy link
Contributor

dkwingsmt commented Mar 22, 2025 •
edited
Loading

I ran the unit tests with the button change reverted but the unit test still passes.

I wonder if it's because getTopLeft is not recognized by the button anyway.

@jason-simmons
Copy link
Member Author

jason-simmons commented Mar 24, 2025

Updated the test with a gesture that should demonstrate the issue - PTAL

dkwingsmt
dkwingsmt approved these changes Mar 24, 2025
View reviewed changes
Copy link
Contributor

@dkwingsmt dkwingsmt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@jason-simmons jason-simmons added the autosubmit Merge PR when tree becomes green via auto submit App label Mar 25, 2025
@auto-submit auto-submit bot added this pull request to the merge queue Mar 25, 2025
Merged via the queue into flutter:master with commit 0af426f Mar 25, 2025
75 checks passed
@flutter-dashboard flutter-dashboard bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Mar 25, 2025
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 26, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 26, 2025
@engine-flutter-autoroll
0af426f Animate a CupertinoButton based on tap move events only if th…
61c4994 
…e move happens between a tap down and a tap up (flutter/flutter#165729)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 26, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 26, 2025
@engine-flutter-autoroll
0af426f Animate a CupertinoButton based on tap move events only if th…
9c1f4ad 
…e move happens between a tap down and a tap up (flutter/flutter#165729)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 26, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 26, 2025
@engine-flutter-autoroll
0af426f Animate a CupertinoButton based on tap move events only if th…
8504caf 
…e move happens between a tap down and a tap up (flutter/flutter#165729)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 26, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 26, 2025
@engine-flutter-autoroll
0af426f Animate a CupertinoButton based on tap move events only if th…
e5dda15 
…e move happens between a tap down and a tap up (flutter/flutter#165729)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 26, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 26, 2025
@engine-flutter-autoroll
0af426f Animate a CupertinoButton based on tap move events only if th…
743a810 
…e move happens between a tap down and a tap up (flutter/flutter#165729)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 26, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 26, 2025
@engine-flutter-autoroll
0af426f Animate a CupertinoButton based on tap move events only if th…
ea04495 
…e move happens between a tap down and a tap up (flutter/flutter#165729)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 26, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 26, 2025
@engine-flutter-autoroll
0af426f Animate a CupertinoButton based on tap move events only if th…
556725f 
…e move happens between a tap down and a tap up (flutter/flutter#165729)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 26, 2025
Closed
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 27, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 27, 2025
@engine-flutter-autoroll
0af426f Animate a CupertinoButton based on tap move events only if th…
43d24e9 
…e move happens between a tap down and a tap up (flutter/flutter#165729)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 27, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 27, 2025
@engine-flutter-autoroll
0af426f Animate a CupertinoButton based on tap move events only if th…
a0c7165 
…e move happens between a tap down and a tap up (flutter/flutter#165729)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 27, 2025
@engine-flutter-autoroll
0af426f Animate a CupertinoButton based on tap move events only if th…
2637b56 
…e move happens between a tap down and a tap up (flutter/flutter#165729)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 28, 2025
@engine-flutter-autoroll
0af426f Animate a CupertinoButton based on tap move events only if th…
4182a7f 
…e move happens between a tap down and a tap up (flutter/flutter#165729)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 28, 2025
@engine-flutter-autoroll
0af426f Animate a CupertinoButton based on tap move events only if th…
db8af92 
…e move happens between a tap down and a tap up (flutter/flutter#165729)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 28, 2025
@engine-flutter-autoroll
0af426f Animate a CupertinoButton based on tap move events only if th…
568e9df 
…e move happens between a tap down and a tap up (flutter/flutter#165729)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 28, 2025
@engine-flutter-autoroll
0af426f Animate a CupertinoButton based on tap move events only if th…
020a97e 
…e move happens between a tap down and a tap up (flutter/flutter#165729)
@Piinks Piinks mentioned this pull request Mar 28, 2025
Open
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 29, 2025
@engine-flutter-autoroll
0af426f Animate a CupertinoButton based on tap move events only if th…
3dc03a8 
…e move happens between a tap down and a tap up (flutter/flutter#165729)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 29, 2025
@engine-flutter-autoroll
0af426f Animate a CupertinoButton based on tap move events only if th…
a854def 
…e move happens between a tap down and a tap up (flutter/flutter#165729)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 30, 2025
@engine-flutter-autoroll
0af426f Animate a CupertinoButton based on tap move events only if th…
7402458 
…e move happens between a tap down and a tap up (flutter/flutter#165729)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 30, 2025
@engine-flutter-autoroll
0af426f Animate a CupertinoButton based on tap move events only if th…
3b39dd7 
…e move happens between a tap down and a tap up (flutter/flutter#165729)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 31, 2025
@engine-flutter-autoroll
0af426f Animate a CupertinoButton based on tap move events only if th…
30eef76 
…e move happens between a tap down and a tap up (flutter/flutter#165729)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 31, 2025
@engine-flutter-autoroll
0af426f Animate a CupertinoButton based on tap move events only if th…
fc9f543 
…e move happens between a tap down and a tap up (flutter/flutter#165729)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 31, 2025
@engine-flutter-autoroll
0af426f Animate a CupertinoButton based on tap move events only if th…
6500556 
…e move happens between a tap down and a tap up (flutter/flutter#165729)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 31, 2025
@engine-flutter-autoroll
0af426f Animate a CupertinoButton based on tap move events only if th…
ba7feac 
…e move happens between a tap down and a tap up (flutter/flutter#165729)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 31, 2025
@engine-flutter-autoroll
0af426f Animate a CupertinoButton based on tap move events only if th…
5ad2972 
…e move happens between a tap down and a tap up (flutter/flutter#165729)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 31, 2025
@engine-flutter-autoroll
0af426f Animate a CupertinoButton based on tap move events only if th…
bf55260 
…e move happens between a tap down and a tap up (flutter/flutter#165729)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 31, 2025
@engine-flutter-autoroll
0af426f Animate a CupertinoButton based on tap move events only if th…
977c7d1 
…e move happens between a tap down and a tap up (flutter/flutter#165729)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 1, 2025
@engine-flutter-autoroll
0af426f Animate a CupertinoButton based on tap move events only if th…
57249f1 
…e move happens between a tap down and a tap up (flutter/flutter#165729)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 1, 2025
@engine-flutter-autoroll
0af426f Animate a CupertinoButton based on tap move events only if th…
d5aee81 
…e move happens between a tap down and a tap up (flutter/flutter#165729)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 1, 2025
@engine-flutter-autoroll
0af426f Animate a CupertinoButton based on tap move events only if th…
e8e4ddf 
…e move happens between a tap down and a tap up (flutter/flutter#165729)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 1, 2025
@engine-flutter-autoroll
0af426f Animate a CupertinoButton based on tap move events only if th…
cca7400 
…e move happens between a tap down and a tap up (flutter/flutter#165729)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 20, 2025
@engine-flutter-autoroll
0af426f Animate a CupertinoButton based on tap move events only if th…
4081c08 
…e move happens between a tap down and a tap up (flutter/flutter#165729)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 20, 2025
@engine-flutter-autoroll
0af426f Animate a CupertinoButton based on tap move events only if th…
863ef90 
…e move happens between a tap down and a tap up (flutter/flutter#165729)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 21, 2025
@engine-flutter-autoroll
0af426f Animate a CupertinoButton based on tap move events only if th…
128423a 
…e move happens between a tap down and a tap up (flutter/flutter#165729)
zhangyuang pushed a commit to zhangyuang/flutter-fork that referenced this pull request Jun 9, 2025
@jason-simmons
Animate a CupertinoButton based on tap move events only if the move h…
248fb1d 
…appens between a tap down and a tap up (flutter#165729)

Fixes flutter#165724
romanejaquez pushed a commit to romanejaquez/flutter that referenced this pull request Aug 14, 2025
@jason-simmons @romanejaquez
Animate a CupertinoButton based on tap move events only if the move h…
61fa234 
…appens between a tap down and a tap up (flutter#165729)

Fixes flutter#165724
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dkwingsmt dkwingsmt dkwingsmt approved these changes

Assignees

No one assigned

Labels

f: cupertino flutter/packages/flutter/cupertino repository framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

CupertinoButton inside ListView remains pressed after tapping and quickly dragging outside the button

2 participants

@jason-simmons @dkwingsmt