fix barrier overlap after and during FadeForwardsPageTransitionsBuilder transition animation #165726

TheLastFlame · 2025-03-22T00:25:31Z

before

screen-20250322-101359.2.mp4

after

screen-20250322-101552.2.mp4

code sample

import 'package:flutter/material.dart';

void main() {
  runApp(const MainApp());
}

class MainApp extends StatelessWidget {
  const MainApp({super.key});

  @override
  Widget build(BuildContext context) {
    return MaterialApp(
      theme: ThemeData(
        pageTransitionsTheme: PageTransitionsTheme(
          builders: {
            for (var platform in TargetPlatform.values)
              platform: FadeForwardsPageTransitionsBuilder(),
          },
        ),
      ),
      home: const HomeScreen(),
    );
  }
}

class HomeScreen extends StatelessWidget {
  const HomeScreen({super.key});

  @override
  Widget build(BuildContext context) {
    return Scaffold(
      body: Center(
        child: Column(
          mainAxisAlignment: MainAxisAlignment.center,

          children: [
            ElevatedButton(
              onPressed: () {
                showDialog(
                  context: context,
                  builder: (context) {
                    return TheDialog();
                  },
                );
              },
              child: const Text('тык'),
            ),
            const SizedBox(height: 20),
            ElevatedButton(
              onPressed: () {
                Navigator.push(
                  context,
                  PageRouteBuilder(
                    opaque: false,
                    barrierDismissible: true,
                    barrierColor: Colors.black54,
                    pageBuilder: (
                      BuildContext context,
                      Animation<double> animation,
                      Animation<double> secondaryAnimation,
                    ) {
                      return TheDialog();
                    },
                  ),
                );
              },
              child: const Text('другой тык'),
            ),
          ],
        ),
      ),
    );
  }
}

class TheDialog extends StatelessWidget {
  const TheDialog({super.key});

  @override
  Widget build(BuildContext context) {
    return Dialog(
      child: Center(
        child: ElevatedButton(
          onPressed: () {
            Navigator.push(
              context,
              MaterialPageRoute(
                builder: (context) => Scaffold(appBar: AppBar()),
              ),
            );
          },
          child: Text('тык 2'),
        ),
      ),
    );
  }
}

Pre-launch Checklist

I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
I read the [Tree Hygiene] wiki page, which explains my responsibilities.
I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
I signed the [CLA].
I listed at least one issue that this PR fixes in the description above.
I updated/added relevant documentation (doc comments with ///).
I added new tests to check the change I am making, or this PR is [test-exempt].
I followed the [breaking change policy] and added [Data Driven Fixes] where supported.
All existing and new tests are passing.

…er transition animation

flutter-dashboard · 2025-03-22T00:25:34Z

It looks like this pull request may not have tests. Please make sure to add tests or get an explicit test exemption before merging.

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.If you believe this PR qualifies for a test exemption, contact "@test-exemption-reviewer" in the #hackers channel in Discord (don't just cc them here, they won't see it!). The test exemption team is a small volunteer group, so all reviewers should feel empowered to ask for tests, without delegating that responsibility entirely to the test exemption group.

…ageTransitionsBuilder delegated transition

MitchellGoodwin · 2025-04-10T20:22:34Z

Hi @TheLastFlame. Thank you for submitting this PR. It looks like this issue was fixed as a part of #164675, so I'm going to close this PR. If this PR is meant to fix a different issue, or does not fix it fully, please reopen.

…rdsPageTransitionsBuilder (#167032) Reopens #165726 with the removed test that has become irrelevant. Depends on: #167324 Actual master: https://github.com/user-attachments/assets/28619355-9c1e-4f06-9ede-38c4dddd13df After fix: https://github.com/user-attachments/assets/a5f2ecf2-5d8e-445a-b5a9-a7d6c0e3ec5d ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [ ] I listed at least one issue that this PR fixes in the description above. - [x] I updated/added relevant documentation (doc comments with `///`). - [x] I added new tests to check the change I am making, or this PR is [test-exempt]. - [x] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [x] All existing and new tests are passing. --------- Co-authored-by: Justin McCandless <[email protected]> Co-authored-by: Qun Cheng <[email protected]>

…rdsPageTransitionsBuilder (flutter#167032) Reopens flutter#165726 with the removed test that has become irrelevant. Depends on: flutter#167324 Actual master: https://github.com/user-attachments/assets/28619355-9c1e-4f06-9ede-38c4dddd13df After fix: https://github.com/user-attachments/assets/a5f2ecf2-5d8e-445a-b5a9-a7d6c0e3ec5d ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [ ] I listed at least one issue that this PR fixes in the description above. - [x] I updated/added relevant documentation (doc comments with `///`). - [x] I added new tests to check the change I am making, or this PR is [test-exempt]. - [x] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [x] All existing and new tests are passing. --------- Co-authored-by: Justin McCandless <[email protected]> Co-authored-by: Qun Cheng <[email protected]>

fix barrier overlap after and during FadeForwardsPageTransitionsBuild…

7b35ae2

…er transition animation

github-actions bot added framework flutter/packages/flutter repository. See also f: labels. f: material design flutter/packages/flutter/material repository. labels Mar 22, 2025

TheLastFlame force-pushed the fix-fade_forwards_transition branch from ca85dde to b337df0 Compare March 22, 2025 02:30

Add test for dismissing dialog by tapping outside after FadeForwardsP…

1a160ea

…ageTransitionsBuilder delegated transition

TheLastFlame force-pushed the fix-fade_forwards_transition branch from b337df0 to 1a160ea Compare March 22, 2025 04:02

dkwingsmt requested a review from MitchellGoodwin April 2, 2025 18:31

MitchellGoodwin closed this Apr 10, 2025

TheLastFlame mentioned this pull request Apr 12, 2025

Fix visual overlap of transparent routes barrier when using FadeForwardsPageTransitionsBuilder #167032

Merged

9 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fix barrier overlap after and during FadeForwardsPageTransitionsBuilder transition animation #165726

fix barrier overlap after and during FadeForwardsPageTransitionsBuilder transition animation #165726

Uh oh!

TheLastFlame commented Mar 22, 2025 •

edited

Loading

Uh oh!

flutter-dashboard bot commented Mar 22, 2025

Uh oh!

MitchellGoodwin commented Apr 10, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

fix barrier overlap after and during FadeForwardsPageTransitionsBuilder transition animation #165726

fix barrier overlap after and during FadeForwardsPageTransitionsBuilder transition animation #165726

Uh oh!

Conversation

TheLastFlame commented Mar 22, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Pre-launch Checklist

Uh oh!

flutter-dashboard bot commented Mar 22, 2025

Uh oh!

MitchellGoodwin commented Apr 10, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

TheLastFlame commented Mar 22, 2025 •

edited

Loading