Skip to content

Disable the address sanitizer in the linux_unopt build #165661

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
matanlurey merged 1 commit into from
Mar 21, 2025
Merged

Disable the address sanitizer in the linux_unopt build #165661

matanlurey merged 1 commit into from
Mar 21, 2025

Conversation

@jason-simmons
Copy link
Member

@jason-simmons jason-simmons commented Mar 21, 2025

This is causing issues on LUCI workers that were upgraded to a new version of Ubuntu.

See #165594
See #165620

@jason-simmons
Disable the address sanitizer in the linux_unopt build
0015bdf 
This is causing issues on LUCI workers that were upgraded to a new version of Ubuntu.

See flutter#165594
See flutter#165620
@github-actions github-actions bot added the engine flutter/engine related. See also e: labels. label Mar 21, 2025
@matanlurey matanlurey added autosubmit Merge PR when tree becomes green via auto submit App emergency Jump the queue; land PR in front of all others; only use for emergencies labels Mar 21, 2025
@flutter-dashboard
Copy link

flutter-dashboard bot commented Mar 21, 2025

Detected the emergency label.

If you add the autosubmit label, the bot will wait until all presubmits pass but ignore the tree status, allowing fixes for tree breakages while still validating that they don't break any existing presubmits.

The "Merge" button is also unlocked. To bypass presubmits as well as the tree status, press the GitHub "Add to Merge Queue".

1 similar comment
@flutter-dashboard
Copy link

flutter-dashboard bot commented Mar 21, 2025

Detected the emergency label.

If you add the autosubmit label, the bot will wait until all presubmits pass but ignore the tree status, allowing fixes for tree breakages while still validating that they don't break any existing presubmits.

The "Merge" button is also unlocked. To bypass presubmits as well as the tree status, press the GitHub "Add to Merge Queue".

@matanlurey matanlurey added this pull request to the merge queue Mar 21, 2025
Merged via the queue into flutter:master with commit 5a8d403 Mar 21, 2025
144 of 174 checks passed
@flutter-dashboard flutter-dashboard bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Mar 21, 2025
jason-simmons added a commit to jason-simmons/flutter that referenced this pull request Mar 21, 2025
@jason-simmons
Remove the path_ops library test from the run_tests script
a3737eb 
This test was not running previously on the Linux builder, but it started running again when ASAN was disabled due to the Ubuntu 24 upgrade on LUCI.  The test is not currently working and needs to be disabled until the Ubuntu upgrade is stable.

See flutter#165661
jason-simmons added a commit to jason-simmons/flutter that referenced this pull request Mar 21, 2025
@jason-simmons
Remove the path_ops library test from the run_tests script
77cd929 
This test was not running previously on the Linux builder, but it started running again when ASAN was disabled due to the Ubuntu 24 upgrade on LUCI.  The test is not currently functioning as intended and needs to be disabled until the Ubuntu upgrade is stable.

See flutter#165661
@jason-simmons jason-simmons mentioned this pull request Mar 21, 2025
Merged
github-merge-queue bot pushed a commit that referenced this pull request Mar 21, 2025
@jason-simmons
Remove the path_ops library test from the run_tests script (#165675)
d3571a2 
This test was not running previously on the Linux builder, but it
started running again when ASAN was disabled due to the Ubuntu 24
upgrade on LUCI. The test is not currently functioning as intended and
needs to be disabled until the Ubuntu upgrade is stable.

See #165661
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 25, 2025
@engine-flutter-autoroll
5a8d403 Disable the address sanitizer in the linux_unopt build (flutt…
8c16213 
…er/flutter#165661)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 25, 2025
@engine-flutter-autoroll
5a8d403 Disable the address sanitizer in the linux_unopt build (flutt…
181d997 
…er/flutter#165661)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 26, 2025
@engine-flutter-autoroll
5a8d403 Disable the address sanitizer in the linux_unopt build (flutt…
dfd7a51 
…er/flutter#165661)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 26, 2025
@engine-flutter-autoroll
5a8d403 Disable the address sanitizer in the linux_unopt build (flutt…
0c6f1fa 
…er/flutter#165661)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 26, 2025
@engine-flutter-autoroll
5a8d403 Disable the address sanitizer in the linux_unopt build (flutt…
dffa725 
…er/flutter#165661)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 26, 2025
@engine-flutter-autoroll
5a8d403 Disable the address sanitizer in the linux_unopt build (flutt…
4065837 
…er/flutter#165661)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 26, 2025
@engine-flutter-autoroll
5a8d403 Disable the address sanitizer in the linux_unopt build (flutt…
3771084 
…er/flutter#165661)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 26, 2025
@engine-flutter-autoroll
5a8d403 Disable the address sanitizer in the linux_unopt build (flutt…
001ab8f 
…er/flutter#165661)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 26, 2025
@engine-flutter-autoroll
5a8d403 Disable the address sanitizer in the linux_unopt build (flutt…
cb0105f 
…er/flutter#165661)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 26, 2025
@engine-flutter-autoroll
5a8d403 Disable the address sanitizer in the linux_unopt build (flutt…
f3f881e 
…er/flutter#165661)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 27, 2025
@engine-flutter-autoroll
5a8d403 Disable the address sanitizer in the linux_unopt build (flutt…
6c728ca 
…er/flutter#165661)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 27, 2025
@engine-flutter-autoroll
5a8d403 Disable the address sanitizer in the linux_unopt build (flutt…
65a51de 
…er/flutter#165661)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 27, 2025
@engine-flutter-autoroll
5a8d403 Disable the address sanitizer in the linux_unopt build (flutt…
2603a7f 
…er/flutter#165661)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 28, 2025
@engine-flutter-autoroll
5a8d403 Disable the address sanitizer in the linux_unopt build (flutt…
58245dd 
…er/flutter#165661)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 28, 2025
@engine-flutter-autoroll
5a8d403 Disable the address sanitizer in the linux_unopt build (flutt…
3e05485 
…er/flutter#165661)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 29, 2025
@engine-flutter-autoroll
5a8d403 Disable the address sanitizer in the linux_unopt build (flutt…
290e2d1 
…er/flutter#165661)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 29, 2025
@engine-flutter-autoroll
5a8d403 Disable the address sanitizer in the linux_unopt build (flutt…
4187dd5 
…er/flutter#165661)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 30, 2025
@engine-flutter-autoroll
5a8d403 Disable the address sanitizer in the linux_unopt build (flutt…
3c558fa 
…er/flutter#165661)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 30, 2025
@engine-flutter-autoroll
5a8d403 Disable the address sanitizer in the linux_unopt build (flutt…
c614f92 
…er/flutter#165661)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 31, 2025
@engine-flutter-autoroll
5a8d403 Disable the address sanitizer in the linux_unopt build (flutt…
e76348c 
…er/flutter#165661)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 31, 2025
@engine-flutter-autoroll
5a8d403 Disable the address sanitizer in the linux_unopt build (flutt…
7895d75 
…er/flutter#165661)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 31, 2025
@engine-flutter-autoroll
5a8d403 Disable the address sanitizer in the linux_unopt build (flutt…
309a2f8 
…er/flutter#165661)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 31, 2025
@engine-flutter-autoroll
5a8d403 Disable the address sanitizer in the linux_unopt build (flutt…
a17eae5 
…er/flutter#165661)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 31, 2025
@engine-flutter-autoroll
5a8d403 Disable the address sanitizer in the linux_unopt build (flutt…
28784a6 
…er/flutter#165661)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 31, 2025
@engine-flutter-autoroll
5a8d403 Disable the address sanitizer in the linux_unopt build (flutt…
6ae8b1d 
…er/flutter#165661)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 31, 2025
@engine-flutter-autoroll
5a8d403 Disable the address sanitizer in the linux_unopt build (flutt…
de05e1c 
…er/flutter#165661)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 1, 2025
@engine-flutter-autoroll
5a8d403 Disable the address sanitizer in the linux_unopt build (flutt…
7ec80ea 
…er/flutter#165661)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 1, 2025
@engine-flutter-autoroll
5a8d403 Disable the address sanitizer in the linux_unopt build (flutt…
a77f6fa 
…er/flutter#165661)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 1, 2025
@engine-flutter-autoroll
5a8d403 Disable the address sanitizer in the linux_unopt build (flutt…
f014ee7 
…er/flutter#165661)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 1, 2025
@engine-flutter-autoroll
5a8d403 Disable the address sanitizer in the linux_unopt build (flutt…
a63e1a9 
…er/flutter#165661)
flutteractionsbot pushed a commit to flutteractionsbot/flutter that referenced this pull request Apr 2, 2025
@jason-simmons
Remove the path_ops library test from the run_tests script (flutter#1…
5732b1e 
…65675)

This test was not running previously on the Linux builder, but it
started running again when ASAN was disabled due to the Ubuntu 24
upgrade on LUCI. The test is not currently functioning as intended and
needs to be disabled until the Ubuntu upgrade is stable.

See flutter#165661
reidbaker pushed a commit to flutteractionsbot/flutter that referenced this pull request Apr 2, 2025
@jason-simmons @reidbaker
Disable the address sanitizer in the linux_unopt build (flutter#165661)
f881bdb 
This is causing issues on LUCI workers that were upgraded to a new
version of Ubuntu.

See flutter#165594
See flutter#165620
@reidbaker reidbaker mentioned this pull request Apr 2, 2025
Merged
5 tasks
auto-submit bot pushed a commit that referenced this pull request Apr 4, 2025
@flutteractionsbot
[CP-beta] Fix out of band breakages on presubmit (#166438)
656a1d9 
This pull request is created by [automatic cherry pick workflow]

### Issue Link:
What is the link to the issue this cherry-pick is addressing?
#166553

CP of 
* #165620
* #165661
* #165675
* #165692 
* #165678
* *Not merged in master* #166559

Test configuration error
https://mail.google.com/chat/u/0/#chat/space/AAAAQFWU2Go/dHeIlEXFg2w/dHeIlEXFg2w

### Changelog Description:
N/A

### Impact Description:
blocking #165430

### Workaround:
none

### Risk:
What is the risk level of this cherry-pick?

### Test Coverage:
Are you confident that your fix is well-tested by automated tests?
reidbaker pushed a commit to reidbaker/flutter-work that referenced this pull request Apr 4, 2025
@jason-simmons @reidbaker
Remove the path_ops library test from the run_tests script (flutter#1…
5fd76b9 
…65675)

This test was not running previously on the Linux builder, but it
started running again when ASAN was disabled due to the Ubuntu 24
upgrade on LUCI. The test is not currently functioning as intended and
needs to be disabled until the Ubuntu upgrade is stable.

See flutter#165661
Fintasys pushed a commit to Fintasys/flutter that referenced this pull request May 14, 2025
@justinmc @Fintasys
Cherry pick to fix linux tests (flutter#166021)
b06705b 
The `Linux tool_integration_tests*` have been failing on this release branch, blocking cherry picks flutter#165430 and flutter#165428. This PR attempts to cherry pick fixes that will make the tests go green.

This PR contains cherry-picks of three PRs:

  * flutter#164935
  * flutter#165620
  * flutter#165661

Example of the failures I was seeing: https://github.com/flutter/flutter/pull/165428/checks?check_run_id=38997055797.

```
error: {
  code: 5
  message: builder not found: "Linux tool_integration_tests_1_6"
}
```
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 20, 2025
@engine-flutter-autoroll
5a8d403 Disable the address sanitizer in the linux_unopt build (flutt…
db1ad2f 
…er/flutter#165661)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 20, 2025
@engine-flutter-autoroll
5a8d403 Disable the address sanitizer in the linux_unopt build (flutt…
4af6f64 
…er/flutter#165661)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 21, 2025
@engine-flutter-autoroll
5a8d403 Disable the address sanitizer in the linux_unopt build (flutt…
87f8479 
…er/flutter#165661)
zhangyuang pushed a commit to zhangyuang/flutter-fork that referenced this pull request Jun 9, 2025
@jason-simmons
Disable the address sanitizer in the linux_unopt build (flutter#165661)
b1d09f3 
This is causing issues on LUCI workers that were upgraded to a new
version of Ubuntu.

See flutter#165594
See flutter#165620
zhangyuang pushed a commit to zhangyuang/flutter-fork that referenced this pull request Jun 9, 2025
@jason-simmons
Remove the path_ops library test from the run_tests script (flutter#1…
c31d54e 
…65675)

This test was not running previously on the Linux builder, but it
started running again when ASAN was disabled due to the Ubuntu 24
upgrade on LUCI. The test is not currently functioning as intended and
needs to be disabled until the Ubuntu upgrade is stable.

See flutter#165661
romanejaquez pushed a commit to romanejaquez/flutter that referenced this pull request Aug 14, 2025
@jason-simmons @romanejaquez
Disable the address sanitizer in the linux_unopt build (flutter#165661)
c43d856 
This is causing issues on LUCI workers that were upgraded to a new
version of Ubuntu.

See flutter#165594
See flutter#165620
romanejaquez pushed a commit to romanejaquez/flutter that referenced this pull request Aug 14, 2025
@jason-simmons @romanejaquez
Remove the path_ops library test from the run_tests script (flutter#1…
a8a17dd 
…65675)

This test was not running previously on the Linux builder, but it
started running again when ASAN was disabled due to the Ubuntu 24
upgrade on LUCI. The test is not currently functioning as intended and
needs to be disabled until the Ubuntu upgrade is stable.

See flutter#165661
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@matanlurey matanlurey matanlurey approved these changes

@jtmcdole jtmcdole Awaiting requested review from jtmcdole

Assignees

No one assigned

Labels

emergency Jump the queue; land PR in front of all others; only use for emergencies engine flutter/engine related. See also e: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jason-simmons @matanlurey