[Impeller] fix barriers on PowerVR hardware / ensure Render pass cached on non-MSAA. #165497
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
engine
Contributor
Author
|
This should also impact the gaussian blur backdrop benchmark, since I switched those surfaces to be non-MSAA |
gaaclarke
reviewed
Mar 19, 2025
Member
gaaclarke
left a comment
gaaclarke
left a comment
There was a problem hiding this comment.
Looks good modulo one missing assert in the test and we can drop the cyclomatic complexity by removing the "bool is_swapchain" arguments from methods.
| EXPECT_NE(texture_vk.GetCachedRenderPass(), nullptr); | ||
|
|
||
| render_pass->EncodeCommands(); | ||
| GetContext()->GetCommandQueue()->Submit({buffer}); |
Member
There was a problem hiding this comment.
Assert the return result for Submit is a success. Maybe we should have [[nodiscard]] for that.
Comment on lines
78
to
+82
| SharedHandleVK<vk::RenderPass> RenderPassVK::CreateVKRenderPass( | ||
| const ContextVK& context, | ||
| const SharedHandleVK<vk::RenderPass>& recycled_renderpass, | ||
| const std::shared_ptr<CommandBufferVK>& command_buffer) const { | ||
| const std::shared_ptr<CommandBufferVK>& command_buffer, | ||
| bool is_swapchain) const { |
Member
There was a problem hiding this comment.
Instead of passing in a bool can you just have CreateVKRenderPass() and CreateSwapchainVKRenderPass()?
| StoreAction store_action, | ||
| vk::ImageLayout current_layout) { | ||
| vk::ImageLayout current_layout, | ||
| bool is_swapchain) { |
Member
There was a problem hiding this comment.
Instead of passing in a bool, why not pass in vk::ImageLayout final_layout?
Contributor
Author
There was a problem hiding this comment.
We still need the logic in the render_pass_builder because the MSAA texture and resolve always need separate layouts. I'd rather leave this determination in the render_pass_builder
jonahwilliams
added
the
autosubmit
auto-submit
bot
removed
the
autosubmit
Contributor
|
autosubmit label was removed for flutter/flutter/165497, because - The status or check suite Google testing has failed. Please fix the issues identified (or deflake) before re-applying this label. |
jonahwilliams
added
the
autosubmit
flutter-dashboard
bot
removed
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 25, 2025
…ass cached on non-MSAA. (flutter/flutter#165497)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 25, 2025
…ass cached on non-MSAA. (flutter/flutter#165497)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 26, 2025
…ass cached on non-MSAA. (flutter/flutter#165497)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 26, 2025
…ass cached on non-MSAA. (flutter/flutter#165497)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 26, 2025
…ass cached on non-MSAA. (flutter/flutter#165497)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 26, 2025
…ass cached on non-MSAA. (flutter/flutter#165497)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 26, 2025
…ass cached on non-MSAA. (flutter/flutter#165497)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 26, 2025
…ass cached on non-MSAA. (flutter/flutter#165497)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 26, 2025
…ass cached on non-MSAA. (flutter/flutter#165497)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 27, 2025
…ass cached on non-MSAA. (flutter/flutter#165497)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 28, 2025
…ass cached on non-MSAA. (flutter/flutter#165497)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 28, 2025
…ass cached on non-MSAA. (flutter/flutter#165497)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 28, 2025
…ass cached on non-MSAA. (flutter/flutter#165497)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 28, 2025
…ass cached on non-MSAA. (flutter/flutter#165497)
github-merge-queue bot
pushed a commit
that referenced
this pull request
Mar 28, 2025
Not to be landed until #165497 lands. We don't both to parse the model number until CXT and DXT as all prior models shouldn't be used.
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 29, 2025
…ass cached on non-MSAA. (flutter/flutter#165497)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 29, 2025
…ass cached on non-MSAA. (flutter/flutter#165497)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 30, 2025
…ass cached on non-MSAA. (flutter/flutter#165497)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 30, 2025
…ass cached on non-MSAA. (flutter/flutter#165497)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 31, 2025
…ass cached on non-MSAA. (flutter/flutter#165497)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 31, 2025
…ass cached on non-MSAA. (flutter/flutter#165497)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 31, 2025
…ass cached on non-MSAA. (flutter/flutter#165497)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 31, 2025
…ass cached on non-MSAA. (flutter/flutter#165497)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 31, 2025
…ass cached on non-MSAA. (flutter/flutter#165497)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 31, 2025
…ass cached on non-MSAA. (flutter/flutter#165497)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 31, 2025
…ass cached on non-MSAA. (flutter/flutter#165497)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Apr 1, 2025
…ass cached on non-MSAA. (flutter/flutter#165497)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Apr 1, 2025
…ass cached on non-MSAA. (flutter/flutter#165497)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Apr 1, 2025
…ass cached on non-MSAA. (flutter/flutter#165497)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Apr 1, 2025
…ass cached on non-MSAA. (flutter/flutter#165497)
This was referenced Apr 17, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
May 20, 2025
…ass cached on non-MSAA. (flutter/flutter#165497)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
May 20, 2025
…ass cached on non-MSAA. (flutter/flutter#165497)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
May 21, 2025
…ass cached on non-MSAA. (flutter/flutter#165497)
zhangyuang
pushed a commit
to zhangyuang/flutter-fork
that referenced
this pull request
Jun 9, 2025
…ed on non-MSAA. (flutter#165497) Work towards flutter#162033 - barriers for render pass are not correct, but only causes a problem on powervr/imagination. Added new external subpass dependencies that have better descriptions for what they do. We now use the subpass to transition images that are sampled to the final shaderReadOnlylayout, while keeping swapchain images in eGeneral. - missing cache for render pass objects when using non-msaa passes. This mostly impacts powervr hardware because render pass construction is much slower there.
zhangyuang
pushed a commit
to zhangyuang/flutter-fork
that referenced
this pull request
Jun 9, 2025
Not to be landed until flutter#165497 lands. We don't both to parse the model number until CXT and DXT as all prior models shouldn't be used.
romanejaquez
pushed a commit
to romanejaquez/flutter
that referenced
this pull request
Aug 14, 2025
…ed on non-MSAA. (flutter#165497) Work towards flutter#162033 - barriers for render pass are not correct, but only causes a problem on powervr/imagination. Added new external subpass dependencies that have better descriptions for what they do. We now use the subpass to transition images that are sampled to the final shaderReadOnlylayout, while keeping swapchain images in eGeneral. - missing cache for render pass objects when using non-msaa passes. This mostly impacts powervr hardware because render pass construction is much slower there.
romanejaquez
pushed a commit
to romanejaquez/flutter
that referenced
this pull request
Aug 14, 2025
Not to be landed until flutter#165497 lands. We don't both to parse the model number until CXT and DXT as all prior models shouldn't be used.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Work towards #162033
barriers for render pass are not correct, but only causes a problem on powervr/imagination. Added new external subpass dependencies that have better descriptions for what they do. We now use the subpass to transition images that are sampled to the final shaderReadOnlylayout, while keeping swapchain images in eGeneral.
missing cache for render pass objects when using non-msaa passes. This mostly impacts powervr hardware because render pass construction is much slower there.