[stable] fix validation check when restoring to onscreen with BDF and mips. #165430
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nd mips. (flutter#165098) Fixes flutter#163421 If we restore to the onscreen but need to generate mips (because its a toImage call) then we could miss the mip map generation. This will primarily happen on Android emulators as they do not support framebuffer fetch.
github-actions
bot
added
engine
jonahwilliams
added
cp: stable
justinmc
approved these changes
Mar 26, 2025
Contributor
justinmc
left a comment
justinmc
left a comment
There was a problem hiding this comment.
LGTM, seems high priority to me as it fixes a crash.
@gaaclarke Can you take a look at the failing tests?
Contributor
|
Same comment as previous PR, seems like an infrastructure issue we don't know how to resolve. |
auto-submit bot
pushed a commit
that referenced
this pull request
Mar 27, 2025
The `Linux tool_integration_tests*` have been failing on this release branch, blocking cherry picks #165430 and #165428. This PR attempts to cherry pick fixes that will make the tests go green. This PR contains cherry-picks of three PRs: * #164935 * #165620 * #165661 Example of the failures I was seeing: https://github.com/flutter/flutter/pull/165428/checks?check_run_id=38997055797. ``` error: { code: 5 message: builder not found: "Linux tool_integration_tests_1_6" } ```
5 tasks
Contributor
|
I put up #166594 which I think will help this pr merge. |
auto-submit bot
pushed a commit
that referenced
this pull request
Apr 4, 2025
This pull request is created by [automatic cherry pick workflow] ### Issue Link: What is the link to the issue this cherry-pick is addressing? #166553 CP of * #165620 * #165661 * #165675 * #165692 * #165678 * *Not merged in master* #166559 Test configuration error https://mail.google.com/chat/u/0/#chat/space/AAAAQFWU2Go/dHeIlEXFg2w/dHeIlEXFg2w ### Changelog Description: N/A ### Impact Description: blocking #165430 ### Workaround: none ### Risk: What is the risk level of this cherry-pick? ### Test Coverage: Are you confident that your fix is well-tested by automated tests?
reidbaker
approved these changes
Apr 9, 2025
Contributor
|
After updating with #166594 tests appear to pass, one test had an infra issue and was re-run. Adding auto submit to get this landed. Thank you for your patience |
reidbaker
added
the
autosubmit
auto-submit
bot
merged commit 1248314
into
flutter:flutter-3.29-candidate.0
150 checks passed
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Apr 14, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Apr 15, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Apr 15, 2025
Fintasys
pushed a commit
to Fintasys/flutter
that referenced
this pull request
May 14, 2025
The `Linux tool_integration_tests*` have been failing on this release branch, blocking cherry picks flutter#165430 and flutter#165428. This PR attempts to cherry pick fixes that will make the tests go green. This PR contains cherry-picks of three PRs: * flutter#164935 * flutter#165620 * flutter#165661 Example of the failures I was seeing: https://github.com/flutter/flutter/pull/165428/checks?check_run_id=38997055797. ``` error: { code: 5 message: builder not found: "Linux tool_integration_tests_1_6" } ```
Fintasys
pushed a commit
to Fintasys/flutter
that referenced
this pull request
May 14, 2025
… mips. (flutter#165430) cherry-pick of flutter#165098 ## Impacted Users Impeller users developing on the Android Emulator (or some old hardware) ## Impact Description Crash in the Flutter app ## Workaround (Is there a workaround for this issue?) Use a real android device. ## Risk (What is the risk level of this cherry-pick?) ## Test Coverage (Are you confident that your fix is well-tested by automated tests?) Yes, there is an integration test that captures most of the problem. ## Validation Steps (What are the steps to validate that this fix works?) flutter#163421 has reproduction steps
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cherry-pick of #165098
Impacted Users
Impeller users developing on the Android Emulator (or some old hardware)
Impact Description
Crash in the Flutter app
Workaround (Is there a workaround for this issue?)
Use a real android device.
Risk (What is the risk level of this cherry-pick?)
Test Coverage (Are you confident that your fix is well-tested by automated tests?)
Yes, there is an integration test that captures most of the problem.
Validation Steps (What are the steps to validate that this fix works?)
#163421 has reproduction steps